Commit Graph

223 Commits

Author SHA1 Message Date
Bernd
3ba502a047 remove dead debugging code r/sr=bzbarsky bug 475075 2009-02-08 17:45:28 +01:00
Arpad Borsos
b2f9b630db Bug 474369 - get rid of nsVoidArray, layout/tables part. r+sr=roc 2009-02-05 10:09:50 +01:00
Benjamin Smedberg
24e7cb1f78 Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.

--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
Benjamin Smedberg
50621e4f9f Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal. 2009-01-09 11:35:24 -05:00
Benjamin Smedberg
d0b948876f Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
Michael Ventnor
318cfd2e10 Bug 472410. Don't adjust selection colors if the background is a -moz-appearance that we can't know anything about. r+sr=roc 2009-01-09 13:29:38 +13:00
Michael Ventnor
0a7591b341 Bug 453641. Make box-shadow work on tables and table parts. r+sr=roc 2008-12-03 14:20:21 +13:00
L. David Baron
be3321e732 Simplify conditions, part 2, since we're really only trying to avoid IsGeometryDirty if we're not going to need any reflow at all. (Bug 438509) r=dholbert sr=roc a=blocking1.9.1+ 2008-11-25 13:27:53 -08:00
L. David Baron
c0cc02dfd5 Simplify condition, part 1, since mVResize already implies IsGeometryDirty thanks to the code immediately above. (Bug 438509) r=dholbert sr=roc a=blocking1.9.1+ 2008-11-25 13:27:53 -08:00
L. David Baron
3dbd3c34af Avoid exponential growth of special height reflows. (Bug 438509) r=dholbert sr=roc a=blocking1.9.1+ 2008-11-25 13:27:53 -08:00
L. David Baron
58064fc1f3 Remove nsHTMLReflowState::mPercentHeightReflowInitiator, which is write-only. (Bug 438509) r+sr=roc a=blocking1.9.1+ 2008-11-25 13:27:53 -08:00
Robert O'Callahan
a722f955fd Bug 462972 - 'Fix nsChangeHint comparisons'. r=bernd, sr=dbaron 2008-11-04 14:03:14 -08:00
Bernd
7c0832937a bug 286797 dynamic changes of the border color require a update of the cellmap as there is stored where a new segment starts. This is used by painting. r/sr=bzbarsky 2008-11-02 19:41:35 +01:00
Bernd
62d4cebdde bug 258377 remove inline on PeekStyleData so that it can be called from the layout library r/sr=bzbarsky 2008-11-01 09:52:29 +01:00
Bernd
6f6f59a250 mac build bustage disable the code in question 2008-10-26 13:06:28 +01:00
Bernd
6777c42861 bug 258377, make border collapsed tables to listen for dynamic border style changes r/sr=bzbarsky 2008-10-26 11:11:34 +01:00
Bernd
f08db4eb5c bug 451170, avoid hanging by going to the next frame instead of quering the same frame again. r/sr=bzbarsky 2008-10-26 10:20:42 +01:00
Robert O'Callahan
85ea5a3965 Bug 460240. Need to repaint the overflow area if the overflow area changes, the frame has effects/outline/box-shadow, and the frame size has not changed. r+sr=bzbarsky 2008-10-21 20:42:28 +13:00
Bernd
ffc4c848b4 trigger fixed layout if the width cahnges from auto to fixed, bug 426629r/sr=dbaron 2008-10-18 19:25:26 +02:00
Bernd
7988560536 use the right method to insert more than one frame, bug 456041 r/sr=bzbarsky 2008-09-27 13:07:29 +02:00
L. David Baron
bb1dbb4eec For fixed-layout tables, leave room for the cell spacing for all columns, whether they have cells originating in them or not, since we don't know if cells for those columns will arrive as the table loads incrementally. (Bug 444928) r=bernd sr=roc 2008-09-24 10:14:35 -07:00
L. David Baron
b4d9cdbfa1 Convert border spacing storage from nsStyleCoord to nscoord. (Bug 443057) r+sr=bzbarsky 2008-09-12 20:45:37 -07:00
Zack Weinberg
0f68a207ca Bug 453916: treat transparency strictly as a special case of color alpha. r+sr=dbaron 2008-09-12 08:35:53 -07:00
Graeme McCutcheon
b6ce570b3c Bug 451252 - "Highlight All" find selection not visible in elements that have -moz-user-select: none set; r+sr=roc 2008-09-07 16:12:50 +02:00
Boris Zbarsky
d9344bb542 Bug 449362 - "Table border is rendered incorrectly when the table cell size changes due to javascript." [r+sr=roc] 2008-08-20 01:45:29 -05:00
Mats Palmgren
0443739378 Manually calculate the overflow area contribution from our children when not reflowing them. b=428278 r=bernd sr=dbaron 2008-08-07 16:19:33 +02:00
Mats Palmgren
d0d73a5ec1 Bug 416845. Use the right x position when distributing height to rows. r=bernd, sr=bzbarsky 2008-08-06 16:53:36 -04:00
Bernd
c98687f036 make the table column dimension setting rtl aware bug 89856 r/sr=roc 2008-08-04 09:27:32 +02:00
Bernd
2b01da090f make sure that we initialize the BCDamageArea bug 351068 r/sr=bzbarsky 2008-08-04 09:14:39 +02:00
Andrew Smith ext:(%2C%20Rob%20Arnold%20%3Ctellrob%40gmail.com%3E%2C%20L.%20David%20Baron%20%3Cdbaron%40dbaron.org%3E)
49c9b3d67e Implement css3 border-image property. (Bug 378217) r=vlad,dbaron,robarnold 2008-07-16 23:30:25 -07:00
L. David Baron
9e4ceade8e Backed out changeset 9b0b2391485c due to linker errors related to nsStyleStructInlines.h not being included enough. 2008-07-16 22:59:14 -07:00
Andrew Smith ext:(%2C%20Rob%20Arnold%20%3Ctellrob%40gmail.com%3E%2C%20L.%20David%20Baron%20%3Cdbaron%40dbaron.org%3E)
bb4be48531 Implement css3 border-image property. (Bug 378217) r=vlad,dbaron,robarnold 2008-07-16 22:18:38 -07:00
Robert O'Callahan
7e15def36c Bug 444688. Use an IsFrameOfType check instead of a frame state bit to detect whether a frame excludes ignorable whitespace children. r+sr=dbaronlayout 2008-07-14 10:41:18 +12:00
roc+@cs.cmu.edu
35910e2c7c Bug 316500. Fix merge regression so that fixed-background tables display correctly. r+sr=mats,a=damon 2008-04-21 15:00:48 -07:00
dholbert@cs.stanford.edu
cd2cd226bc Bug 409084: When determining if a row or rowgroup isTopOfPage, check if the previous row has positive YMost, rather than just checking if there *is* a previous row. r=bernd sr=dbaron a1.9=beltzner 2008-04-17 11:18:41 -07:00
roc+@cs.cmu.edu
4f41fd4761 Bug 416735. When a table frame paints the backgrounds for all its parts, make sure those parts notify the table frame display item when they are background-attachment:fixed. r+sr=dbaron 2008-04-06 04:34:14 -07:00
bzbarsky@mit.edu
8deea0cbbf Invalidate the original overflow rect too when the frame moves. Bug 424766, r+sr=roc 2008-04-01 16:27:25 -07:00
dbaron@dbaron.org
128863679e Don't do translation during table border painting. b=421069 Patch by Robert O'Callahan <roc@ocallahan.org>. r+sr=dbaron approval1.9b5=damon 2008-03-20 18:18:30 -07:00
dbaron@dbaron.org
c633f035a4 Backing out bug 421069 (which I landed earlier today for roc) because it caused bug 424016. 2008-03-19 22:58:00 -07:00
dbaron@dbaron.org
9e7d833654 Don't do translation during table border painting. b=421069 Patch by Robert O'Callahan <roc@ocallahan.org>. r+sr=dbaron 2008-03-19 16:02:38 -07:00
bzbarsky@mit.edu
71f4c3f4b8 Comment fix 2008-03-16 17:22:54 -07:00
bzbarsky@mit.edu
b607f1de90 Invalidate tables a little harder. Bug 421632, r+sr=roc 2008-03-16 13:32:48 -07:00
fantasai.cvs@inkedblade.net
d4dc37580f switch GetOverflowAreaProperty callers to GetOverflowRect b=417116 r+sr=roc a=roc 2008-02-19 23:08:55 -08:00
bzbarsky@mit.edu
8b8a07f4a7 Fix bug 416073: invalidate more things as needed during table reflow to prevent glitches. r+sr=roc 2008-02-08 01:36:32 -08:00
surkov.alexander@gmail.com
d35a90484c Bug 410052 - Fix our nsHTMLAccessibleTable class so GetIndexAt and GetRowAtIndex and GetColumnAtIndex behave consistently, patch=me, marcoz, r=marcoz, me, bernd, sr=roc, blocking1.9+=dsicore 2008-02-06 23:03:26 -08:00
bzbarsky@mit.edu
5dd3d3e48e Don't invalidate the entire table just because we reflowed something inside it. Bug 414298, r+sr+a=roc 2008-02-06 14:01:41 -08:00
mats.palmgren@bredband.net
41aa517a29 Add a null-check to wallpaper bug 411582. b=411582 r+sr=bzbarsky a=mtschrep 2008-01-15 15:29:53 -08:00
bmlk@gmx.de
55b29989dc fix handling of empty rowgroups (that are rg without a row beneath) in the border collapse code (bug 383193 r/sr=bzbarsky a=mtschrep 2007-12-15 12:23:10 -08:00
bmlk@gmx.de
58193a56aa Implement row height distribution as it was described in the comment. Consider to give space to empty unconstrained rows as one option bug 197391 r/sr=roc a=mtschrep 2007-12-15 08:08:52 -08:00
bzbarsky@mit.edu
722a530cca Remove dead code. Bug 404666 followup, r=bernd, sr=roc, a=schrep 2007-12-05 11:38:26 -08:00
roc+@cs.cmu.edu
277d659675 Bug 383195. Recreate support for repeatable table headers and footers while printing. r=bernd,sr=dbaron 2007-12-04 18:32:56 -08:00
dbaron@dbaron.org
579235bed6 Rename new width keywords to match CSS WG decision. b=402706 r+sr=bzbarsky a=blocking1.9+ 2007-11-15 10:10:31 -08:00
dbaron@dbaron.org
625b15b895 Distribute height to rows even if the rows in question are all zero-height (in which case, distribute it equally). b=403656, 377711 r=dholbert sr=roc a=blocking1.9+ 2007-11-13 17:24:21 -08:00
reed@reedloden.com
9930afe4ba Bug 368600 - "Table with table-layout: fixed has unconstrained width even when width specified on cell" [p=bernd_mozilla@gmx.de (Bernd) r+sr+a1.9=dbaron] 2007-10-21 21:40:02 -07:00
fantasai.cvs@inkedblade.net
03dc1015c3 using wrong BC damage area for BC calculations b=244135 p=malcolm.parsons r=bernd r=fantasai (credits for a good review go to Bernd Mielke, blame for a bad one to fantasai) sr=bz 2007-10-14 21:49:45 -07:00
bzbarsky@mit.edu
4f5bba9acb Make sure to not propagate special height reflows too far. Bug 391901, r+sr+a=dbaron 2007-10-08 19:39:06 -07:00
cbarrett@mozilla.com
4184694ede Bug 370353 followup: Check in white space changes. Patch by Daniel Holbert <dholbert@mozilla.com>. r=bernd sr=dbaron a1.9=dbaron. 2007-08-17 16:58:19 -07:00
cbarrett@mozilla.com
392dc16f4f Bug 370353: Dynamically setting "visibility: collapse" to a <col> no longer works. Patch by Daniel Holbert <dholbert@mozilla.com>. r=bernd sr=dbaron a1.9=dbaron 2007-08-17 16:51:58 -07:00
bmlk@gmx.de
8169bea74e adapt assert to code reality, bug 364512 r/sr/a=dbaron 2007-08-11 09:19:55 -07:00
bzbarsky@mit.edu
21e0d65a42 Introduce a setter for nsHTMLReflowState::mComputedHeight so that we're sure to
update the resize flags properly.  Bug 388084, r+sr+a=dbaron
2007-08-02 11:08:05 -07:00
bzbarsky@mit.edu
4e0e5d2463 Fix regression in sizing of tables with scrollable rowgroups. Bug 387344,
r=bernd, sr=roc
2007-07-12 13:54:18 -07:00
jwalden@mit.edu
e3c4baccae Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros. 2007-07-08 00:08:04 -07:00
mats.palmgren@bredband.net
db689821bf Cleanup implementations of QueryInterface. b=385750 r+sr=dbaron r+sr=jst 2007-07-03 19:15:31 -07:00
dbaron@dbaron.org
fa564b3d4e Only do special height reflows for percentage-height children of table cells when there is a specified height on the table, row group, row, or cell in the row. b=370525 Patch by Daniel Holbert <dholbert@mozilla.com>. r+sr=dbaron 2007-06-25 13:34:35 -07:00
dbaron@dbaron.org
3ee9b0de0f Handle the vertical resizing in the first pass reflow correctly when we've previously done a special height reflow. b=381507 r=dholbert sr=roc 2007-06-18 16:19:39 -07:00
bzbarsky@mit.edu
4ffd04a699 Make OrderRowGroups type-safe. Bug 367706, r=bernd, sr=roc 2007-06-05 11:55:26 -07:00
dbaron@dbaron.org
d4440c538a Call SetGeometryDirty if we need to call DistributeHeightToRows, since DistributeHeightToRows can't deal with rows that have already had height distributed to them. Patch by Daniel Holbert <dholbert@mozilla.com>. b=380227 r+sr=dbaron 2007-05-17 23:04:43 -07:00
dbaron@dbaron.org
ce027d98d6 Remove eCSSUnit_Proportional and eStyleUnit_Proportional, which were used only for a removed feature. b=333352 r+sr=bzbarsky 2007-05-10 23:00:26 -07:00
bzbarsky@mit.edu
ab6e18ee19 Fix determination of the style context parent for the inner table frame of aroot table. Bug 379386, r+sr=roc 2007-05-07 20:59:12 -07:00
bzbarsky@mit.edu
3cb4bc9240 Change the FrameNeedsReflow API to pass the dirty flags to be added directly tothe method, instead of setting them before calling the method. That way we canavoid reflowing the ancestor of a reflow root which is not itself dirty but hasdirty children. This also makes it harder to set dirty bits inconsistentlywith the FrameNeedsReflow call. Bug 378784, r+sr=dbaron, pending rbs' reviewon the mathml parts. 2007-05-06 12:16:51 -07:00
dbaron@dbaron.org
7dc7c89d6c Add support for -moz-intrinsic, -moz-min-intrinsic, -moz-shrink-wrap, and -moz-fill for width, min-width, and max-width. b=311415 r+sr=bzbarsky 2007-05-03 16:11:00 -07:00
bzbarsky@mit.edu
2fd17c94d8 Rename nsIFrame::GetPresContext to nsIFrame::PresContext. Bug 376042, patch byTaras Glek <tglek@mozilla.com>, rs=roc. 2007-03-30 14:11:41 -07:00
hg@mozilla.com
465265d0d4 Free the (distributed) Lizard! Automatic merge from CVS: Module mozilla: tag HG_REPO_INITIAL_IMPORT at 22 Mar 2007 10:30 PDT, 2007-03-22 10:30:00 -07:00