Commit Graph

297 Commits

Author SHA1 Message Date
Marco Bonardo
04d3fb42d9 Bug 462213 - make migrateV8 tolerant to downgrade-upgrade paths, r=sdwilsh 2008-10-30 09:37:49 +01:00
Shawn Wilsher
53d9ccaa7e Bug 459789 - lazily get mDB[Invalid|Old]Frecencies
r=dietrich
2008-10-27 18:52:23 -04:00
Shawn Wilsher
d3792f99c1 Bug 459788 - Lazily get mDBBookmarkToUrlResult
r=dietrich
2008-10-27 18:52:23 -04:00
Shawn Wilsher
53bf616b5a Bug 459786 - lazily get mDBVisitTo[Visit|URL]Result
r=dietrich
2008-10-27 18:52:23 -04:00
Shawn Wilsher
5c893a5e9c Bug 459787 - remove mDBUrlToUrlResult
This changeset removes an unused query that was in the startup path.
r=dietrich
2008-10-27 18:52:22 -04:00
Shawn Wilsher
c7e57e1cb1 Bug 459781 - create our string bundle in a more sane way
This changeset only creates the string bundle when we need it, and only in one
place as opposed to two separate places.
r=dietrich
2008-10-27 18:52:22 -04:00
Shawn Wilsher
d3d72c5b09 Bug 459776 - date formatter is unused
This changeset removes a small part of code that places does in startup that is
not used or needed.
r=dietrich
2008-10-27 18:52:22 -04:00
Shawn Wilsher
34a4755e8b Bug 459773 - Creating a collation is expensive
This makes a lazy getter for getting our collation saving us about 3% of places
startup time.
r=dietrich
2008-10-27 18:52:21 -04:00
Marco Bonardo
27bd310336 Bug 455474 - cleanup nsNavBookmarks::Init
r=dietrich
2008-10-27 18:52:21 -04:00
Shawn Wilsher
2a07d62a96 Bug 459299 - nsNavHistory::SetPageTitleInternal is slow
This caches a statement that is created any time a pages title changes.  The
creation of the statement took roughly 66% of the functions execution time
according to shark.
It also removes a transaction that was not needed in this method.
r=dietrich
2008-10-27 18:52:21 -04:00
Shawn Wilsher
7a2e763702 Bug 450290 - Sync the temp tables to the permanent tables.
This changeset adds code that is run at app-startup that will flush out changes
to the temporary tables into the permanent ones.  For moz_places, this is done
whenever we sync moz_historyvisits and when we add or modify a bookmark.  For
moz_historyvisits, this is done on a timer controlled by the preference
places.syncDBTableIntervalInSecs.
Changeset includes full test coverage for the above behaviors.
r=dietrich
r=Mak77
2008-10-27 18:52:20 -04:00
Marco Bonardo ext:(%2C%20Shawn%20Wilsher%20%3Csdwilsh%40shawnwilsher.com%3E)
3fc608c2a6 Bug 449640 - Modify the places backend to use the temporary tables &
Bug 450705 - Optimize the query changes from the temp table rewrite
This changeset merges patches from two bugs to actually use the temporary tables
created for places.
Bug 449640 patch by Shawn Wilsher <sdwilsh@shawnwilsher.com>
r=dietrich, r=Mak77
Bug 450705 patch by Marco Bonardo <mak77@bonardo.net>
r=sdwilsh, r=dietrich, r=Mardak
2008-10-27 18:52:20 -04:00
Shawn Wilsher
825b607244 Bug 449086 - Create temporary tables for frequently used places tables
This changeset creates two temporary tables that will be used when inserting
data into moz_places and moz_historyvisits.  This will reduce the number of
writes as well as the number of fsyncs that happen.
r=dietrich
2008-10-27 18:52:19 -04:00
Ehsan Akhgari
229637b291 Bug 248970 - Private Browsing mode (global toggle for saving/caching everything) [places part]; r=dietrich 2008-10-20 00:44:59 +03:30
Shawn Wilsher
5edc587690 Backout places fsync changes 2008-10-17 12:29:34 -04:00
Shawn Wilsher
8cb912ef64 Bug 459789 - lazily get mDB[Invalid|Old]Frecencies
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
10cebaa66f Bug 459788 - Lazily get mDBBookmarkToUrlResult
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
2f47ae77b2 Bug 459786 - lazily get mDBVisitTo[Visit|URL]Result
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
653538e53f Bug 459787 - remove mDBUrlToUrlResult
This changeset removes an unused query that was in the startup path.
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
bb7e0e8c36 Bug 459781 - create our string bundle in a more sane way
This changeset only creates the string bundle when we need it, and only in one
place as opposed to two separate places.
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
d9d1b7f304 Bug 459776 - date formatter is unused
This changeset removes a small part of code that places does in startup that is
not used or needed.
r=dietrich
2008-10-17 06:12:52 -04:00
Shawn Wilsher
1d0921f3e0 Bug 459773 - Creating a collation is expensive
This makes a lazy getter for getting our collation saving us about 3% of places
startup time.
r=dietrich
2008-10-17 06:12:52 -04:00
Marco Bonardo
867daf5b5f Bug 455474 - cleanup nsNavBookmarks::Init
r=dietrich
2008-10-17 06:12:52 -04:00
Shawn Wilsher
4d5fb2f862 Bug 459299 - nsNavHistory::SetPageTitleInternal is slow
This caches a statement that is created any time a pages title changes.  The
creation of the statement took roughly 66% of the functions execution time
according to shark.
It also removes a transaction that was not needed in this method.
r=dietrich
2008-10-17 06:12:52 -04:00
Shawn Wilsher
4f97936d8c Bug 450290 - Sync the temp tables to the permanent tables.
This changeset adds code that is run at app-startup that will flush out changes
to the temporary tables into the permanent ones.  For moz_places, this is done
whenever we sync moz_historyvisits and when we add or modify a bookmark.  For
moz_historyvisits, this is done on a timer controlled by the preference
places.syncDBTableIntervalInSecs.
Changeset includes full test coverage for the above behaviors.
r=dietrich
r=Mak77

--HG--
rename : toolkit/components/places/tests/unit/head_bookmarks.js => toolkit/components/places/tests/background/head_background.js
2008-10-17 06:12:51 -04:00
Marco Bonardo ext:(%2C%20Shawn%20Wilsher%20%3Csdwilsh%40shawnwilsher.com%3E)
5715c324ab Bug 449640 - Modify the places backend to use the temporary tables &
Bug 450705 - Optimize the query changes from the temp table rewrite
This changeset merges patches from two bugs to actually use the temporary tables
created for places.
Bug 449640 patch by Shawn Wilsher <sdwilsh@shawnwilsher.com>
r=dietrich, r=Mak77
Bug 450705 patch by Marco Bonardo <mak77@bonardo.net>
r=sdwilsh, r=dietrich, r=Mardak
2008-10-17 06:12:51 -04:00
Shawn Wilsher
5790687517 Bug 449086 - Create temporary tables for frequently used places tables
This changeset creates two temporary tables that will be used when inserting
data into moz_places and moz_historyvisits.  This will reduce the number of
writes as well as the number of fsyncs that happen.
r=dietrich
2008-10-17 06:12:50 -04:00
Shawn Wilsher
810e90b149 Bug 460315 - set journal_mode to TRUNCATE
Sets the journal_mode to the places database to TRUNCATE
r=dietrich
2008-10-16 15:59:33 -04:00
Arpad Borsos
8b11d938d2 Bug 456388 - Remove PR_STATIC_CALLBACK and PR_CALLBACK(_DECL) from the tree; r+sr=brendan 2008-10-10 17:04:34 +02:00
Daniel Holbert
72c410a648 Bug 458167 - (comments-only changes) Grammar Nazi Vol1: s/it's/its/ for the posessive version of the word, and a few other misc comment-typos, in these directories: accessible browser config profile rdf toolkit tools xpcom xpfe 2008-10-01 23:49:45 -07:00
Dietrich Ayala
89c275d5aa Bug 420331 - wyciwyg: uris show up in location bar (r=mardak) 2008-09-29 23:46:52 -07:00
Shawn Wilsher
abd0d61c89 Backed out changeset ebafcda56f98 (bug 456910)
Backed out for Tp regression (bug 457288)
2008-09-26 15:55:03 -04:00
Shawn Wilsher
af8e0300cd Bug 456910 - Stop using exclusive locking in places
This allows us to greatly reduce the number of fsyncs when upgrading to sqlite.
The perf loss in no longer using this locking is not significant (10^-6 %).
r=dietrich
2008-09-25 13:50:41 -04:00
Shawn Wilsher
c7fa5f7164 Bug 453181 - Remove code that is labeled REMOVE ME
This changeset removes a bunch of code that was labeled REMOVE ME with a release
stated.  All those releases have passed, so let's get rid of the code.
r=dietrich
2008-09-05 12:20:40 -04:00
Oleg Romashin
77c933f0f8 Bug 453821 - Places building in embedding-minimal profile failed. r=edilee. 2008-09-05 17:49:49 +03:00
Shawn Wilsher
6f881e6434 Bug 451590 - nsNavHistory needs nsIClassInfo with THREADSAFE flag
This changeset marks nsNavHistory as threadsafe so we can use the database
connection on more than one thread in JS.  It also adds assertions on every
other public API to ensure that it is only running on the main thread.
r=dietrich
r=bent
2008-09-04 18:11:14 -04:00
Edward Lee
2958cfc7b7 Bug 451760 - Allow matching at beginning of title/url by pref. r=dietrich 2008-08-24 10:45:33 -05:00
Shawn Wilsher
631638c56c Bug 451244 - nsNavHistory does not use threadsafe refcounting
This changeset makes nsNavHistory use the threadsafe addref and release macros
so database access can be done off of the main thread via nsPIPlacesDatabase.
r=dietrich
2008-08-19 23:31:53 -05:00
Marco Bonardo
f682e17963 Bug 411966 - Wrong favicon appears in the bookmarks list, r=dietrich 2008-08-19 11:26:16 -04:00
Shawn Wilsher
b77395a679 Bug 449884 - Stop using mozIStorageConnection::GetLastInsertRowID
It turns out that this is not a safe function to use at all when you start using
the database connection on more than one thread.  It also does not work as
expected when triggers are used to insert data into a database.
r=dietrich
2008-08-16 18:28:28 -04:00
Shawn Wilsher
186dba48ff Bug 444763 - Use an unshared cache connection instead of a shared one
This makes places no longer use a shared cache for the database.  This wins us
about 7% for location bar queries.  For those needing access to the places
database now, they should QI nsINavHistoryService to nsPIPlacesDatase and get
the database connection off of it.
r=dietrich
2008-08-16 18:23:24 -04:00
Shawn Wilsher
d2b18f154b Bug 449506 - Expose the places db connection
This adds a private interface that consumers can QI to to get access to the
internal database connection.
r=dietrich
2008-08-16 18:21:23 -04:00
Dão Gottwald
d6eb562dc8 Backed out changeset be5521120b06 2008-08-13 09:52:48 +02:00
Marco Bonardo
56162e6327 Bug 411966 – Wrong favicon appears in the bookmarks list. r=dietrich 2008-08-13 08:44:38 +02:00
Shawn Wilsher
f7c9f5d3ec Bug 443433 - [refactor] move places table creation statements to one file
This refactors how tables are created in places.  There is no change in logic.
r=dietrich
2008-08-04 13:14:17 -04:00
Shawn Wilsher
1082eae412 Address spelling mistake from review comment for bug 443068. 2008-08-04 13:07:17 -04:00
Shawn Wilsher
dbc4d6734f Bug 443068 - Move triggers into migration code
This moves all the triggers created by places into the appropriate migration
functions.  This saves us two queries to sqlite_master every time the places
service starts up.
r=dietrich
2008-08-04 12:59:56 -04:00
Edward Lee
26fd4468ea Bug 395161 - Make it possible to restrict the url bar autocomplete results to bookmarks/tagged/history entries and match only url/title. r=dietrich 2008-07-19 01:51:34 -07:00
Shawn Wilsher
5fe28f1ea4 Bug 429987
Remove unused IN_MEMORY_LINKS
r=dietrich
2008-06-11 16:52:24 -04:00
reed@reedloden.com
fd10d2e6de Bug 398811 - "Remove MOZILLA_1_8_BRANCH ifdefs from toolkit on trunk" [p=mh+mozilla@glandium.org (Mike Hommey) r=gavin a1.9=damons] 2008-05-09 00:25:29 -07:00
dietrich@mozilla.com
60892555a5 Bug 428481 - nsFaviconService calls Abandon on a scoped global statement (for mak77@supereva.it, r=dietrich, a=schrep) 2008-05-07 21:26:10 -07:00
dietrich@mozilla.com
90eb744768 Bug 419957 - History sidebar "By Site" should use visit_count to avoid display of empty sites (for ondrej@allpeers.com, r=dietrich, a=beltzner) 2008-05-06 21:33:05 -07:00
dietrich@mozilla.com
833ad69d76 backing out, tree is closed 2008-05-06 20:28:03 -07:00
dietrich@mozilla.com
2c1cf52261 Bug 419957 - History sidebar "By Site" should use visit_count to avoid display of empty sites (for ondrej@allpeers.com, r=dietrich, a=beltzner) 2008-05-06 20:26:19 -07:00
dietrich@mozilla.com
cbcab9ee50 perf testing bug 431758 (a=mconnor) 2008-05-05 11:11:49 -07:00
gavin@gavinsharp.com
eca397a97a Bug 421180: When removing bookmarks existing keywords aren't deleted/removed, patch by Marco Bonardo <mak77@supereva.it>, r=dietrich, a=damon 2008-04-29 12:20:50 -07:00
gavin@gavinsharp.com
21fa60bf1c Bug 402799: Saved searches that match on tags show duplicates, patch by Marco Bonardo <mak77@supereva.it>, r=dietrich, a=beltzner 2008-04-29 12:16:42 -07:00
dietrich@mozilla.com
b3a186f681 Bug 430600 - crash in CanAddURI (r=mano, a=beltzner) 2008-04-24 12:42:01 -07:00
edward.lee@engineering.uiuc.edu
fc3d4e4739 Bug 429531 - Location bar should show non-word-boundary matches below word-boundary matches. r=dietrich, ui-r=beltzner, b-ff3=beltzner, a1.9=beltzner 2008-04-23 21:20:05 -07:00
edward.lee@engineering.uiuc.edu
a993453306 Bug 251337 - Download manager history should have "aging" option, just like the browser history. r=sdwilsh, r=mano, r=bsmedberg, a1.9=damons 2008-04-22 16:37:00 -07:00
dholbert@cs.stanford.edu
cd91e7dfe2 Backing out mardak's Bug 251337 checkin to fix Thunderbird & Sunbird tinderbox bustage. 2008-04-21 16:00:59 -07:00
edward.lee@engineering.uiuc.edu
a5ee1dc568 Bug 251337 - Download manager history should have "aging" option, just like the browser history. r=sdwilsh, r=mano, a1.9=damons 2008-04-21 14:48:55 -07:00
dietrich@mozilla.com
57a6700157 Bug 424769 - Smart bookmarks Recent Tags menu contains self reference (PPC Mac) (for mak77@supereva.it, r=dietrich, a=beltzner) 2008-04-15 10:07:13 -07:00
dietrich@mozilla.com
ba016f8cad Bug 423677 - misc places compiler warnings (r=mano, a=schrep) 2008-04-13 11:21:40 -07:00
dietrich@mozilla.com
f28f799c23 Bug 428733 - add better error handling in AddVisit (r=mano, a=schrep) 2008-04-13 11:19:55 -07:00
dietrich@mozilla.com
89b533ac42 Bug 419731 - Changing bookmark title in places should be reflected in tag containers (for mak77@supereva.it, r=mano, a=beltzner) 2008-04-11 09:22:01 -07:00
reed@reedloden.com
03c6511560 Bug 421483 - "Reorganize pre-populated smart bookmarks (add versioning)" [p=mak77@supereva.it (Marco Bonardo [mak77]) ui-r=beltzner r=dietrich a=blocking-firefox3+] 2008-04-08 11:42:53 -07:00
reed@reedloden.com
3803afe2a3 Bug 317472 - "Save custom encoding (last charset) in annotation service" [p=mak77@supereva.it (Marco Bonardo [mak77]) r=dietrich r=Mano a=blocking-firefox3+] 2008-04-08 11:41:04 -07:00
dietrich@mozilla.com
49d9ed0f13 Bug 424038 - Assertion thrown when setting query.sort to SORT_BY_ANNOTATION_* (for ondrej@allpeers.com, r=dietrich) 2008-04-08 11:12:13 -07:00
joshmoz@gmail.com
02f9335fc2 back out fixes for bugs 423200 and 424038 2008-04-06 13:03:21 -07:00
dietrich@mozilla.com
da201676cd Bug 424038 - Assertion thrown when setting query.sort to SORT_BY_ANNOTATION_* (for ondrej@allpeers.com, r=dietrich) 2008-04-06 10:11:41 -07:00
dietrich@mozilla.com
7740fc1282 Bug 424884 - Places can lead to circular menus (r=mano) 2008-04-03 14:00:51 -07:00
reed@reedloden.com
b9e2894bd9 Bug 425563 - "Clicked links not colored as visited, or visited color forgotten after hard refresh" [p=mak77@supereva.it (Marco Bonardo [mak77]) r=dietrich a=blocking-firefox3+] 2008-03-28 23:48:28 -07:00
dietrich@mozilla.com
e8b583fd16 Bug 416313 ? Define the identity of the visit_count column (for mak77@supereva.it, r=edilee,dietrich) 2008-03-26 21:05:25 -07:00
dietrich@mozilla.com
feb03707fb Bug 423159 ? WARNING: Unsafe use of LIKE detected! (for mak77@supereva.it, r=dietrich) 2008-03-26 20:34:07 -07:00
sdwilsh@shawnwilsher.com
e99293d31f Bug 423273 - Fix storage API to not break old behavior. r=shaver, sr=shaver, a=shaver 2008-03-24 15:14:38 -07:00
edward.lee@engineering.uiuc.edu
c82a98dee4 Bug 422177 - Awesome bar interrupts typing, so continue from where it left off. r=dietrich, a1.9b5=mconnor, b-ff3=beltzner. Bug 424388 - Autocomplete results keep disappearing and reappearing when typing more letters. 2008-03-22 23:38:28 -07:00
dietrich@mozilla.com
f1c28ec55e Bug 423960 ? regression: disabling history remembers visits (for mak77@supereva.it, r=dietrich) 2008-03-19 16:18:56 -07:00
dietrich@mozilla.com
b1efb5da96 Bug 420354 ? History not shown in sidebar when sorted by date or by date and site (for ondrej@allpeers.com, r=dietrich) 2008-03-19 14:08:10 -07:00
edward.lee@engineering.uiuc.edu
86937a9632 Bug 393678 - location bar autocomplete should take word boundaries in account. r=dietrich, b-ff3=beltzner 2008-03-18 19:11:05 -07:00
dietrich@mozilla.com
70fe7d928a Bug 419170 ? The history includes too few days, browser.history_expire_days_min is ignored (for mak77@supereva.it, r=dietrich) 2008-03-18 11:03:34 -07:00
mconnor@steelgryphon.com
e296c9749a Bug 329741 - history.dat, formhistory.dat, downloads.rdf should be deleted when the user clears private data, r=gavin 2008-03-18 05:54:23 -07:00
dietrich@mozilla.com
0825242d9e Bug 393498 ? on cut, then undo of a bookmark, we lose the dateAdded and lastModified values (r=mano) 2008-03-17 16:25:36 -07:00
edward.lee@engineering.uiuc.edu
b3c03cf71b Bug 422490 - Throbber keeps spinning when typing in a new url (AwesomeBar keeps searching when there's no results). r=dietrich, b-ff3=beltzner 2008-03-13 21:59:50 -07:00
dietrich@mozilla.com
3930f6f3af Bug 419749 - Add/Update/Delete for items in query set do not seem to close transaction (r=dietrich) 2008-03-12 16:36:24 -07:00
dietrich@mozilla.com
f6d49a16aa Bug 419642 ? WARNING: Unsafe use of LIKE detected! (for ondrej@allpeers.com, r=dietrich) 2008-03-07 10:53:04 -08:00
dietrich@mozilla.com
708034734a Bug 420261 ? "Recent Tags" is not properly refreshed when a new tag is added (for ondrej@allpeers.com, r=dietrich) 2008-03-07 10:47:34 -08:00
dietrich@mozilla.com
3fc0e64ffe Bug 419832 ? Change Livemark service update timings (for mak77@supereva.it, r=dietrich) 2008-03-07 10:35:29 -08:00
dietrich@mozilla.com
a56db7d65b Bug 420003 ? Sort by name on tag container removes titles of tagged links and does not show correct order (for ondrej@allpeers.com, r=dietrich) 2008-03-07 10:09:23 -08:00
reed@reedloden.com
7199e2093e Bug 419877 - "history sidebar unit test failing due to TZ issues" (Use PRTime instead of sqlite date/time functions) [p=ondrej@allpeers.com (Ondrej Brablc) r=dietrich a1.9b4=beltzner] 2008-02-28 02:29:36 -08:00
reed@reedloden.com
3d466a21b1 Bug 419866 - ""Recent Tags" list in smart bookmarks no longer seems to be working" [p=ondrej@allpeers.com (Ondrej Brablc) r=dietrich a1.9b4=beltzner] 2008-02-28 02:27:39 -08:00
edward.lee@engineering.uiuc.edu
862f0ae642 Bug 415460 - searching in places queries does not decode urls. r=dietrich, b-ff3=beltzner 2008-02-26 22:25:40 -08:00
dietrich@mozilla.com
1136b97aea bustage fix for bug 385245 2008-02-26 21:09:25 -08:00
dietrich@mozilla.com
e99b7ee9f2 Bug 385245 ? history sidebar very slow (way slower than fx2) (for ondrej@allpeers.com, r=dietrich) 2008-02-26 20:48:51 -08:00
edward.lee@engineering.uiuc.edu
cbac583318 Bug 401660 - when showing autocomplete result, show tags that partially match. r=dietrich, a1.9=damons 2008-02-25 15:52:14 -08:00
edward.lee@engineering.uiuc.edu
576aaa6a30 Bug 395735 - Instrument the location bar auto-complete to report accuracy. r=dietrich, a1.9=damons 2008-02-25 13:35:57 -08:00
edward.lee@engineering.uiuc.edu
a3c801d0da Bug 417798 - History can fill FF3 addressbar suggestions with unwanted bookmarklets that look almost like real pages but execute in the current page's scope. r=dietrich, b-ff3=beltzner 2008-02-23 16:54:19 -08:00
reed@reedloden.com
51ae6185f5 Bug 376706 - "Can't Delete History by Date when grouped by 'Date' or by 'Date and Site'" [p=mak77@supereva.it (Marco Bonardo [mak77]) r=dietrich a=blocking-firefox3+] 2008-02-22 03:46:29 -08:00
reed@reedloden.com
aae984c88e Bug 402161 - "moz_places_visitcount index is bad in some profiles" [p=mak77@supereva.it (Marco Bonardo [mak77]) r=dietrich a=blocking-firefox3+] 2008-02-22 03:30:44 -08:00
sdwilsh@shawnwilsher.com
03b02f2802 Bug 405497 - Calling RunInBatchedMode within a RunBatched implementation hangs. r=Mano 2008-02-21 20:09:08 -08:00