wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity
149,154 Commits 1 Branch 166 Tags 1.2 GiB
1fa28fd3cd
Commit Graph

342 Commits

Author SHA1 Message Date
Dan Gohman
55d23f9696 Bug 883574 - Add const qualifiers to variables and pointers in the JS tree. r=evilpies 2013-06-17 18:31:47 -07:00
David Zbarsky
7a6db2c997 Fix a typo, no bug 2013-06-17 14:28:11 -07:00
Bobby Holley
5d8b9c031d Bug 880697 - Push in a few other suspicious places. r=gabor 2013-06-12 14:17:56 -07:00
Bobby Holley
dfe5a1b7ea Bug 880697 - Remove dumbContext. r=gabor 
Whew.
 2013-06-12 14:17:56 -07:00
Bobby Holley
ebb40605e8 Bug 880697 - Remove JSD_GetDefaultJSContext and fix callers. r=gabor 2013-06-12 14:17:55 -07:00
Bobby Holley
08897ecc69 Bug 880697 - Replace usage of dumbContext with AutoSafeJSContext. r=gabor 
dumbContext ends up with jsdc->glob as its default global, so we have to be
very careful to audit for any places where the code might be assuming that
its cx is in the compartment of jsdc->glob. Luckily, the code already seems
pretty explicit about its compartments.
 2013-06-12 14:17:55 -07:00
Bobby Holley
4f75c3875f Bug 880697 - Root directly with a runtime in jsd_DestroyScriptHookProc. r=gabor 2013-06-12 14:17:55 -07:00
Bobby Holley
7f1f2366e0 Bug 880697 - Make JS_ClearScriptTraps take a runtime directly. r=gabor 
This obviates the need for a context at the JSD callsite.
 2013-06-12 14:17:55 -07:00
Bobby Holley
f814be5d18 Bug 880697 - Stop using clunky C API in JSD and start using RAII classes. r=gabor 2013-06-12 14:17:54 -07:00
Bobby Holley
ec5b064aee Bug 880697 - Add an RAII class to JSD to save/restore exception state. r=gabor 2013-06-12 14:17:54 -07:00
Bobby Holley
6c71d90238 Bug 879341 - Use an AutoPushJSContext in JSD. r=gabor 
We can do this now, since it won't cause infinite recursion.
 2013-06-04 15:37:59 -07:00
Bobby Holley
a77fe13461 Bug 877235 - Use the default global for just a little bit longer in JSD. r=gabor 2013-05-29 17:49:25 -07:00
Mike Shal
6f32ddf61c Bug 864774 - Part 2: Move CPPSRCS to moz.build as CPP_SOURCES; r=joey CLOSED TREE 
From 9e0ba7f425143f545eb6c4b26a9a96b5ade4d8e9 Mon Sep 17 00:00:00 2001
 2013-04-23 17:54:15 -04:00
Bobby Holley
48e5c84941 Bug 871306 - Use the current global rather than the default global in jsdContext::GetGlobalObject. r=gabor 
As far as I can tell from the IDL docs and digging through the Firebug source,
this is what we want here.
 2013-05-22 15:42:44 -06:00
Bobby Holley
a024c7d683 Bug 871306 - Remove globalObject from jsdIFilter. r=gabor 
It looks like firebug only ever passes null, which is equivalent to not using
it at all.
 2013-05-22 15:42:43 -06:00
Bobby Holley
bf47cc7efa Bug 871306 - Add an API for directly accessing the default JSD global and use it in ActivateDebugger. r=gabor 2013-05-22 15:42:43 -06:00
Bobby Holley
1b2f22fe61 Bug 868130 - Remove the lion's share of JSAutoRequests in gecko. r=gabor 
There are still a handful that either are used with other runtimes, or that
happen very early/late in cx the lifetime of various things where it doesn't
necessarily make sense to have a cx on the stack. This should definitely ensure
that we're not doing double-duty with the nsCxPusher change, though.
 2013-05-22 10:05:28 -06:00
Bobby Holley
ba05c93769 Bug 868130 - Include nsCxPusher.h everywhere we need it, and stop including it from nsContentUtils.h. r=gabor 2013-05-22 10:05:26 -06:00
Joey Armstrong
0d49db0381 bug 869143: phase2 cleanup for XPCSHELL_TEST conversion. r=mshal 2013-05-13 16:24:07 -04:00
Ed Morley
2710e5d6a9 Backed out changeset 496846474ed3 (bug 864774) 2013-05-13 10:05:49 +01:00
Mike Shal
d2b29f4e87 Bug 864774 - Part 2: Move CPPSRCS to moz.build as CPP_SOURCES; r=joey 
From 140b9201e3b5d2d8efe7af286d279c2411dbc197 Mon Sep 17 00:00:00 2001
 2013-04-23 17:54:15 -04:00
Ehsan Akhgari
4b325c9d64 Bug 871192 - Fix more rooting hazards in the JS debugger; r=till 2013-05-12 09:13:22 -04:00
Till Schneidereit
a16f645bce Bug 868369 - remove guard in jsd_SetExecutionHook made superfluous by change in _newJSDScript to align with beta and aurora branches. r=me 
--HG--
extra : rebase_source : 88045156e58f6d65f2ee1e821e24452be1a64a94
 2013-05-06 21:43:57 +02:00
Till Schneidereit
b733362072 Bug 868369 - don't ever create JSDScripts for self-hosted scripts. r=sfink 
--HG--
extra : rebase_source : 2104e9dca9c05c158e78a0ba740227e4a190e125
 2013-05-06 19:17:38 +02:00
Ehsan Akhgari
0cd35f4252 Bug 868790 - Fix some rooting hazards in the JS Debugger; r=till 2013-05-05 17:13:03 -04:00
Andrew McCreight
4247aef614 Bug 867350 - remove JS_UnwrapObject and JS_UnwrapObjectAndInnerize from jsdbgapi.h r=sfink 2013-05-01 09:19:18 -07:00
Joey Armstrong
12356a4c50 bug 844655: Port XPCSHELL_TESTS to moz.build as XPCSHELL_TESTS_MANIFESTS 2013-04-29 14:49:00 -04:00
Aryeh Gregor
e78504c9a9 Bug 859817 - Remove implicit conversions from raw pointer to already_AddRefed; r=Ms2ger 2013-04-22 14:15:59 +03:00
Daniel Holbert
fb5bb1a70d Bug 865396: Insert space between string literal and macro arg, to fix GCC 4.8 Wliteral-suffix build warning. r=sfink 2013-04-24 20:54:24 -07:00
Till Schneidereit
8125daee22 Bug 851788 - prevent jsd_SetExecutionHook from operating on self-hosted functions. r=jimb 2013-04-23 12:58:24 +01:00
Bobby Holley
1a9540312c Bug 860438 - Use nsCxPusher in JSD. r=gabor 2013-04-18 11:36:05 -04:00
Sean Stangl
7c06a2ec68 Bug 860029 - Standardize Modelines in the JS Module. r=njn 2013-04-16 13:47:10 -07:00
Mike Shal
24b4056720 Bug 846634 - Part 2: Move EXPORTS to moz.build; r=joey 2013-04-16 15:24:43 -04:00
Jeff Walden
6539207aee Bug 858677 - Fix up code not built by SpiderMonkey to use the newly-changed deletion signatures. r=bholley, r=billm 2013-04-05 21:22:55 -07:00
Phil Ringnalda
c0b436c32d Back out a5a1dd3bd8ae (bug 860029) for stupidorange 2013-04-15 12:55:38 -07:00
Sean Stangl
efc7d9a873 Bug 860029 - Standardize Modelines in the JS Module. r=njn 2013-04-15 11:33:03 -07:00
Phil Ringnalda
f9e5683baf Back out 5bf9771e1a28 (bug 860029) for bustage 
CLOSED TREE
 2013-04-11 19:55:37 -07:00
Sean Stangl
9c52e8cf81 Bug 860029 - Standardize Modelines in the JS Module. DONTBUILD. r=njn 2013-04-11 18:48:59 -07:00
Andrew McCreight
5600e1404e Bug 856313 - Clean up some Traverse/Unlink declarations. r=smaug 2013-04-02 09:48:59 -07:00
Gabor Krizsanits
e65e82a5ba Bug 820170 - SandboxPrivate for jsd global. r=bholley 2013-04-04 11:27:37 +02:00
Kyle Machulis
f5e3aadf0b Bug 855465 - Add emacs python mode comments to moz.build files; r=gps 2013-04-01 11:36:59 -07:00
Kyle Machulis
d2b6e6e01a Backout for changeset 03452b187c14 (Bug 855465) due to bustage on a CLOSED TREE; r=qdot 2013-03-29 15:12:58 -07:00
Kyle Machulis
5663b98bc5 Bug 855465 - Add emacs python mode comments to moz.build files; r=gps 
--HG--
extra : rebase_source : 004a756492323e1a049586e85b3be5037159df20
 2013-03-29 13:56:18 -07:00
Gregory Szorc
94ec89296d Bug 844654 - Part 3: Remove now empty Makefile.in files; rs=khuey 
--HG--
extra : rebase_source : 8de9c7f68a953e574dda22f8c14c2b2ca60444f9
 2013-03-19 18:49:07 -07:00
Mike Shal
ea1d9b8ba7 Bug 844654 - Part 2: Move MODULE to moz.build; rs=gps 2013-03-19 11:47:00 -07:00
Ms2ger
ecaff4e0d2 Bug 845374 - Part r: Stop including nsTArray.h in nsReadableUtils.h; r=khuey 2013-03-17 08:55:16 +01:00
Mike Shal
2eb7c496cb Bug 818246 - Part 7: Move XPIDL_MODULE to moz.build; rs=gps 2013-03-11 22:00:00 -07:00
Gregory Szorc
629b5d86c6 Bug 818246 - Part 4: Move XPIDLSRCS into moz.build (auto); rs=glandium 
This is the result of running
|mach mozbuild-migrate --list XPIDLSRCS SDK_XPIDLSRCS XPIDL_SOURCES| and
reverting xpcom/sample/*.
 2013-03-12 10:17:46 -07:00
Jon Coppeard
f85957ecb3 Bug 848395 - GC: Move Rooted to JS namespace - rename js::Rooted to JS::Rooted outside SpiderMonkey r=terrence 
--HG--
extra : rebase_source : 35cbf3cc4da4598c2e9e6975028ef397718849db
 2013-03-06 16:41:43 +00:00
Ed Morley
0887cddaa0 Backed out changeset 28ef4bdff455 (bug 848395) 2013-03-07 13:03:35 +00:00
Jon Coppeard
19ed4f05c2 Bug 848395 - GC: Move Rooted to JS namespace - rename js::Rooted to JS::Rooted outside SpiderMonkey r=terrence 
--HG--
extra : rebase_source : 866879df05e3ec3f8e93570eb3f6b71103636b41
 2013-03-06 16:41:43 +00:00
Gregory Szorc
51faf012ef Bug 784841 - Part 18s: Convert /js; r=glandium 2013-02-25 12:47:22 -08:00
Steve Fink
2a42a7a9fb Bug 838014 - More rooting in Debugger, plus some minor rooting in JSD and xpconnect for some should-be-private JSAPI changes. r=terrence 
--HG--
extra : rebase_source : 46febe5421f6e1901f0d5ac2707fb3fdde1894db
 2013-02-12 12:27:02 -08:00
Bobby Holley
e03bc92cec Bug 831076 - Enter a compartment in jsd. r=mrbkap 2013-02-04 15:13:14 +00:00
Bill McCloskey
0b41061a2c Bug 751618 - Add js/GCAPI.h (r=terrence) 2013-01-27 12:35:12 -08:00
Jan de Mooij
223b6a2efc Bug 833817 part 3 - Replace JSStackFrame with JSAbstractFramePtr. r=luke 2013-01-25 09:49:29 +01:00
Trevor Saunders
b98e34aed0 bug 822289 - remove NS_IMPL_CYCLE_COLLECTION_CLASS and friends r=mccr8 2013-01-12 07:40:33 -05:00
Terrence Cole
b97ee61fd5 Bug 811060 - Move DeflateString out of jsstr and make it Typey; r=Waldo 
--HG--
extra : rebase_source : 9d239c525e8b0c04a63770d4ed732c9c6da54a2c
 2012-11-09 09:45:25 -08:00
Benoit Jacob
5a8b82a1cb Bug 807437 - Eliminate redundant Traverse/Unlink CC macros - part 1: automatic changes - r=mccr8 2012-11-15 02:32:40 -05:00
Bill McCloskey
f13e8e29d9 Bug 787856 - Convert JS_GetPrototype to support lazy protos (r=bhackett) 2012-09-03 16:42:17 -07:00
David Anderson
7b70ee195a Merge from mozilla-central. 
--HG--
rename : js/jsd/jsd_scpt.c => js/jsd/jsd_scpt.cpp
rename : js/jsd/jsd_stak.c => js/jsd/jsd_stak.cpp
rename : js/jsd/jsd_val.c => js/jsd/jsd_val.cpp
 2012-09-05 16:18:11 -07:00
David Anderson
9e81520770 Merge from mozilla-central. 
--HG--
rename : content/base/public/nsIFrameMessageManager.idl => content/base/public/nsIMessageManager.idl
 2012-08-29 17:51:24 -07:00
Luke Wagner
c692b48100 Bug 786068 - make JS_EnterCrossCompartmentCall infallible (and call it JS_EnterCompartment) (r=sfink) 2012-08-27 13:32:51 -07:00
David Anderson
fd50a14c90 Merge from mozilla-central. 2012-08-22 16:09:24 -07:00
David Anderson
f3d3148ca7 Merge from mozilla-central. 2012-08-21 15:59:12 -07:00
David Anderson
348793a989 Remove JS_FrameIterator (bug 732653, r=luke,mrbkap). 2012-08-15 17:28:33 -07:00
Ehsan Akhgari
8c296bbcd4 Bug 579517 - Part 1: Automated conversion of NSPR numeric types to stdint types in Gecko; r=bsmedberg 
This patch was generated by a script.  Here's the source of the script for
future reference:

function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
       ! -wholename "*security/nss*" \
       ! -wholename "*/.hg*" \
       ! -wholename "obj-ff-dbg*" \
       ! -name nsXPCOMCID.h \
       ! -name prtypes.h \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.c" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert PRInt8 int8_t
convert PRUint8 uint8_t
convert PRInt16 int16_t
convert PRUint16 uint16_t
convert PRInt32 int32_t
convert PRUint32 uint32_t
convert PRInt64 int64_t
convert PRUint64 uint64_t

convert PRIntn int
convert PRUintn unsigned

convert PRSize size_t

convert PROffset32 int32_t
convert PROffset64 int64_t

convert PRPtrdiff ptrdiff_t

convert PRFloat64 double
 2012-08-22 11:56:38 -04:00
Nicholas Nethercote
015b5205c6 Bug 647367 - Sequester jshash.{h,cpp} in js/jsd/ (attempt 2). r=luke. 
--HG--
rename : js/src/jshash.cpp => js/jsd/jshash.cpp
rename : js/src/jshash.h => js/jsd/jshash.h
 2012-07-18 17:38:10 -07:00
Terrence Cole
c2e391d0f5 Bug 501536 - Make jsd compile as C++; r=luke 
This should be the last real C consumer of JS-API in mozilla-central.

--HG--
rename : js/jsd/jsd_atom.c => js/jsd/jsd_atom.cpp
rename : js/jsd/jsd_high.c => js/jsd/jsd_high.cpp
rename : js/jsd/jsd_hook.c => js/jsd/jsd_hook.cpp
rename : js/jsd/jsd_java.c => js/jsd/jsd_java.cpp
rename : js/jsd/jsd_lock.c => js/jsd/jsd_lock.cpp
rename : js/jsd/jsd_obj.c => js/jsd/jsd_obj.cpp
rename : js/jsd/jsd_scpt.c => js/jsd/jsd_scpt.cpp
rename : js/jsd/jsd_stak.c => js/jsd/jsd_stak.cpp
rename : js/jsd/jsd_step.c => js/jsd/jsd_step.cpp
rename : js/jsd/jsd_text.c => js/jsd/jsd_text.cpp
rename : js/jsd/jsd_val.c => js/jsd/jsd_val.cpp
rename : js/jsd/jsdebug.c => js/jsd/jsdebug.cpp
rename : js/jsd/jsdstubs.c => js/jsd/jsdstubs.cpp
 2012-09-04 09:02:03 -07:00
Luke Wagner
ce71e55555 Bug 625199 - s/JSAutoEnterCompartment/JSAutoCompartment/ and make it infallible (r=bholley) 
--HG--
extra : rebase_source : 12acf2288285f5caefd7fecea8207de3a47eab5b
 2012-08-21 18:42:53 -07:00
Luke Wagner
48412c861d Bug 625199 - kill dummy frames (r=mrbkap) 
--HG--
extra : rebase_source : df4e3bddabf20cdc5b9122370fa62b40e64177c7
 2012-08-17 18:05:06 -07:00
Steve Fink
51e7c767ae Bug 756267 - Move the internal logic to only call script destroy hook if create hook was called from inside the JS engine to JSD, and add a flag for controlling it. r=jorendorff 
--HG--
extra : rebase_source : f561d1d2acf5980f2efd9faf019317bb3306e9b1
 2012-08-17 10:23:21 -07:00
Mike Hommey
c1b35e7b2a Bug 774032 bonus - Use @DEPTH@ and @relativesrcdir@ in Makefile.in. r=ted 2012-08-04 20:26:44 +02:00
Benjamin Peterson
1c1e824772 Bug 780051 - Remove JS_MAX and JS_MIN. r=luke 2012-08-02 20:50:51 -07:00
Aryeh Gregor
57c0ad57fb Bug 777292 part 2 - Change all nsnull to nullptr 2012-07-30 17:20:58 +03:00
Luke Wagner
b844e5f326 Bug 772285 - rm JSPD_ARGUMENT/JSPD_VARIABLE (r=sfink) 
--HG--
extra : rebase_source : 7be9ea3e5e90be9abd65f7d5268741e453cc717b
 2012-07-10 15:34:12 -07:00
Nathan Froyd
5b30baa4c3 Bug 370750 - consolidate mochitest files installation; r=glandium 
With assistance on the patch from Ms2ger, Waldo, and Mossop.
 2012-07-03 16:49:02 -04:00
Luke Wagner
0c274df8bd Bug 755186 - s/JS_NewCompartmentAndGlobalObject/JS_NewGlobalObject/ (r=jorendorff) 
--HG--
extra : rebase_source : f1ead9226915f72473a01db0a1019cdbe50c8e92
 2012-06-20 08:57:29 -07:00
Ehsan Akhgari
8a5e6af383 Bug 758992 - Make the classes which use the XPCOM nsISupports implementation macros final, to avoid the warning about deleting using a pointer to a base class with virtual functions and no virtual dtor (jsd parts); r=Waldo 2012-06-12 23:45:08 -04:00
Randell Jesup
29ac5c0b8c Bug 773151: Convert nsCAutoString->nsAutoCString CLOSED TREE r=bsmedberg 2012-09-01 22:35:17 -04:00
Luke Wagner
8c486830fd Bug 787246 - rm OffTheBooks/Foreground/UnwantedForeground gunk (r=billm) 2012-08-31 15:01:33 -07:00
Jason Orendorff
31a1022fa0 Bug 753542 - Add prefs to enable/disable E4X (javascript.options.xml.content and .chrome). r=bsmedberg, sr=jst. 2012-06-06 21:52:14 -05:00
Jason Orendorff
d0e13c7d3f Bug 753885 - Part 2: Add JSOPTION_ALLOW_XML, making E4X support optional per-context. r=Waldo. 2012-05-30 15:05:59 -05:00
Gervase Markham
87620f5676 Bug 716478 - update licence to MPL 2. 2012-05-21 12:12:37 +01:00
Luke Wagner
d7522046db Bug 690135 - create scope objects eagerly or not at all (r=jimb) 
--HG--
extra : rebase_source : 6b1e37699e0556685b1ed88fa15ab380428b6ffa
 2011-12-20 17:42:45 -08:00
Steve Fink
1b16f82893 Bug 723712 - Test for !isCachedEval assertion failure. r=test 
--HG--
extra : rebase_source : a88931728024e9045947cee4b3e6a5a82030909d
 2012-04-16 11:44:10 -07:00
Steve Fink
ff6423c5f3 Bug 751398 - Make jsdService participate in cycle collection for all of its hooks. r=khuey 
--HG--
extra : rebase_source : dd85ac1398037964cb729afb4c0d6ace07387c7b
 2012-04-30 13:58:38 -07:00
Tom Schuster
889e3a0487 Bug 752226 - Remove any use of JSVAL_IS_OBJECT. r=luke,Ms2ger 2012-05-11 17:46:26 +02:00
Ed Morley
4c4c3cfd18 Backout 9b0fcaacb788 & bf3fef257e68 (bug 752226) for mochitest-other orange 2012-05-11 18:25:52 +01:00
Tom Schuster
6e0861373a Bug 752226 - Remove any use of JSVAL_IS_OBJECT. r=luke,Ms2ger 
--HG--
extra : rebase_source : edf2077f8b8bad1970eab6ebe9996e761d4e596c
 2012-05-11 17:46:26 +02:00
Steve Fink
9dedd97230 Bug 730208 - Root JSD's pet global so it can't participate in CC cycles. r=billm 
--HG--
extra : rebase_source : 9bf6a12faedab111efee048af0e543b2c1881782
 2012-03-20 21:29:47 -07:00
Steve Fink
4817a993d2 Bug 748937 - Switch JSD destroyScript signature from JSContext -> JSFreeOp. r=jorendorff 
This is a warning fix only; JSD doesn't use the argument anyway.

--HG--
extra : rebase_source : 9529bdbfbb387cc03b29abef780e45abb881ed43
 2012-04-27 11:49:57 -07:00
Steve Fink
34c21a01f5 Bug 751396 - Fire slice callbacks only for "outer" GCs. r=billm 
--HG--
extra : rebase_source : d30a5157d0f87bbc691ddf1cd0598974d0e509fc
 2012-05-03 12:32:37 -07:00
Matt Brubeck
657b0b8a57 Back out bug 730208 and bug 747543 because of xpcshell test failures 2012-04-24 20:47:16 -07:00
Steve Fink
c8e72b6a54 Bug 730208 - Root JSD's pet global so it can't participate in CC cycles. r=billm 
--HG--
extra : rebase_source : 9211b881e0c0931bd7df16989bed492449b1c74f
 2012-03-20 21:29:47 -07:00
Igor Bukanov
d3018bc6d8 Bug 737364 - part 2 - replace JSContext with JSRuntime in the GC-related API 
This part replaces the JSContext *cx argument in most GC-related API
with JSRuntime *rt. When possible, the patch removes the code to obtain
a temporary cx just to run the GC.

The patch also removes JS_DestroyContextMaybeGC. That function is not
used in FF code base and its implementation is broken. It requires that
the context has an entered compartment when it is destroyed, which in
turns implies a missing leave compartment call.
 2012-03-28 12:13:30 +02:00
Nicholas Nethercote
ba5600fd65 Bug 711895 - Tweak the warning options used for GCC builds (3rd attempt). r=waldo,derf,khuey,mhommey. 
--HG--
extra : rebase_source : 20540c9b838ee3be6cb0847c1b90fdc3bd44059d
 2012-03-21 22:21:16 -07:00
Nicholas Nethercote
256772d52e Backed out changeset 0124795a8cbb (bug 711895) due to i10n build bustage. r=me. 2012-03-21 21:46:27 -07:00
Nicholas Nethercote
1859bc3ea6 Bug 711895 - Tweak the warning options used for GCC builds (2nd attempt). r=waldo,derf,khuey,mhommey,jwatt. 2012-03-15 19:40:00 -07:00
Igor Bukanov
ed3f5972bd bug 736978 - remove JS_FinalizeStub. r=:billm 
Currently the GC finalizes on the background thread only objects with null
JSClass::finalize. However, this implies that any object that uses
JS_FinalizeStub for the finalizer would be prevented from the background
finalization.

To fix this the patch removes JS_FinalizeStub replacing it with NULL in all
cases when the class has no custom finalizer. For style consistency the patch
also removed the usage of JSCLASS_NO_OPTIONAL_MEMBERS in the static
declarations as the compiler fills the missing fields with null in any cases.
 2012-03-19 15:27:58 +01:00