Commit Graph

125179 Commits

Author SHA1 Message Date
Bobby Holley
35d97256a4 Bug 658909 - Use JS_{,Strict}PropertyOp instead of null when defining value props in nsDOMClassInfo. r=mrbkap
Using JSPropertyOp means a null shape getter, whereas null means that the shape
uses the class getter. This means that stuff like window.top, which is defined
as a non-configurable |own| property in nsDOMClassInfo, was getting set up with
XPC_WN_Helper_GetProperty as its get operation. But this confused
SandboxProxyHandler, which explicitly avoids rebinding class getters/setters,
which in turn meant that our sandboxPrototype feature was relying on the crazy
prototype-climbing behavior of GetWrappedNativeOfJSObject to make stuff like
|this.top| work. We're removing this behavior, so we need to fix nsDOMClassInfo
here.

Here are some DefineProperty cases that I left with null getters/setters:
* nsDOMClassInfo::ResolveConstructor
* The child window stuff at the bottom of nsWindowSH::NewResolve
* Named item resolution in nsNamedArraySH::NewResolve
* document.all stuff (scary!)
* nsHTMLDocumentSH::NewResolve
* nsHTMLFormElementSH::NewResolve
* nsStorage2SH::NewResolve
2013-03-16 22:58:14 -07:00
Bobby Holley
6db2f10d4c Bug 658909 - Implement carefully-checked unwrapping in XPCCallContext. r=mrbkap 2013-03-16 22:58:14 -07:00
Bobby Holley
0ac4a08fc8 Bug 658909 - Set args at XPCCallContext construct time in XPC_WN_GetterSetter. r=mrbkap
It's not clear to me why it's done this way, but it confuses our ability to
determine during wrapper lookup whether we're doing a set or a get. This aligns
the behavior with XPC_WN_CallMethod, including passing JSID_VOID for the name
(which is safe because XPCCallContext explicitly special-cases JSID_VOID and
doesn't call SetName in that case).
2013-03-16 22:58:13 -07:00
Bobby Holley
3e05c5d01b Bug 658909 - Initialize the same fields in both XPCCallContext constructors. r=mrbkap
This is a huge footgun. XPCCallContext is hot, but it's not too hot to be safe
here. Garbage XPCWN and JSObject pointers are bad.
2013-03-16 22:58:13 -07:00
Bobby Holley
7d252db9d9 Bug 658909 - Remove unnecessary ccx param. r=mrbkap 2013-03-16 22:58:13 -07:00
Bobby Holley
98ec54a6bc Bug 658909 - Make isSafeToUnwrap pseudo-dynamic for SOWs. r=mrbkap
This can go away as soon as XBL scopes are no longer behind a pref.
2013-03-16 22:58:13 -07:00
Bobby Holley
b2282e03e7 Bug 658909 - Force |this| computation in SandboxCallableProxyHandler::call when using Xrays. r=bz
Comment says it all.
2013-03-16 22:58:12 -07:00
Daniel Holbert
fbb0c25aed Bug 848159: In jsopcode.cpp, cast formalIndex to be unsigned when comparing it against another unsigned value, since we've already asserted it's nonnegative. r=jandem 2013-03-16 21:38:06 -07:00
Bill McCloskey
bfa3037d1f Bug 759585 - Zones (r=jonco,bhackett,njn,dvander,luke,bz,mccr8,bholley) 2013-03-16 20:36:37 -07:00
Phil Ringnalda
835396f6b3 Back out 9bfca2900825 (bug 694254) for incompetent review 2013-03-16 20:35:53 -07:00
Nicolas B. Pierron
6af702a0f4 Bug 849014 - Check type inference before optimizing regexp calls. r=sstangl 2013-03-16 20:05:46 -07:00
Trevor Saunders
063ecdc9fb bug 694254 - disable test_focus_browserui.xul on win 7/8 to see if it fixes the leak rs=philor 2013-03-16 22:10:32 -04:00
Brian R. Bondy
65b9cefed5 Bug 849342 - Remember passwords preference does not take effect immediately. r=mbrubeck. 2013-03-16 22:12:09 -04:00
Chris Lord
15c14b3e12 Bug 850789 - Pin the dynamic toolbar on screen when the tabs tray is open. r=kats 2013-03-17 01:53:41 +00:00
Chris Lord
c59a4feed2 Bug 850154 - Fix alignment of find-in-page bar after bug 716403. r=sriram
Use the RelativeLayout.LayoutParams instead of LinearLayout.LayoutParams to
make sure the find-in-page bar is aligned to the bottom of the page.
2013-03-17 01:53:40 +00:00
Chris Lord
2ea639cdcb Bug 850724 - Don't hide toolbar on load, or pin while loading. r=kats
UX decisions have been made to not hide the toolbar after the page has finished
loading, and not to pin the toolbar during page loading. These decisions fix
this bug.
2013-03-17 01:53:40 +00:00
Phil Ringnalda
be75725f52 Merge inbound and m-c 2013-03-16 15:09:36 -07:00
Brian Hackett
1bef51ca40 Backout 04695ce03bb6 (bug 836968) for topcrashing on a CLOSED TREE 2013-03-16 15:57:39 -06:00
Ehsan Akhgari
61554acae7 Bug 851814 - Do not clobber the high word of SharedLibrary addresses/offset on Win64; r=jrmuizel
--HG--
extra : rebase_source : 9bf7d5cd3dd71e0e1b315059bce4836663bc3a65
2013-03-16 15:05:32 -04:00
Ms2ger
d1bfe8e9c1 Merge backout on a CLOSED TREE. 2013-03-16 11:09:58 +01:00
Ms2ger
cf62a502a1 Backout changeset f4beba4909b0 and changeset 1666ca9b946b for bc test failures. 2013-03-16 11:09:43 +01:00
Ms2ger
637f274b81 Bug 766546 - Disable test on Mac OS X on a CLOSED TREE. 2013-03-16 10:32:51 +01:00
Ms2ger
d8bb6f3db9 Backout changeset 46585b03426a for assertion failures in test_input_range_mouse_and_touch_events.html on a CLOSED TREE. 2013-03-16 10:11:26 +01:00
Phil Ringnalda
e1fd27660d Back out 6922ed98876a (bug 851603) for failing a test it should have removed
CLOSED TREE
2013-03-16 00:13:19 -07:00
Frank Yan
e7abcb56fd Bug 848150 - Update icon data url in Google search plugin test. a=test-only 2013-03-15 23:38:49 -07:00
Phil Ringnalda
0a4a40cfdb Merge m-c to fx-team 2013-03-15 22:46:04 -07:00
Ehsan Akhgari
19c480342c Bug 851603 - Enable Web Audio in Nightly; r=roc
--HG--
extra : rebase_source : b79d7f2cb0e6257eae2f65bd8637f718324b43f4
2013-03-16 01:35:22 -04:00
Gregory Szorc
852c2c9fdc Bug 846083 - Submit an FHR payload after initialization failure; r=rnewman 2013-03-15 21:31:07 -07:00
Gregory Szorc
e0cb31b4d2 Bug 845935 - Don't perform FHR activities unless fully initialized; r=rnewman 2013-03-15 21:10:08 -07:00
Gregory Szorc
994a0b49e0 Bug 849947 - Flush preferences after FHR document submission; r=glandium, rnewman 2013-03-15 13:19:38 -07:00
Gregory Szorc
304463adfd Bug 830408 - Tests for data reporting notification bar; r=gavin 2013-03-15 10:07:39 -07:00
Eddy Bruel
779c83b67b Bug 808960 - Can't fetch sources packed in jar bundles when debugging chrome; r=past,vporof 2013-03-14 21:57:00 -07:00
Ryan VanderMeulen
d989bc93e8 Merge m-c to inbound. 2013-03-14 21:45:34 -04:00
Richard Newman
c74636b653 Merge m-c to s-c. 2013-03-14 15:31:08 -07:00
Eddy Bruel
08666f1654 Bug 820012 - unable to debug scripts loaded via loadSubScript in Browser Debugger; r=past 2013-03-14 15:21:00 -07:00
Tim Taubert
ea12cd4c5e Bug 841350 - Drag and drop a CTP tab in a new window makes the CTP icon disappear; r=gavin,ttaubert 2013-03-15 14:13:52 +01:00
Paul Rouget
8f8b7ab653 merge fx-team to m-c 2013-03-14 15:18:42 -07:00
Hannes Verschore
be5012c1c0 Backed out changeset 9f39547cfab3 (bug 850534) for yarr crashes on a CLOSED TREE 2013-03-14 23:15:50 +01:00
Benoit Girard
c85d18b694 Bug 850833 - Fix unused function warning. r=bustage CLOSED TREE 2013-03-14 18:10:18 -04:00
Richard Newman
08fbe8babd Merge m-c to s-c. 2013-03-14 15:03:48 -07:00
Ryan VanderMeulen
63f0956fe9 Backed out changeset 3614febde426 (bug 841028) for xpcshell failures on a CLOSED TREE. 2013-03-14 17:55:47 -04:00
Ryan VanderMeulen
fcf51f7c92 Backed out changeset 7d2ea731f5a5 (bug 838374) for B2G test bustage on a CLOSED TREE. 2013-03-14 17:45:49 -04:00
Sebastian Hengst
fc9abd6ffd Bug 845825 - [New tab page] Undo bar: Close button's tooltip not shown. r=ttaubert 2013-03-14 19:56:41 +01:00
Benoit Girard
4ce62426d9 Bug 850833 - Remove desktop logging for Gecko Profiker. r=ehsan
--HG--
extra : rebase_source : 1ed1b6573df4da828efa958af3ff0e2e2a7c1f49
2013-03-14 14:37:04 -04:00
Richard Newman
f403fd66a6 Bug 849353 - Add basic app info section to top level of FHR payload. r=gps 2013-03-14 11:24:12 -07:00
Richard Newman
8ad988fb70 Bug 851209 - Make exceptionStr robust against null exceptions. r=gps 2013-03-14 11:23:47 -07:00
Fernando Jiménez
7c59801006 Bug 843309 - paymentSuccess sometimes does not appear in scope (payment window does not close); r=fabrice 2013-03-14 09:58:34 +01:00
Daniel Holbert
dd74dcaf8c Bug 841827: Mark flex container frame as having a relative height, if it's abspos w/ auto-height and top,bottom both set. r=dbaron
--HG--
rename : layout/reftests/flexbox/flexbox-dyn-changeFrameWidth-1-iframe.html => layout/reftests/flexbox/flexbox-dyn-changeFrameWidth-4-iframe.html
rename : layout/reftests/flexbox/flexbox-dyn-changeFrameWidth-1-ref.xhtml => layout/reftests/flexbox/flexbox-dyn-changeFrameWidth-4-ref.xhtml
rename : layout/reftests/flexbox/flexbox-dyn-changeFrameWidth-1.xhtml => layout/reftests/flexbox/flexbox-dyn-changeFrameWidth-4.xhtml
2013-03-14 01:18:53 -07:00
Makoto Kato
889bbe69b1 Bug 850957 - Update injection test for some functions. r=ehsan 2013-03-14 16:35:33 +09:00
Fabrice Desré
f590dffb40 Bug 848615 - B2G: IPC's nsStringBuffer leak r=bent 2013-03-13 22:55:25 -07:00