Commit Graph

117 Commits

Author SHA1 Message Date
Gregory Szorc
093d067e47 Bug 1055102 - Properly handle Unicode in Bagheera payloads; r=bsmedberg
It was observed that FHR was sending invalid JSON payloads to the
server. Specifically, JSON payloads contained invalid Unicode strings.

Investigation revealed that the culprint was CommonUtils.convertString()
silently swallowing high bytes. When the Bagheera client went to gzip
the JSON payload, the input buffer into gzip was missing high bytes.

This patch changes the bagheera client to UTF-8 encode strings before
gzip, thus ensuring all data is preserved. A corresponding change was
also added to the mock bagheera server implementation.

Alternatively, we could have changed CommonUtils.convertString() to
be high byte aware. However, many consumers rely on this function.
This patch is written with the intent of being uplifted and the change
performed is targeted at the specific problem.

Tests for Unicode preserving behavior have been added to both the
generic Bagheera client and to FHR. The latter test is arguably
not necessary, but peace of mind is a good thing, especially with
FHR.

See also bug 915850.

--HG--
extra : rebase_source : 4efddea7767c2e5f8cf19df247c3aba07c40eec6
extra : amend_source : ae3b6d89efa54fc9ed1794404476622946ad4b22
2014-08-19 09:12:12 -07:00
Nathan Froyd
0adba0b0cc Bug 1045617 followup - remove dummy mach command DONTBUILD; r=me 2014-08-06 12:28:37 -04:00
Nathan Froyd
f62e421d13 Bug 1045617 - move services's run_server.py Makefile rules into mach; r=gps 2014-07-30 15:44:13 -04:00
Steve Workman
1f442e1878 Bug 982816 - Remove extra calls to nextTest in test_hawkrequest.js r=ckarlof 2014-07-08 11:44:03 -07:00
Gregory Szorc
a8fec952c2 Bug 1033836 - Rename services-common to services/common; rs=rnewman
The upcoming build system patches don't support hypthens in path names.
Changing this for that reason is kind of silly, but it's the easiest
way. Besides, nothing else uses hyphens in directory names.

--HG--
extra : rebase_source : 42dda2b1f16a3c0bfe17397a70092362e400530f
2014-07-02 16:49:36 -07:00
Mark Banner
19c7270342 Bug 1020859 Part 1 - Make HawkClient return all the response details for a request, and make deriveHawkCredentials common code. r=jparsons 2014-06-18 10:42:15 +01:00
Mark Hammond
b27f3714b9 Bug 985902 - expose fxaccounts/MOZ_SERVICES_FXACCOUNTS to mozinfo and only run test_hawkclient when enabled. r=ted 2014-03-31 14:15:05 +11:00
Mark Hammond
3682be1ef0 Bug 985212 - check if the username looks like an email address to determine what sync to use. r=rnewman 2014-03-24 11:44:43 +11:00
Phil Ringnalda
dc60ab2e46 Back out b9597187a3d6 (bug 985212) for xpcshell bustage
CLOSED TREE
2014-03-22 21:30:46 -07:00
Mark Hammond
9f6f9d5b81 Bug 985212 - check if the username looks like an email address to determine what sync to use. r=rnewman 2014-03-23 14:20:38 +11:00
Phil Ringnalda
98c5350ad8 Back out 61454adff1d6 (bug 985212) for xpcshell bustage 2014-03-20 21:50:21 -07:00
Mark Hammond
2779b46dec Bug 985212 - check if the username looks like an email address to determine what sync to use. r=rnewman 2014-03-21 14:39:35 +11:00
Richard Newman
75e7c94a27 Bug 978876 - Part 0: add set utilities to CommonUtils. r=gps 2014-03-13 16:37:25 -07:00
Jed Parsons
055d91dec8 Bug 969892 - Fixes and improvements to FxAccounts test suite; r=ttaubert 2014-02-18 09:47:52 -08:00
Jed Parsons
96d06ec0f2 Bug 974990 - hawk request to access lang prefs as infrequently as possible. r=rnewman
--HG--
rename : services/common/hawk.js => services/common/hawkclient.js
rename : services/common/tests/unit/test_hawk.js => services/common/tests/unit/test_hawkclient.js
2014-02-25 09:19:47 -08:00
Geoff Brown
5d64d66697 Bug 969624 - Skip test_storageservice_client.js on Android 2.3 emulator; r=dminor 2014-02-24 17:51:15 -07:00
Sam Penrose
0be9c7ab99 Bug 955953 - FxAccountsClient should set Accept-Language header on all server calls. r=rnewman 2014-02-16 08:39:05 -08:00
Gregory Szorc
5f499af8a5 Bug 972093 - Detect run_next_test() during add_task(); r=ted, rnewman
If an xpcshell test called run_next_test() from inside an add_task(),
bad things would happen. This patch detects that behavior and aborts the
test immediately with an actionable error message.

--HG--
extra : rebase_source : c5cf11070421b95a6fcf476d0a86289a3d0ba73a
extra : amend_source : cec6ad2a751bba01e7d4ecbff0735b39e3326efb
2014-02-12 16:47:29 -08:00
Jed Parsons
f25b27aed0 Bug 967372 - Fix intermittent test_hawk.js failures on Windows. r=ttaubert 2014-02-08 17:07:34 -08:00
Gregory Szorc
aef1d3b82f Bug 970336 - test_restrequest.js times out on Android 2.3 emulator; r=rnewman
--HG--
extra : rebase_source : 686beb0c5ccfab3ebde27f554a3fa60439df5e53
extra : amend_source : 787e95b977f4557073f8c30b9e4e97269e6d1572
2014-02-12 17:16:44 -08:00
Mark Hammond
6942725f5b Bug 965896 - allow a sync startOver to re-enable Firefox Accounts. r=rnewman 2014-02-12 17:25:41 +11:00
Jed Parsons
3199967ef7 Bug 943521 - Use onepw prototcol in fxa client. r=ckarlof 2014-02-04 22:14:30 -08:00
Ryan VanderMeulen
bc5b0fe4e6 Backed out changeset 79b198be3e50 (bug 943521) for xpcshell failures. 2014-02-07 17:55:12 -05:00
Jed Parsons
8c0fcd3390 Bug 943521 - Use onepw prototcol in fxa client. r=ckarlof 2014-02-04 22:14:30 -08:00
Peiyong Lin
757ab497a9 Bug 964735 - Convert libc into Library to make it link lazily. r=Yoric 2014-02-07 10:37:21 -05:00
Tim Taubert
5d977d0da8 Bug 964922 - Enable FxA Sync on Nightly r=markh 2014-01-30 12:09:12 -08:00
Jed Parsons
357c44f512 Bug 957863 - Use FxA auth clock skew in hawk, jwcrypto, and sync. r=warner, r=rnewman 2014-01-23 18:04:38 -08:00
Jed Parsons
f25709861f Bug 959919 - Send X-Client-State header to token server. r=rnewman 2014-01-29 15:02:09 -08:00
Jed Parsons
ed85114ff4 Bug 958464 - Report cause of 401 error from token server. r=ckarlof 2014-01-28 15:01:23 -08:00
Mark Hammond
322fe2a50a Bug 959222 (part 1) - Make browserid_identity a first-class identity module. r=rnewman 2014-01-28 17:51:09 -08:00
Chris Karlof
0000c001cf Bug 772261 - Add duration to token server and client. r=rnewman 2013-12-13 12:12:00 -05:00
Zachary Carter
09185a9092 Bug 935232 - Implement a client for the Firefox Accounts auth server. r=markh 2013-12-02 13:56:24 -08:00
Mike Hommey
f0d1cd1e10 Bug 939044 - Remove most definitions of MODULE. r=mshal 2013-11-19 11:47:39 +09:00
Mark Hammond
eebb974974 Bug 927457 - processTokenResponse fails to handle 401 response correctly. r=gps 2013-10-16 11:32:36 -07:00
Blair McBride
908c3ef327 Bug 451283 - Move log4moz.js to Toolkit as Log.jsm. r=gps,Mossop
--HG--
rename : services/common/log4moz.js => toolkit/modules/Log.jsm
rename : services/common/tests/unit/test_log4moz.js => toolkit/modules/tests/xpcshell/test_Log.js
2013-08-26 11:55:58 -07:00
Gregory Szorc
8b226765e2 Bug 845623 - Intermittent failure in test_storage_server.js; r=gbrown 2013-08-20 11:21:02 -07:00
Gregory Szorc
ba63b1be2d Bug 884421 - Automatically select network ports for /services tests; r=rnewman 2013-07-23 13:53:05 -07:00
Gregory Szorc
c2eba8109d Backout b817406485f8 (bug 884421) for intermittent WinXP failures (bug 896093)
CLOSED TREE
2013-07-22 13:24:45 -07:00
Gregory Szorc
49f266f628 Bug 884421 - Automatic network port selection for /services tests; r=rnewman 2013-07-16 17:14:21 -07:00
Ryan VanderMeulen
7e3e2ab547 Backed out 3 changesets (bug 884421) for intermittent xpcshell failures on a CLOSED TREE.
Backed out changeset 75b7cf367efb (bug 884421)
Backed out changeset 2264c04671c4 (bug 884421)
Backed out changeset 45c529ffbe90 (bug 884421)
2013-07-18 14:08:18 -04:00
Gregory Szorc
9df4bc1b02 Bug 884421 - Automatic network port selection for /services tests; r=rnewman 2013-07-16 17:14:21 -07:00
Chris Manchester
5e59082b81 Bug 884397 - Implement structured logging in Log4Moz; r=gps 2013-07-12 16:39:43 -07:00
Stefan Mirea
691821534a Bug 872758 - Delete all documents on FHR upload; r=gps 2013-06-21 10:30:30 -07:00
Chris Manchester
cc9b642164 Bug 662247 - Replace synchronous appenders with async appenders using OS.File; r=gps 2013-06-20 14:00:14 -07:00
Gregory Szorc
c1b865f669 Bug 873629 - Remove 129 empty Makefile.in files; r=ted 2013-05-17 16:20:11 -07:00
Joey Armstrong
0d49db0381 bug 869143: phase2 cleanup for XPCSHELL_TEST conversion. r=mshal 2013-05-13 16:24:07 -04:00
Joey Armstrong
12356a4c50 bug 844655: Port XPCSHELL_TESTS to moz.build as XPCSHELL_TESTS_MANIFESTS 2013-04-29 14:49:00 -04:00
Nick Alexander
5411bce250 Bug 848519 - Part 3: Replace services-common/preferences.js with gre/modules/Preferences.jsm in imports. r=gavin 2013-04-15 12:45:37 -07:00
Nick Alexander
004449feb1 Bug 848519 - Part 2: Update Makefile.in and test harness. r=gavin 2013-04-15 12:45:33 -07:00
Nick Alexander
8b888a0726 Bug 848519 - Part 1: Move files. r=gavin
--HG--
rename : services/common/preferences.js => toolkit/modules/Preferences.jsm
rename : services/common/tests/unit/test_preferences.js => toolkit/modules/tests/xpcshell/test_Preferences.js
2013-04-15 12:45:29 -07:00