Commit Graph

116 Commits

Author SHA1 Message Date
Jeremy Lea
1800930122 Bug 448830. Make nsIntRect/nsIntMargin/nsIntSize/nsIntPoint different types from nsRect/nsMargin/nsSize/nsPoint different types for better compile-type unit checking. r+sr=roc
--HG--
extra : rebase_source : a331a9e49fbc5931f546919281fcca7f008ab615
2009-01-15 16:27:09 +13:00
Nick Kreeger
6373ae3766 Fixing Bug 454632 - Resizing tree widget always re-scrolls to current index. r=enndeakin,sr=bz. Patch by Stephen Lau <steve@grommit.com>. 2009-01-13 10:50:26 -08:00
Ehsan Akhgari
4d6f0e54b7 Bug 140759 - tree cell content is not aligned to the right when tree direction is right to left; r=roc,gavin sr=roc 2009-01-13 21:30:06 +03:30
Benjamin Smedberg
24e7cb1f78 Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.

--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
Benjamin Smedberg
50621e4f9f Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal. 2009-01-09 11:35:24 -05:00
Benjamin Smedberg
d0b948876f Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
Mark Banner
e3b3b94e98 Additional crashtest fix follow up from bug 399227 - catch errors thrown by functions that now fail, so that the test completes properly 2008-12-22 19:05:25 +00:00
Mark Banner
3209d46da1 Crashtest fix follow up from bug 399227 - Add missing removeAttribute to let the crashtests finish 2008-12-22 17:05:18 +00:00
Mark Banner
5e20bae7bc Bug 399227 Crash @ nsTreeSelection::GetSingle, null mTree. r=enndeakin,sr=Neil 2008-12-22 15:32:19 +00:00
Olli Pettay
b6effe14d5 Bug 430214, patch2, r+sr=roc 2008-12-03 13:11:34 +02:00
Robert O'Callahan
0d380f02a0 Bug 458487 - 'Rework image snapping logic'. r=vlad+joedrew, sr=dbaron 2008-11-04 14:01:21 -08:00
Peter Van der Beken
9a338d486e Fix for bug 461560 (Make nsNamedArraySH::NamedItem not AddRef/Release). r/sr=bz. 2008-10-31 14:40:35 -07:00
Peter Van der Beken
9157896344 Backed out changeset 5d65342d7287 to fix orange 2008-10-31 11:08:24 -07:00
Peter Van der Beken
71167e05be Backed out changeset 5d65342d7287 to fix orange 2008-10-31 11:07:26 -07:00
Benjamin Smedberg
b1918bb2c3 Bug 462381 - Build layout directories in parallel r=ted sr=roc 2008-10-31 09:07:15 -07:00
Peter Van der Beken
155edafd57 Fix for bug 461560 (Make nsNamedArraySH::NamedItem not AddRef/Release). r/sr=bz. 2008-10-31 08:55:59 -07:00
Benjamin Smedberg
09975e25e4 Bug 461359 - Make nsTreeBodyFrame not implement nsITreeBoxObject... nsTreeBoxObject can just call the methods on nsTreeBodyFrame directly, and we avoid nsISupports oddities for bug 396185 r=Enn sr=roc 2008-10-28 00:47:19 -04:00
Bernd
6777c42861 bug 258377, make border collapsed tables to listen for dynamic border style changes r/sr=bzbarsky 2008-10-26 11:11:34 +01:00
Peter Van der Beken
f3f2a880fb Fix for bug 460512 (Avoid AddRef/Release in scriptable helper methods for NodeList). r/sr=bz. 2008-10-22 16:31:14 +02:00
L. David Baron
9d7714304c Make sure DidSetStyleContext methods call the base class DidSetStyleContext, and change the signature to return void. (Bug 459649) r+sr=bzbarsky 2008-10-13 18:03:28 -04:00
Arpad Borsos
8b11d938d2 Bug 456388 - Remove PR_STATIC_CALLBACK and PR_CALLBACK(_DECL) from the tree; r+sr=brendan 2008-10-10 17:04:34 +02:00
Robert O'Callahan
279af36fc7 Backing out bug 448830 2008-09-28 23:13:58 +13:00
Jeremy Lea
92e7030a42 Bug 448830. Make nsIntRect/nsIntMargin/nsIntSize/nsIntPoint their own types so that we can catch errors by distinguishing pixels from appunits. r+sr=roc 2008-09-28 20:38:34 +13:00
Robert O'Callahan
6a45b282aa Backing out bug 448830 2008-09-26 13:10:26 +12:00
Jeremy Lea
67f3afd13b Bug 448830. Make nsIntRect/nsIntSize/nsIntPoint/nsIntMargin separate types so we get appunit vs pixel typechecking. r+sr=roc 2008-09-26 10:42:19 +12:00
Zack Weinberg
a64209d05b Bug 456792 - Two more API cleanups for nsCSSRendering; patch 1; r+sr=roc 2008-09-25 17:53:27 +02:00
Arpad Borsos
d0e70a51bf Bug 452797 - Clean up unused variables in layout/; v6; r+sr=roc 2008-09-20 15:42:03 +02:00
Arpad Borsos
4b13300a8d Bug 452797 - Clean up unused variables in layout/; "crashtest" part; r=roc 2008-09-20 15:18:50 +02:00
Robert O'Callahan
f79290bb0e Bug 450930. Fire a DOM event when painting so that content and chrome can track what's being repainted. r=smaug,sr=dbaron 2008-09-18 21:47:21 +12:00
Zack Weinberg
0f68a207ca Bug 453916: treat transparency strictly as a special case of color alpha. r+sr=dbaron 2008-09-12 08:35:53 -07:00
Olli Pettay
2602e9632c Bug 430394, r+sr=roc 2008-09-09 12:00:02 +03:00
timeless@mozdev.org
b0c349250f Backed out changeset 54215f2cbc66
to fix Bug 454186
SM crashes when try to download file [@ nsString::ToInteger - nsTreeBodyFrame::PaintProgressMeter]
2008-09-08 16:00:32 +02:00
Arpad Borsos
1f62482141 Bug 452797 - Clean up unused variables in layout/; r+sr=roc 2008-09-06 20:38:31 +02:00
Karsten Düsterloh
1879945e28 Bug 434080: GTK treelines are drawn in random colour when no specific rule is given; r/sr=roc 2008-09-01 22:52:38 +02:00
Neil Deakin
7ad96d6b3e Bug 356295. Implement HTML5 drag-drop. r=smaug,neil,sr=roc 2008-08-27 08:07:27 -04:00
Boris Zbarsky
fc1785cbc1 Backed out changeset 6958399a2eb1 o try to fix failed mochitests on Windows and Linux 2008-08-25 11:08:28 -04:00
Neil Deakin
7c92721496 Bug 356295. Implement HTML5 drag-drop API. r=smaug,sr=roc 2008-08-25 21:56:29 +12:00
Dave Camp
66ad0d3422 Backed out changeset 30d900751ca9 to fix unit test orange (Bug 356295) 2008-08-19 17:55:30 -07:00
Neil Deakin
f58dac1bbf Bug 356295. Implement HTML5 drag-drop. r=smaug,sr=roc 2008-08-20 10:31:45 +12:00
Zack Weinberg
c9153c98a8 Bug 446498 – use new border rendering for focus rectangles, and strip dead code. r+sr=vlad 2008-08-06 12:33:18 +02:00
Andrew Smith ext:(%2C%20Rob%20Arnold%20%3Ctellrob%40gmail.com%3E%2C%20L.%20David%20Baron%20%3Cdbaron%40dbaron.org%3E)
49c9b3d67e Implement css3 border-image property. (Bug 378217) r=vlad,dbaron,robarnold 2008-07-16 23:30:25 -07:00
L. David Baron
9e4ceade8e Backed out changeset 9b0b2391485c due to linker errors related to nsStyleStructInlines.h not being included enough. 2008-07-16 22:59:14 -07:00
Andrew Smith ext:(%2C%20Rob%20Arnold%20%3Ctellrob%40gmail.com%3E%2C%20L.%20David%20Baron%20%3Cdbaron%40dbaron.org%3E)
bb4be48531 Implement css3 border-image property. (Bug 378217) r=vlad,dbaron,robarnold 2008-07-16 22:18:38 -07:00
Simon Montagu
dfcf9f51e9 Remove unnecessary argument from SetBidiEnabled. Bug 435856, r+sr=roc 2008-06-16 02:28:17 -07:00
L. David Baron
53f51289fe Rename nsAtomStringList to nsPseudoClassList, since that's what it's for, and we want to make it more than just atoms and strings. Also remove an unused constructor. b=75375 r+sr=bzbarsky 2008-06-02 20:17:35 -07:00
marco.zehe@googlemail.com
b8b85c46b1 bug 424161 - Tree invalidation screwed up badly, getting 6 failures on Mochitest for bug 368835. p=Alexander Surkov (surkov.alexander@gmail.com) r=me, r=Olli.Pettay sr=jonas a1.9=beltzner 2008-04-10 08:11:15 -07:00
roc+@cs.cmu.edu
14c8d05caf Bug 421885. Make tiled image drawing sample only the correct subimage by manually padding if necessary. r=vlad 2008-03-31 02:40:53 -07:00
reed@reedloden.com
601e529c06 Back out Robert O'Callahan's patch from bug 421885 due to reftest failure. 2008-03-28 02:32:03 -07:00
reed@reedloden.com
ddba94bd6d Bug 421885 - "Google reader search results have strange red line and broken border around them" [p=roc@ocallahan.org (Robert O'Callahan [roc]) r=vlad a=blocking1.9+] 2008-03-28 01:54:27 -07:00
reed@reedloden.com
cb78ef1dde Bug 415257 - "Editable trees: input sized wrongly and rows jumping with flexible and non-flexible treecols" [p=paul.rouget@gmail.com (Paul Rouget) r+sr=Neil a1.9=beltzner] 2008-03-18 12:41:34 -07:00