Commit Graph

4995 Commits

Author SHA1 Message Date
Jeff Walden
0d638ca87a Bug 483103 - TM: "Assertion failed: p->isQuad()" with str["-1"]; make str[-1] a non-special property rather than one that returns the length of str. r=brendan 2009-03-17 15:27:31 -07:00
Brendan Eich
fd84f47200 Followup nit-picks for 457065. 2009-03-17 12:52:16 -05:00
Andreas Gal
315a5d0bcb Read barrier for global object properties (463153, r=brendan). 2009-03-17 10:39:51 -07:00
Andreas Gal
6f8cc1ba9e Merge. 2009-03-17 10:27:06 -07:00
Andreas Gal
8fb6a7a444 Use lir->insImmf and emit ins_eq0 centrally in guard() (483365, r=brendan). 2009-03-17 10:26:37 -07:00
Brendan Eich
4117cd07fb Bug 457065. TM: Assertion failure: !fp->callee || fp->thisp == JSVAL_TO_OBJECT(fp->argv[-1]). r=mrbkap 2009-03-17 10:42:44 -04:00
Igor Bukanov
01b205d742 bug 369696 - improving object graph serialization. r=brendan 2009-03-17 09:51:38 +01:00
Jim Blandy
debdb32ef3 Bug 480132: Clone lexical blocks only when needed. r=igor
Terminology:

A "script block" is an object of class Block allocated by the byte
compiler and associated with a script.  Script blocks are never
modified, and may be used as a prototype for a "closure block":

A "closure block" is an object of class Block that holds variables
that have been closed over (although we actually leave the variables
on the stack until we leave their dynamic scope).  A closure block is
a clone of a script block (its prototype is a script block).

Adjust the meanings of fp->blockChain and fp->scopeChain:

  fp->blockChain is always the innermost script block in whose static
  scope we're executing.

  fp->scopeChain is the current scope chain, including 'call' objects
  and closure blocks for those function calls and blocks in whose
  static scope we are currently executing, and 'with' objects for with
  statements; the chain is typically terminated by a global object.
  However, as an optimization, the young end of the chain omits block
  objects we have not yet needed to clone.

Closures need fully reified scope chains, so have js_GetScopeChain
reify any closure blocks missing from the young end of fp->scopeChain
by cloning script blocks as needed from fp->blockChain.  Thus, if we
never actually close over a particular block, we never place a closure
block for it on fp->scopeChain.

Have JSOP_ENTERBLOCK and JSOP_LEAVEBLOCK always keep fp->blockChain
current.  When JSOP_LEAVEBLOCK pops a block from fp->blockChain that
has been cloned on fp->scopeChain, pop fp->scopeChain as well.

Remove the JSFRAME_POP_BLOCKS flag, as it is no longer needed.

Ensure that the JIT won't have to create closure blocks or call
js_PutBlockObject; it can't handle those things yet.  Note our current
script block when we begin recording.  Abort recording if we leave
that block; we can't tell in advance whether it will need to be "put"
in future trace invocations.  Leave trace if we call js_GetScopeChain
while in the static scope of lexical blocks.  Remove JIT tests based
on JSFRAME_POP_BLOCKS.

Verify that generators capture the correct value for blockChain.

Add a constructor to JSAutoTempValueRooter for rooting JSObject
pointers.
2009-03-16 09:55:06 -07:00
Andreas Gal
c5b3eb193e Backed out changeset 10b781704400 (bug 457065). 2009-03-15 23:45:51 -07:00
Brendan Eich
719048c202 Fix bogus assertion (457065, r=gal). 2009-03-15 23:09:50 -07:00
Jason Orendorff
befcabe89e Bug 481444 - TM: objectHook is called on trace, via js_NewObject [@ LeaveTree] or [@ js_SynthesizeFrame]. r=gal.
Thanks Daniel!
2009-03-12 08:34:57 -05:00
Bob Clary
98c4c640f7 bug 452913 - JavaScript Test by Gary Kwong. 2009-03-14 15:27:08 -07:00
Bob Clary
152d76e179 bug 460504 - JavaScript Test by Jesse Ruderman. 2009-03-14 15:27:08 -07:00
Bob Clary
1e81ded1fe bug 466747 - JavaScript Test by Jesse Ruderman. 2009-03-14 15:27:08 -07:00
Bob Clary
d745dbd258 bug 476192 - JavaScript Test by Carsten Book, Jesse Ruderman. 2009-03-14 15:27:08 -07:00
Bob Clary
2494d76a7d bug 479740 - JavaScript Test by Gary Kwong. 2009-03-14 15:27:08 -07:00
Bob Clary
e21a72888c bug 480147 - JavaScript Test by Carsten Book, Jesse Ruderman. 2009-03-14 15:27:08 -07:00
Bob Clary
074e0979bd bug 481800 - JavaScript Test by Gary Kwong. 2009-03-14 15:27:07 -07:00
Bob Clary
b92e885cf8 bug 481989 - JavaScript Test by Gary Kwong. 2009-03-14 15:27:07 -07:00
Bob Clary
d6f16d4d2c bug 482263 - JavaScript Test by Gary Kwong. 2009-03-14 15:27:07 -07:00
Bob Clary
3f17b8b08a bug 482421 - JavaScript Test by Gary Kwong. 2009-03-14 15:27:07 -07:00
Bob Clary
f73e317351 Bug 482783, Bug 481793, Bug 476871, Bug 482349, Bug 482594 - merge js/src/trace-test.js, js/tests/js1_8_1/trace/trace-test.js. 2009-03-14 15:27:07 -07:00
Bob Clary
b80af17a33 bug 483438 - remove public failures from source control. 2009-03-14 15:27:07 -07:00
Bob Clary
af6906d71b bug 483434 - Sisyphus - JavaScript Tests - add support for narcissus. 2009-03-14 15:27:06 -07:00
Bob Clary
af1acbbe04 bug 483433 - comment bug number in spidermonkey-n-1.9.2.tests. 2009-03-14 15:27:05 -07:00
Igor Bukanov
20e6be9c80 bug 362910 - js_GetMethod cleanup. r=brendan 2009-03-14 17:41:47 +01:00
Jim Blandy
74847db9cd Back out 480132: orange on Linux (http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1237017748.1237029269.2403.gz&fulltext=1) 2009-03-14 08:19:58 -07:00
Jim Blandy
bed3611385 Bug 480132: Clone lexical blocks only when needed. r=igor
Terminology:

A "script block" is an object of class Block allocated by the byte
compiler and associated with a script.  Script blocks are never
modified, and may be used as a prototype for a "closure block":

A "closure block" is an object of class Block that holds variables
that have been closed over (although we actually leave the variables
on the stack until we leave their dynamic scope).  A closure block is
a clone of a script block (its prototype is a script block).

Adjust the meanings of fp->blockChain and fp->scopeChain:

  fp->blockChain is always the innermost script block in whose static
  scope we're executing.

  fp->scopeChain is the current scope chain, including 'call' objects
  and closure blocks for those function calls and blocks in whose
  static scope we are currently executing, and 'with' objects for with
  statements; the chain is typically terminated by a global object.
  However, as an optimization, the young end of the chain omits block
  objects we have not yet needed to clone.

Closures need fully reified scope chains, so have js_GetScopeChain
reify any closure blocks missing from the young end of fp->scopeChain
by cloning script blocks as needed from fp->blockChain.  Thus, if we
never actually close over a particular block, we never place a closure
block for it on fp->scopeChain.

Have JSOP_ENTERBLOCK and JSOP_LEAVEBLOCK always keep fp->blockChain
current.  When JSOP_LEAVEBLOCK pops a block from fp->blockChain that
has been cloned on fp->scopeChain, pop fp->scopeChain as well.

Remove the JSFRAME_POP_BLOCKS flag, as it is no longer needed.

Ensure that the JIT won't have to create closure blocks or call
js_PutBlockObject; it can't handle those things yet.  Note our current
script block when we begin recording.  Abort recording if we leave
that block; we can't tell in advance whether it will need to be "put"
in future trace invocations.  Leave trace if we call js_GetScopeChain
while in the static scope of lexical blocks.  Remove JIT tests based
on JSFRAME_POP_BLOCKS.

Verify that generators capture the correct value for blockChain.

Add a constructor to JSAutoTempValueRooter for rooting JSObject
pointers.
2009-03-14 00:58:27 -07:00
Jim Blandy
d72dff994b Back out 480132 fix; static analysis red 2009-03-14 00:57:54 -07:00
Jim Blandy
4778b96a85 Bug 480132: Clone lexical blocks only when needed. r=igor
Terminology:

A "script block" is an object of class Block allocated by the byte
compiler and associated with a script.  Script blocks are never
modified, and may be used as a prototype for a "closure block":

A "closure block" is an object of class Block that holds variables
that have been closed over (although we actually leave the variables
on the stack until we leave their dynamic scope).  A closure block is
a clone of a script block (its prototype is a script block).

Adjust the meanings of fp->blockChain and fp->scopeChain:

  fp->blockChain is always the innermost script block in whose static
  scope we're executing.

  fp->scopeChain is the current scope chain, including 'call' objects
  and closure blocks for those function calls and blocks in whose
  static scope we are currently executing, and 'with' objects for with
  statements; the chain is typically terminated by a global object.
  However, as an optimization, the young end of the chain omits block
  objects we have not yet needed to clone.

Closures need fully reified scope chains, so have js_GetScopeChain
reify any closure blocks missing from the young end of fp->scopeChain
by cloning script blocks as needed from fp->blockChain.  Thus, if we
never actually close over a particular block, we never place a closure
block for it on fp->scopeChain.

Have JSOP_ENTERBLOCK and JSOP_LEAVEBLOCK always keep fp->blockChain
current.  When JSOP_LEAVEBLOCK pops a block from fp->blockChain that
has been cloned on fp->scopeChain, pop fp->scopeChain as well.

Remove the JSFRAME_POP_BLOCKS flag, as it is no longer needed.

Ensure that the JIT won't have to create closure blocks or call
js_PutBlockObject; it can't handle those things yet.  Note our current
script block when we begin recording.  Abort recording if we leave
that block; we can't tell in advance whether it will need to be "put"
in future trace invocations.  Abort recording if we call
js_GetScopeChain while in the static scope of lexical blocks.  Remove
JIT tests based on JSFRAME_POP_BLOCKS.

Verify that generators capture the correct value for blockChain.

Add a constructor to JSAutoTempValueRooter for rooting JSObject
pointers.
2009-03-13 23:43:32 -07:00
Robert Sayre
8e061e35da Backout patch for Bug 480132. Debug only nit fix busts static analysis compile. 2009-03-14 02:20:45 -04:00
Jim Blandy
40e8a7d560 Bug 480132. SpiderMonkey clones too many blocks into the heap. r=igor 2009-03-14 02:09:28 -04:00
Jim Blandy
249eed4eb3 Back out fix for 481444; orange on Linux TraceMonkey unit test: http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1236978913.1236990062.26824.gz&fulltext=1 2009-03-13 18:07:25 -07:00
Jason Orendorff
f7ad0e9e06 Bug 481444 - TM: objectHook is called on trace, via js_NewObject [@ LeaveTree] or [@ js_SynthesizeFrame]. r=gal.
Thanks Daniel!
2009-03-12 08:34:57 -05:00
Igor Bukanov
8021720a68 backout merge 2009-03-13 18:37:27 +01:00
Igor Bukanov
4b95050fe2 Backed out changeset 57de81309176 - bug 437325 - due to mochitest leaks on tinderbox 2009-03-13 18:36:46 +01:00
Igor Bukanov
a9dd7cc7ab triggering tinderbox rebuild for bug 437325 to check if orange there persists 2009-03-13 16:06:23 +01:00
Igor Bukanov
3de011b9cd bug 437325 - JSThread is no longer shared between runtimes. r=brendan 2009-03-13 12:36:21 +01:00
Igor Bukanov
75640ecce1 Backed out changeset 4159ebdfe31e to fix some typos in the patch 2009-03-13 12:21:04 +01:00
Igor Bukanov
8eeedd9647 bug 437325 - JSThread is not shared between runtimes. r=brendan 2009-03-13 12:10:34 +01:00
Robert Sayre
d1d5f4493f Merge mozilla-central to tracemonkey. 2009-03-13 02:40:28 -04:00
Graydon Hoare
b65177a23f Bug 482263 - Avoid re-entering recorder while deep aborting, r=mrbkap. 2009-03-12 20:14:51 -07:00
Robert Sayre
ef566ce8da Merge tracemonkey to mozilla-central. 2009-03-12 21:56:18 -04:00
Graydon Hoare
2b47f671ac Backout changeset 5e0cc374593c for bug 482800. 2009-03-12 16:15:33 -07:00
Andreas Gal
d3533c3025 Don't emit overflow guards if the operation is constant (483030, r=danderson). 2009-03-12 16:51:34 -04:00
Andreas Gal
7118a3b6b6 Make sure we don't walk out of a thin loop even if the loop condition is constant (482800, r=danderson). 2009-03-12 16:49:29 -04:00
Igor Bukanov
16863b8913 triggering rebuild to check if bug 482038 really caused tinderbox failures 2009-03-12 15:04:00 +01:00
Ted Mielczarek
efd484eecc bug 482733 - nsinstall.py should support copying directories recursively. r=pike (fix the js/src copy as well) 2009-03-12 09:42:23 -04:00
timeless@mozdev.org
292ef18fb2 Bug 482809 Crash [@ jsds_SyncFilter(FilterRecord*, jsdIFilter*) ] when appendFilter() called with Console2 installed
removing errant change that crept into rev 36f4da6e262a with the fix for bug 136292
r=roc
2009-03-12 13:04:48 +01:00
timeless@mozdev.org
e4571da779 Bug 482809 Crash [@ jsds_SyncFilter(FilterRecord*, jsdIFilter*) ] when appendFilter() called with Console2 installed
removing errant change that crept into rev 36f4da6e262a with the fix for bug 136292
r=roc
2009-03-12 12:31:34 +01:00