L. David Baron
0d0cdd5410
Bug 898329 patch 4: Avoid using newContext outside of what will be in RestyleManager::RestyleSelf. r=heycam
...
This replaces newContext with mFrame->StyleContext(), which is a valid
replacement since all of the replacements are inside a test that we
don't have a framechange hint. If we have a framechange hint, then
mFrame still has its old style context.
2013-07-30 17:36:11 -07:00
L. David Baron
8c39cda548
Bug 898329 patch 3.5: Don't check undisplayed content if we're going to reframe. r=heycam
...
This avoids doing work that is unnecessary; if we're going to reframe
anyway, the frame destruction will clear the undisplayed content list,
and we'll then rebuild it when we recreate the frame (if needed).
It is also a prerequisite for patch 4, which replaces some uses of
newContext with mFrame->StyleContext(). These are the same as long as
we don't have a framechange hint, since when we do have a framechange
hint we leave the old style context on the frame to avoid violating
invariants. This patch ensures that all such uses replaced in patch 4
are actually inside a check that we don't have a framechange hint.
(Most of them already were.)
2013-07-30 17:36:11 -07:00
L. David Baron
069d654106
Bug 898329 patch 3: Create and use ElementRestyler::mWasFrameVisible. r=heycam
2013-07-30 17:36:11 -07:00
L. David Baron
6edf3e771d
Bug 898329 patch 2: Fix indentation in ReParentStyleContext from patch 1. r=heycam
2013-07-30 17:36:11 -07:00
L. David Baron
7b10df02a0
Bug 898329 patch 1: Remove null-checks on oldContext and newContext and avoid manual reference counting. r=heycam
2013-07-30 17:36:11 -07:00
L. David Baron
aee2be3fd9
Bug 898209 patch 15: Use constructor flags on ElementRestyler's regular constructor to avoid manipulating mHintsHandled from the outside. r=heycam
...
This is the second of two patches added on top to address review
comments on patch 2.
2013-07-30 17:36:10 -07:00
L. David Baron
07bdb25977
Bug 898209 patch 14: Add constructor flags to ElementRestyler's regular constructor so we can avoid manipulating mHintsHandled from the outside. r=heycam
...
This is the first of two patches added on top to address review comments
on patch 2.
2013-07-30 17:36:10 -07:00
L. David Baron
8c05c48f7d
Bug 898209 patch 13: Create and use ElementRestyler::mTreeMatchContext. r=heycam
2013-07-30 17:36:10 -07:00
L. David Baron
812f86eb07
Bug 898209 patch 12: Create and use ElementRestyler::mVisibleKidsOfHiddenElement. r=heycam
2013-07-30 17:36:10 -07:00
L. David Baron
52ab982fe7
Bug 898209 patch 11: Create and use member variables for accessibility notifications. r=heycam
2013-07-30 17:36:10 -07:00
L. David Baron
a663478e1a
Bug 898209 patch 10: Create and use ElementRestyler::mRestyleTracker. r=heycam
2013-07-30 17:36:10 -07:00
L. David Baron
59a41597b1
Bug 898209 patch 9: Create and use ElementRestyler::mParentFrameHintsNotHandledForDescendants and mHintsNotHandledForDescendants. r=heycam
2013-07-30 17:36:10 -07:00
L. David Baron
6d0532d145
Bug 898209 patch 8: Create and use ElementRestyler::mChangeList. r=heycam
2013-07-30 17:36:10 -07:00
L. David Baron
739a42f65e
Bug 898209 patch 7: Fix remaining variable shadowing warning. r=heycam
2013-07-30 17:36:10 -07:00
L. David Baron
9c7983dbd5
Bug 898209 patch 6: Create and use ElementRestyler::mParentContent and mContent. r=heycam
2013-07-30 17:36:09 -07:00
L. David Baron
4a58134c69
Bug 898209 patch 5: Remove the localContent variable in favor of writing mFrame->GetContent(). r=heycam
2013-07-30 17:36:09 -07:00
L. David Baron
62d516ab40
Bug 898209 patch 4: Remove aPresContext parameter to ElementRestyler::Restyle. r=heycam
2013-07-30 17:36:09 -07:00
L. David Baron
59c10658b8
Bug 898209 patch 3: Create and use ElementRestyler::mFrame. r=heycam
2013-07-30 17:36:09 -07:00
L. David Baron
2fa0e6ec12
Bug 898209 patch 2: Create and use ElementRestyler::mHintsHandled. r=heycam
2013-07-30 17:36:09 -07:00
L. David Baron
ef1ccb845b
Bug 898209 patch 1: Add ElementRestyler class to begin refactoring ReResolveStyleContext. r=heycam
2013-07-30 17:36:09 -07:00
L. David Baron
48ff61e4ab
Bug 896138 patch 10: Move beginning and ending of ProcessPendingRestyles into helper functions on the RestyleManager. r=heycam
2013-07-30 17:36:08 -07:00
Ehsan Akhgari
085494b95d
Bug 895322 - Part 1: Replace the usages of MOZ_STATIC_ASSERT with C++11 static_assert; r=Waldo
...
This patch was mostly generated by running the following scripts on the codebase, with some
manual changes made afterwards:
# static_assert.sh
#!/bin/bash
# Command to convert an NSPR integer type to the equivalent standard integer type
function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
! -wholename "*security/nss*" \
! -wholename "*/.hg*" \
! -wholename "obj-ff-dbg*" \
! -name nsXPCOMCID.h \
! -name prtypes.h \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.cc" \
-o -iname "*.mm" \) | \
xargs -n 1 `dirname $0`/assert_replacer.py #sed -i -e "s/\b$1\b/$2/g"
}
convert MOZ_STATIC_ASSERT static_assert
hg rev --no-backup mfbt/Assertions.h \
media/webrtc/signaling/src/sipcc/core/includes/ccapi.h \
modules/libmar/src/mar_private.h \
modules/libmar/src/mar.h
# assert_replacer.py
#!/usr/bin/python
import sys
import re
pattern = re.compile(r"\bMOZ_STATIC_ASSERT\b")
def replaceInPlace(fname):
print fname
f = open(fname, "rw+")
lines = f.readlines()
for i in range(0, len(lines)):
while True:
index = re.search(pattern, lines[i])
if index != None:
index = index.start()
lines[i] = lines[i][0:index] + "static_assert" + lines[i][index+len("MOZ_STATIC_ASSERT"):]
for j in range(i + 1, len(lines)):
if lines[j].find(" ", index) == index:
lines[j] = lines[j][0:index] + lines[j][index+4:]
else:
break
else:
break
f.seek(0, 0)
f.truncate()
f.write("".join(lines))
f.close()
argc = len(sys.argv)
for i in range(1, argc):
replaceInPlace(sys.argv[i])
--HG--
extra : rebase_source : 4b4a4047d82f2c205b9fad8d56dfc3f1afc0b045
2013-07-18 13:59:53 -04:00
Corey Ford
5833dd725c
Bug 894629 - Reference containing block's content box for relatively positioned elements in RestyleManager::RecomputePosition. r=dbaron
2013-07-22 09:28:31 -07:00
Robert O'Callahan
1151b8a8a1
Fix bustage for bug 886295
2013-07-22 16:30:18 +12:00
Robert O'Callahan
53a01fa207
Bug 886295. Backout fix for bug 880854 to fix regression. r=mats
...
--HG--
extra : rebase_source : 66bc089c3ece4dbe4f6533fce97a902abdd4871a
2013-07-22 14:04:46 +12:00
L. David Baron
8d8a067407
Bug 896138 patch 9: Move RecomputePosition to a more logical place in the .cpp file, near other hint handling implementations. No review.
2013-07-20 12:14:25 -07:00
L. David Baron
c9a702e711
Bug 896138 patch 7: Remove unused aFrameManager parameters to some functions. r=heycam
2013-07-20 12:14:25 -07:00
L. David Baron
33de67ec1b
Bug 896138 patch 6: Move restyle management code from nsFrameManager to RestyleManager. r=heycam
...
This is the second of two big chunks of code moved into the new
RestyleManager class from another sources.
Note that the undisplayed map remains in nsFrameManager, although it
could perhaps have moved.
2013-07-20 12:14:25 -07:00
L. David Baron
0354744354
Bug 896138 patch 4: Move restyle management code from nsCSSFrameConstructor to RestyleManager. r=heycam
...
This moves restyling management out of nsCSSFrameConstructor (thus
reducing its size), and keeps the restyling code closer together.
This is the first of two big chunks of code moved in this patch series.
A later patch in this series will move related code from nsFrameManager
into the same destination file.
2013-07-20 12:14:25 -07:00
L. David Baron
67d46003ba
Bug 896138 patch 2: Add a RestyleManager class. r=heycam
...
The later patches in this series will move restyling code into this file
from nsCSSFrameConstructor and nsFrameManager.
2013-07-20 12:14:24 -07:00
