Commit Graph

874 Commits

Author SHA1 Message Date
Shawn Huang
ca6d9f4f08 Bug 979160 - Outgoing connection failure shall trigger OnConnect instead of OnDisconnect, r=echou 2014-03-10 10:33:32 +08:00
Ryan VanderMeulen
fee54ff24f Backed out changesets a7ea2d51414d and 901717199390 (bug 957917) for causing bug 980375. 2014-03-06 16:30:35 -05:00
Thomas Zimmermann
358e315d3e Bug 978809: Send ToggleBtAck after finishing BlueZ connection setup, r=echou
With this patch, ToggleBtAck is sent by the BlueZ backend of
Bluetooth after the connection has been set up completely.
2014-03-06 12:45:16 +01:00
Thomas Zimmermann
59813d6a1f Bug 978809: Remove sToggleBtMonitor from Bluedroid backend, r=echou
When enabling or disabling Bluetooth, the Bluedroid backend waits
on sToggleBtMonitor until a BT adapter has been activated. Once
the monitor gets notified, the backend sends a ToggleBtAck runnable
to the main thread.

This patch removes sToggleBtMonitor from the Bluetooth Bluedroid
backend. Instead of signalling the monitor's notification, the
Bluedroid handler function sends the ToggleBtAck directly.
2014-03-06 12:43:35 +01:00
Eric Chou
e7759d8ae3 Bug 976943 - Replace OnConnect/OnDisconnect with one function, f=btian, r=gyeh
In BluetoothProfileController, it's meaningless to separate OnConnect
and OnDisconnect since the following steps would be the same for both
cases. Therefore I introduced a function called NotifyCompletion() for
each profile manager to report the completion of connecting/disconnecting
operations.
2014-03-06 19:26:28 +08:00
Eric Chou
1fc9272c77 Bug 976943 - Add error handing for connect/disconnect process, f=btian, r=gyeh 2014-03-06 19:26:22 +08:00
Eric Chou
fbb9be6ba1 Bug 976883 - Handle unknown property sent from bt stack properly, f=btian, r=shuang 2014-03-05 15:50:54 +08:00
Shawn Huang
d55fedaad4 Bug 951634: Add TimerCallback in Profile Controller, r=gyeh 2014-01-29 19:13:10 +08:00
Vicamo Yang
1df6a7d262 Bug 957917 - 2/2: test cases. r=hsinyi 2014-03-05 10:37:45 +08:00
Jamin Liu
8eeb05bde8 Bug 972730 - Avoid disabling BT before the BT adapter is initialized in marionette test. r=echou, f=vicamo
The current Bluetooth API can't allow user to disable BT before the BT
adapter is initialized.
In practice, We block the clicking event in gaia layer to prevent user
to turn off BT before BT enable procedure complete.
If we use marionette test to force emulator turn on and turn off BT in
a short period of time, it may crash emulator.

Listen to 'adapteradded' event rather than 'enabled' as the end of
BT enable to make sure we wouldn't disable BT when it's not ready.
2014-03-03 10:20:24 -05:00
Thomas Zimmermann
f3401e1c87 Bug 977146: Push ToggleBtAck into implementations of {Start|Stop}Internal, r=echou
The methods {Start|Stop}Internal for BlueZ and Bluedroid now send
ToggleBtAck to signal completeness of the operation.

The current patch allows for further cleanups in the BlueZ code. It
does not change the semantics or code flow.
2014-03-03 13:07:17 +01:00
Thomas Zimmermann
714a2b2204 Bug 977146: Declare ToggleBtAck in header file, r=echou
Declaring ToggleBtAck in the header file of BluetoothService makes
it available ot others classes.
2014-03-03 13:07:17 +01:00
Thomas Zimmermann
f9675b3254 Bug 977146: Set PROP_BLUETOOTH_ENABLED in ToggleBtAck, r=echou
PROP_BLUETOOTH_ENABLED signals the Bluetooth state to other
components in the system. Setting its value in ToggleBtAck
on the main thread avoids duplicated code in the upcoming
patches.
2014-03-03 13:07:16 +01:00
Carsten "Tomcat" Book
236427f5bf Merge mozilla-central to b2g-inbound 2014-02-27 15:59:39 +01:00
Hsin-Yi Tsai
334747f140 Bug 881174 - part5 - cdma 3way call: BT. r=gyeh 2014-02-21 17:53:23 +08:00
Ben Tian
7214cc65d3 Bug 939672 - Patch 2/2: Move NS_DECL_ISUPPORTS and NS_DECL_NSIOBSERVER into BluetoothProfileManagerBase.h 2014-02-20 18:15:47 +08:00
Ben Tian
b0d8828c19 Bug 939672 - Patch 1/2: [bluedroid] Add fallback BluetoothHfpManager, r=gyeh
--HG--
rename : dom/bluetooth/bluedroid/BluetoothHfpManager.cpp => dom/bluetooth/bluedroid/hfp/BluetoothHfpManager.cpp
rename : dom/bluetooth/bluedroid/BluetoothHfpManager.h => dom/bluetooth/bluedroid/hfp/BluetoothHfpManager.h
2014-02-25 11:37:37 +08:00
Ben Tian
b13bcbca73 Bug 972732 - Patch 1/2: Remove bluez/linux and bluedroid/gonk folders, r=echou
--HG--
rename : dom/bluetooth/bluedroid/gonk/BluetoothServiceBluedroid.cpp => dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp
rename : dom/bluetooth/bluedroid/gonk/BluetoothServiceBluedroid.h => dom/bluetooth/bluedroid/BluetoothServiceBluedroid.h
rename : dom/bluetooth/bluez/linux/BluetoothDBusService.cpp => dom/bluetooth/bluez/BluetoothDBusService.cpp
rename : dom/bluetooth/bluez/linux/BluetoothDBusService.h => dom/bluetooth/bluez/BluetoothDBusService.h
2014-02-25 10:38:51 +08:00
Ehsan Akhgari
f870f4f3d0 Bug 975732 - Move one CXXFLAGS variable in dom/bluetooth to DEFINES; r=mshal 2014-02-22 21:42:12 -05:00
Ehsan Akhgari
f1e844fd62 Bug 935778 - Part 0.4: Spray even more MOZ_DECLARE_REFCOUNTED_TYPENAME across the tree 2014-02-21 09:11:33 -05:00
Thomas Zimmermann
405bf0e97a Bug 972253: Remove GetDBusConnection, r=echou
All calls to GetDBusConnection have been replaced by direct references
to sDBusConnection.
2014-02-20 12:56:11 +01:00
Thomas Zimmermann
dc6988b2be Bug 972253: Cleanup Start/Stop methods in BlueZ backend, r=echou
This patch cleans up the code for starting and stopping DBus
connections in the BlueZ backend of Bluetooth. It also fixes
a bug were the initial 'adapteradded' reply might have been
missed.
2014-02-20 12:55:57 +01:00
Thomas Zimmermann
e55b242e41 Bug 972253: Merge the content of DBusThread.cpp into Bluetooth code, r=echou
DBusThread.{cpp,h} maintains state for Bluetooth. This patch moves
the content of these files to Bluetooth's Bluez backend.
2014-02-20 12:55:41 +01:00
Sam Joch
05d227e6b6 Bug 968215 - SettingsService needs to have a callback when transaction are completed. r=bent 2014-02-07 12:19:58 +01:00
Thomas Zimmermann
524ed620dd Bug 969314: Cleanup Gonk start/stop code in BluetoothDBusService, r=echou
This patch removes all unnecessary code when starting and stopping
Gonk in BluetoothDBusService. The change simplifies the respective
methods considerably.
2014-02-13 16:28:11 +01:00
Thomas Zimmermann
e2ca916054 Bug 969314: Cleanup handling of libbluedroid.so, r=echou
This patch cleans up the handling of libbluedroid.so and its
interfaces. Open and closing the library is now handled internally
and contained functions are wrapped in class methods.
2014-02-13 16:28:09 +01:00
Thomas Zimmermann
05248a2faa Bug 969314: Merge BluetoothGonkService into BluetoothDBusService, r=echou
This patch merges the code from BluetoothGonkService into
BluetoothDBusService. The merged code is protected by ifdef
statements.
2014-02-13 16:28:07 +01:00
Vicamo Yang
688d10a1be Bug 969109 follow-up: strictly define the order of participating promises. r=echou, f=jaliu 2014-02-13 19:52:05 +08:00
Ben Tian
a4430f867c Bug 969447 - Unable to turn bluetooth on after turning it on and off several times, r=echou, a=1.3+ 2014-02-13 12:08:41 +08:00
Ryan VanderMeulen
d2ec89c8d0 Backed out changeset eea91c2d859d (bug 969447) for Marionette-webapi bustage.
CLOSED TREE
2014-02-11 12:48:09 -05:00
Ben Tian
8c22c727a9 Bug 969447 - Unable to turn bluetooth on after turning it on and off several times, r=echou 2014-02-11 18:14:58 +08:00
Eric Chou
fff01c4303 Bug 962310 - Support in-process bt file transfer, f=bent, r=gyeh
Currently if an app which lives in chrome process calls SendFile()
to send a file via Bluetooth, it would crash.
2014-02-11 10:07:23 +08:00
Carsten "Tomcat" Book
fdd1afb70a merge b2g-inbound to mozilla-central 2014-02-10 12:52:16 +01:00
Vicamo Yang
fdbcbdbad9 Bug 969109: fix racing condition in test_dom_BluetoothManager_enabled.js. r=echou, f=jaliu 2014-02-10 12:03:43 +08:00
Chris Peterson
c87e8bfa46 Bug 952785 - RawDBusConnection::SendWithReply() returns bool, not nsresult. r=echou 2014-02-09 12:44:05 -08:00
Thomas Zimmermann
1e6a5b445b Bug 964817: Invoke DBus send operations on I/O thread, r=echou
Currently, the DBus connection for Bluetooth is shared between the
main thread and the I/O thread. This causes race conditions when
starting or stopping Bluetooth.

This patch moves all occurences of main-thread-invoked DBus send
operations to the I/O thread. This is mostly refactoring. Internally,
send operations are already executed on the main thread, so there is
no change in the over all logic of these methods.
2014-02-06 13:44:46 +01:00
Thomas Zimmermann
257bd53794 Bug 843857: Don't listen if connect fails on BT server, r=echou
If the listen operation fails for Bluetooth servers, we should
not call listen again in the error handler. Otherwise, we run
into an endless loop of listen calls and error callbacks.
2014-02-05 14:17:22 +01:00
Jon Coppeard
50e1f34d5a Bug 959787 - Handlify JS_GetProperty and related APIs r=terrence r=bz 2014-01-31 09:55:20 +00:00
Birunthan Mohanathas
e81a8f702d Bug 828300 - Replace NS_ARRAY_LENGTH with mozilla::ArrayLength/MOZ_ARRAY_LENGTH. r=ehsan 2014-01-30 13:26:54 -05:00
Kyle Huey
f105033d5c Bug 965498 - Don't lose an already_AddRefed<T> and leak blobs in bluetooth. r=qdot 2014-01-29 17:03:51 -05:00
Ben Tian
edea0147d3 Bug 957949 - [HFP] Add B2G common bluedroid config file, r=echou 2014-01-15 11:50:27 +08:00
Ben Tian
88b73b0670 Bug 921999 - Bluetooth Device connection status in Settings is incorrect if remote headset restores connection, r=gyeh 2014-01-23 10:46:45 +08:00
Gina Yeh
a3eb2efd58 Bug 952907 - Patch 1: Use WebIDL codegen to implement Bluetooth events, r=smaug 2014-01-22 14:26:29 +08:00
L. David Baron
4f04bcdc57 Bug 976350 patch 1: Move the contents of nsTraceRefcnt.h into nsISupportsImpl.h. r=bsmedberg
This makes sense since the file no longer contains anything with the
nsTraceRefcnt name in it, and it will allow renaming nsTraceRefcntImpl
back to nsTraceRefcnt.
2014-02-26 13:36:35 -08:00
Jamin Liu
a4869641e7 Bug 953045 - Fix a bug of bluetooth AVRCP to support media metadata updating correctly. f=shuang, r=echou 2014-01-17 18:15:37 +08:00
Ryan VanderMeulen
aabad2abb4 Merge m-c to inbound. 2014-01-16 15:07:22 -05:00
Ryan VanderMeulen
b05202b7e2 Merge inbound to m-c. 2014-01-16 15:06:12 -05:00
Terrence Cole
f017da90d9 Bug 959787 - Handlify several JSAPI interfaces that can GC, Part 3; r=sfink
--HG--
extra : rebase_source : ace7b0fa6ba93acbf0ec8ecaeb68ffa287a33665
2014-01-16 09:48:58 -08:00
Shawn Huang
1793a7b7be Bug 953034 - Part 2: Change MediaNumber type to uint64_t. r=gyeh 2014-01-16 08:39:34 -05:00
Shawn Huang
08d8978fb6 Bug 953034 - Part 1: Reply RegisterNotification event EVENT_TRACK_CHANGED with correct parameter whether a track is selected or not. r=gyeh 2014-01-16 08:39:14 -05:00
Shawn Huang
c231ddb423 Bug 950220 - Unable to change Bluetooth device name from Settings UI, r=echou 2014-01-16 14:36:35 +08:00
Tom Schuster
e64b35e141 Bug 939294 - Change xpidl jsval to handles. r=gabor,bz,khuey,bsmedberg,terrence 2014-01-09 18:39:36 +01:00
Ben Tian
0e05b3a258 Bug 948337 - create BluetoothHfpManagerBase for audio manager access 2014-01-13 13:58:43 +08:00
Jamin Liu
6c1b84b456 Bug 953036 - Set HSP flag when BluetoothHfpManager chooses to connect HSP. r=echou 2014-01-10 08:23:13 -05:00
Ben Tian
b09206d9f0 Bug 956258 - [cleanup] Patch 2/2: reduce warnings and remove cancel_discovery() in SendFile(), r=echou 2014-01-03 17:25:04 +08:00
Ben Tian
d395920253 Bug 956258 - [cleanup] Patch 1/2: rename g* variables to s* ones, r=echou 2014-01-10 09:34:43 +08:00
Thomas Zimmermann
473a6d5afc Bug 950891: Don't run GetServiceChannel while turning Bluetooth on/off, r=echou
This patch adds a check to BluetoothDBusService::GetServiceChannel to
ensure that Bluetooth is ready. If the system is in a transition from
on to off, or vice versa, the method might operate on an undefined
state.
2014-01-07 13:46:20 +01:00
Shawn Huang
b769ea8f1c Bug 946240 - [Bluetooth][gonk-kk] Add flags to support different AVRCP profile version. r=echou 2014-01-08 09:32:19 -05:00
Boris Zbarsky
9cdaf7bf8e Bug 950188. DOMRequest should only have a constructor taking a Window. r=khuey 2014-01-06 21:53:23 -05:00
Birunthan Mohanathas
c293ca84b8 Bug 784739 - Switch from NULL to nullptr in remaining directories; r=ehsan
--HG--
extra : rebase_source : 1ff19b2c8fd0e77fa8e822f5007a9fa3a6b6d474
2014-01-06 10:06:04 -05:00
Ehsan Akhgari
ebd358dfd7 Bug 927728 - Part 1: Replace PRUnichar with char16_t; r=roc
This patch was automatically generated by the following script:

#!/bin/bash
# Command to convert PRUnichar to char16_t

function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
       ! -wholename "*security/nss*" \
       ! -wholename "*modules/libmar*" \
       ! -wholename "*/.hg*" \
       ! -wholename "obj-ff-dbg*" \
       ! -name prtypes.h \
       ! -name Char16.h \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.c" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert PRUnichar char16_t
2014-01-04 10:02:17 -05:00
Ben Tian
1551465c06 Bug 947870 - Assertion in BluetoothOppManager::CreateFile (bluedroid), r=echou 2013-12-23 16:47:12 +08:00
Ben Tian
6fe5d8ef31 Bug 939022 - BluetoothUtils for bluedroid. Patch 2/3: Modify files, r=echou 2013-12-23 11:24:11 +08:00
Ben Tian
c232ce69db Bug 939022 - BluetoothUtils for bluedroid. Patch 1/3: Move files, r=echou
--HG--
rename : dom/bluetooth/BluetoothUtils.cpp => dom/bluetooth/bluedroid/BluetoothUtils.cpp
rename : dom/bluetooth/BluetoothUtils.h => dom/bluetooth/bluedroid/BluetoothUtils.h
rename : dom/bluetooth/BluetoothUtils.cpp => dom/bluetooth/bluez/BluetoothUtils.cpp
rename : dom/bluetooth/BluetoothUtils.h => dom/bluetooth/bluez/BluetoothUtils.h
2013-12-16 19:00:54 +08:00
Ms2ger
dda2a3ced0 Bug 942104 - Fix a mismerge from the backout on a CLOSED TREE; a=Tomcat 2013-12-20 15:19:14 +01:00
Ms2ger
4720fc16e5 Merge backout. 2013-12-20 11:36:27 +01:00
Ms2ger
09229ed637 Backout bug 942104 (changesets 4e5746a65a5e:62e32a84a9fb) for missing review. 2013-12-20 11:33:37 +01:00
Eric Chou
5e59ce2690 Bug 949772 - Fire PropertyChanged to registered BluetoothDevice objects, r=gyeh 2013-12-18 18:21:37 +08:00
Eric Chou
510e723f79 Bug 949772 - Make BluetoothAdpater be able to deal with multiple properties in one PropertyChanged event, f=btian, r=gyeh 2013-12-18 18:21:05 +08:00
Ben Tian
aed903d3cd Bug 949843 - Don't use char* str = NS_ConvertUTF16toUTF8(aBdAddress).get();, r=echou 2013-12-18 09:53:11 +08:00
Eric Chou
4fb67060de Bug 942104 - Fire event 'ondiscoverystatechanged' (bluez), r=gyeh 2013-11-30 20:20:18 +08:00
Eric Chou
3f1fd8da53 Bug 942104 - Fire event 'ondiscoverystatechanged', r=gyeh
From b03fc76c1810cf3f91aa9f92732c3df4ffd471a3 Mon Sep 17 00:00:00 2001
2013-11-25 14:13:26 +08:00
Eric Chou
e25ca0c35b Bug 942104 - Add nsIDOMBluetoothDiscoveryStateChangedEvent, r=gyeh 2013-11-30 20:20:17 +08:00
Eric Chou
d3a0fe86e9 Bug 942104 - Add an event "ondiscoverystatechanged", r=gyeh, sr=mrbkap 2013-11-30 20:20:17 +08:00
Shawn Huang
8922023cee Bug 944293 - [Bluetooth] Correct IS_PERIPHERAL COD validation and add error handling if COD is invalid, r=gyeh 2013-11-29 16:01:22 +08:00
Eric Chou
e31fb582fb Bug 942712 - Ensure event 'AdapterAdded' will be fired after 'Enabled' being fired, r=gyeh 2013-11-27 16:24:51 +08:00
Eric Chou
fe02440431 Bug 942712 - Set gToggleInProgress to false when bt toggling is done, r=gyeh
From 2e8e1d84251fac968caf9104536d1b794c986670 Mon Sep 17 00:00:00 2001
2013-11-26 15:13:43 +08:00
Mike Hommey
9245936f8b Bug 874266 - Move all DEFINES that can be moved to moz.build. r=mshal 2013-11-27 22:55:07 +09:00
Mike Hommey
2b828323f2 Backout changeset 3fd4b546eed4 (bug 874266) and changeset a35d2e3a872f (bug 942043) for ASAN build bustage and Windows test bustage
--HG--
extra : amend_source : f20d09aeff1c8b5cbd0f1d24c7ce04e86f3aed1d
2013-11-28 14:24:05 +09:00
Mike Hommey
d210f8ff00 Bug 874266 - Move all DEFINES that can be moved to moz.build. r=mshal 2013-11-28 13:08:16 +09:00
Jamin Liu
100bf64d24 Bug 881194 - [Bluetooth] Send +CIEV callheld for conference call. r=echou 2013-12-16 08:37:33 -05:00
Jamin Liu
84ab62f5c1 Bug 881194 - [Bluetooth] Send +CIEV callheld properly to indicate call hold status. r=echou
- Send +CIEV callheld=1 when active calls become held calls
- Send +CIEV callheld=0 when all held calls become active calls.
2013-11-15 14:48:00 +08:00
Jamin Liu
adb2431ed7 Bug 881194 - [Bluetooth] Support AT+CHLD=3 in dom bluetooth. When "AT+CHLD=3" is received from a hands-free device, notify the Dialer app to "Add a held call to the conversation". r=echou 2013-11-28 14:05:05 +08:00
Vicamo Yang
d66bff1ccd Bug 939637: B2G Bluetooth: add test case for navigator.BluetoothManager.adapteradded. r=echou 2013-12-13 15:31:21 +08:00
Vicamo Yang
2b9f628cc2 Bug 939441: B2G Bluetooth: add test cases for navigator.BluetoothManager.enabled. r=echou, f=jgriffin 2013-12-13 15:31:16 +08:00
Thomas Zimmermann
ea7e350a24 Bug 932728: Open only one connection to DBus, r=echou,qdot
Bluetooth maintains two connections to the DBus server and the DBus
system itself maintains a third one. This implies some overhead and
makes the code more difficult to understand.

This patch changes the Bluetooth code to use the connection that is
established by the DBus system.
2013-12-12 12:56:00 +01:00
Shawn Huang
a3360114e1 Bug 941462 - Reply internal error code when getting I/O error from BlueZ, r=gyeh 2013-12-12 19:37:42 +08:00
Jamin Liu
0e31364f96 Bug 932490 - Fix the buffer overflows of OBEX packet. r=echou 2013-12-11 09:53:24 -05:00
Ben Tian
70a3ee3993 Bug 948247 - [bluedroid] Race condition in BluetoothSocket may result in segmentation fault, r=echou 2013-12-11 16:53:11 +08:00
Eric Chou
e98a57a98b Bug 947870 - Avoid assertion on receiving files via Bluetooth, r=gyeh 2013-12-11 13:17:34 +08:00
Ryan VanderMeulen
ca386608b9 Merge b2g-inbound to m-c. 2013-12-09 17:26:11 -05:00
Birunthan Mohanathas
bdda80d8b8 Bug 798033 - Remove 'using namespace' from dom/ headers. r=echou 2013-12-08 21:53:11 -05:00
Birunthan Mohanathas
759ab69b0a Bug 713082 - Part 2: Rename Util.h to ArrayUtils.h. r=Waldo
--HG--
rename : mfbt/Util.h => mfbt/ArrayUtils.h
2013-12-08 21:52:54 -05:00
Birunthan Mohanathas
2a97f4dc0d Bug 713082 - Part 1: Remove unnecessary Util.h includes. r=Waldo 2013-12-08 21:52:33 -05:00
Ben Tian
f40c952ebe Bug 946555 - Remove unused functions in BluetoothService classes and some warnings, r=echou 2013-12-06 12:20:07 +08:00
Eric Chou
9588efd947 Bug 947060 - Don't go through bonding procedure while transferring files via OPP, r=gyeh 2013-12-09 17:43:15 +08:00
Ben Tian
80ebb68b44 Bug 947096 - [Flatfish] Build break results from variable access that requires MOZ_B2G_RIL flag, r=echou 2013-12-06 15:17:24 +08:00
Eric Chou
89562bccd5 Bug 932496 - Add length check to prevent from memory pollusion, r=gyeh 2013-12-06 16:23:35 +08:00
Ryan VanderMeulen
ad71ecfc91 Merge inbound to m-c. 2013-12-05 17:29:03 -05:00
Ben Tian
7439710810 Bug 946048 - Reset mPhoneType in BluetoothHFPManager constructor, r=echou 2013-12-04 13:51:57 +08:00