wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity
211,930 Commits 1 Branch 166 Tags 1.2 GiB
09561fd3ed
Commit Graph

23424 Commits

Author SHA1 Message Date
Simon Montagu
9d4c08e621 Tests for bug 1083748 (not run in a default build). r=jfkthame 2014-10-22 06:34:41 -07:00
Aryeh Gregor
3cce7e3e0d Bug 1055722 - Remove spammy warning; r=smaug 2014-10-22 15:45:30 +03:00
Simon Montagu
4c9064021f Bug 1082844: when converting between logical and physical coordinates in nsLineLayout, use the width of the containing block as container-width for the root span, and the width of the root span for child spans. r=jfkthame 2014-10-22 05:14:41 -07:00
Simon Montagu
3931080007 Tests for bug 1082844 (not run in a default build). r=jfkthame 2014-10-22 05:14:39 -07:00
Jonathan Watt
d7b3c4e0e0 Bug 1087224 - Allow compareSnapshots and assertSnapshots to be passed fuzz values. r=smontagu 2014-10-22 12:29:06 +01:00
Jonathan Watt
734b9f31a9 Bug 1086610 - Get color working for ::-moz-tree-progressmeter again. r=mattwoodrow 2014-10-22 12:29:06 +01:00
Jonathan Watt
d266467576 Bug 1086708 - Rename the snapping variant of NSRectToRect to NSRectToSnappedRect. r=mattwoodrow 2014-10-22 12:29:06 +01:00
Jonathan Watt
2a309ca31b Bug 1074161 - Avoid creating a Moz2D Path object to draw SVG <rect>, <image> and <line> elements. r=mattwoodrow 2014-10-22 12:29:05 +01:00
peter chang
ff819b0901 Bug 1068461 - Locate the text frames from viewport frame to select word, r=roc 2014-10-15 10:43:29 +08:00
Alexandre Poirot
50c732ad70 Bug 1048441 - blacklist test_bug696020.html being too intermittent on mulet. r=ahal 2014-10-21 06:04:00 +02:00
Simon Montagu
10de562497 Bug 1079139: make nsFlowAreaRect.mRect a LogicalRect. r=jfkthame 2014-10-21 15:16:13 -07:00
Jonathan Watt
f072d85261 Bug 477504 - Snap to device pixels any CSS border edges that are painted as a polygon. r=mats 2014-10-22 10:48:37 +01:00
Jonathan Watt
2903dfaa66 Bug 1085092 - Fix stroking of SVG polygon elements. r=longsonr 2014-10-22 10:48:37 +01:00
Jonathan Watt
7309aabfb6 Bug 1086714 - Change test_selection_underline.html's log output so that it can be used with reftest-analyzer.xhtml. r=dholbert 2014-10-22 10:48:37 +01:00
Jonathan Watt
5b2b119d02 Bug 1084650, part 2 - Change test_reftests_with_caret.html's log output so that it can be used with reftest-analyzer.xhtml. r=dholbert 2014-10-22 10:48:36 +01:00
Jonathan Watt
eb253e3301 Bug 1084650, part 1 - Change test_reftests_with_caret.html's references to 'canvas' to 'iframe' to make the test less confusing. r=dholbert 2014-10-22 10:48:36 +01:00
Jonathan Watt
434b0ae138 Bug 1084665 - Make reftest-analyzer.xhtml support test/reference images of arbitrary dimensions. r=dholbert 2014-10-22 10:48:36 +01:00
Rik Cabanier
72130a55c4 Bug 591600 - CSS gradients should work on premultiplied colors. r=mstange 
--HG--
extra : rebase_source : 24d38e88d6efc8ed34960c3d3602b18f5bcd2c95
 2014-10-22 08:13:56 +02:00
Robert O'Callahan
80c077b306 Bug 1081185. Traverse rect edges when searching for w=0 crossings instead of taking diagonals. r=mattwoodrow 
--HG--
extra : rebase_source : c87d145abea750cf0d8b02f0ea387ec9148e6be1
 2014-10-22 11:01:00 +13:00
Robert O'Callahan
80494b4085 Bug 1073290. Don't render with displayports if we're not painting to the window. r=mattwoodrow 
--HG--
extra : rebase_source : 088b2156069248ac920d1a525d069b9a7330f980
 2014-10-21 10:32:11 +13:00
Jonathan Kew
c26eb4aa1b Bug 1062963 - reftest that catches the floatmanager writing-mode mismatch bug on container resize. r=smontagu 2014-10-21 17:21:21 +01:00
Simon Montagu
d28ba68b08 Bug 1062963 patch 3: make nsFloatManager's origin a LogicalPoint, adapt GetFlowAreas, AddFloats, ClearFloats, etc. to use it and make nsFloatManager region functions work with logical region. r=jfkthame 2014-10-21 15:16:12 -07:00
Simon Montagu
221b9e4462 Bug 1062963 patch 2: changes and additions to WritingModes.h. r=jfkthame 2014-10-21 15:16:12 -07:00
Simon Montagu
8e4543f3b7 Bug 1062963 patch 1: Logical coordinates in nsLineLayout:ReflowFrame and CanPlaceFrame. r=jfkthame 2014-10-21 15:16:11 -07:00
Benoit Girard
d45b46a3e9 Bug 961871 - Part 4: Fix budget calculation by adding Maybe prerenderer and animate. r=roc 2014-10-21 21:55:55 -04:00
Benoit Girard
70ab4c8ba8 Bug 961871 - Part 3: Implement will-change budgeting. r=roc 2014-10-21 21:54:32 -04:00
Benoit Girard
1086c42e6e Bug 961871 - Part 2: Refactor will-change scroll, pass through a nsDisplayListBuilder. r=mattwoodrow 2014-10-21 21:54:06 -04:00
Benoit Girard
2b7c4a32e3 Bug 961871 - Part 1: Refactor ScrollingActive. r=mattwoodrow 2014-10-21 21:53:38 -04:00
Timothy Nikkel
ac0404553b Bug 1062792. Don't add clipped out parts of a layer to the opaque region. r=roc 2014-10-21 20:33:12 -05:00
Alexander Surkov
5a5c3c647d Bug 1076816 - segregate XPCOM tree, r=davidb 2014-10-21 20:49:28 -04:00
Ryan VanderMeulen
01ff55dc0f Merge m-c to inbound. a=merge 2014-10-22 16:38:48 -04:00
Dirk Schulze
027f3fd827 Bug 1081350 - Fix leak in clip-path computed style code. r=bz 2014-10-12 13:14:00 +02:00
Gina Yeh
4d98afa8b4 Bug 989198, Patch 3: Dispatch BeforeAfterKeyboardEvent on b2g, r=smaug 
---
 b2g/app/b2g.js                   |    3 +
 content/base/src/nsGkAtomList.h  |    4 +
 dom/events/EventNameList.h       |   16 +++
 dom/events/EventStateManager.cpp |    6 +
 dom/ipc/PBrowser.ipdl            |    2 +
 dom/ipc/TabChild.cpp             |    6 +-
 dom/ipc/TabParent.cpp            |   24 ++++
 dom/ipc/TabParent.h              |    1 +
 layout/base/nsIPresShell.h       |   12 +-
 layout/base/nsPresShell.cpp      |  250 ++++++++++++++++++++++++++++++++++++++
 layout/base/nsPresShell.h        |   26 ++++
 modules/libpref/init/all.js      |    3 +
 12 files changed, 350 insertions(+), 3 deletions(-)
 2014-10-14 15:09:24 +08:00
Morris Tseng
2368f06ce4 Bug 1067231 - Send touch caret tap event. r=ehsan 2014-10-12 23:44:00 +02:00
Mats Palmgren
8e411ea4c2 Bug 1080352 - Update the rendering for <input type=range> after it was reset. r=jwatt 2014-10-13 11:48:33 +00:00
Ryan VanderMeulen
1c70cab650 Backed out changeset 7ab2fdaadd1a (bug 1078337) for crashes and reftest failures. 2014-10-12 20:39:44 -04:00
Matt Woodrow
f68f29db65 Bug 1078337 - Use the clipped image in DrawSingleImage if one was requested. r=seth 2014-10-13 11:49:22 +13:00
Robert Longson
b1dd836c60 Bug 1067375 - Fix animateTransform in svg-as-image to invalidate properly. r=jwatt 2014-10-12 08:49:34 +01:00
Mihaita Ghiorghe
a67435033c Bug 1081013 - Removed unused parameter in AnimationPlayerCollection constructor. r=dholbert 2014-10-12 00:37:22 -07:00
Mats Palmgren
58d729985f Bug 1076918. r=dbaron 2014-10-11 22:59:00 -07:00
Dirk Schulze
a6ee8862ea Bug 1077388 - Fix parsing/computing issue with polygon(). r=dbaron 2014-10-10 02:10:00 -04:00
Hallvord R. M. Steen
c971532162 Bug 923971 - Prevent global F10 shortcut from overriding devtools one. r=enndeakin 2014-10-06 09:56:00 -04:00
Sebastian Hengst
f078b24bd6 Bug 1078033 - Remove remaining Camino code. r=ted 2014-10-10 17:00:29 +02:00
Yonggang Luo
20aa790b25 Bug 1066459 - Clamp the new top row index to the valid range before assigning it to mTopRowIndex when scrolling. r=kip 2014-10-11 06:22:00 -04:00
Ryan VanderMeulen
22a114c180 Merge inbound to m-c. a=merge 2014-10-11 16:16:00 -04:00
Kartikaya Gupta
0d11dd5d12 Bug 1078373 - Use the scrollPositionClampingScrollPortSize when computing whether or not to show the scrollbar. r=tn 2014-10-10 22:16:03 -04:00
Robert Longson
8cfd040019 Bug 1078031 - get rid of renderMode. r=jwatt 2014-10-11 09:24:44 +01:00
Nicolas Silva
ec158aa914 Bug 1071769 - Fuzz two reftests which fail with the tiled DrawTarget. r=roc 2014-10-10 16:04:35 +02:00
Timothy Nikkel
a5f3e2c992 Bug 1076447. When building the display list for scrollbars and we have a display port just use the whole scrollbar rect as the dirty rect. r=mattwoodrow 
When we have a display port the dirty rect for root scroll frames is going to be the display port already when it is passed in. The display port can contain a somewhat arbitrary area of the scroll frame, there is no reason is has to include the scrollbars, which are laid out at the desktop scrollport (and adjusted as necessary in the compositor).

As well as BuildDisplayListForChild, we need the dirty rect to be set for the creation of the nsDisplayWrapList or nsDisplayOwnLayer in AppendToTop.
 2014-10-09 15:10:01 -05:00
Jon Morton
c559dd1ab0 Bug 979835: Port BoxObject and its subclasses to WebIDL. r=khuey sr=bz 
--HG--
rename : layout/xul/nsIPopupBoxObject.idl => dom/webidl/PopupBoxObject.webidl
rename : layout/xul/tree/nsITreeBoxObject.idl => dom/webidl/TreeBoxObject.webidl
rename : layout/xul/nsBoxObject.cpp => layout/xul/BoxObject.cpp
rename : layout/xul/nsBoxObject.h => layout/xul/BoxObject.h
rename : layout/xul/nsListBoxObject.cpp => layout/xul/ListBoxObject.cpp
rename : layout/xul/nsMenuBoxObject.cpp => layout/xul/MenuBoxObject.cpp
rename : layout/xul/nsPopupBoxObject.cpp => layout/xul/PopupBoxObject.cpp
 2014-10-14 13:15:21 -07:00
Ted Mielczarek
3dc06c1cce bug 915865 - port reftest to mozbase. r=ahal 2014-07-29 11:47:50 -04:00
Kearwood (Kip) Gilbert
d456e97113 Bug 1074165 - Prevent out of range scrolling in nsListboxBodyFrame. r=mats 
- nsListBoxBodyFrame::UpdateIndex now uses the position returned by
  nsScrollBarFrame::MoveToNewPosition to calculate the new row position.
- Code used to calculate the row position from the scroll position has been
  moved to a new function, ToRowIndex.
- nsListBoxBodyFrame::ThumbMoved has been updated to use ToRowIndex.
 2014-10-09 12:14:26 +00:00
Carsten "Tomcat" Book
640ca40670 Backed out changeset ccde95bd3c7e (bug 1074165) for bustage 2014-10-09 10:59:44 +02:00
Kearwood (Kip) Gilbert
d30ba1fdc1 Bug 1074165 - Prevent out of range scrolling in nsListboxBodyFrame. r=mats 
- nsListBoxBodyFrame::UpdateIndex now uses the position returned by
  nsScrollBarFrame::MoveToNewPosition to calculate the new row position.
- Code used to calculate the row position from the scroll position has been
  moved to a new function, ComputeNewIndex.
- nsListBoxBodyFrame::ThumbMoved has been updated to use ComputeNewIndex.
 2014-10-08 17:14:00 +02:00
Jonathan Kew
c8f5ca91f7 Bug 1080174 - Do not send Accept-Encoding:gzip,deflate when requesting WOFF or WOFF2 webfonts. r=mcmanus 2014-10-09 08:42:51 +01:00
Jonathan Kew
5dbced3a9f Bug 1077312 - Clean up Accept headers on @font-face HTTP requests. r=mcmanus 2014-10-09 08:42:02 +01:00
John Daggett
333b409170 Bug 1079422 - eliminate the ptr to FontFace within @font-face rules. r=heycam 2014-10-09 16:03:56 +09:00
John Daggett
dd1070ceef Bug 1079422 - backout changeset 7fceb8bf84d2. r=heycam 2014-10-09 16:03:28 +09:00
Kartikaya Gupta
22f08e6ac7 Bug 1078316 - Tweaks for root-frame overlay scrollbars so they don't oscillate while panning around. r=botond,tn 2014-10-08 22:56:38 -04:00
Lebedev Maksim
d8fc3125f6 Bug 1073563 - The lostpointercapture event must be dispatched before any other pointer events. r=smaug 2014-10-08 16:27:34 -07:00
L. David Baron
005b269107 Bug 1047928 patch 14 - Explain why changes to theme require rerunning selector matching. r=bzbarsky 2014-10-08 14:27:04 -07:00
L. David Baron
394de3e578 Bug 1047928 patch 13 - Don't rerun selector matching for changes to zoom, min font size, or app units per dev pixel. r=bzbarsky 2014-10-08 14:27:04 -07:00
L. David Baron
b1ad6a1d08 Bug 1047928 patch 10 - Pass restyle hint to nsPresContext::MediaFeatureValuesChanged. r=bzbarsky 
This patch is not intended to contain any changes in behavior.

The behavior changes in these callers are in the following 4 patches.
 2014-10-08 14:27:03 -07:00
L. David Baron
aedbfdef2c Bug 1047928 patch 9 - Don't rerun selector matching for viewport units. r=bzbarsky 2014-10-08 14:27:03 -07:00
L. David Baron
91602cb4e6 Bug 1047928 patch 8 - Don't rerun selector matching when @counter-style rules change. r=bzbarsky 2014-10-08 14:27:03 -07:00
L. David Baron
ae9182fccb Bug 1047928 patch 7 - Don't rerun selector matching when user font set is updated. r=bzbarsky 2014-10-08 14:27:03 -07:00
L. David Baron
7a6da0ed0b Bug 1047928 patch 6 - Pass restyle hint to nsPresContext::PostRebuildAllStyleDataEvent. r=bzbarsky 
This patch is not intended to contain any changes in behavior.

The behavior changes for these callers are in the following 2 patches.
 2014-10-08 14:27:02 -07:00
L. David Baron
533c2af9d3 Bug 1047928 patch 5 - Pass restyle hint to RestyleManager::PostRebuildAllStyleDataEvent. r=bzbarsky 
This patch is not intended to contain any changes in behavior.
 2014-10-08 14:27:02 -07:00
L. David Baron
fcce5ef9fc Bug 1047928 patch 4a - Explain why we need to rerun selector matching for preference changes. r=bzbarsky 2014-10-08 14:27:02 -07:00
L. David Baron
0303218250 Bug 1047928 patch 4 - Don't rerun selector matching for charset or system color changes. r=bzbarsky 2014-10-08 14:26:59 -07:00
L. David Baron
0fdd93bcbf Bug 1047928 patch 3 - Pass restyle hint to nsPresContext::RebuildAllStyleData. r=bzbarsky 
This patch is not intended to contain any changes in behavior.

The behavior changes for these callers are in the following patch.
 2014-10-08 14:26:57 -07:00
L. David Baron
c4cfdf269a Bug 1047928 patch 2 - Pass restyle hint to RestyleManager::RebuildAllStyleData. r=bzbarsky 
This patch is not intended to contain any changes in behavior.
 2014-10-08 14:26:57 -07:00
L. David Baron
c64a3d3c7d Bug 1047928 patch 1 - Add more comments explaining eRestyle_Subtree vs. eRestyle_ForceDescendants. r=bzbarsky 2014-10-08 14:26:57 -07:00
Eric Rahm
739ad6c34e Bug 806819 - Part 4: Add files that were excluded from unified builds back in. r=ehsan 2014-10-08 13:19:14 -07:00
Eric Rahm
be71a0b71a Bug 806819 - Part 3: Remove redundant FORCE_PR_LOG entries. r=ehsan 2014-10-08 13:17:32 -07:00
Andrea Marchesini
a1e153cad8 Bug 1047483 - patch 4 - Removing nsDOMBlobBuilder, r=ehsan 
--HG--
rename : content/base/src/nsDOMBlobBuilder.cpp => content/base/src/MultipartFileImpl.cpp
rename : content/base/src/nsDOMBlobBuilder.h => content/base/src/MultipartFileImpl.h
 2014-10-08 17:15:23 +01:00
Andrea Marchesini
57fa89d6de Bug 1047483 - patch 1 - Porting DOMFile/DOMBlob to WebIDL, r=bz, r=bkelly, r=bholley 2014-10-08 17:15:22 +01:00
Jonathan Kew
77efa649e3 Bug 1074735 pt 2 - Support drawing CSS text decorations (underline, overline, strikeout) on vertical text frames. r=smontagu 2014-10-08 10:32:55 +01:00
Jonathan Kew
657f1df134 Bug 1079314 - Remove the mWritingMode field from logical-coordinate objects in non-debug builds. r=smontagu 2014-10-08 10:32:50 +01:00
Carsten "Tomcat" Book
b6fc6a7e02 Backed out changeset b818ba8aabc2 (bug 1079314) for reftest failures on a CLOSED TREE 2014-10-08 13:07:39 +02:00
Carsten "Tomcat" Book
574a5d4faf Backed out changeset 32c4d5043b18 (bug 1074735) 2014-10-08 13:06:51 +02:00
Jonathan Kew
786563c36b Bug 1074735 pt 2 - Support drawing CSS text decorations (underline, overline, strikeout) on vertical text frames. r=smontagu 2014-10-08 10:32:55 +01:00
Jonathan Kew
3676733790 Bug 1079314 - Remove the mWritingMode field from logical-coordinate objects in non-debug builds. r=smontagu 2014-10-08 10:32:50 +01:00
Morris Tseng
081ac8f2ef Bug 1062468 - Reset transform-style when entering fullscreen mode. r=bz 2014-10-06 02:46:00 +02:00
Jonathan Watt
05092c4eea Bug 1077961, part 2 - Stop doing lots of unnecessary and expensive Matrix4x4 multiplication. r=Bas 2014-10-08 04:43:00 +01:00
Daniel Holbert
b2780f8b42 Bug 978044: Center print-previewed pages inside the viewport. r=mats 2014-10-07 18:37:50 -07:00
Ehsan Akhgari
52d479a3f0 Bug 1079324 - Fix some more bad implicit constructors in layout; r=dholbert 2014-09-24 09:16:53 -04:00
Ryan VanderMeulen
566e49b6ff Backed out 7 changesets (bug 1047483, bug 1079301, bug 1079335) for webplatform test failures. 
Backed out changeset 7d06b68c44d0 (bug 1079335)
Backed out changeset 92030169528e (bug 1079301)
Backed out changeset c09d7f95554a (bug 1047483)
Backed out changeset c199f1057d7e (bug 1047483)
Backed out changeset 18830d07884c (bug 1047483)
Backed out changeset e087289ccfbb (bug 1047483)
Backed out changeset 6238ff5d3ed0 (bug 1047483)

CLOSED TREE

--HG--
rename : content/base/public/File.h => content/base/public/nsDOMFile.h
rename : content/base/src/MultipartFileImpl.cpp => content/base/src/nsDOMBlobBuilder.cpp
rename : content/base/src/MultipartFileImpl.h => content/base/src/nsDOMBlobBuilder.h
rename : content/base/src/File.cpp => content/base/src/nsDOMFile.cpp
 2014-10-07 13:16:11 -04:00
Andrea Marchesini
3cae2ef25d Bug 1047483 - patch 4 - Removing nsDOMBlobBuilder, r=ehsan 
--HG--
rename : content/base/src/nsDOMBlobBuilder.cpp => content/base/src/MultipartFileImpl.cpp
rename : content/base/src/nsDOMBlobBuilder.h => content/base/src/MultipartFileImpl.h
 2014-10-07 15:20:57 +01:00
Andrea Marchesini
570a9abfb8 Bug 1047483 - patch 1 - Porting DOMFile/DOMBlob to WebIDL, r=bz, r=bkelly, r=bholley 2014-10-07 15:20:52 +01:00
Ting-Yu Lin
22279846ae Bug 1078991 - Add TouchCaret::GetCaretFocusFrame(). r=roc 2014-10-06 21:02:00 -04:00
Peter Van der Beken
4b7e268d87 Bug 1078744 - Replace SetIsDOMBinding with SetIsNonDOMBinding, remove nsWrapperCache::SetIsDOMBinding. r=bz. 
--HG--
extra : rebase_source : 89c476cd9436530b2df5acc903909e34188417a0
 2014-10-07 11:44:49 +02:00
Masayuki Nakano
5a29f2b8bb Bug 960871 part.11 Rename EventUtils.synthesizeText() to EventUtils.synthesizeCompositionChange() r=smaug 2014-10-07 19:01:50 +09:00
Masayuki Nakano
329b23036c Bug 960871 part.10 Some methods which took both WidgetCompositionEvent and WidgetTextEvent should take only WidgetCompositionEvent r=smaug 2014-10-07 19:01:49 +09:00
Masayuki Nakano
c2bf46d0e4 Bug 960871 part.6 Use WidgetCompositionEvent for NS_COMPOSITION_CHANGE instead of WidgetTextEvent r=smaug 2014-10-07 19:01:48 +09:00
Wes Kocher
5000218064 Backed out 5 changesets (bug 806819) for WinXP test failures on a CLOSED TREE 
Backed out changeset 009ae35b0c67 (bug 806819)
Backed out changeset 5a57f87f5061 (bug 806819)
Backed out changeset f06cd735b5b3 (bug 806819)
Backed out changeset e25a2a8d4af4 (bug 806819)
Backed out changeset 70a167982c3f (bug 806819)
 2014-10-06 16:32:50 -07:00
Eric Rahm
600bc87781 Bug 806819 - Part 4: Add files that were excluded from unified builds back in. r=ehsan 
--HG--
extra : rebase_source : 49a3f57d94fc94702f1604175c4e206091b67197
 2014-10-06 13:11:24 -07:00
Eric Rahm
4a41e11c21 Bug 806819 - Part 3: Remove redundant FORCE_PR_LOG entries. r=ehsan 
--HG--
extra : rebase_source : c96eea1c12ea8c19314393f0e8b4b57a4316a61d
 2014-10-06 13:08:20 -07:00
Andrew McCreight
575425d0ec Bug 1076969 - processLeakLog should come up with reasonable defaults itself. r=jmaher 
Instead of grabbing attributes off options at every call site, pass
in the options object to processLeakLog, and attempt to get the attributes
there. If not present, use a restrictive default value.

This will prevent silent harness failures if one of the many ways to invoke
processLeakLog fails to set up these options, and makes it so they
don't have to set it up if they don't care.
 2014-10-06 14:23:17 -07:00
Tanvi Vyas
92ed4309c4 Bug 418354 - Redirects should go through Mixed Content Blocker. r=smaug, ckerschb 2014-10-18 13:21:06 -07:00
Nils
9ab0651b10 Bug 814995 - Add crashtest. 2014-10-18 17:08:23 +00:00
SkyLined
52fdcecab6 Bug 810303 - Add crashtest. 2014-10-18 17:08:23 +00:00
Jesse Ruderman
8c97c0b7c3 Bug 415503 - Add crashtest. 2014-10-18 17:08:23 +00:00
Martijn Wargers
b10ee66767 Bug 668579 - Add crashtest. 2014-10-18 17:08:23 +00:00
Gary Kwong
9a3e48ab93 Bug 428113 - Add crashtest. 2014-10-18 17:08:22 +00:00
Jesse Ruderman
eff9b3cb53 Bug 459883 - Add crashtest. 2014-10-18 17:08:22 +00:00
Jesse Ruderman
4b78b4338f Bug 459968 - Add crashtest. 2014-10-18 17:08:22 +00:00
Jesse Ruderman
a4c6949253 Bug 462968 - Add crashtest. 2014-10-18 17:08:22 +00:00
Jonathan Kew
dcdd2db6fa Bug 1077371 - Remove unnecessary null-checks on the result of gfxFontGroup::GetFirstValidFont. r=jdaggett 2014-10-06 15:14:49 +01:00
Robert Longson
f04702d9bd Bug 1077993 - make changes to clip-rule work. r=jwatt 2014-10-06 14:19:14 +01:00
Cameron McCormack
61fa63463d Bug 1076803 - Disable subtest 18 in test_font_loading_api.html for intermittent timeouts. r=philor 2014-10-06 10:17:06 +11:00
Cameron McCormack
c48e32b09c Bug 1077746 - Move FontFace pointer from nsCSSFontFaceRule to a table on FontFaceSet. r=jdaggett 2014-10-06 15:29:35 +11:00
Simon Montagu
2109bf0fd7 Bug 1067268: don't mix physical and logical coordinates when calculating width to clear past floats, r=jfkthame 2014-10-04 23:03:00 -07:00
Simon Montagu
4b70ef14b0 Test for bug 1067268, r=jfkthame 2014-10-04 23:02:37 -07:00
Simon Montagu
9ae01b3767 Bug 1076986: make LogicalMargin and LogicalRect's IsEmpty the same as nsMargin and nsRect, r=jfkthame 2014-10-04 23:02:36 -07:00
L. David Baron
581c8fe4b7 Bug 1077849 - Use eRestyle_ForceDescendants for all cases of rebuilding the rule tree. r=heycam 
Bug 931668 added the eRestyle_ForceDescendants case for all cases that
go through RebuildAllStyleData, but there is another case that calls
DoRebuildAllStyleData directly, and we should cover that too.

This is needed because when we're rebuilding the rule tree, we need to
create new style contexts for all frames.

I don't know of any bugs caused by this, but it seems worth fixing.
 2014-10-04 16:59:47 -07:00
Trevor Saunders
21cecdb67f no bug - fix nullptr to bool conversion in FontFaceSet.cpp r=themaid 2014-10-04 11:06:21 -04:00
Jonathan Watt
ab6c7388b8 Bug 932762, part 2 - Make SVG elements cache their Moz2D path data to speed up rendering, hit-testing, clipPath clipping, bbox calculations and animation/text along a path. r=longsonr 2014-10-04 12:13:30 +01:00
Jonathan Watt
ddbdd580a2 Bug 1077745 - Get rid of the scaling hack and GetCanvasTM() call in nsSVGPathGeometryFrame::GetBBoxContribution. r=longsonr 2014-10-04 12:13:30 +01:00
Jonathan Watt
3915b285fe Bug 1077120 - Remove gfxContext::HasError(). r=Bas 2014-10-04 12:13:29 +01:00
Jonathan Kew
6d59a6a90c Bug 1064737 pt 4 - Simple reftest for a WOFF2 font. r=jdaggett 2014-10-04 11:47:11 +01:00
Jonathan Kew
f7b6074716 Bug 1064737 pt 3 - Read metadata from a WOFF2 font if present. r=jdaggett 2014-10-04 11:46:54 +01:00
Jonathan Kew
0768d94de1 Bug 1064737 pt 2 - Support for WOFF2 as a webfont format. r=jdaggett 2014-10-04 11:36:05 +01:00
William Chen
efc007e0f2 Bug 1076784 - Don't remove binding when shadow root host is removed from tree. r=smaug 2014-10-03 18:32:05 -07:00
Ryan VanderMeulen
1e05b90cf5 Backed out changeset cb3fd4a4b7c5 (bug 771043) for Android mochitest-8 failures. 
CLOSED TREE
 2014-10-03 15:26:06 -04:00
Boris Zbarsky
fc75ac6acd Bug 771043. Move MediaQueryList tracking from the prescontext to the document, so they will correctly outlive prescontext changes. r=dbaron 2014-10-03 14:15:25 -04:00
Kartikaya Gupta
f8118760e7 Bug 1074401 - Ensure that the repaint request is always dispatched from the APZ on the main thread. r=botond 2014-10-03 13:39:37 -04:00
Max Vujovic
fd5b0bb84c Bug 913990 - Test 'feed:' filter URL as crashtest instead of computed style test. r=dbaron 2014-10-03 10:06:07 -07:00
Jonathan Kew
08beb76502 Bug 1077139 - Use the vertical-text I-beam cursor when the writing mode is vertical. r=dbaron 2014-10-03 13:47:26 +01:00
Jonathan Watt
a8fd52ce9c Bug 1075399 - Temporary follow-up to disable test while I get fuzzing right. r=orange CLOSED TREE 2014-10-03 11:02:23 +01:00
Ed Morley
b7f870ecfa Backed out changeset a2192165100c (bug 1041180) for xpcshell failures; CLOSED TREE 2014-10-03 10:12:53 +01:00
Jonathan Watt
544ffe53b3 Bug 934183, part 2 - Remove lots of old Thebes code paths from the SVG code (GeneratePath and all the nsSVGPathGeometryElement::ConstructPath implementations). r=longsonr 2014-10-03 09:50:44 +01:00
Jonathan Watt
96cef3133e Bug 934183, part 1 - Convert the bounds calculation code for SVG geometry to use Moz2D Path. r=longsonr 2014-10-03 09:50:43 +01:00
Jonathan Watt
44410c0ebe Bug 1075399, part 4 - Don't make an exception for arcs when simulating zero length SVG subpaths. r=longsonr 2014-10-03 09:50:43 +01:00
Jonathan Watt
c0bb11b805 Bug 1075399, part 2 - Add more reftests for zero-length SVG subpaths. r=longsonr 2014-10-03 09:50:43 +01:00
Jonathan Watt
a62a1e6c6f Bug 1075399, part 1 - Simulate zero length SVG subpath for stroke-linecap=round. r=longsonr 2014-10-03 09:50:42 +01:00
Christoph Kerschbaumer
599a7f15d9 Bug 1041180: Remove deprecated nsIChannelPolicy (r=sstamm,jduell,jst) 2014-10-02 23:34:30 -07:00
Masayuki Nakano
3e20ab1463 Bug 975383 part.9 Remove compositionupdate event dispatchers from all tests r=smaug 2014-10-03 15:33:50 +09:00
L. David Baron
e6a364a01f Bug 1075137 patch 7 - Remove old IsProcessingRestyles and IsProcessingAnimationStyleChange booleans. r=birtles 2014-10-02 21:53:24 -07:00
L. David Baron
74a8d78db6 Bug 1075137 patch 6 - Convert remaining IsProcessingAnimationStyleChange calls to call the method on the RestyleManager. r=birtles 2014-10-02 21:53:24 -07:00
L. David Baron
aba79cd536 Bug 1075137 patch 5 - Add new boolean to RestyleManager for whether we're currently processing animation restyles. r=birtles 
This is just moving one bit of data from the pres context without any
logic change.  But given the other refactoring, it seems to make more
sense here now.
 2014-10-02 21:53:24 -07:00
L. David Baron
ed09e905d2 Bug 1075137 patch 4 - Convert callers from IsProcessingRestyles/IsProcessingAnimationStyleChange to SkipAnimationRules/PostAnimationRestyles. r=birtles 2014-10-02 21:53:24 -07:00
L. David Baron
481c419fd4 Bug 1075137 patch 3 - Add PresContext() method to nsRuleWalker. r=birtles 2014-10-02 21:53:23 -07:00
L. David Baron
ad2b0a920f Bug 1075137 patch 2 - Add new booleans for whether to skip animation styles and whether to post animation restyles. r=birtles 2014-10-02 21:53:23 -07:00
L. David Baron
e4428de7bf Bug 1075137 patch 1 - Convert one use of IsProcessingRestyles that doesn't follow normal pattern to a debug-only member on the restyle manager. r=birtles 2014-10-02 21:53:23 -07:00
L. David Baron
d120465d4b Bug 1075082 patch 2 - Add assertion in destructor of style contexts that should have been destroyed earlier. r=birtles 2014-10-02 21:53:23 -07:00
L. David Baron
5a45cf9123 Bug 1075082 patch 1 - Add a helper function for the root of the rule tree. r=birtles 2014-10-02 21:53:22 -07:00
L. David Baron
c78b1f75bb Bug 1074634 - Don't overwrite eRestyleResult_ContinueAndForceDescendants with eRestyleResult_Continue. r=heycam 2014-10-02 21:53:22 -07:00
Xidorn Quan
6b70562b17 Bug 1075336 - Fix lifetime management of CounterStyle. r=dbaron 
--HG--
extra : rebase_source : c9fe6b023024c11147372cd4a9d7f25fdfaabed8
 2014-10-02 14:29:04 -04:00
Andrew McCreight
385f7c868a Bug 1068276, part 4 - Fix indentation of leak option setting in reftests. r=ted 2014-10-02 08:42:11 -07:00
Andrew McCreight
a72aa8ab00 Bug 1068276, part 3 - Set some defaults for leak parameters on B2G reftests. r=jmaher 2014-10-02 08:40:21 -07:00
Mats Palmgren
c5be424a5b Bug 649849 - part 1b, Remove the default -moz-appearance:none for <select> in Fennec theme. r=wjohnston@mozilla.com 2014-10-02 13:05:16 +00:00
Mats Palmgren
40070919df Bug 649849, part 1 - Make -moz-appearance:none on a combobox remove the dropdown button (for WebKit compat). r=roc 2014-10-02 13:05:15 +00:00
Anuj Agarwal
4fb2f0f09c Bug 791777 - Replaced NS_finite() with mozilla::IsFinite. r=froydnj 2014-10-01 11:26:00 +02:00
David Zbarsky
5a40e7ae63 Bug 1067701 - Implement Animation.target; r=birtles, r=bz 2014-10-02 15:14:15 +09:00
Brian Birtles
62b903a7e1 Bug 1046055 part 5 - Check for current animations from ActiveLayerTracker::IsStyleAnimated; r=dbaron 
Within the context of determining of a layer is active, we should only consider
an element animated if it has an animation that is yet to finish, i.e. a current
animation. Animations that have finished should not cause a layer to be active
(even if they are applying a forwards fill).

This patch makes that change by calling
nsLayoutUtils::HasCurrentAnimationsForProperty instead of
nsLayoutUtils::HasAnimations.
 2014-10-02 15:14:14 +09:00
Brian Birtles
f6a9643ef6 Bug 1046055 part 4 - Add HasCurrentAnimationsForProperty to nsLayoutUtils; r=dbaron 
This patch adds a method to nsLayoutUtils, alongside the existing
HasCurrentAnimations, that returns true if there exists an unfinished animation
on the element for the specified property.
 2014-10-02 15:14:14 +09:00
Brian Birtles
94aa873419 Bug 1046055 part 3 - Add AnimationPlayerCollection::HasCurrentAnimationsForProperty; r=dbaron 
This patch adds another method to AnimationPlayerCollection alongside
HasCurrentAnimations that returns true if there is a player in the collection
with current source content that targets the specified property.

At the same time it also makes the original HasCurrentAnimations a const method.
 2014-10-02 15:14:13 +09:00
Brian Birtles
6de21c8b65 Bug 1046055 part 2 - Rename AnimationPlayer::IsCurrent to HasCurrentSource; r=dbaron 
It's not the player that's "current" (a Web Animations term for an animation
that hasn't yet finished), but its source content, if any. This patch renames
the method on AnimationPlayer accordingly.

At the same time this patch moves the method to the header file since it's
quite simple and could possibly benefit from inlining.
 2014-10-02 15:14:13 +09:00
Brian Birtles
46c3ada344 Bug 1046055 part 1 - Remove nsPresContext parameter from nsLayoutUtils::HasCurrentAnimations; r=dbaron 2014-10-02 15:14:13 +09:00
Brian Birtles
4bf6785250 Bug 1074651 - Detect integer overflow in BaseTimeDuration::TicksFromMilliseconds; r=bz 2014-10-02 15:14:12 +09:00
Boris Zbarsky
1ca473b6c1 Bug 1075617 followup to fix crash when rule is null. 2014-10-02 02:06:39 -04:00
Boris Zbarsky
47a1dd4ed6 Bug 1075617. Log the correct file/line for the @font-face rule for font errors. r=jfkthame 2014-10-02 00:23:53 -04:00
Cameron McCormack
df5fa13ceb Bug 1028497 - Part 28: Reftests. r=jdaggett 2014-10-02 12:32:10 +10:00
Cameron McCormack
901c98da8a Bug 1028497 - Part 27: Rename some things. r=jdaggett 2014-10-02 12:32:10 +10:00
Cameron McCormack
233cd991a7 Bug 1028497 - Part 26: Tests. r=jdaggett 2014-10-02 12:32:09 +10:00
Cameron McCormack
40e6e7198a Bug 1028497 - Part 25: Support loading of fonts from ArrayBuffer{,View}s. r=bzbarsky,jdaggett 2014-10-02 12:32:09 +10:00
Cameron McCormack
20246f8891 Bug 1028497 - Part 24: Implement FontFaceSet.{ready,status} and dispatch events. r=jdaggett,bzbarsky 2014-10-02 12:32:09 +10:00
Cameron McCormack
044e5d8e38 Bug 1028497 - Part 23: Implement FontFaceSet.{add,clear,delete,has}. r=jdaggett 
Implementing Add, Delete and Clear involves shuffling FontFace objects
between mOtherFaces and mUnavailableFaces.
 2014-10-02 12:32:09 +10:00
Cameron McCormack
cc1aefeae7 Bug 1028497 - Part 22: Make FontFace.load() work for unconnected FontFace objects. r=jdaggett 
The same DoLoad() call works with both CSS-connected and unconnected
FontFaces.
 2014-10-02 12:32:09 +10:00
Cameron McCormack
e101dab5b7 Bug 1028497 - Part 21: Implement the FontFace constructor's parsing of descriptors. r=bzbarsky,jdaggett 
This implements the bulk of the FontFace JS constructor, which parses
the descriptors passed in. We need a notion now of whether a FontFace is
"initialized", since the spec requires us to go through the event loop
before parsing the 'src' descriptor. So a couple of places now have to
check whether the FontFace is fully initialized, and we have a method to
inform the FontFaceSet when a FontFace becomes initialized, in case we
added it to the FontFaceSet before it was initialized (easy to do with
|document.fonts.add(new FontFace(...))|.
 2014-10-02 12:32:09 +10:00
Cameron McCormack
bd49942314 Bug 1028497 - Part 20: Add storage for unconnected FontFace objects and create user font entries for them. r=jdaggett,bzbarsky 
We add a third array on FontFaceSet, mOtherFaces, which stores
unconnected FontFace objects that have been added to the FontFaceSet. We
reflect them in the indexed properties and also create user font entries
for them.

Part 23 will actually allow us to add some of these FontFaces to
mOtherFaces.
 2014-10-02 12:32:08 +10:00
Cameron McCormack
613230f8e4 Bug 1028497 - Part 19: Support disconnecting FontFaces that reflect @font-face rules. r=jdaggett,bzbarsky 
This adds support for a CSS-connected FontFace to be disconnected from
its rule. This causes it to get its own copy of the descriptors on the
nsCSSFontFaceStyleDecl, and for the pointers between the FontFace and
the nsCSSFontFaceRule to be nulled out.

We start tracking now whether a given FontFace is in the FontFaceSet
(in the sense that it will appear on the DOM FontFaceSet object if we
inspect it with script). All FontFace objects created though, whether
they are currently "in" the FontFaceSet or not, are still tracked by the
FontFaceSet. We use the new mUnavailableFaces array on the FontFaceSet
for that.

We need to track these FontFaces that aren't in the FontFaceSet as
that's where we store their user font entry -- important if we call
load() on a FontFace before adding it to the FontFaceSet.
 2014-10-02 12:32:08 +10:00
Cameron McCormack
bb19bc8df1 Bug 1028497 - Part 18: Create user font entries from FontFaces rather than nsCSSFontFaceRules. r=jdaggett 
This changes InsertRule, which looked at the descriptors on an
nsCSSFontFaceRule to create a user font entry and add it to a family,
into InsertConnectedFontFace, which can do the same but for the FontFace
that reflects the rule.
 2014-10-02 12:32:08 +10:00
Cameron McCormack
6add2e10fb Bug 1028497 - Part 17: Factor out FontFace family-name getting. r=jdaggett 2014-10-02 12:32:08 +10:00
Cameron McCormack
8999518250 Bug 1028497 - Part 16: Don't destroy the user font set if there are no @font-face rules. r=jfkthame 
We can no longer call FontFaceSet::DestroyUserFontSet (what used to be
nsUserFontSet::Destroy) in nsPresContext::FlushUserFontSet, since we
need to keep tracking FontFace objects even if the list of @font-face
rules is empty.
 2014-10-02 12:32:08 +10:00
Cameron McCormack
8ff113b040 Bug 1028497 - Part 15.1: Store user font entries in FontFace objects. r=jdaggett 2014-10-02 12:32:08 +10:00
Cameron McCormack
bcf9c1ea1e Bug 1028497 - Part 15: Store FontFace objects on the FontFaceSet rather than nsCSSFontFaceRules. r=jdaggett,bzbarsky 
Here we change FontFaceSet's records array to associate gfxUserFontEntry
pointers with FontFace pointers, rather than with nsCSSFontFaceRule
pointers.  This will make it more uniform to handle both CSS-connected
and unconnected FontFace objects when rebuilding the user font entries
under UpdateRules.
 2014-10-02 12:32:07 +10:00
Cameron McCormack
64ba5709f9 Bug 1028497 - Part 14: Rename some methods to talk about UserFontEntry instead of FontFace. r=jdaggett 
How that we have a class named "FontFace", it's a bit confusing for some
of the gfxUserFontSet methods to have "FontFace" in their names, so I'm
renaming them to mention "UserFontEntry" instead.
 2014-10-02 12:32:07 +10:00
Cameron McCormack
391bce26f9 Bug 1028497 - Part 13: Implement FontFace.load(). r=jdaggett 2014-10-02 12:32:07 +10:00
Cameron McCormack
8044963e80 Bug 1028497 - Part 12: Implement FontFace.loaded. r=jdaggett,bzbarsky 2014-10-02 12:32:07 +10:00
Cameron McCormack
9c5af7dbfe Bug 1028497 - Part 11: Implement FontFace descriptor setters. r=jdaggett 
These set the descriptors, but don't cause anything to update, just
like setting descriptors on an @font-face rule's style declaration
doesn't do anything yet.
 2014-10-02 12:32:07 +10:00
Cameron McCormack
18b7324bdf Bug 1028497 - Part 10: Implement FontFace descriptor getters. r=jdaggett 
We add an mDescriptors that will be used to store the descriptor values
of an unconnected FontFace object.  For CSS-connected FontFace objects,
the descriptors are stored in the nsCSSFontFaceRule::mDecl.mDescriptors.
(Both of these use the same type, though, CSSFontFaceDescriptors.)

Ideally we could have the descriptors always stored on the FontFace,
and for the nsCSSFontFaceStyleDecl go and fetch them from the FontFace,
but it turned out to be impossible to ensure that a FontFace could be
created whenever a nsCSSFontFaceStyleDecl was cloned, since it needs
access to the window object to create the FontFace's promise objects!
 2014-10-02 12:32:07 +10:00
Cameron McCormack
98a3173e51 Bug 1028497 - Part 9: Implement FontFace.status. r=jdaggett 
We make gfxUserFontEntry::SetLoadState virtual so that we can hook into
changes and update FontFace::mStatus.  We can't just reflect the
gfxUserFontEntry's value in FontFace::Status() since the spec has
requirements about when exactly the status is set.
 2014-10-02 12:32:06 +10:00
Cameron McCormack
06f6aeb3c1 Bug 1028497 - Part 8: Implement Length and array access on FontFaceSet. r=jfkthame 
This is a temporary measure until we support iterators on the
FontFaceSet; the spec does not expose FontFaces as indexed properties on
the FontFaceSet.
 2014-10-02 12:32:06 +10:00
Cameron McCormack
e772a00e7b Bug 1028497 - Part 7: Add ability to create a FontFace for a @font-face rule; store it on the nsCSSFontFaceRule. r=jdaggett,bzbarsky 
Every nsCSSFontFaceRule that is used will get a FontFace object to
reflect it in the FontFaceSet.  Here we add storage on the
nsCSSFontFaceRule for its FontFace, although it will be the
FontFaceSet's responsibility to set it.  We also add a static
constructor function on FontFace to create one that reflects a rule.
 2014-10-02 12:32:06 +10:00
Cameron McCormack
550275b747 Bug 1028497 - Part 6: Have a FontFace::Entry class extending gfxUserFontEntry that can inform the FontFaceSet about loading. r=jdaggett 
We can't make FontFace inherit from gfxUserFontEntry, since the former
is cycle collected.  So instead, we have a small class that inherits
from it that will override its virtual methods and forward things on to
the FontFace object.

We make gfxUserFontSet::CreateFontFace virtual so we can override it to
produce instances of our gfxUserFontEntry subclass.
 2014-10-02 12:32:06 +10:00
Cameron McCormack
4a940b57ac Bug 1028497 - Part 4: Move the nsUserFontSet object into FontFaceSet. r=jdaggett 
This (a) moves ownership of the gfxUserFontSet into FontFaceSet, (b) moves
nearly all of the functionality of nsUserFontSet into FontFaceSet, and (c)
adds a class that inherits from gfxUserFontSet so that we can override some
of its virtual functions and delegate them to the FontFaceSet.
 2014-10-02 12:32:05 +10:00
Cameron McCormack
88d0d6a7ac Bug 1028497 - Part 3: Add skeleton implementations of CSSFontFaceLoadEvent, FontFace, FontFaceSet and FontFaceSource. r=jdaggett 2014-10-02 12:32:05 +10:00
Jonathan Kew
e4d8d67d5c Bug 902762 pt 7 - Draw caret appropriately for vertical textruns. r=smontagu 2014-10-01 20:25:50 +01:00
Jonathan Kew
7746f0e276 Bug 902762 pt 6 - Handle vertical textruns for mouse click in nsTextFrame. r=smontagu 2014-10-01 20:25:50 +01:00
Jonathan Kew
4e2adf654b Bug 902762 pt 5 - Handle vertical textruns when painting text in nsTextFrame. r=smontagu 2014-10-01 20:25:49 +01:00
Jonathan Kew
9e9486bb55 Bug 902762 pt 1 - Pass a 'vertical' flag to font shapers, and support vertical shaping through harfbuzz. r=jdaggett 2014-10-01 20:25:48 +01:00
Bas Schouten
6bc7bca0f0 Bug 902952 - Part 1: Add a slight amount of fuzz for radial gradient tests. r=jrmuizel 2014-10-01 19:50:25 +02:00
Jeff Muizelaar
c3affcb72a Bug 1074615. Remove DRAW_SNAPPED. r=mwoodrow 
This doesn't seem to be necessary and doesn't really make sense to me. This
will help us moving region clipping into Moz2D

--HG--
extra : rebase_source : 4a5987ce2a95eaba44a69233d1b7f461f5ec16ea
 2014-10-01 01:25:25 -04:00
Cameron McCormack
ae21036370 Bug 1072724 - Support showing more information about style structs in restyle logs. r=dbaron 
The MOZ_DEBUG_RESTYLE_STRUCTS environment variable can be set to a comma-
separated list of style struct names.  When restyle logging is enabled,
this will cause the style context tree -- showing cached style struct
pointers for those structs specified -- to be logged before each
individual restyle is processed.  It will also show the struct pointer
values involved when swapping structs between style contexts.

For example, set MOZ_DEBUG_RESTYLE_STRUCTS=Font,UserInterface to show
the cached nsStyleFont and nsStyleUserInterface pointers on the style
contexts involved in the restyle process.
 2014-10-01 09:13:57 +10:00
Andrew McCreight
d3a4fe3402 Bug 1068276, part 1 - Allow configuring which type of processes we complain about when there's no leak log. r=jmaher 
Then don't warn for missing logs from tab and geckomediaplugin processes, or default processes on B2G.
 2014-09-30 14:17:27 -07:00
Simon Montagu
3c7be8cd36 Bug 1069941 patch 3: Pass the frame physical width, not inline size, to the inner loop of RepositionFrame, plus cosmetic fixes, r=jfkthame 2014-09-30 10:59:14 -07:00
Simon Montagu
492dd0ecc6 Bug 1069941 patch 2: reset the start coordinate of the inline frames before ReorderFrames so that the margin doesn't get added twice, r=jfkthame 2014-09-30 10:59:13 -07:00
Simon Montagu
9646460f2b Bug 1069941 patch 1: be more accurate when identifying the first and last frames on the line and applying margin/border/padding, r=jfkthame 2014-09-30 10:59:13 -07:00