wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity
63,563 Commits 1 Branch 166 Tags 1.2 GiB
0788ccd0dd
Commit Graph

2702 Commits

Author SHA1 Message Date
Peter Van der Beken
70746efa4b bug 580128 - Fix test_printpreview.xul. r=mrbkap 2010-10-10 15:48:13 -07:00
Mounir Lamouri
7873baa96e Bug 595606 - "ASSERTION: no common ancestor at all" when removing a subtree with more than one id pointed by @form. r=jst a=blocking 
--HG--
rename : content/base/crashtests/595606.html => content/base/crashtests/595606-1.html
 2010-10-13 12:52:45 +02:00
Daniel Holbert
7857adfcb5 Bug 589558, patch 2: Make html5 canvas write-only after an SVG image has been drawn to it. r=roc a=blocking-betaN+ 2010-10-12 12:00:31 -07:00
Daniel Holbert
246bdc65d2 Bug 598798 patch 4: Remove hard-coded GraphicsFilter from nsLayoutUtils::DrawSingleUnscaledImage, and make its dirty-rect argument optional. r=roc a=blocking-betaN 2010-10-11 13:08:07 -07:00
Daniel Holbert
071d06788c Bug 598798 patch 3: Add typedef for gfxPattern::GraphicsFilter to nsLayoutUtils. r=roc a=blocking-betaN 2010-10-11 13:07:59 -07:00
L. David Baron
0b7f765281 Make hit testing for border-radius follow the curvature of the border. (Bug 595652) r=roc a2.0=blocking2.0:betaN 2010-10-11 11:03:12 -07:00
Jesse Ruderman
27a9f1c13e Bug 589723 - Remove framing in layout/base/crashtests/311661-* to ensure onload fires 
--HG--
rename : layout/base/crashtests/311661-1-inner.xul => layout/base/crashtests/311661-1.xul
rename : layout/base/crashtests/311661-2-inner.xul => layout/base/crashtests/311661-2.xul
 2010-10-11 09:55:22 -07:00
Robert O'Callahan
f8ce382549 Bug 596491. Part 4: Rename ForcePluginGeometryUpdate to SynchronousPluginGeometryUpdate, and make it do nothing if no plugin geometry update is required. r=mats,a=blocking 2010-10-11 13:58:21 +13:00
Matt Woodrow
47554e7736 Bug 594983. Look inside display sublists to determine whether there is text for the layer. r=roc,a=blocking 2010-10-11 13:58:20 +13:00
Timothy Nikkel
c126c217ef Bug 602794. nsPresContext::IsRootContentDocument is wrong for the embedding situation. r=bzbarsky a=dbaron 2010-10-09 14:09:22 -05:00
Timothy Nikkel
ce930f4482 Bug 592803. Remove nsPresContext::NotifyInvalidateForScrolling because it is not used. r=roc a=dbaron 2010-10-09 14:09:22 -05:00
Ehsan Akhgari
83a84791e8 Bug 602141 - Right arrow navigation broken on later contenteditable content on single line; r=bzbarsky a=blocking-final+ 2010-10-08 15:49:47 -04:00
Ehsan Akhgari
a6771f6553 Bug 601833 - layout/base/tests/bug240933-1.html and bug240933-2.html triggers uncaught exception: Unknown key: DOM_VK_VK_ENTER; r=bzbarsky a=NPOTB 2010-10-05 19:17:21 -04:00
Ehsan Akhgari
133d6d5182 Bug 597519 - Attempting to add characters to a textarea filled to its maxlength with a trailing newline results in the caret to jump to the previous line; r=roc a=blocking-final+ 2010-09-24 15:10:53 -04:00
Jim Mathies ext:(%2C%20L.%20David%20Baron%20%3Cdbaron%40dbaron.org%3E)
88b93df19d Set vertical resize flags on the root's reflow state when we're doing SizeToContent reflows. (Bug 562955) r=bzbarsky a2.0=blocking2.0:betaN 2010-10-06 21:25:47 -07:00
L. David Baron
2b00d08685 Adjust known assertion counts for assertions that now happen for each overflow area. (Bug 542595, patch 21) a2.0=blocking2.0:beta8 2010-10-06 21:25:47 -07:00
L. David Baron
a56a24a514 Change callers to use new nsIFrame overflow APIs. (Bug 542595, patch 20) r=roc a2.0=blocking2.0:beta8 2010-10-06 21:25:47 -07:00
L. David Baron
40d60928c6 Fix miscellaneous reflow methods to use new overflow area APIs. (Bug 542595, patch 19) r=roc a2.0=blocking2.0:beta8 2010-10-06 21:25:46 -07:00
Boris Zbarsky
a7d2e54c98 Bug 129941 followup. Continue creating scrollframes for native anonymous content. a=crashing tests 2010-10-06 22:21:58 -04:00
Boris Zbarsky
280f2c88c6 Bug 129941. Don't create scrollframes for blockframes (except inline blocks) while printing, and make such blockframes clip their contents instead. r=dbaron 2010-10-06 21:01:24 -04:00
Chris Jones
dfe1b316b7 Bug 596969: Allow a document's CSS viewport to be permanently overridden by chrome script. sr=dbaron a=blocking-fennec 2010-09-24 17:41:31 -05:00
Jesse Ruderman
3d1792e601 Bug 537631 - add crashtest. a=NPOTB 2010-09-24 11:27:58 -07:00
Alexander Surkov
7838007ca0 Bug 597311 - make WM_GETOBJECT return root accessible always, r=davidb, sr=roc, f=marcoz, a=blocking7beta 2010-09-23 12:35:39 +09:00
Masatoshi Kimura
2df4090123 Bug 593577 - Get rid of nsContentType. r=roc a=a 2010-09-20 15:40:13 +02:00
L. David Baron
96b0a79389 Bug 597676. If there's no rootPresContext, we should never detect DOM modification. Makes printing paint again. r=dbaron a=blocking2.0:beta7 2010-09-18 11:43:17 -07:00
Mats Palmgren
83bdf12a71 Bug 559705 - Testcase. a=test 2010-09-18 18:14:25 +02:00
Mats Palmgren
a8e03cc0ca Bug 559705 - "ASSERTION: Subdoc frames must have an inner view too". r=roc a2.0=roc 2010-09-18 13:28:50 +02:00
Mats Palmgren
698eb966cf Bug 449734 part 1 - Preserve presentation when dragging a tab between browser windows. r=roc a=blocking2.0:betaN 2010-09-18 13:28:49 +02:00
Robert O'Callahan
c9fe10ac6d Bug 594774. Detect DOM changes during painting, and abort painting ASAP when that happens. r=dbaron a=blocking 2010-09-17 12:09:08 -07:00
Oleg Romashin
7ab9f25f57 Bug 576437 - CreateOffscreenSurface should not silently translate ImageFormat24 into ImageFormat16_565. r=joe a=blocking2.0 2010-09-16 14:34:53 -07:00
Tom Brinkman
ceef26ba74 Bug 576437 - CreateOffscreenSurface should not silently translate ImageFormat24 into ImageFormat16_565. r=joe a=blocking2.0 2010-09-16 14:34:53 -07:00
Justin Dolske
b7ce13c0fc Bug 588292 - Remove site-supplied text for beforeunload and onunload dialogs, and improve button text. r=jst, ui-r=limi, a=blocking 2010-09-16 00:51:24 -07:00
Chris Jones
0a1ec83bc9 Merge m-c --> cedar 2010-09-15 18:28:06 -05:00
Jonas Sicking
aac728d04b Bug 391177: XSLT should reuse the existing inner window in order to help debuggers and the like. r=jst a=blocker CLOSED TREE 2010-09-15 15:54:00 -07:00
Jonas Sicking
ed8cde0a01 Bug 591198: Display element using normal layout rules if XBL binding fails for security reasons. r=jst a=blocker 2010-09-15 15:53:01 -07:00
Chris Jones
0a4b5217a4 Merge m-c --> cedar 2010-09-15 12:33:59 -05:00
L. David Baron
06bd2147cd Support calc() on background-position, background-size, -moz-transform-origin, and background-image gradient stop positions. (Bug 594934) r=bzbarsky a=blocking2.0:betaN 
(Note:  this also depends on the change to nsStyleAnimation.cpp's StyleCoordToValue in bug 520234 and on other changes in that bug.)
 2010-09-15 08:11:26 -07:00
L. David Baron
d79b3f75c2 Change storage of background-size and background-position to allow percentages and lengths. (Bug 594934) r=bzbarsky a=blocking2.0:betaN 2010-09-15 08:11:26 -07:00
Chris Jones
110d280286 Merge m-c --> cedar 2010-09-14 14:28:39 -05:00
Chris Jones
c9ae92ec81 Fix hunk lost in merge. 2010-09-13 19:51:52 -05:00
Chris Jones
ee72f210ea Merge m-c --> cedar 2010-09-13 19:24:09 -05:00
Siddharth Agarwal
e6277ff20e Back out bug 588712 and bug 595337 due to leaks and test failures. a=orange 2010-09-14 23:04:50 +05:30
Ehsan Akhgari
f92191a290 Bug 595337 - Crash [@ nsTextEditorState::InitializeKeyboardEventListeners] on print preview close with iframe, position:fixed and input r,a=roc 2010-09-13 16:36:43 -04:00
Oleg Romashin
497f2db326 Merge with mozilla central 2779c55431a4, no conflicts 2010-09-10 22:32:25 -07:00
Chris Jones
4820da2166 Merge m-c --> cedar 2010-09-08 17:25:30 -05:00
Daniel Holbert
2aa15ae3ce Bug 594941: Handle imgIContainer::GetHeight/GetWidth failure in DrawBorderImage. r=roc a=roc 2010-09-10 10:42:57 -07:00
Daniel Holbert
ecd6d13497 Bug 594650: Replace static variable in header file with static variable + accessor method, to fix codesighs & Composer.dll bustage. r=roc r=taras a=bustage 2010-09-09 09:41:58 -07:00
Zack Weinberg ext:(%2C%20L.%20David%20Baron%20%3Cdbaron%40dbaron.org%3E)
e4c76eccb0 Bug 451134 (1/2): switch to the official border-radius property names: purely mechanical changes. r=dbaron a2.0=blocking2.0:beta6 
This was generated with the command:

LC_ALL=C grep -irlEZe '[-_]moz[-_]border[-_]radius([-_](top|bottom)(right|left))?' * | xargs -0 perl -pi -e \
    's/-moz-border-radius-(top|bottom)(left|right)/border-${1}-${2}-radius/gi;
     s/_moz_border_radius_(top|bottom)Right/border_${1}_right_radius/g;
     s/_moz_border_radius_(top|bottom)Left/border_${1}_left_radius/g;
     s/-moz-border-radius/border-radius/gi;
     s/_moz_border_radius/border_radius/g;'
 2010-09-09 08:21:47 -07:00
L. David Baron
a9d5fab154 Add a (wrapping) display item that clips its contents to the curvature of a border-radius. (Bug 459144, patch 13) r=roc a2.0=blocking2.0:beta6 2010-09-09 08:21:46 -07:00
L. David Baron
cec33102e4 Remove unneeded nsDisplayClip::mClippingFrame. (Bug 459144, patch 11) r=roc a2.0=blocking2.0:beta6 2010-09-09 08:21:46 -07:00
L. David Baron
f9bc2d9cef Fix places where I missed clamping negative calc() to 0. (Bug 585715) r=bzbarsky a2.0=blocking2.0:beta6 2010-09-09 08:21:46 -07:00
L. David Baron
8aaf22a0f4 Add support for calc() on -moz-border-radius and -moz-outline-radius. (Bug 585715) r=bzbarsky a2.0=blocking2.0:beta6 2010-09-09 08:21:45 -07:00
Chris Jones
9e23f35349 Merge m-c --> cedar 2010-09-07 17:35:15 -05:00
Timothy Nikkel
6b532c4152 Bug 594271. Don't send synth mouse moves to hidden documents. r=dbaron a=dbaron 2010-09-11 13:24:50 -05:00
Timothy Nikkel
5be08ac8ee Bug 594267. Don't call WillPaint on hidden documents. r=bzbarsky a=roc 2010-09-11 13:24:50 -05:00
Timothy Nikkel
bb07e18e5b Bug 594267. Get rid of hack to determine if a document is visible now that chrome and content view managers are linked. r=roc a=roc 2010-09-11 13:24:50 -05:00
Timothy Nikkel
9e47257ea3 Bug 593286. Use the frame/view system to determine parent documents, not the docshell because the docshell hierarchy doesn't stay intact during page tranisition. r=roc a=blocking final 2010-09-11 13:24:50 -05:00
Timothy Nikkel
ba86230db3 Bug 592596. When we thaw a presshell, unsuppress painting after we update our active status. r=bzbarsky a=roc 2010-09-11 13:24:49 -05:00
Timothy Nikkel
64df346e92 Bug 593892. Draw the previous page if the new page is suppressed. r=roc a=roc 2010-09-11 13:24:49 -05:00
L. David Baron
7476de1256 Change blur radii in themes and in some tests to match change in how we interpret text-shadow and -moz-box-shadow blur radii. (Bug 590039) r=dao a2.0=blocking2.0:beta6 2010-09-11 09:27:12 -07:00
L. David Baron
b272e35a61 Change the blur radius for -moz-box-shadow and text-shadow to match what is specified in css3-background, and the blur radius for canvas to follow what is specified in HTML5. (Bug 590039) r=roc a2.0=blocking2.0:beta6 
This fixes the multiplication by 1.5 in
gfxAlphaBoxBlur::CalculateBlurRadius (originally added in changeset
ce9f05b57b95 for bug 467518) to work correctly.  It was previously a
multiplication by 1 due to integer division.  CalculateBlurRadius
previously multiplied by 1.880; it now multiplies by 2.820.

This changes canvas shadow handling to multiply shadowBlur by 2 before
taking its square root, as described in the spec.  This means that
canvas shadow blurs 8px or smaller are 1.5 times larger than they were
previously (due to the CalculateBlurRadius change), and canvas shadow
blurs larger than 8px are 2.121 times larger than they were previously
(due to the CalculateBlurRadius change *and* the additional factor of
sqrt(2)).

This changes text-shadow and -moz-box-shadow handling to use
CalculateBlurRadius on half of the value given instead of passing the
value through directly.  This means that text-shadow and box-shadow
blurs are multiplied by 1.410 relative to their old sizes.  It also
means that we round rather than floor, so that the effect that used to
be drawn by a blur in the range 1px to 1.99px is now drawn by a blur
anywhere in the range 0.36px to 1.05px, the effect that used to be drawn
by a blur in the range 2px to 2.99px is now drawn by a blur anywhere in
the range 1.06px to 1.77px, what used to be a drawn by a blur in the
range 3px to 3.99px is now drawn by a blur anywhere in the range 1.78px
to 2.47px, etc.
 2010-09-11 09:27:12 -07:00
L. David Baron
38c6bf9401 Backed out changeset 2e55203d7b80 to fix orange (test_bug508115.xul timing out). 2010-09-13 20:44:17 -07:00
Jonas Sicking
b6ae0cb58a Bug 591198 - Don't make elements disappear if XBL bindings fail due to security restrictions. r=jst a2.0=blocking 2010-09-14 02:22:06 +02:00
Boris Zbarsky
4753f55125 Bug 593544. Apply first-letter to legends. r=dbaron a=dbaron 2010-09-07 15:10:42 -04:00
Boris Zbarsky
4ccf0e4b31 Bug 593552. If our parent document has no presshell, just fall back to a separate refresh driver instead of trying to dig around for a presshell by other means. r=roc a=dbaron 2010-09-07 15:10:41 -04:00
Chris Jones
e817f48db6 Bug 593506: Fix tests broken by bad patch update. r=roc 2010-09-04 15:46:34 -05:00
Chris Jones
29a74cf7e8 Bug 590294, part 8: Implement resolution-scaled drawing for basic layers. r=roc 2010-09-03 15:10:46 -05:00
Chris Jones
3d571692f4 Bug 590294, part 6: Add a window.setResolution(xres, yres) API to control the number of backing pixels allocated to scalable content. r=roc sr=dbaron 2010-09-03 15:10:46 -05:00
Chris Jones
26466ba198 Bug 590294, part 5: Add a setDisplayPort() API to allow the frontend (or whatever else) to set an arbitrary visible region for the purposes of invalidation and layer retaining. r=roc sr=dbaron 2010-09-03 15:10:46 -05:00
Chris Jones
23f5ee4db4 Bug 590294, part 4: IGNORE_VIEWPORT_SCROLLING currently implies interpreting the visible region as being relative to document space. Displayport rendering wants everything IGNORE_VIEWPORT_SCROLLING implies, except it wants the visible region to be relative to the viewport. So, split the coordinate-space interpretation into a new flag DOCUMENT_RELATIVE, which interprets the visible region as document-relative. r=tn sr=roc 2010-09-03 15:10:46 -05:00
Chris Jones
c3e279df85 Bug 590294, part 3: Keep ContainerLayer type info around in a few places. r=roc 2010-09-03 15:10:45 -05:00
Chris Jones
6e7a7cd71a Merge m-c --> cedar 
--HG--
rename : layout/style/test/hover_helper.html => layout/style/test/chrome/hover_helper.html
rename : layout/style/test/test_hover.html => layout/style/test/chrome/test_hover.html
 2010-09-03 14:07:55 -05:00
Mats Palmgren
76f0893448 Backing out bug 449734 due to unexpected orange. a=ted 2010-09-03 18:13:49 +02:00
Mats Palmgren
d234af154c Bug 449734 - Preserve presentation when dragging a tab between browser windows. r=roc a=blocking2.0:betaN 2010-09-03 16:22:00 +02:00
Robert O'Callahan
bd90f73745 Bug 579276. Part 5: Set CONTENT_NO_TEXT and CONTENT_NO_TEXT_OVER_TRANSPARENT flags. r=tnikkel 2010-09-02 21:18:40 +12:00
Robert O'Callahan
0356f8659e Bug 579276. Part 3: Change Set/IsOpaqueContent API to a more generic Get/SetContentFlags API. r=cjones,sr=vlad 2010-09-02 21:18:40 +12:00
Robert O'Callahan
ad566be621 Bug 579276. Part 4: Move nsDisplayItem parameter down to ThebesLayerData::Accumulate. r=tnikkel 2010-09-02 21:18:39 +12:00
Robert O'Callahan
0f5f9e5391 Bug 579276. Part 2: If a transparent layer is over a solid background color, hoist that color into the layer to make it opaque. r=tnikkel 2010-09-02 21:18:39 +12:00
Robert O'Callahan
a150e0aa96 Bug 579276. Part 1: Change layer/layermanager user data API to use keys and values. r=cjones,sr=vlad 2010-09-02 21:18:39 +12:00
Ehsan Akhgari
7b654288bf Back out bug 240933 and bug 590554 because of reftest failure on Win7 and also bug 593211 2010-09-02 19:54:23 -04:00
Oleg Romashin
bd3aa71c63 Merged m-c: 51d17027ff45 -> cedar 2010-09-01 09:36:29 -07:00
Ehsan Akhgari
666a59371c Back out bug 594774 because of reftest failures and crashtest assertions 2010-09-15 12:28:29 -04:00
Robert O'Callahan
5fc84d7803 Bug 594774. Detect DOM changes during painting, and abort painting ASAP when that happens. r=dbaron a=blocking-beta6+ 2010-09-15 11:30:00 -04:00
Simon Montagu
73b323bd97 Don't include floats in bidi resolution and reordering, unless they are first-letters. Bug 588739, r+a=roc 2010-09-06 17:33:18 +03:00
Neil Deakin
b753ff6479 Bug 558072. Allow getting of popup position and size from popupshowing event. r=roc,a=blocking 
--HG--
extra : rebase_source : 0589fbc0410548f8f7ee748d59e70721c5fcc29b
 2010-09-06 15:30:17 +12:00
Kyle Huey
a846b63dba Bug 583863: Refactor <input> implementation to deal with files that aren't on the disk. r=sicking a=blocking-fennec 
--HG--
extra : rebase_source : 2b3605042aea4e4c8273cdad5ec7f05af15959cc
 2010-09-05 14:00:05 -04:00
Kyle Huey
73e9690f8f Backed out changeset af1365b24066 2010-09-05 11:32:57 -04:00
Kyle Huey
bde906120c Bug 583863: Refactor <input> implementation to deal with files that are not on the disk. r=sicking a=blocking-fennec 2010-09-05 09:09:04 -04:00
Chris Jones
7b7af2c67c Merge m-c --> cedar 
--HG--
rename : layout/generic/nsFrameFrame.cpp => layout/generic/nsSubDocumentFrame.cpp
 2010-08-31 02:29:31 -05:00
Robert O'Callahan
b10df1641d Bug 592131. Don't propagate invalidations across document boundaries where the child document's docshell is inactive (e.g., a hidden tab). r=tnikkel,a=blocking 
--HG--
extra : rebase_source : 468f5fab9b2a50f515d50e147fb79bdb8d6a845c
 2010-08-31 17:02:08 +12:00
Robert O'Callahan
c7acef03ff Bug 579323. Part 1.8: Rename InvalidateOverflowRect to InvalidateFrameSubtree. r=tnikkel 
--HG--
rename : layout/generic/nsFrameFrame.cpp => layout/generic/nsSubDocumentFrame.cpp
extra : rebase_source : f7bd38670a03e8a7f3f8c40838af114be79b06f1
 2010-08-31 12:49:12 +12:00
Robert O'Callahan
f6aa05c375 Bug 579323. Part 1.4: Switch nsIFrameFrame users to use nsSubDocumentFrame.h. r=tnikkel 
--HG--
extra : rebase_source : de526602586c70b994a061bbb8a7ca2731c72bbd
 2010-08-31 12:49:07 +12:00
Robert O'Callahan
f566520efb Bug 579323. Part 1: Add FrameLayerBuilder::InvalidateThebesLayersInSubtree, and call it from InvalidateOverflowRect. r=tnikkel,sr=dbaron 
--HG--
extra : rebase_source : c1dbc5b625e23d55ba030709f5cd429122977685
 2010-08-31 12:46:26 +12:00
Robert O'Callahan
41073d6e5b Bug 584193. Allow print preview to work without its own widget. r=smaug a=blocking beta5 2010-08-27 18:15:08 -05:00
Robert O'Callahan
8f331949bd Bug 590468. Part 6: Fix setting of nsDisplayList::mOpaque, and return it from nsDisplayWrapList::IsOpaque. r=tnikkel 2010-08-27 18:15:08 -05:00
Robert O'Callahan
5dc7f6aacb Bug 574621. Ensure that the prescontext DefaultBackgroundColor is painted on the background of root content documents. r=tnikkel 2010-08-26 22:01:43 -05:00
Chris Jones
49048c0d61 Merge m-c --> cedar 
--HG--
rename : layout/style/test/test_hover.html => layout/style/test/hover_helper.html
 2010-08-31 00:35:03 -05:00
Chris Jones
a23b322c10 Merge backout 2010-08-31 00:32:51 -05:00
Chris Jones
b4fc7982d0 Revert temporary landing of 130078 2010-08-31 00:32:24 -05:00
Timothy Nikkel
72cb3f4b66 Revert to rev 36a5e2fa01c9 2010-08-28 01:11:22 -05:00
Robert O'Callahan
495dccb598 Bug 584193. Allow print preview to work without its own widget. r=smaug a=blocking beta5 2010-08-27 18:15:08 -05:00
Jim Mathies
dbd4f65888 Bug 130078. Part 1.1. Update part 1 to deal with changes from bug 513162. r=roc 2010-08-27 18:15:08 -05:00
Robert O'Callahan
0ed33ec62a Bug 130078. Part 1. Hookup view managers unconditionally. r=dbaron 2010-08-27 18:15:08 -05:00
Robert O'Callahan
c02234511d Bug 590468. Part 6: Fix setting of nsDisplayList::mOpaque, and return it from nsDisplayWrapList::IsOpaque. r=tnikkel 2010-08-27 18:15:08 -05:00
Timothy Nikkel
8139d1a8d5 Bug 590468. Part 6: Fix setting of nsDisplayList::mOpaque, and return it from nsDisplayWrapList::IsOpaque. r=tnikkel 2010-08-27 03:34:27 -05:00
Timothy Nikkel
db9bbf8746 Revert to rev 7dd7010e3dc7. 2010-08-27 03:29:44 -05:00
Timothy Nikkel
165b06043a Big oops. 2010-08-27 00:38:52 -05:00
Robert O'Callahan
f23546c84d Bug 574621. Ensure that the prescontext DefaultBackgroundColor is painted on the background of root content documents. r=tnikkel 2010-08-26 22:01:43 -05:00
Timothy Nikkel
a9ea89a789 imported patch recordignoringsuppressiononsubdocs 2010-08-26 22:01:43 -05:00
Timothy Nikkel
844374701c imported patch addignoresuppressiontobuilder 2010-08-26 22:01:43 -05:00
Robert O'Callahan
32c50c5467 Bug 590468. Part 6: Fix setting of nsDisplayList::mOpaque, and return it from nsDisplayWrapList::IsOpaque. r=tnikkel 2010-08-26 22:01:43 -05:00
Timothy Nikkel
deb3dacf04 Bug 574621. Ensure that the prescontext DefaultBackgroundColor is painted on the background of root content documents. r=tnikkel 2010-08-26 22:01:43 -05:00
Robert O'Callahan
0c7ca7b2c0 Bug 584193. Allow print preview to work without its own widget. r=smaug 2010-08-26 22:01:43 -05:00
Chris Jones
8992432666 Merge m-c --> cedar 2010-08-26 21:36:43 -05:00
Jim Mathies
ee8930467d Temporarily landing patches for bug 130078. Will be backed out when it lands for real. 2010-08-20 18:24:40 -05:00
Robert O'Callahan
444f617901 Temporarily landing patches for bug 130078. Will be backed out when it lands for real. 2010-08-20 18:24:40 -05:00
Boris Zbarsky
400e64bf2a Bug 586201. Throttle refresh drivers in background tabs. r=roc, a=roc 2010-08-27 00:26:23 -04:00
Chris Jones
6616076b0a Bug 582057, part i: Use nsIWidget::CreateChild in nsIView::CreateWidget* (where possible). r=roc a=blocking-fennecb1 2010-08-20 14:29:02 -05:00
Chris Jones
26435d9035 Bug 582057, part g: Split nsIView::CreateWidget into CreateWidget, CreateWidgetForParent, and CreateWidgetForPopup in preparation of eliminating IIDs here. sr=roc 2010-08-20 14:29:02 -05:00
Robert O'Callahan
06241c1e45 Bug 585817. Part 2: Change nsIPresShell::CreateRenderingContext to GetReferenceRenderingContext, that uses the shared 1x1 surface, and use it all over the place. r=mats,sr=dbaron 2010-08-20 14:29:01 -05:00
Jonas Sicking
0b25dbb018 Backout 2d6ead22831c (bug 588977) due to orange. a=backout 2010-08-20 10:25:52 -07:00
Ryan VanderMeulen
e2afcb8aa4 Bug 588977 - Fix MSVC warning spam by casting as floats. r=roc a2.0=joe 2010-08-20 14:45:07 +02:00
Oleg Romashin
832333ab06 Merged with mozilla-central: 00186bbb7459 2010-08-24 14:21:48 -07:00
Chris Jones
1b38174082 Merge remote-frame code into m-c tip 2010-08-23 22:10:50 -05:00
Robert O'Callahan
e1bb3d5dc8 Bug 587887. Create pref for refresh driver timer, and make it 60Hz by default. r=dbaron,a=bsmedberg 2010-08-23 21:30:08 +12:00
Robert O'Callahan
4e218eafbb Bug 581222. Ensure that the bounds for opaque native-theme backgrounds are correct. r=tn 
--HG--
extra : rebase_source : 0f660f659bf4240713de6e034b4dc8bd88dfb10e
 2010-08-23 21:30:08 +12:00
Robert O'Callahan
6fac80e56c Bug 581222. Draw outer box-shadows for native-themed elements using the alpha mask of the theme background as the border-shape, and disable inner box-shadows. r=dbaron 
--HG--
extra : rebase_source : a9b81a5d3e09cca41a8b479a4b62b3e2df6c4354
 2010-08-23 21:30:08 +12:00
Robert O'Callahan
79b8d06302 Bug 581222. Extend gfxAlphaBlur to support "spread radii". r=vlad 
--HG--
extra : rebase_source : e644ae08007e52c524c3237d336441f1413f846b
 2010-08-23 21:30:07 +12:00
Robert O'Callahan
794cc06f63 Bug 581222. Back out patch that disabled box-shadows for native-themed content elements. 
--HG--
extra : rebase_source : 4685dfdddd9e0bf1ed9e5f8401d6bc73b91a5600
 2010-08-23 21:30:07 +12:00
Chris Jones
07e1a3fd87 Bug 570620, part n: Hook layout/ipc into the build system, and integrate PRenderFrame into the PBrowser family. sr=bsmedberg 2010-08-20 18:24:41 -05:00
Chris Jones
8bf9326ebe Bug 570620, part k: Implement the compositor side of PRenderFrame, which grafts a shadow layer tree into the compositor's tree. r=mats sr=roc 2010-08-20 18:24:41 -05:00
L. David Baron
70c2ff90c6 Share IsPaddingZero between nsBlockFrame and nsInlineFrame by putting it in nsLayoutUtils. (Bug 585715) r=bzbarsky a2.0=blocking:beta6+ 2010-08-31 12:05:12 -04:00
Zack Weinberg
38c9db7305 Bug 471643: Evaluate vertical percentages in border-radius relative to box height. r=dbaron a2.0=blocking:beta6+ 2010-08-31 12:05:11 -04:00
Ms2ger
a2c049c1fc Bug 531030 - Remove support for the spacer element; r=bzbarsky a=blocking-betaN 2010-08-20 08:05:05 +02:00
Karl Tomlinson
0e0e9d5750 b=588306 only invalidate all layers on PAINT_IGNORE_SUPPRESSION when there is suppression to ignore r=roc a=bsmedberg 
--HG--
extra : rebase_source : 28d8cdebf0e8f06a33518263fa3089b317b5ccbc
 2010-08-20 15:49:16 +12:00
Robert O'Callahan
812e6204ae Bug 584282. Use nsDisplayItem::ToReferenceFrame() instead of calling nsDisplayListBuilder::ToReferenceFrame, wherever possible. r=tnikkel,a=dbaron 
--HG--
extra : rebase_source : 730ba8640cb37bd8484ff069b5d6fd46d9bc3e84
 2010-08-13 22:01:58 +12:00
Robert O'Callahan
a581cd6197 Bug 584282. Add nsDisplayItem::mToReferenceFrame and initialize it in the constructor. r=tnikkel,a=dbaron 
--HG--
extra : rebase_source : 496cbde7c495eb8872c3d0ffc0ca4c57c2a6a777
 2010-08-13 22:01:13 +12:00
Jim Mathies
4682c37ce5 Bug 593440 - Remove remaining child widgets on windows. r=roc, a=joe. 2010-09-08 10:52:58 -05:00
Oleg Romashin
2d72b944f4 Bug 556487 - reftests, test_flush_on_paint.html fix. r=roc a=blocking2.0 
--HG--
extra : rebase_source : b322e49716bb2d74c5b86a0908076dea5bfdb3db
 2010-09-07 17:36:54 -07:00
Alon Zakai
4606f548ac Bug 359608 - Animated GIFs are animated even when user navigates to another page.r=bholley,bz;sr=bz;a=blocker 2010-09-07 17:33:02 -07:00
Bobby Holley
dbade7f8ac Bug 592493 - Register border-images with the document image tracker.r=dbaron 2010-09-07 17:30:40 -07:00
L. David Baron
2779814ca6 Expose RectToGfxRect on nsLayoutUtils. (Bug 459144, patch 10) r=roc a2.0=blocking:beta6+ 2010-09-07 15:20:35 -07:00
L. David Baron
c3fe7e1462 Expose nsCSSRendering::ComputePixelRadii. (Bug 459144, patch 9) r=roc a2.0=blocking:beta6+ 2010-09-07 15:20:35 -07:00
L. David Baron
867c202386 Use nsIFrame::GetBorderRadii so that we pick up when it is overridden. (Bug 459144, patch 7) r=roc a2.0=blocking:beta6+ 2010-09-07 15:20:35 -07:00
L. David Baron
fb568df1f4 Move clamping of border-radii that are too big from nsCSSRendering::ComputePixelRadii to nsIFrame::ComputeBorderRadii. This also fixes a bug in nsDisplayBoxShadowOuter::ComputeVisibility. (Bug 459144, patch 5) r=roc a2.0=blocking:beta6+ 2010-09-07 15:20:35 -07:00
L. David Baron
28e2edd0b4 Don't throw away the subpixel part of the border-radius. (Bug 459144, patch 4) r=roc a2.0=blocking:beta6+ 2010-09-07 15:20:34 -07:00
L. David Baron
59ce09e952 Move skip-sides handling from nsCSSRendering::ComputePixelRadii to nsIFrame::ComputeBorderRadii. This fixes a bug (ignoring skip-sides) in nsDisplayBoxShadowOuter::ComputeVisibility, and improves the no-border-radius optimizations when skip-sides allow us to take them. (Bug 459144, patch 3) r=roc a2.0=blocking:beta6+ 2010-09-07 15:20:34 -07:00
L. David Baron
228dbed13a Make nsIFrame::ComputeBorderRadii take an nsSize instead of two nscoords. (Bug 459144, patch 2) r=roc a2.0=blocking:beta6+ 2010-09-07 15:20:34 -07:00
L. David Baron
452d0afadd Move nsCSSRendering::GetBorderRadiusTwips to nsIFrame and rename it to ComputeBorderRadii. (Bug 459144, patch 1) r=roc a2.0=blocking:beta6+ 2010-09-07 15:20:34 -07:00
Timothy Nikkel
25c0749345 Bug 588337. When looking for a container view try a little harder to find the parent document's presshell. r=roc 2010-08-21 19:55:55 -05:00
Timothy Nikkel
e0f7b76a11 Bug 588692. If we can't paint with widget layers, don't try to. r=roc 2010-08-21 19:55:55 -05:00
Ryan VanderMeulen
2cba149979 Bug 588977 - Fix MSVC warning spam by casting as floats. r=roc a2.0=joe 2010-08-20 14:45:07 +02:00
Henri Sivonen
920f5c1228 Bug 577508 - Make the HTML5 parser hide the old page from view when the page being loaded shows a dialog. r=bzbarsky, a=blocking2.0-final. 2010-07-21 12:49:36 +03:00
Boris Zbarsky
f6879c0a75 588174. Make it possible to pass an explicit callback function to mozRequestAnimationFrame. r=roc, sr=dbaron 2010-09-09 01:38:04 -04:00
Daniel Holbert
b2deb14937 Bug 276431 patch 12b: Allow "UnsuppressPainting" call to be effective in resource documents, by disabling EnsureVisible check. r=roc a=blocking 2010-09-08 13:40:39 -07:00
Daniel Holbert
f246613ef4 Bug 276431 Patch 10: Make imgContainer::Draw take image-viewport-size, and improve nsLayoutUtils drawing wrappers. r=roc r=joe a=blocking 2010-09-08 13:40:39 -07:00
Daniel Holbert
52375da4a7 Bug 276431 Patch 9: Handle kFullImageSpaceRect in imgIContainerObserver::OnFrameChanged impls. r=roc a=blocking 2010-09-08 13:40:39 -07:00
Daniel Holbert
0c7ead0f64 Bug 276431 Patch 4c: Add convenience method nsIDocument::IsResourceDocument, for code shared between external resource docs & svg-as-image helper docs. r=roc sr=jst a=blocking 2010-09-08 13:40:39 -07:00
Daniel Holbert
2532488690 Bug 276431 Patch 4b: Don't create a widget for documents that are being used as images. r=roc a=blocking 2010-09-08 13:40:39 -07:00
Daniel Holbert
f385159cba Bug 276431 Patch 4: Add flag on nsIDocument to let us check if it's actually being used as an image. r=roc sr=jst a=blocking 2010-09-08 13:40:39 -07:00
Daniel Holbert
833fe03068 Bug 574529: When determining layout-flushing-safety, ignore IsSafeToRunScript if we aren't able to run script in the first place. r=bz a=blocking 2010-09-08 13:40:38 -07:00
Mounir Lamouri
d01e645ef5 Bug 594109 - FrameLayerBuilder.cpp uses TYPE_MATHML_CHAR_FOREGROUND outside of #ifdef MOZ_MATHML. r=roc a=bustage 2010-09-08 19:44:47 +02:00
Ehsan Akhgari
ddbe740048 Bug 240933 - Part 7: Collapse the selection in textarea's to the trailing BR if needed after every edit operation; r,a=roc 
--HG--
extra : rebase_source : a13c6c277ddb545614eb8c93131112bc793c1348
 2010-09-01 18:06:52 -04:00
Ehsan Akhgari
88f276e98a Bug 240933 - Part 7: Collapse the selection in textarea's to the trailing BR if needed after every edit operation; r,a=roc 
--HG--
extra : rebase_source : def2e0da4f32e9e50231b250075c45766bb00819
 2010-09-01 18:06:52 -04:00
L. David Baron
a9774b11d6 Make IsAutoHeight be a member of nsLayoutUtils so we don't have to have two copies of it. (Bug 585715) r=bzbarsky a2.0=blocking+ 2010-08-25 12:17:56 +02:00
L. David Baron
b99a005c4c Add support for calc() to the 'min-width' and 'max-width' properties. (Bug 585715) r=bzbarsky a2.0=blocking+ 2010-08-25 12:17:56 +02:00
L. David Baron
091d6b7837 Add support for calc() to the 'height', 'min-height', and 'max-height' properties. (Bug 585715) r=bzbarsky a2.0=blocking+ 2010-08-25 12:17:55 +02:00
L. David Baron
1a458f4877 Introduce nsStyleCoord::HasPercent to check for either a percent value or a calc() value containing a percent. (Bug 585715) r=bzbarsky a2.0=blocking+ 2010-08-25 12:17:55 +02:00
L. David Baron
698bb0f927 Add support for calc() to ComputeWidthDependentValue and ComputeHeightDependentValue. Also change calc() handling of percents from using round to using floor, which changes our handling of percents on 'width' back to using floor, reverting an earlier change in this bug. (Bug 585715) r=bzbarsky a2.0=blocking+ 2010-08-25 12:17:55 +02:00
Boris Zbarsky
3e88cabbf5 Bug 586900. Loosen up the test condition for now, pending a fix for the real problem. 2010-08-25 02:52:07 -04:00
Ehsan Akhgari
3b1ecb5fe3 Bug 593211 - Part 2: Back out bug 581585 r,a=roc 
--HG--
extra : rebase_source : f368d3214a458bd642055c46ded2955bdec2a28b
 2010-09-08 20:15:24 -04:00
Ehsan Akhgari
db9e8d389b Bug 593211 - Part 1: Back out the code parts of bug 585922 r,a=roc 
--HG--
extra : rebase_source : bab2379053115e6bcbb72515e3e161547be9029a
 2010-09-08 20:15:24 -04:00
Robert O'Callahan
e31e06e790 Backing out bug 579276. a=me 2010-09-02 23:14:25 +12:00
Robert O'Callahan
9bfc8a863e Bug 579276. Part 5: Set CONTENT_NO_TEXT and CONTENT_NO_TEXT_OVER_TRANSPARENT flags. r=tnikkel 2010-09-02 21:18:40 +12:00
Robert O'Callahan
09145533e8 Bug 579276. Part 3: Change Set/IsOpaqueContent API to a more generic Get/SetContentFlags API. r=cjones,sr=vlad 2010-09-02 21:18:40 +12:00
Robert O'Callahan
32869ab46f Bug 579276. Part 4: Move nsDisplayItem parameter down to ThebesLayerData::Accumulate. r=tnikkel 2010-09-02 21:18:39 +12:00
Robert O'Callahan
a2c4dd3d43 Bug 579276. Part 2: If a transparent layer is over a solid background color, hoist that color into the layer to make it opaque. r=tnikkel 2010-09-02 21:18:39 +12:00
Robert O'Callahan
14f3d9ad78 Bug 579276. Part 1: Change layer/layermanager user data API to use keys and values. r=cjones,sr=vlad 2010-09-02 21:18:39 +12:00
timeless@mozdev.org
a1ef3f23dc Bug 587483 warning: comparison between signed and unsigned integer expressions in FrameLayerBuilder. r=roc,a=roc 2010-09-02 16:46:53 +12:00
Robert O'Callahan
305ec4bd70 Bug 592941. Fix performance regression by ensuring we create a ThebesLayerInvalidRegionProperty for frames with new container layers. r=tnikkel,a=blocking 2010-09-02 16:43:45 +12:00
Timothy Nikkel
ada83800d7 Bug 591435. Need to honour paint suppression in subdocuments. r=roc a=blocking beta6+ 2010-09-01 15:44:48 -05:00
Ms2ger
0cf7a5d525 Bug 562698 - Part c: Pass Elements to AttributeWillChange; r=bzbarsky, a=dbaron 2010-08-24 09:06:20 +02:00
Ms2ger
27271a8a8f Bug 562698 - Part a: Pass Elements to nsIMutationObserver::AttributeChanged and nsCSSFrameConstructor::AttributeChanged; r=bzbarsky, a=dbaron 2010-08-24 09:05:56 +02:00
Ehsan Akhgari
93d6681861 Bug 512405 - Adjust the assertion count on all platforms unconditionally; r=Jesse a=NPOTB 2010-08-23 20:49:25 -07:00
Ehsan Akhgari
5f4aeee6a2 Bug 585922 - Text cursor doesn't follow character input for passwords (encrypted phrases) r=roc a=blocking-fennec2.0b1+ 2010-08-23 20:49:15 -07:00
Chris Jones
921ef38edc Backed out changeset 7b3726c3a580 2010-08-19 19:04:08 -05:00
Robert O'Callahan
210184cb84 Bug 585817. Part 2: Change nsIPresShell::CreateRenderingContext to GetReferenceRenderingContext, that uses the shared 1x1 surface, and use it all over the place. r=mats,sr=dbaron 2010-08-19 13:49:35 -05:00
Mounir Lamouri
ef6632684a Bug 344615 - Implement <input type="url">. r=sicking, sr=smaug a2.0=blocking 2010-08-18 20:33:37 +02:00
Mounir Lamouri
17e57ca845 Bug 555559 - Implement <input type="email">. r=smaug,sicking sr=jst a2.0=blocking 2010-08-18 20:31:54 +02:00
Benjamin Smedberg
3a5f09a601 Revert bug 595337 because of persistent leaks running mochitests, and bug 556487 because of in-process test failures (crashes) and a reftest failure. 2010-09-14 14:50:24 -07:00
Ehsan Akhgari
12f7c089a6 Bug 595337 - Crash [@ nsTextEditorState::InitializeKeyboardEventListeners] on print preview close with iframe, position:fixed and input r,a=roc 2010-09-13 16:36:43 -04:00
Mark Banner
32648806db Backed out changeset f600448ae7db / bug 471643 due to reftest failures 2010-08-19 09:27:01 +01:00
Zack Weinberg
531e232c65 Bug 471643: Make vertical percentages in border-radius relative to box height. r=dbaron 2010-08-19 09:45:32 +02:00
Daniel Holbert
5d6d60ecb4 (no bug) a few whitespace fixes in layout, to triger fresh builds on a CLOSED TREE 2010-08-18 21:53:55 -07:00
Timothy Nikkel
f2fbddac07 Bug 572599. If we get an event on a child widget that is in a disconnected view subtree the view subtree might not have a root widget. r=roc 2010-08-18 20:16:58 -05:00
Timothy Nikkel
cc09403fac Bug 587542. If painting is suppressed in the presshell, drop invalidations that come through the view subsystem as well as through the usual frame invalidation path. r=roc 2010-08-18 20:16:58 -05:00
Timothy Nikkel
fcaca91e69 Bug 587539. When we get a paint event for a widget in a disconnected view subtree there isn't a display root widget. r=roc 2010-08-18 20:16:58 -05:00
Bobby Holley
6788ead45a bug 512260 - part 2 - Make ImageRenderer take a pointer to nsStyleImage rather than making a copy.r=dbaron,a=blocker 2010-08-05 17:30:19 -04:00
Bobby Holley
7a580f398c bug 512260 - Add image tracker to nsDocument and register content images with it.r=roc,sr=dbaron,a=blocker 2010-08-03 20:40:29 -04:00
Robert O'Callahan
20c2a19d6a Bug 537890. Part 10: Fix nsPresContext and nsIDeviceContext unit-conversion methods to be explicit about using CSS logical units instead of physical units. r=dbaron 2010-08-13 21:58:04 +12:00
Robert O'Callahan
b7df1787ef Bug 537890. Part 4: Make points be a fixed number of CSS pixels. r=dbaron 2010-08-13 21:58:01 +12:00
Rob Arnold
beb6ddf7e8 Bug 554982 - Add support for borderless glass and remove the borders from the main window. r=roc,dao a=blocking2.0 2010-08-17 23:07:10 -04:00
Neil Deakin
838688f1fb Bug 551434 - Store the keydown target and retarget the keypress/keyup events when focus changes from chrome to content. r=smaug 2010-08-17 14:37:50 +02:00
Mounir Lamouri
41b8bedd41 Bug 587875 - Build bustage: nsRefreshDriver.h is included by files not included when SMIL is disabled. r=jst@mozilla.org, a=buildbustage 2010-08-17 02:08:35 +02:00
Mats Palmgren
520a653dae Get the parent pres shell from the docshell instead of the document. b=587064 r=roc a=blocking2.0 2010-08-15 15:54:02 +02:00
Daniel Holbert
5b754a5516 Bug 582004 part 2: Make imgIContainerObserver::FrameChanged take a const aDirtyRect argument. r=joe a=blocking 2010-08-13 21:09:48 -07:00
Robert Sayre
f80324a33f Merge tracemonkey to mozilla-central. 2010-08-13 12:45:44 -07:00
Robert Sayre
ff3fd8aeaf Merge mozilla-central to tracemonkey. 2010-08-12 10:12:04 -07:00
Robert Sayre
e0df9dbc6a Disable the test for bug 458898. See bug 562955. 2010-08-11 09:59:54 -07:00
Mats Palmgren
a9ff1e450d Bug 576649. r=bzbarsky a=blocking2.0 2010-08-10 19:04:43 -03:00
Robert O'Callahan
f8dc984ede Backing out bug 584282 and bug 537890 2010-08-14 02:35:06 +12:00
Markus Stange
27b4c7fdf3 Bug 506826 - Hook up -moz-element painting. r=roc 2010-08-13 15:34:01 +02:00
Markus Stange
62cafdb8cc Bug 506826 - Make nsLayoutUtils::PaintFrame able to draw all continuations of a frame. r=roc 2010-08-13 15:32:04 +02:00
Markus Stange
b7ae3b9683 Bug 572680 - Add nsLayoutUtils::DrawPixelSnapped. r=roc 2010-08-13 15:30:37 +02:00
Timothy Nikkel
7e149ba847 Bug 579621. Fix print preview tests to be content subdocuments. r=roc 2010-08-13 21:57:29 +12:00
Robert O'Callahan
0b542b46ed Bug 579258. Remove the 'before move' region parameter to ComputeVisibility. r=tnikkel,a=joe 2010-08-13 21:55:54 +12:00
Robert O'Callahan
b004c93cb1 Bug 579258. Change IsVaryingRelativeToMovingFrame to take the 'moving frame' as a direct parameter instead of getting it from the builder. r=tnikkel,a=joe 2010-08-13 21:54:37 +12:00
Robert O'Callahan
254458b52a Backed out changeset 0c4519d63a98 2010-08-12 11:32:21 +12:00
Boris Zbarsky
657e764de8 Bug 577607 part 2. Teach the refresh driver to flush restyles and reflow on more than one presshell. r=roc 2010-08-11 17:05:27 -04:00
Boris Zbarsky
d9188b16ef Bug 577607 part 1. Make sure resource documents don't have presshells when their display document doesn't. r=roc 2010-08-11 17:05:26 -04:00
L. David Baron
ee89e22866 Add support for calc() to the 'width' property. (Bug 585715) r=bzbarsky a2.0=blocking2.0+ 2010-08-11 12:32:53 -07:00
Boris Zbarsky
456e9e5548 Bug 569520 part 2. Implement a mozRequestAnimationFrame/mozAnimationStartTime API. r=roc, a=joe 2010-08-11 17:05:28 -04:00
Boris Zbarsky
4de28566f3 Bug 577607 part 3. Use the main doc refresh driver for resource documents and the parent document's refresh driver for documents that are not roots of their type. r=roc, a=joe 2010-08-11 17:05:27 -04:00
Boris Zbarsky
b2753641df Bug 577607 part 2. Teach the refresh driver to flush restyles and reflow on more than one presshell. r=roc 2010-08-11 17:05:27 -04:00
Neil Deakin
b698859822 Bug 585841 - Right click, 'copy link location' no longer works 
r=Neil
a=blocking2.0
a=sheriff for landing
 2010-08-10 13:55:31 -07:00
Dão Gottwald
f246f9a00f Backed out changeset cdd440adb726 2010-08-10 15:10:11 +02:00
Ms2ger
e0dc6046da Bug 562698 - Part a: Pass Elements to nsIMutationObserver::AttributeChanged and nsCSSFrameConstructor::AttributeChanged; r=bzbarsky, a=dbaron 2010-08-10 14:25:28 +02:00
Simon Montagu
d5a4b2d2de Check that frame offsets are within content. Bug 579655, r=roc, blocking2.0=dsicore 2010-08-10 10:08:59 +03:00
Neil Deakin
fb66fae998 Bug 383930/552341, allow usage of a property on popups instead of using document.popupNode, should fix leak of popupNode, r=neil,sr=roc 2010-08-09 12:17:19 -04:00
Timothy Nikkel
e3a4bc82b8 Merge back out of changeset 86e8ec17e532 (bug 584193). 2010-08-08 16:58:59 -05:00
Timothy Nikkel
f7b17b72dc Backed out changeset 86e8ec17e532 (bug 584193). 2010-08-08 16:58:40 -05:00
Robert O'Callahan
e14c5ee113 Bug 584193. Allow print preview to work without its own widget. r=smaug 2010-08-08 13:49:07 -05:00
Timothy Nikkel
470b36c651 Bug 579663. Part 9. Simplify ProcessDisplayItems because all items in a container layer have the same app units per dev pixel. r=roc 2010-08-08 13:49:07 -05:00
Timothy Nikkel
76194eb9aa Bug 579663. Part 8. Simplify FrameLayerBuilder::DrawThebesLayer because it does not have to deal with items at different AppUnitsPerDevPixel ratios. r=roc 2010-08-08 13:49:07 -05:00
Timothy Nikkel
e9dcad73c7 Bug 579663. Part 7. Assert AppUnitsPerDevPixel is constant in container layers. r=roc 2010-08-08 13:49:07 -05:00
Timothy Nikkel
308d16ff7b Bug 579663. Part 5. Make display zoom items create a container layer. r=roc 2010-08-08 13:49:06 -05:00
Timothy Nikkel
714913a4d8 Bug 579663. Part 3. Use the right AppUnitsPerDevPixel for zoom items. r=roc 2010-08-08 13:49:06 -05:00
Timothy Nikkel
b96104bb22 Bug 579663. Part 2. Be able to get the APDs out of display zoom items. r=roc 2010-08-08 13:49:06 -05:00
Timothy Nikkel
bbc6dff559 Bug 579663. Part 1. Remove unused offset param from GetActiveScrolledRootFor. r=roc 2010-08-08 13:49:06 -05:00
Timothy Nikkel
16a985dc6e Bug 584617. Part 2. If we get passed an unusual backstop color we need to flush layers. r=roc a=dbaron 2010-08-08 13:49:07 -05:00
Timothy Nikkel
f51a1285cb Bug 584617. Part 1. Make sure that we don't use the overflow rect of the root frame instead of the dirty region when we are drawing ignoring viewport scrolling because that might be wrong. r=roc a=dbaron 2010-08-08 13:49:07 -05:00
Timothy Nikkel
f05b15e0e0 Bug 584516. With linked view manager hierarchies we need to draw the print preview background on subdocument frames as well. r=roc 2010-08-08 13:49:07 -05:00
Ehsan Akhgari
c997e86b2e Bug 581585 - Cache the frame for caret; r=roc approval2.0=dbaron 
--HG--
extra : rebase_source : 3043705ce2689532c40d6e0f1b023b55174e8a88
 2010-07-26 20:05:14 -04:00
Boris Zbarsky
052a2f6a83 Bug 575336 part 5. Stop flushing out layout on the whole viewmanager tree when layout is flushed on a document and results in invalidates. r=roc 2010-08-05 14:39:39 -04:00
Boris Zbarsky
e8a9de31ab Bug 575336 part 1. Make sure to update the size of the current prescontext on style flush, so that media queries do the right thing. r=roc 2010-08-05 14:39:39 -04:00
L. David Baron
d34dbc633c Adjust reftest assertion manifests for churn in nscoord_MAX-related assertions (which includes 'computed overflow area' assertion, because of width wraparound in UnionRect making overflow area empty). (Bug 563584, patch 23) r=roc 2010-08-05 21:59:20 -07:00
Chris Jones
1d4cc217ed Bug 570620, part b: Fix a hidden header depedency and add a PresShell::GetLayerManager() helper. r=tn 2010-08-05 17:11:23 -05:00
Chris Jones
3b7ff8f6bc Bug 570620, part a: Fix an assertion that will soon no longer hold and remove obsoleted already_AddRefed idiom in two places. r=roc 2010-08-05 17:11:23 -05:00
Boris Zbarsky
0b5df24742 Bug 582037. When computing intrinsic widths, take the viewport's dimensions into account when it has percent-height descendants. r=dbaron 2010-08-05 17:59:36 -04:00
Bobby Holley
27a2d4812b Bug 343515 - need API for tabbrowsers to tell docshells they're visible/hidden.r=gavin,sr=bz,a=blocker 2010-08-05 11:27:52 -04:00
Daniel Holbert
996b8e29c8 Bug 579492: Use dev pixels for screen rect in PresShell::PaintRangePaintInfo. r=roc a=dbaron 2010-08-05 07:53:43 -07:00
Boris Zbarsky
b9fae2b3d2 Bug 577838. The first line baseline of a fieldset should be the first line baseline of its legend (if it has one), or of its content if it does not. r=dbaron 2010-08-04 22:40:19 -04:00
David Zbarsky
de6582a359 Remove unneeded nsIDOMNSHTMLInputElement interface by merging it into nsIDOMHTMLInputElement. (Bug 582303) r=jst 2010-08-04 22:40:18 -04:00
Robert O'Callahan
706d94d7e3 Bug 580834. Make nsLayoutUtils::GetActiveScrolledRoot stop at the nearest popup ancestor instead of asserting. r=tnikkel,a=dbaron 2010-08-13 22:03:51 +12:00
Robert O'Callahan
9eb991d75a Bug 584282. Use nsDisplayItem::ToReferenceFrame() instead of calling nsDisplayListBuilder::ToReferenceFrame, wherever possible. r=tnikkel,a=dbaron 2010-08-13 22:01:58 +12:00
Robert O'Callahan
6ea38bb418 Bug 584282. Add nsDisplayItem::mToReferenceFrame and initialize it in the constructor. r=tnikkel,a=dbaron 2010-08-13 22:01:13 +12:00
Robert O'Callahan
f3efde653e Bug 537890. Part 10: Fix nsPresContext and nsIDeviceContext unit-conversion methods to be explicit about using CSS logical units instead of physical units. r=dbaron 2010-08-13 21:58:04 +12:00
Robert O'Callahan
ec0ed23afc Bug 537890. Part 6: Switch DPI dynamically when the window moves across screens or the screen mode changes. r=dbaron 2010-08-13 21:58:02 +12:00
Robert O'Callahan
973ebcc0ad Bug 537890. Part 4: Make points be a fixed number of CSS pixels. r=dbaron 2010-08-13 21:58:01 +12:00
Jim Mathies
f0c2ed6fd9 Bug 579421 - Title bar(window without body) appears at the upper left corner of monitor screen. r=roc. (CLOSED TREE) 2010-08-03 22:36:19 -07:00
Robert O'Callahan
44555f22b8 Bug 580494. Avoid creating an empty ThebesLayer when an inactive nsDisplayItem::BuildLayer returns null. r=tnikkel 
--HG--
extra : rebase_source : a22225bb3b5c2bbc12ab2f9b50594083143dbdf0
 2010-08-03 15:33:24 +12:00
Felipe Gomes
8d9b3f1877 Bug 508906. Add experimental MozTouch events. r=smaug,jimm 2010-08-02 15:34:54 +02:00
Matt Woodrow
a580694478 Bug 505115. Use layers to render active 2D transforms. r=roc,dbaron 2010-08-02 15:07:04 +12:00
Robert O'Callahan
6f767dbf3d Bug 581317. DoApplyRenderingChangeToTree needs to invalidate the ThebesLayer contents of descendants. r=tnikkel 2010-08-02 15:06:58 +12:00
Robert O'Callahan
01e41cf67d Bug 579349. Track the 'drawn region' of content in layers, whhich ignores visibility, and use it to determine which layer a display item should be placed in. r=tnikkel 2010-08-02 15:06:58 +12:00
Craig Topper
a53310509d Bug 579830 - Change nsCOMPtr<Element> to nsRefPtr<Element>. Change one location that was QIing to Element. r=bz a2.0=benjamin 
--HG--
extra : rebase_source : db2a1a863ed6c646ef8eb850eaf93b64b4552be7
 2010-07-30 20:44:45 -07:00
L. David Baron
c06c57f6e6 Fix bustage from bug 570329 with s/windowsWidget/winWidget/g. 2010-07-30 20:50:52 -07:00
L. David Baron
9cc2e9ec05 Switch reftest manifests to new, shorter syntax for widget toolkit tests. (Bug 570329) a2.0=tests 
This patch was created by running the following sed commands:
s/MOZ_WIDGET_TOOLKIT=="\(gtk2\|cocoa\|qt\|windows\)"/\1Widget/g
s/MOZ_WIDGET_TOOLKIT!="\(gtk2\|cocoa\|qt\|windows\)"/!\1Widget/g
on all *.list files in the tree.
 2010-07-30 16:48:57 -07:00
Timothy Nikkel
26feee5b65 Backed out changeset 9e290d196600 (bug 574621) for causing test failures. 2010-07-29 15:16:40 -05:00
Robert O'Callahan
5c284f8466 Bug 574621. Make sure top level content documents get an opaque background. (patch modified to review comments by romaxa) r=tnikkel 2010-07-29 14:12:46 -05:00
Joe Drew
a3756ff597 Bug 572520: step 2.3: make the bug 445810 tests not assume that finishing the load of one image implies that all images have finished loading. r=dbaron 2010-07-28 14:51:37 -07:00
Neil Deakin
20eab8552e Bug 552982, Part 4: change nsXULPopupManager::GetVisiblePopups to also return noautohide panels, r=mats 2010-07-27 09:38:03 -04:00
Ginn Chen
8f3c78f577 Bug 580546 FrameLayerBuilder.cpp failed to compile with Sun Studio 12 r=roc a=bsmedberg 2010-07-27 17:20:55 +08:00
Bobby Holley
ff6a2fbd06 Bug 578511 - Canvas API to disable sync decoding of images.r=roc,sr=vlad 2010-07-26 17:20:45 -04:00
Robert O'Callahan
c3ee8486fe Bug 579264. Ensure that ApplyRenderingChangeToTree repaints popup descendants of the frame. r=bz 2010-07-24 21:38:55 +12:00
Robert O'Callahan
5eaac34d84 Bug 579250. Revamp unified-titlebar interface so that we can tell nsNativeThemeCocoa about toolbars even if they're not actually painted. r=mstange 2010-07-24 21:35:29 +12:00
Olli Pettay
abf43f852b Bug 566466 - speed up createElement(), r=jst, peterv 2010-07-23 12:49:57 +03:00
Craig Topper
b9673b8709 Bug 577438 Part 1: Add previous sibling to nsIMutationObserver::ContentRemoved. r=sicking 2010-07-21 15:05:17 -07:00
Chris Jones
544264704f Bug 567421, part 2: Implement Dump[Self](FILE*) and Log[Self]() methods for layers. r=roc 2010-07-21 13:06:33 -05:00
Robert O'Callahan
163349d538 Bug 579262. Fix logic around mNeedsToUpdatePluginGeometry so we don't miss updating geometry for some plugins. r=tnikkel 2010-07-20 13:29:29 +12:00
Robert O'Callahan
2608584bee Bug 562833. Set proper alignment for display items. r=dbaron 2010-07-20 13:29:25 +12:00
Zack Weinberg
76dbdde0f4 Bug 569719 part 2: Move headers for the former nsCSSLoader and nsCSSDeclaration into mozilla/css/. r=dbaron 
--HG--
rename : layout/style/nsCSSDeclaration.cpp => layout/style/Declaration.cpp
rename : layout/style/nsCSSDeclaration.h => layout/style/Declaration.h
rename : layout/style/nsCSSLoader.cpp => layout/style/Loader.cpp
rename : layout/style/nsCSSLoader.h => layout/style/Loader.h
 2010-06-28 15:49:35 -07:00
Timothy Nikkel
3d5bb058f6 Bug 572296. Default the position to open the context menu to the top left of the document. r=mats 2010-07-18 21:23:48 -05:00
Timothy Nikkel
eaf04d25f4 Bug 563878. Part 15. Fix GetOffsetTo callsites. r=mats 2010-07-18 21:23:48 -05:00
Timothy Nikkel
8d58defa7a Convert to calls of GetOffsetTo from retained layers to GetOffsetToCrossDoc. r=roc on irc 2010-07-18 21:23:48 -05:00
Timothy Nikkel
25663b3497 Bug 563878. Part 13. Implement zoom display list item to handle document hierarchies where zoom is not constant. r=mats sr=roc 2010-07-18 21:23:48 -05:00
Timothy Nikkel
b364da1a00 Bug 563878. Part 12. Change the view observer interface and overhaul painting in view/. r=mats f=roc 2010-07-18 21:23:47 -05:00
Timothy Nikkel
3317cb6848 Bug 563878. Part 11. Rework the synth mouse move code. r=mats 2010-07-18 21:23:47 -05:00
Timothy Nikkel
b131ad775d Adjust comment. r=roc on irc 2010-07-18 21:23:47 -05:00
Timothy Nikkel
460def762d Bug 563878. Part 7. Change frame, point, rect, region APIs. r=mats sr=roc 2010-07-18 21:23:47 -05:00
Craig Topper
dcd5047456 Bug 571946 - Let nsICSSRule::GetType return the type as a PRInt32 type instead of taking an outparam for that. r=bz 2010-07-18 16:39:20 +02:00
Jim Mathies
40cf61b306 merge 2010-07-15 21:47:52 -05:00
Jim Mathies
f529587759 Backing out 'Call Show if our nsIXULWindow will not' patch from bug 574690 due to various regressions. r=bz 2010-07-15 21:47:14 -05:00
Robert O'Callahan
c5cdc8c894 Bug 564991. Part 44: Move IsFixedAndCoveringViewport implementation to nsDisplayBackground so it can work on any frame, not just the canvas background. r=tnikkel 2010-07-16 09:08:12 +12:00
Robert O'Callahan
27f182eeac Bug 564991. Part 42: When the root frame changes size, invalidate the changed area. r=tnikkel 2010-07-16 09:08:12 +12:00
Robert O'Callahan
e9cc1ca0ad Bug 564991. Part 39: Accumulate the full opaque rect of opaque display items, and don't simplify away opaque areas of display items low in z-order. r=tnikkel 2010-07-16 09:08:11 +12:00
Robert O'Callahan
2b0f4a408a Bug 564991. Part 38: Make invalidation-during-paint work reliably. r=mats,sr=dbaron 2010-07-16 09:08:11 +12:00
Robert O'Callahan
4e94c263b7 Bug 564991. Part 35: Fix text decorations to have a unique GetPerFrameKey. r=tnikkel 2010-07-16 09:08:10 +12:00
Robert O'Callahan
e98a518e3c Bug 564991. Part 34: Make sure that ThebesLayerBuffers are always allocated as similar surfaces to the widget surface, whenever possible. r=cjones 2010-07-16 09:08:10 +12:00
Robert O'Callahan
cc0c10fa76 Bug 564991. Part 33: Copy data out of hashtable in DrawThebesLayer in case hashtable is modified during the method. r=tnikkel 2010-07-16 09:08:10 +12:00
Robert O'Callahan
efa400c1bc Bug 564991. Part 31: Don't cull display items in nsDisplayList::ComputeVisibility. r=mats 2010-07-16 09:08:09 +12:00
Robert O'Callahan
504ea430ab Bug 573942. Adjust transform matrix in RenderDocument to ensure that components close to integers become actual integers. r=jrmuizel,sr=vlad 2010-07-16 09:08:08 +12:00
Robert O'Callahan
8ff43c1e7b Bug 564991. Part 29: Sort plugins so they get moved in the best order. r=karl 2010-07-16 09:08:08 +12:00
Robert O'Callahan
1df5a7ec56 Bug 564991. Part 27: Make plugin geometry changes asynchronous and make them happen as close to the final paint as possible. r=matspal,sr=vlad 2010-07-16 09:08:08 +12:00
Robert O'Callahan
c5362bf642 Bug 564991. Part 26: Put background-attachment:fixed backgrounds that propagated to the canvas in their own layer. r=mats,sr=dbaron 2010-07-16 09:08:06 +12:00
Robert O'Callahan
1cbc86420d Bug 564991. Part 25: Introduce a 'has active layers' flag on frames, which times out, and use it for 'opacity'. r=mats,sr=dbaron 2010-07-16 09:08:06 +12:00
Robert O'Callahan
d09c39d0a9 Bug 564991. Part 23: Introduce the concept of 'inactive' layers. r=mats,sr=dbaron 2010-07-16 09:08:05 +12:00
Robert O'Callahan
8fef922c84 Bug 564991. Part 17: Reimplement ColorLayers. r=mats 2010-07-16 09:08:03 +12:00
Robert O'Callahan
9ac2bf6f05 Bug 564991. Part 16: Improve performance by putting each scrollbar in its own layer. Also note that Mac scrollbars are opaque. r=mats,sr=dbaron 2010-07-16 09:08:03 +12:00
Robert O'Callahan
fa8f373bc3 Bug 564991. Part 14: Scroll using the layer system. r=mats,sr=dbaron 2010-07-16 09:08:02 +12:00
Robert O'Callahan
f756e0c2a9 Bug 572613. Avoid creating a SolidColor display item when possible by poking the color into the canvas background display item. r=tnikkel 2010-07-16 09:07:53 +12:00
Robert O'Callahan
1917c1d836 Bug 564991. Part 13: Optimize invalidation to avoid repainting ThebesLayer contents sometimes. r=mats,sr=dbaron 2010-07-16 09:07:53 +12:00
Robert O'Callahan
8e44ae607d Bug 564991. Part 12: Refactor RenderDocument to use nsLayoutUtils::PaintFrame. r=mats 2010-07-16 09:07:52 +12:00
Robert O'Callahan
5bf4f6d915 Bug 564991. Part 11: Start retaining layer trees. r=mats 2010-07-16 09:07:51 +12:00
Robert O'Callahan
2c8b5b5a93 Bug 564991. Part 10: When NS_DOCUMENT_STATE_WINDOW_INACTIVE changes, flush the contents of all ThebesLayers. We need to do this because this change can change the rendering of themed content, and explicitly tracking and invalidating all such content would be way too expensive to justify. r=mats 2010-07-16 09:07:51 +12:00
Robert O'Callahan
cc872e7c9e Bug 564991. Part 9: Retain layer trees. r=tnikkel,sr=mats 2010-07-16 09:07:51 +12:00
Robert O'Callahan
fa45207070 Bug 564991. Part 7: Create Begin/EndDeferredInvalidates API so we can catch and defer invalidates on frames (and suppress certain areas completely). r=mats,sr=dbaron 2010-07-16 09:07:50 +12:00
Robert O'Callahan
079e79c90c Bug 564991. Part 5: Make GetClipRect return a const reference. r=tnikkel 2010-07-16 09:07:50 +12:00
Robert O'Callahan
d3ac39adbb Bug 564991. Part 4: Create GetFrameKey API. r=tnikkel,sr=mats 2010-07-16 09:07:49 +12:00
Michael Ventnor
8139bee929 Bug 564991. Part 3: Create unique nsDisplayItem types for every single display item. r=tnikkel 2010-07-16 09:07:49 +12:00
Robert O'Callahan
a7c0fe60ac Bug 564991. Part 2: Create retained layer API: methods on FrameLayerBuilder that frames can use to access, reuse and invalidate retained layers. r=mats,sr=vlad 2010-07-16 09:07:46 +12:00
Robert O'Callahan
270cfe600a Bug 564991. Part 1: Create a new kind of frame property that can receive a frame pointer when its destructor is called. r=mats 2010-07-16 09:07:45 +12:00
Timothy Nikkel
7bfe0a17cb Bug 560455. Be more careful about the namespace when finding HTML frame construction data. r=bzbarsky 2010-07-15 14:20:32 -05:00
Timothy Nikkel
4a0f17cca3 Bug 558663. When recreating frames, recreate the parent if the parent is a leaf frame. r=bzbarsky 2010-07-15 14:20:31 -05:00
timeless@mozdev.org
792133b46f Bug 577993 mark debug code in InsertFontFaceRule and nsStyleAnimation::ComputeDistance 
r=dbaron

--HG--
extra : rebase_source : a8b1ed0732f8f06a192dbcc485dffe0bb10d4a50
 2010-07-15 15:55:05 +03:00
Bas Schouten
998523d4ec Bug 574690: Don't have DocumentViewer call show on its window if the XULWindow will do this once it's done loading chrome. r=roc 2010-06-28 06:24:52 +02:00
Robert O'Callahan
87188f2833 Bug 572282. Reuse main window layer tree to paint child windows. r=mats 2010-06-28 12:30:39 +12:00
Timothy Nikkel
9df6bf07d2 Bug 496011. Add crashtest. 2010-06-27 16:00:16 -05:00
Timothy Nikkel
0b0bd05f6f Bug 534768. Add crashtest. 2010-06-27 16:00:13 -05:00
Timothy Nikkel
3ba589c76e Bug 572296. Fix logic error when adjusting the position to show the context menu at for a context menu key press. r=enndeakin 2010-06-27 15:58:56 -05:00
Mats Palmgren
ba0d9a576a Bug 536720 - Don't say the frame is in the nsGkAtoms::popupList if that list is empty. r=fantasai 2010-06-27 22:53:59 +02:00
Daniel Holbert
4418e720b6 whitespace-only fix to trigger another Win64 build 2010-06-26 19:43:13 -07:00
Daniel Holbert
ed05c57d55 Bug 574750: Use size_t for counter, in loops over contents of an nsCSSValue::Array. r=bz 2010-06-25 12:38:57 -07:00
Ehsan Akhgari
daaaa51f71 Bug 574071 - Intermittent failure in layout/base/crashtests/348729-1.html | assertion count 0 is less than expected 2 assertions; r=jesse 2010-06-25 15:12:00 -04:00
Boris Zbarsky
59286dcbf7 Bug 577309 part 15. Stop using content indices entirely in nsCSSFrameConstructor::ContentRemoved. r=tnikkel 2010-07-15 00:38:24 -04:00
Boris Zbarsky
29800a9621 Bug 577309 part 14. Stop using content indices entirely in nsCSSFrameConstructor::ContentAppended. r=tnikkel 2010-07-15 00:38:23 -04:00
Boris Zbarsky
e7c8d97165 Bug 577309 part 13. Stop using content indices entirely in nsCSSFrameConstructor::ContentInserted. r=tnikkel 2010-07-15 00:38:23 -04:00
Boris Zbarsky
2c37598755 Bug 577309 part 12. Eliminate most content index use in ContentRangeInserted. r=tnikkel 2010-07-15 00:38:22 -04:00
Boris Zbarsky
5db355713c Bug 577309 part 11. Stop using content indices in AddTextItemIfNeeded. r=roc 2010-07-15 00:38:22 -04:00
Boris Zbarsky
d2c8f30717 Bug 577309 part 10. Stop using content indices in GetRangeInsertionPoint. r=tnikkel 2010-07-15 00:38:22 -04:00
Boris Zbarsky
e5bac765ac Bug 577309 part 9. Stop using content indices in GetInsertionPrevSibling. r=tnikkel 2010-07-15 00:38:21 -04:00
Boris Zbarsky
f8f24c5e2e Bug 577309 part 8. Stop using content indices in ChildIterator. r=roc 2010-07-15 00:38:21 -04:00
Boris Zbarsky
ad541421fe Bug 577309 part 7. Stop using content indices in determining whether to suppress whitespace frames. r=roc 2010-07-15 00:38:21 -04:00
Boris Zbarsky
8e3b4bda8e Bug 577309 part 5. Change MaybeConstructLazily to not use content indices. r=tnikkel 2010-07-15 00:38:20 -04:00
Boris Zbarsky
a3e715c327 Bug 577309 part 4. Change MaybeRecreateForFrameset to not use content indices. r=tnikkel 2010-07-15 00:38:20 -04:00
Boris Zbarsky
89bfea579c Bug 577309 part 3. Change ClearLazyBitsInChildren to not use content indices. r=tnikkel 2010-07-15 00:38:20 -04:00
Boris Zbarsky
3f0ad685c1 Bug 577309 part 2. Change the ContentRangeInserted signature to take the end child in addition to the start child. r=tnikkel 2010-07-15 00:38:20 -04:00
Karl Tomlinson
6980b3ff48 b=444870 include overflow in the dirty rect passed to DrawWidgetBackground() r=roc 2010-07-15 10:25:41 +12:00
Jonathan Kew
1341e3f276 bug 511339 - part 1 - implement -moz-font-feature-settings and -moz-font-language-override in CSS. r=dbaron 2010-07-13 21:30:42 +01:00
Mats Palmgren
a1c32a5075 Bug 556432 - Dragging a content selection shows non-selectable text in the drag feedback. r=roc 2010-07-12 22:24:33 +02:00