Shawn Wilsher
6ea17d3edc
Backed out changeset b6f762fde736 (bug 466582) for unit test orange.
2008-12-08 18:51:46 -05:00
Shawn Wilsher
52fa025019
Bug 466582 - smarter handling of remote chrome (and not allowing it)
...
r=bsmedberg, r=bz, sr=bz
2008-12-08 17:14:14 -05:00
Daniel Holbert
ca3e28538e
Bug 418643 trivial follow-up: Remove unneded 'typedef' token, in 'typedef struct folderChildrenInfo { ...', to fix compiler warning. r=sdwilsh
2008-12-07 11:56:39 -08:00
Marco Bonardo
2a4f1b3c4e
ug 466303 - When removing bookmark backups remove also old html ones, r=dietrich
2008-12-05 16:27:23 +01:00
Marco Bonardo
c53ec05b07
Bug 460119 - Convert autocomplete feedback increase to an async query, r=dietrich
2008-12-04 16:41:06 +01:00
Marco Bonardo
4069663e3a
Bug 423139 - BOOKMARK_REDIRECT_TIME_THRESHOLD is weird, r=dietrich
2008-12-04 16:11:04 +01:00
Marco Bonardo
b74ce92e03
Bug 460830 - Tag containers and queries have bogus QUERY_TYPE definition, r=dietrich
2008-12-04 16:01:19 +01:00
Marco Bonardo
d984c838eb
Bug 463863 - Download history not shown in Places history, r=dietrich, ui-r=beltzner
2008-12-04 13:59:04 +01:00
Marco Bonardo
b2e922b709
backing out bug 414715 due to possible Ts regression
2008-11-27 16:10:36 +01:00
Dietrich Ayala
9f81601ddc
Bug 414715. Notify the user if places.sqlite is locked. r=pike, r=mak77, ui-review=faaborg, a=blocking-firefox3.1
2008-11-26 20:59:47 -05:00
mak77@bonardo.net
3d576ef8ce
Bug 463471 - temp tables are not correctly synced to disk when the user clear private data on shutdown (r=sdwilsh, r=dietrich)
2008-11-13 22:45:49 -08:00
Ehsan Akhgari
a89e46f55a
Bug 461710 - Write an automated test to ensure that visited link coloring is turned off in private browsing mode (further fixes); r=dietrich (NPOTB)
2008-11-13 23:12:03 +03:30
Dietrich Ayala
d6bf19faab
Fix for bug 445704 (JSON bookmarks backup has localized filename (and can't be easily restored). r=zeniko, a=beltzner.
2008-11-13 17:54:25 +01:00
Marco Bonardo
45455110de
backout test for bug 463471 causing orange
2008-11-13 11:33:01 +01:00
Dietrich Ayala
127a3341a9
[mq]: backout-bug-463471
2008-11-12 23:50:19 -08:00
Marco Bonardo
36f739f320
Bug 463471 - temp tables are not correctly synced to disk when the user clear private data on shutdown, r=dietrich, sdwilsh a=beltzner
2008-11-12 21:50:02 +01:00
Marco Bonardo
20ae2fab49
Bug 462366 - correct bogus importBookmarksHTML behaviour, r=dietrich a=beltzner
2008-11-12 21:45:53 +01:00
Edward Lee
a246ed282d
Bug 463661 - Create a pref to control the location bar search sources (history, bookmark, both, none). r=dietrich, a1.9.1b2=beltzner
...
Bug 463535 - Continuing search immediately after changing prefs give wrong results
2008-11-10 10:04:36 -06:00
Marco Bonardo
d2ef7735fd
Bug 459493 - remove placesBackground, r+a=mconnor
2008-11-06 23:22:10 +01:00
mak77@bonardo.net
234918c058
Bug 418643 - Bookmark folder deletion executes too many SQL statements (r=dietrich)
2008-11-05 14:02:12 -08:00
Dietrich Ayala
029ea93f23
Bug 419792 - Use optimized query to get tags for nsNavHistoryResultNode (r=mano)
2008-11-05 10:20:00 -08:00
Dietrich Ayala
81891e2697
Bug 457473 - Bookmark copy creates bookmark with duplicate guid - regression in FF 3.0.3 (r=mano)
2008-11-05 10:15:49 -08:00
Shawn Wilsher
0a32f72c76
Bug 453180 - Adding moz_annos_placeattributeindex should be done in migration code not shutdown
...
r=dietrich
2008-11-03 22:41:16 -05:00
Shawn Wilsher
1f89b4462e
Bug 453179 - Remove unused indecies in a migration code path - not shutdown
...
r=dietrich
2008-11-03 22:41:15 -05:00
Shawn Wilsher
cf48f23ca7
Bug 453177 - Move moz_places.user_title removal back to MigrateV6Up
...
r=dietrich
2008-11-03 22:41:15 -05:00
Ehsan Akhgari
5fdab7c48c
Bug 461710 - Write an automated test to ensure that visited link coloring is turned off in private browsing mode; r=dietrich
2008-11-04 02:52:23 +03:30
Ehsan Akhgari
a2e1bc51b4
Bug 248970 - Private Browsing mode (global toggle for saving/caching everything) [Places unit test fix]; r=dietrich
2008-11-04 02:52:22 +03:30
Ehsan Akhgari
4770654ff7
Bug 248970 - Private Browsing mode (global toggle for saving/caching everything) [unit test API changes]; r,sr=mconnor
2008-11-04 02:52:22 +03:30
Dietrich Ayala
46b4a3eec0
Bug 462379 - (NS_ERROR_FAILURE) [nsINavBookmarksService.insertBookmark] when trying to star a bookmark (r=sdwilsh, for marco, sdwilsh)
2008-10-31 17:59:38 -07:00
Dietrich Ayala
15440bfcb0
Bug 415960 - bookmark tags edit control should provide autocomplete (r=mano, core by asouzis@users.sf.net)
2008-10-31 09:16:22 -07:00
Dietrich Ayala
b6d5857bc6
backing out bug 462379 due to persistent test failures
2008-10-30 23:11:04 -07:00
Edward Lee
7314b9afe4
More bug 462379 followup (both == 2) rs=sdwilsh
2008-10-30 20:30:35 -05:00
Dietrich Ayala
f1def076d9
bug 462379 followup (for sdwilsh@forerunnerdesigns.com)
2008-10-30 16:36:14 -07:00
Shawn Wilsher
a2d0e846cb
Bug 462379 - (NS_ERROR_FAILURE) [nsINavBookmarksService.insertBookmark] when trying to star a bookmark
...
r=dietrich
2008-10-30 17:20:33 -04:00
Marco Bonardo
8d17009bde
Bug 462206 - finalize statements in nsPlacesDBFlush, r=sdwilsh
2008-10-30 09:51:34 +01:00
Marco Bonardo
3e6ce6e98a
Bug 462205 - add statementCallback interface to nsPlacesDBFlush, r=sdwilsh
2008-10-30 09:45:21 +01:00
Marco Bonardo
bd5be67a29
Bug 462204 - Don't try to cancel a not existant timer in nsPlacesDBFlush, r=sdwilsh
2008-10-30 09:42:36 +01:00
Marco Bonardo
04d3fb42d9
Bug 462213 - make migrateV8 tolerant to downgrade-upgrade paths, r=sdwilsh
2008-10-30 09:37:49 +01:00
Shawn Wilsher
ffb57e62b1
Bug 462047 - nsPlacesDBFlush.js should have an error handler.
...
This changeset adds the handleError method from mozIStorageStatementCallback to
nsPlacesDBFlush so we can report errors to the error console if they occur.
r=dietrich
2008-10-28 17:44:35 -04:00
Marco Bonardo
f118fc44e0
Bug 460947 - fsync stuff has a wrong query for expiration sites cap
...
r=dietrich
2008-10-27 18:52:23 -04:00
Marco Bonardo
ed77be778c
Bug 459934 - should lazy-load places autocomplete statements
...
r=dietrich
r=sdwilsh
2008-10-27 18:52:23 -04:00
Shawn Wilsher
53d9ccaa7e
Bug 459789 - lazily get mDB[Invalid|Old]Frecencies
...
r=dietrich
2008-10-27 18:52:23 -04:00
Shawn Wilsher
d3792f99c1
Bug 459788 - Lazily get mDBBookmarkToUrlResult
...
r=dietrich
2008-10-27 18:52:23 -04:00
Shawn Wilsher
53bf616b5a
Bug 459786 - lazily get mDBVisitTo[Visit|URL]Result
...
r=dietrich
2008-10-27 18:52:23 -04:00
Shawn Wilsher
5c893a5e9c
Bug 459787 - remove mDBUrlToUrlResult
...
This changeset removes an unused query that was in the startup path.
r=dietrich
2008-10-27 18:52:22 -04:00
Shawn Wilsher
c7e57e1cb1
Bug 459781 - create our string bundle in a more sane way
...
This changeset only creates the string bundle when we need it, and only in one
place as opposed to two separate places.
r=dietrich
2008-10-27 18:52:22 -04:00
Shawn Wilsher
d3d72c5b09
Bug 459776 - date formatter is unused
...
This changeset removes a small part of code that places does in startup that is
not used or needed.
r=dietrich
2008-10-27 18:52:22 -04:00
Shawn Wilsher
34a4755e8b
Bug 459773 - Creating a collation is expensive
...
This makes a lazy getter for getting our collation saving us about 3% of places
startup time.
r=dietrich
2008-10-27 18:52:21 -04:00
Marco Bonardo
27bd310336
Bug 455474 - cleanup nsNavBookmarks::Init
...
r=dietrich
2008-10-27 18:52:21 -04:00
Marco Bonardo
e8ac5aeecb
Bug 459491 - nsPlacesDBFlush could use async queries instead of background thread
...
r=sdwilsh
--HG--
rename : toolkit/components/places/tests/background/head_background.js => toolkit/components/places/tests/sync/head_sync.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addBookmark.js => toolkit/components/places/tests/sync/test_database_sync_after_addBookmark.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addBookmark_batched.js => toolkit/components/places/tests/sync/test_database_sync_after_addBookmark_batched.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addVisit.js => toolkit/components/places/tests/sync/test_database_sync_after_addVisit.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addVisit_batched.js => toolkit/components/places/tests/sync/test_database_sync_after_addVisit_batched.js
rename : toolkit/components/places/tests/background/test_database_sync_after_modifyBookmark.js => toolkit/components/places/tests/sync/test_database_sync_after_modifyBookmark.js
rename : toolkit/components/places/tests/background/test_database_sync_after_quit_application.js => toolkit/components/places/tests/sync/test_database_sync_after_quit_application.js
rename : toolkit/components/places/tests/background/test_multiple_bookmarks_around_sync.js => toolkit/components/places/tests/sync/test_multiple_bookmarks_around_sync.js
rename : toolkit/components/places/tests/background/test_multiple_visits_around_sync.js => toolkit/components/places/tests/sync/test_multiple_visits_around_sync.js
2008-10-27 18:52:21 -04:00
Shawn Wilsher
866c0b3978
Bug 459315 - Wrap favicon work in a transaction
...
This wraps a series of statements that run on the main thread to reduce the
number of fsyncs that end up happening.
r=dietrich
2008-10-27 18:52:21 -04:00
Shawn Wilsher
2a07d62a96
Bug 459299 - nsNavHistory::SetPageTitleInternal is slow
...
This caches a statement that is created any time a pages title changes. The
creation of the statement took roughly 66% of the functions execution time
according to shark.
It also removes a transaction that was not needed in this method.
r=dietrich
2008-10-27 18:52:21 -04:00
Marco Bonardo
f6e56b6916
Bug 456029 - optimize the temp table triggers
...
This changeset makes the triggers work much faster which should greatly reduce
the timings of adding a visit and a bookmark.
r=sdwilsh
2008-10-27 18:52:21 -04:00
Shawn Wilsher
7a2e763702
Bug 450290 - Sync the temp tables to the permanent tables.
...
This changeset adds code that is run at app-startup that will flush out changes
to the temporary tables into the permanent ones. For moz_places, this is done
whenever we sync moz_historyvisits and when we add or modify a bookmark. For
moz_historyvisits, this is done on a timer controlled by the preference
places.syncDBTableIntervalInSecs.
Changeset includes full test coverage for the above behaviors.
r=dietrich
r=Mak77
2008-10-27 18:52:20 -04:00
Marco Bonardo ext:(%2C%20Shawn%20Wilsher%20%3Csdwilsh%40shawnwilsher.com%3E)
3fc608c2a6
Bug 449640 - Modify the places backend to use the temporary tables &
...
Bug 450705 - Optimize the query changes from the temp table rewrite
This changeset merges patches from two bugs to actually use the temporary tables
created for places.
Bug 449640 patch by Shawn Wilsher <sdwilsh@shawnwilsher.com>
r=dietrich, r=Mak77
Bug 450705 patch by Marco Bonardo <mak77@bonardo.net>
r=sdwilsh, r=dietrich, r=Mardak
2008-10-27 18:52:20 -04:00
Shawn Wilsher
825b607244
Bug 449086 - Create temporary tables for frequently used places tables
...
This changeset creates two temporary tables that will be used when inserting
data into moz_places and moz_historyvisits. This will reduce the number of
writes as well as the number of fsyncs that happen.
r=dietrich
2008-10-27 18:52:19 -04:00
Ehsan Akhgari
229637b291
Bug 248970 - Private Browsing mode (global toggle for saving/caching everything) [places part]; r=dietrich
2008-10-20 00:44:59 +03:30
Shawn Wilsher
5edc587690
Backout places fsync changes
2008-10-17 12:29:34 -04:00
Marco Bonardo
877c2f729e
followup to bug 459934, fix memory leak, mpa=mano, for post facto review
2008-10-17 08:56:25 -04:00
Marco Bonardo
4d5942f11f
Bug 459934 - should lazy-load places autocomplete statements
...
r=dietrich
r=sdwilsh
2008-10-17 06:12:53 -04:00
Shawn Wilsher
8cb912ef64
Bug 459789 - lazily get mDB[Invalid|Old]Frecencies
...
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
10cebaa66f
Bug 459788 - Lazily get mDBBookmarkToUrlResult
...
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
2f47ae77b2
Bug 459786 - lazily get mDBVisitTo[Visit|URL]Result
...
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
653538e53f
Bug 459787 - remove mDBUrlToUrlResult
...
This changeset removes an unused query that was in the startup path.
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
bb7e0e8c36
Bug 459781 - create our string bundle in a more sane way
...
This changeset only creates the string bundle when we need it, and only in one
place as opposed to two separate places.
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
d9d1b7f304
Bug 459776 - date formatter is unused
...
This changeset removes a small part of code that places does in startup that is
not used or needed.
r=dietrich
2008-10-17 06:12:52 -04:00
Shawn Wilsher
1d0921f3e0
Bug 459773 - Creating a collation is expensive
...
This makes a lazy getter for getting our collation saving us about 3% of places
startup time.
r=dietrich
2008-10-17 06:12:52 -04:00
Marco Bonardo
867daf5b5f
Bug 455474 - cleanup nsNavBookmarks::Init
...
r=dietrich
2008-10-17 06:12:52 -04:00
Marco Bonardo
53ea567322
Bug 459491 - nsPlacesDBFlush could use async queries instead of background thread
...
r=sdwilsh
--HG--
rename : toolkit/components/places/tests/background/head_background.js => toolkit/components/places/tests/sync/head_sync.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addBookmark.js => toolkit/components/places/tests/sync/test_database_sync_after_addBookmark.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addBookmark_batched.js => toolkit/components/places/tests/sync/test_database_sync_after_addBookmark_batched.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addVisit.js => toolkit/components/places/tests/sync/test_database_sync_after_addVisit.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addVisit_batched.js => toolkit/components/places/tests/sync/test_database_sync_after_addVisit_batched.js
rename : toolkit/components/places/tests/background/test_database_sync_after_modifyBookmark.js => toolkit/components/places/tests/sync/test_database_sync_after_modifyBookmark.js
rename : toolkit/components/places/tests/background/test_database_sync_after_quit_application.js => toolkit/components/places/tests/sync/test_database_sync_after_quit_application.js
rename : toolkit/components/places/tests/background/test_multiple_bookmarks_around_sync.js => toolkit/components/places/tests/sync/test_multiple_bookmarks_around_sync.js
rename : toolkit/components/places/tests/background/test_multiple_visits_around_sync.js => toolkit/components/places/tests/sync/test_multiple_visits_around_sync.js
2008-10-17 06:12:52 -04:00
Shawn Wilsher
f5d2e83ae5
Bug 459315 - Wrap favicon work in a transaction
...
This wraps a series of statements that run on the main thread to reduce the
number of fsyncs that end up happening.
r=dietrich
2008-10-17 06:12:52 -04:00
Shawn Wilsher
4d5fb2f862
Bug 459299 - nsNavHistory::SetPageTitleInternal is slow
...
This caches a statement that is created any time a pages title changes. The
creation of the statement took roughly 66% of the functions execution time
according to shark.
It also removes a transaction that was not needed in this method.
r=dietrich
2008-10-17 06:12:52 -04:00
Marco Bonardo
b71369cd19
Bug 456029 - optimize the temp table triggers
...
This changeset makes the triggers work much faster which should greatly reduce
the timings of adding a visit and a bookmark.
r=sdwilsh
2008-10-17 06:12:52 -04:00
Shawn Wilsher
4f97936d8c
Bug 450290 - Sync the temp tables to the permanent tables.
...
This changeset adds code that is run at app-startup that will flush out changes
to the temporary tables into the permanent ones. For moz_places, this is done
whenever we sync moz_historyvisits and when we add or modify a bookmark. For
moz_historyvisits, this is done on a timer controlled by the preference
places.syncDBTableIntervalInSecs.
Changeset includes full test coverage for the above behaviors.
r=dietrich
r=Mak77
--HG--
rename : toolkit/components/places/tests/unit/head_bookmarks.js => toolkit/components/places/tests/background/head_background.js
2008-10-17 06:12:51 -04:00
Marco Bonardo ext:(%2C%20Shawn%20Wilsher%20%3Csdwilsh%40shawnwilsher.com%3E)
5715c324ab
Bug 449640 - Modify the places backend to use the temporary tables &
...
Bug 450705 - Optimize the query changes from the temp table rewrite
This changeset merges patches from two bugs to actually use the temporary tables
created for places.
Bug 449640 patch by Shawn Wilsher <sdwilsh@shawnwilsher.com>
r=dietrich, r=Mak77
Bug 450705 patch by Marco Bonardo <mak77@bonardo.net>
r=sdwilsh, r=dietrich, r=Mardak
2008-10-17 06:12:51 -04:00
Shawn Wilsher
5790687517
Bug 449086 - Create temporary tables for frequently used places tables
...
This changeset creates two temporary tables that will be used when inserting
data into moz_places and moz_historyvisits. This will reduce the number of
writes as well as the number of fsyncs that happen.
r=dietrich
2008-10-17 06:12:50 -04:00
Shawn Wilsher
810e90b149
Bug 460315 - set journal_mode to TRUNCATE
...
Sets the journal_mode to the places database to TRUNCATE
r=dietrich
2008-10-16 15:59:33 -04:00
Marco Bonardo
564c306794
Bug 458683 - Backup only uri nodes into tag containers, r=dietrich
2008-10-14 17:24:08 +02:00
Neil Rashbrook
b50d21d9c9
Bug 459571 Places autocomplete results contain incorrect search string r=sdwilsh,mardak
2008-10-14 14:54:17 +01:00
Marco Bonardo
3b22c3d551
Bug 457698 - nsNavHistoryFolderResultNode::OnItemAdded ignores dynamic containers, r=dietrich
2008-10-13 18:14:50 +02:00
Marco Bonardo
6d926ff1b7
Bug 457686 - appendURINode should not append to a dynamic container if we are inside an excludeItems query, r=dietrich
2008-10-13 18:06:50 +02:00
Marco Bonardo
56441e9d6e
Bug 457681 - if ExcludeReadOnlyFolders is false, readonly dynamic containers are still excluded, r=dietrich
2008-10-13 17:58:36 +02:00
Marco Bonardo
b1351fc910
Bug 457677 - PlacesUtils ignores dynamic containers, r=dietrich
2008-10-13 17:54:25 +02:00
Marco Bonardo
68881489cf
Bug 458013 - QueryResultNode Tag refresh optimization is useless as it is, r=dietrich
2008-10-13 14:11:27 +02:00
Ben Turner
311284ddff
Bug 455436 - "XPConnect insists on using its own error reporter even when another is already set." r+sr=jst.
2008-10-12 11:32:34 -07:00
Arpad Borsos
8b11d938d2
Bug 456388 - Remove PR_STATIC_CALLBACK and PR_CALLBACK(_DECL) from the tree; r+sr=brendan
2008-10-10 17:04:34 +02:00
Daniel Holbert
72c410a648
Bug 458167 - (comments-only changes) Grammar Nazi Vol1: s/it's/its/ for the posessive version of the word, and a few other misc comment-typos, in these directories: accessible browser config profile rdf toolkit tools xpcom xpfe
2008-10-01 23:49:45 -07:00
Marco Bonardo
bd07734758
Bug 448584 - Don't save invalid uri nodes while doing a JSON backup (don't stop while saving data), r=dietrich
2008-09-30 10:41:36 +02:00
Dietrich Ayala
89c275d5aa
Bug 420331 - wyciwyg: uris show up in location bar (r=mardak)
2008-09-29 23:46:52 -07:00
Dietrich Ayala
2fa7f086c3
test for bug 331459 - Places query ignores onlyBookmarked
2008-09-29 23:28:08 -07:00
Dietrich Ayala
5d9c44b264
pushing test for bug 433317, forgot to check-in initially
2008-09-29 23:22:46 -07:00
Marco Bonardo
a599a40812
Follow-up to Bug 329534 - Live bookmarks load way too aggressively. Try to workaround possible VM timers bugs that could cause test failures. r=dietrich
2008-09-30 01:24:44 +02:00
Takeshi Ichimaru
820d6827ba
Bug 329534 - Live bookmarks load way too aggressively (lock up/hang/freeze browser), r=dietrich, mak77
2008-09-27 13:05:28 +02:00
Shawn Wilsher
abd0d61c89
Backed out changeset ebafcda56f98 (bug 456910)
...
Backed out for Tp regression (bug 457288)
2008-09-26 15:55:03 -04:00
Shawn Wilsher
af8e0300cd
Bug 456910 - Stop using exclusive locking in places
...
This allows us to greatly reduce the number of fsyncs when upgrading to sqlite.
The perf loss in no longer using this locking is not significant (10^-6 %).
r=dietrich
2008-09-25 13:50:41 -04:00
Marco Bonardo
77bb2e6d9c
Bug 407468 - Livemark loading and failed to load messages should be static menuitems from menu.xml, original patch by Michael Schonfeld <dev@schonfeld.org>, r=mano
2008-09-25 12:30:33 +02:00
Marco Bonardo
5edd5fff2c
Bug 418671 - Clean up places views drag and drop code, r=mano
2008-09-19 17:47:45 +02:00
Shawn Wilsher
5d3ab665f0
backout merge
2008-09-18 15:05:36 -04:00
Shawn Wilsher
9bf0fdc3ad
backout merge
2008-09-18 15:03:15 -04:00
Shawn Wilsher
f46423d1af
Backed out changeset eb14737f8488 (places fsync work)
2008-09-18 15:02:55 -04:00
Shawn Wilsher
9bc5bb6827
backout merge
2008-09-18 15:02:17 -04:00
Shawn Wilsher
47008f4df3
Backed out changeset c99b7659dc0a (places fsync work)
2008-09-18 15:01:51 -04:00
Shawn Wilsher
8df9786bcd
backout merge
2008-09-18 15:01:01 -04:00
Shawn Wilsher
900250bc91
Backed out changeset f3c9af143cc1 (places fsync work)
2008-09-18 15:00:30 -04:00
Shawn Wilsher
09255da4ab
Backed out changeset dabae13daacb
2008-09-18 14:47:31 -04:00
Shawn Wilsher
f909f6ff81
Test breakage fix from bug 449640
2008-09-18 13:51:33 -04:00
Shawn Wilsher
16fef55947
Bug 450290 - Sync the temp tables to the permanent tables.
...
This changeset adds code that is run at app-startup that will flush out changes
to the temporary tables into the permanent ones. For moz_places, this is done
whenever we sync moz_historyvisits and when we add or modify a bookmark. For
moz_historyvisits, this is done on a timer controlled by the preference
places.syncDBTableIntervalInSecs.
Changeset includes full test coverage for the above behaviors.
r=dietrich
r=Mak77
--HG--
rename : toolkit/components/places/tests/unit/head_bookmarks.js => toolkit/components/places/tests/background/head_background.js
2008-09-18 11:10:47 -04:00
Marco Bonardo ext:(%2C%20Shawn%20Wilsher%20%3Csdwilsh%40shawnwilsher.com%3E)
ec97557606
Bug 449640 - Modify the places backend to use the temporary tables &
...
Bug 450705 - Optimize the query changes from the temp table rewrite
This changeset merges patches from two bugs to actually use the temporary tables
created for places.
Bug 449640 patch by Shawn Wilsher <sdwilsh@shawnwilsher.com>
r=dietrich, r=Mak77
Bug 450705 patch by Marco Bonardo <mak77@bonardo.net>
r=sdwilsh, r=dietrich, r=Mardak
2008-09-18 11:10:34 -04:00
Shawn Wilsher
a981391a48
Bug 449086 - Create temporary tables for frequently used places tables
...
This changeset creates two temporary tables that will be used when inserting
data into moz_places and moz_historyvisits. This will reduce the number of
writes as well as the number of fsyncs that happen.
r=dietrich
2008-09-18 11:10:09 -04:00
Marco Bonardo
1d4ddeb7ae
Bug 430442 - Undo and redo in the library are sometimes not correctly working, r=dietrich
2008-09-11 16:16:54 +02:00
Phil Ringnalda
b65979710c
Bug 454360 - Use Components.results.NS_BINDING_ABORTED instead of hardcoding the value, r=gavin
2008-09-09 21:33:27 -07:00
Ted Mielczarek
468a3823fc
bug 447642 - get rid of --disable-mochitest, replace MOZ_MOCHITEST with ENABLE_TESTS. r=bsmedberg
2008-09-09 13:59:11 -04:00
Serge Gautherie
d583b6d94c
Bug 450938 - "test_417228-other-roots.js:89: strict warning: assignment to undeclared variable excludedFolderId"; Av1; r=mano
2008-09-07 16:46:41 +02:00
Marco Bonardo
016e09eab3
Bug 451499 - wrong folder icon appears on smart bookmarks, r=dietrich
2008-09-06 17:21:55 +02:00
Shawn Wilsher
c7fa5f7164
Bug 453181 - Remove code that is labeled REMOVE ME
...
This changeset removes a bunch of code that was labeled REMOVE ME with a release
stated. All those releases have passed, so let's get rid of the code.
r=dietrich
2008-09-05 12:20:40 -04:00
Oleg Romashin
77c933f0f8
Bug 453821 - Places building in embedding-minimal profile failed. r=edilee.
2008-09-05 17:49:49 +03:00
Shawn Wilsher
6f881e6434
Bug 451590 - nsNavHistory needs nsIClassInfo with THREADSAFE flag
...
This changeset marks nsNavHistory as threadsafe so we can use the database
connection on more than one thread in JS. It also adds assertions on every
other public API to ensure that it is only running on the main thread.
r=dietrich
r=bent
2008-09-04 18:11:14 -04:00
Simon Wagner
2c6f2ecec6
Bug 452958 - Livemarks service does not show children with empty titles, r=dietrich
2008-09-04 19:00:18 +02:00
Shawn Wilsher
f22841cdcd
Bug 452777 - regression from lastInsertRowID: Undo folder deletion mix up views
...
r=Mak77
2008-09-03 12:45:20 -04:00
Marco Bonardo
fed5a1056a
Bug 442731 - GIF favicons are not resampled in places.sqlite (large icons are stored), r=dietrich, pavlov
2008-09-02 13:59:59 +02:00
Shawn Wilsher
538d2ecdf2
Bug 429988 - Use a background thread for places work when possible
...
This changeset creates a JS module that acts as a wrapper for a background
thread to do places work on.
Tests included!
r=bent
r=dietrich
2008-08-27 22:33:01 -04:00
Edward Lee
2958cfc7b7
Bug 451760 - Allow matching at beginning of title/url by pref. r=dietrich
2008-08-24 10:45:33 -05:00
Shawn Wilsher
631638c56c
Bug 451244 - nsNavHistory does not use threadsafe refcounting
...
This changeset makes nsNavHistory use the threadsafe addref and release macros
so database access can be done off of the main thread via nsPIPlacesDatabase.
r=dietrich
2008-08-19 23:31:53 -05:00
Marco Bonardo
f682e17963
Bug 411966 - Wrong favicon appears in the bookmarks list, r=dietrich
2008-08-19 11:26:16 -04:00
Marco Bonardo
9ac24ff28a
Bug 427142 sporadic test_393498.js failure on bm-win2k3-pgo01 because of VM timer issues. r=dietrich
2008-08-18 12:55:24 -04:00
Dietrich Ayala
974dc64fd8
Bug 450674 - Fix test_expiration.js
...
r=sdwilsh
2008-08-16 18:34:36 -04:00
Shawn Wilsher
b77395a679
Bug 449884 - Stop using mozIStorageConnection::GetLastInsertRowID
...
It turns out that this is not a safe function to use at all when you start using
the database connection on more than one thread. It also does not work as
expected when triggers are used to insert data into a database.
r=dietrich
2008-08-16 18:28:28 -04:00
Shawn Wilsher
186dba48ff
Bug 444763 - Use an unshared cache connection instead of a shared one
...
This makes places no longer use a shared cache for the database. This wins us
about 7% for location bar queries. For those needing access to the places
database now, they should QI nsINavHistoryService to nsPIPlacesDatase and get
the database connection off of it.
r=dietrich
2008-08-16 18:23:24 -04:00
Shawn Wilsher
d2b18f154b
Bug 449506 - Expose the places db connection
...
This adds a private interface that consumers can QI to to get access to the
internal database connection.
r=dietrich
2008-08-16 18:21:23 -04:00
Dão Gottwald
d6eb562dc8
Backed out changeset be5521120b06
2008-08-13 09:52:48 +02:00
Marco Bonardo
56162e6327
Bug 411966 – Wrong favicon appears in the bookmarks list. r=dietrich
2008-08-13 08:44:38 +02:00
L. David Baron
7732175080
Merge backout of changeset fb56f835e52d due to test failure and leaks.
2008-08-06 11:54:04 -07:00
L. David Baron
a2d75eb595
Backed out changeset fb56f835e52d due to test failure and leaks.
2008-08-06 11:53:44 -07:00
Dietrich Ayala
e8837e2090
bustage fix for bug 329534
2008-08-06 10:20:30 -07:00
Dietrich Ayala
a8f3c3d3f3
[mq]: bug-329534-livemarks-load
2008-08-06 09:51:14 -07:00
Edward Lee
bb6e4fbb75
Bug 422698 - different levels of URL decoding for address bar and autocomplete suggestions
2008-08-05 18:16:35 -07:00
Edward Lee
e3376d97b9
Bug 424717 - Location bar autocomplete should be willing to complete to a URL with a different protocol
2008-08-05 18:16:12 -07:00
Edward Lee
ead983f50a
Bug 424509 - Location bar autocomplete favors "http://" over domain name starting with "h". r=dietrich
2008-08-05 17:56:04 -07:00
Shawn Wilsher
f7c9f5d3ec
Bug 443433 - [refactor] move places table creation statements to one file
...
This refactors how tables are created in places. There is no change in logic.
r=dietrich
2008-08-04 13:14:17 -04:00
Shawn Wilsher
1082eae412
Address spelling mistake from review comment for bug 443068.
2008-08-04 13:07:17 -04:00
Shawn Wilsher
dbc4d6734f
Bug 443068 - Move triggers into migration code
...
This moves all the triggers created by places into the appropriate migration
functions. This saves us two queries to sqlite_master every time the places
service starts up.
r=dietrich
2008-08-04 12:59:56 -04:00
Edward Lee
5920dfe5d5
Backout 6831521f03ac to fix Bug 446621 - Slowdown on AutoComplete - AwesomeBar. a=beltzner
2008-07-22 08:49:39 -07:00
Edward Lee
aced9a6487
Bug 412736 - in the case of a frecency tie, break it with h.typed and h.visit_count. r=dietrich
2008-07-21 23:29:51 -07:00
Edward Lee
3f4c03d18d
Bug 424557 - Allow AwesomeBar to default search only urls (or history/titles/bookmarks/tags). r=dietrich
2008-07-21 14:27:50 -07:00
Marco Bonardo
f93c481bb8
bug 427142 - sporadic test_393498.js failure on bm-win2k3-pgo01 because of VM timer issues. r=dietrich
2008-07-21 11:41:09 -04:00
Edward Lee
26fd4468ea
Bug 395161 - Make it possible to restrict the url bar autocomplete results to bookmarks/tagged/history entries and match only url/title. r=dietrich
2008-07-19 01:51:34 -07:00
Edward Lee
b8397c4e80
Bug 249468 - Add all bookmark keywords to location bar autocomplete drop-down list
2008-07-17 04:50:37 -07:00
Edward Lee
2fb181ae19
Bug 392143 - show keywords as url bar autocomplete choices. r=dietrich, r=gavin
2008-07-17 04:48:40 -07:00
Edward Lee
45d4dba4ef
Bug 406422 - Globally decay adaptive input history to allow for new entries. r=dietrich
2008-07-16 13:45:42 -07:00
Serge Gautherie
6f72cab4f0
Bug 311672 – Remove the obsolete 2nd parameter from |nsIStringBundleService::createBundle(...)| "JS" callers. r=zeniko/mano
2008-07-12 11:56:02 +02:00
Olli Pettay
7283e91f7c
Relanding Bug 444432 - Mozilla2 Tinderbox 'qm-win2k3-moz2-01': test_places/unit/test_419731.js: FAIL
2008-07-11 16:00:41 +03:00