Commit Graph

794 Commits

Author SHA1 Message Date
dietrich@mozilla.com
4541ab0bc3 Bug 381795 places indexes need review (followup, r=sspitzer) 2007-11-20 15:27:41 -08:00
dietrich@mozilla.com
466257d6aa Bug 381795 places indexes need review (r=sspitzer, r=marco) 2007-11-20 10:23:38 -08:00
dietrich@mozilla.com
a8a5d28b4f Bug 389789 nsNavHistory::RemoveDuplicateURIs() should not delete moz_historyvisits, it should remap them to the moz_place id we are keeping (r=marco, r=sspitzer) 2007-11-19 21:14:57 -08:00
mozilla.mano@sent.com
eb11c71b56 Backing out bug 404370, which caused sortFolderByName to fail (in test_placesTxn). 2007-11-19 19:28:27 -08:00
mozilla.mano@sent.com
adf51f6912 Bug 387746 - New Left Pane for Places Organizer, along with other places back-end and front-end changes; also fixes bugs 393547, 395994, 401075, 403141. r=dietrich. 2007-11-19 18:01:53 -08:00
mozilla.mano@sent.com
051876ac24 Bug 404370 - perf: Don't call AdjustIndices when inserting a bookmark at the default index. r=sspitzer. a=mconnor. 2007-11-19 17:14:28 -08:00
gavin@gavinsharp.com
7f2645a2c7 Fix newlines 2007-11-19 12:48:56 -08:00
sdwilsh@shawnwilsher.com
9ce3a83879 Bug 400543 - Add TRANSITION_DOWNLOAD. r=mano, a=schrep 2007-11-12 18:54:32 -08:00
dietrich@mozilla.com
f46ce4ead5 Bug 320183 Optimize statement compilation (r=sspitzer, a=drivers) 2007-11-09 13:21:38 -08:00
dietrich@mozilla.com
b487b75a28 Bug 400679 get last session query is joining against itself (could be faster) (r=dietrich, a=drivers) 2007-11-09 13:05:49 -08:00
dietrich@mozilla.com
f493153e14 Bug 402753 remove post-sql options checks from nsNavHistory::IsHistoryMenuQuery (r=sspitzer, a=drivers) 2007-11-09 12:20:37 -08:00
dietrich@mozilla.com
c96b2a0062 Bug 403040 Places killed all my history >2 days ago (r=sspitzer, a=drivers) 2007-11-09 12:04:13 -08:00
dietrich@mozilla.com
b435ec328c Bug 385397 history menu is slow to open with a large history (r=mano, a=beltzner) 2007-11-06 12:54:46 -08:00
sspitzer@mozilla.org
6136270b4a backing out my fix for bug #399664, due to 2% Ts regression (see bug #402668 for details) 2007-11-06 00:43:53 -08:00
sspitzer@mozilla.org
10234c2591 fix for bug #399664: In location bar autocomplete, indicate which part of the result matches the query (and make sure it is visible) r=gavin, parts r=neil deakin a=m9 blocker 2007-11-05 21:31:22 -08:00
dietrich@mozilla.com
4e5504eede Bug 402297 Firefox hangs on shutdown - places shutdown cleanup takes an inordinately long time (r=sspitzer) 2007-11-05 09:18:21 -08:00
dietrich@mozilla.com
7aaaa8940c Bug 332748 Figure out how much history we can show by default (browser.history_expire_days now set to 180 days) (r=sspitzer) 2007-11-04 17:10:37 -08:00
dietrich@mozilla.com
675fa00c84 Fixing comments. 2007-11-02 10:48:08 -07:00
dietrich@mozilla.com
a3b7551038 Bug 385834 don't do incremental vacuuming, makes fragmentation worse [was: places' sqlite file can get overly large, do incremental vacuuming] (r=sspitzer) 2007-11-02 10:46:41 -07:00
dietrich@mozilla.com
46395e4413 Bug 381795 places indexes need review (r=sspitzer) 2007-11-01 20:24:03 -07:00
dietrich@mozilla.com
b96d78d845 Bug 401722 aggressively expire history visits that are not top-level (r=sspitzer) 2007-11-01 16:49:01 -07:00
sspitzer@mozilla.org
6cf3d1d1eb fix for bug #401985 change places.sqlite default page_size value to 4K r=dietrich, a=schrep for M9 2007-11-01 10:07:11 -07:00
dietrich@mozilla.com
cff8715e50 Bug 401726 orphaned moz_places records maybe not being deleted (for mak77@supereva.it, r=dietrich, a=mconnor) 2007-10-31 11:34:26 -07:00
mozilla.mano@sent.com
68b3a4816f Bug 401449 - Smart-folders are exposed in bookmark queries. r=sspitzer, a=beltzner. 2007-10-30 16:53:53 -07:00
reed@reedloden.com
48cc2624c7 Bug 382358 - "move places properties back into localizable location before betas" [p=dietrich r=sspitzer a=blocking-firefox3+ for M9] 2007-10-25 13:25:59 -07:00
reed@reedloden.com
114aaea069 Bug 382358 - "move places properties back into localizable location before betas" [p=dietrich r=sspitzer a=blocking-firefox3+ for M9] 2007-10-25 13:18:41 -07:00
mozilla.mano@sent.com
908e585d0d Bug 399729 - Reduce places viewa performance overhead. This also fixes bugs 397117, 399472, 400738 and likely also 399476. r=sspitzer, a=blocking-m9/beltzner. 2007-10-24 19:02:28 -07:00
sayrer@gmail.com
8b06ccf061 Bug 399673. reloading a live bookmark results in refcount leaks of nsNavHistoryResultNode. r=mano, a=mconnor 2007-10-24 11:18:18 -07:00
sspitzer@mozilla.org
b118ec6ece fix for bug #400448: particular places.sqlite freezes browser when attempting to open "Recently Starred Pages, Recently Used Tags or Most Used Tags" r=dietrich, a=mconnor for m9 2007-10-23 22:50:47 -07:00
sspitzer@mozilla.org
c597b3a9a2 fix for bug #387203: getFolderContents() can crash [@nsNavHistoryContainerResultNode::CloseContainer] when JS GC happens nsNavHistoryContainerResultNodes will now keep a strong reference back to the nsNavHistoryResult. This introduces a cycle, so use the cycle collector. r=sicking, a=blocking-firefox3+ 2007-10-18 23:26:34 -07:00
reed@reedloden.com
0b577e572e Bug 395066 - "Hang when trying to clear browsing history" (erasehistory and cleanup) [p=mak77@supereva.it (Marco Bonardo [MaK77]) r=dietrich a=blocking-firefox3+ for M9] 2007-10-18 21:21:17 -07:00
dietrich@mozilla.com
abc10ad0d5 Partial backout of bug 398295, possible cause of Ts regression (bug 399807) 2007-10-15 20:48:14 -07:00
dietrich@mozilla.com
da5b532914 Bug 398295 When I delete multiple items in the Bookmarks Organizer, dozens of assertions appear (r=sspitzer) 2007-10-15 09:44:18 -07:00
reed@reedloden.com
4f57f3b401 Bug 382827 - "Error Message in Linux Terminal when adding an RSS Feed (NS_ERROR_NOT_AVAILABLE) [nsIAnnotationService.getItemAnnotationString]" [p=reed r=Mano a=blocking-firefox3+] 2007-10-13 13:50:57 -07:00
sspitzer@mozilla.org
ceb9ea1661 fix bustage. 2007-10-11 00:17:02 -07:00
sspitzer@mozilla.org
f7f5b51147 fix for bug #387996: add a "Places" folder to the bookmarks menu, populated with smart folders fix for bug #387734: add a "Places" folder to the bookmarks toolbar, populated with smart folders fix for bug #385826: pre-populated places queries fix for bug #396807: have "top 10 most visited sites" as a pre-populated smart folder fix for bug #385831: Investigate dependencies for Most Used Tags query fix for bug #378799: GROUP_BY_FOLDER only works in simple bookmark-folder queries thanks to dietrich for the initial GROUP_BY_FOLDER patch. r=dietrich,mano a=blocking-firefox-3+ 2007-10-10 23:42:38 -07:00
sspitzer@mozilla.org
929d3ee2c7 fix for bug #399367: unknown place: url query keys can cause problems r=dietrich, a=blocks a bug that has blocking-firefox3-+ 2007-10-10 16:00:13 -07:00
dietrich@mozilla.com
6caf1d01fd Bug 398896 New history search hang since 6 Sep 2007 (r=sspitzer) 2007-10-09 12:14:48 -07:00
sspitzer@mozilla.org
0b518cce0a fix for bug #394508: queries that use maxResults can return incorrect results due to post query filtering. initial patch=Colin Walters <walters@verbum.org> r=dietrich, a=mconnor 2007-10-01 10:36:18 -07:00
dbaron@dbaron.org
d690d98bb8 Backing out bug 394508 due to tinderbox orange (test failure of places unit tests). 2007-09-28 18:04:31 -07:00
sspitzer@mozilla.org
a67ceea715 fix for bug #394508: queries that use maxResults can return incorrect results due to post query filtering. initial patch=Colin Walters <walters@verbum.org> r=dietrich, a=mconnor 2007-09-28 16:36:03 -07:00
dietrich@mozilla.com
bf8fe50fb6 Bug 378594 Closing takes very long after deleting a livemark (places) (r=sspitzer) 2007-09-28 16:28:14 -07:00
dietrich@mozilla.com
8f96652d48 Bug 397221 nsNavHistoryQuery leaks opening bookmark/places organizer (for asqueella@gmail.com, r=sayrer, a=mconnor) 2007-09-28 10:51:33 -07:00
sspitzer@mozilla.org
9c0f9c251e fix for bug #397527: append folder and all ancestors to the include / exclude folder array in nsNavHistory::FilterResultSet(), to save repeated queries r=dietrich, a=mconnor 2007-09-27 10:08:15 -07:00
sayrer@gmail.com
4948c86f8c Bug 396982. Location bar autocomplete leaks. Patch by Nickolay Ponomarev <asqueella@gmail.com>. r=sspitzer/sayrer, a=mconnor 2007-09-26 00:36:01 -07:00
mozilla.mano@sent.com
2a7a2ceb32 Bug 396556 - Bookmarks menu does not update when adding/deleting/reloading livemarks or when adding/deleting bookmarks. r=dietrich. 2007-09-22 15:54:42 -07:00
mozilla.mano@sent.com
d116cc2b61 Bug 384752 - onItem* notifications are dispatched for closed containers. r=dietrich, a=mconnor. 2007-09-16 18:47:49 -07:00
mozilla.mano@sent.com
727500d87d Bug 396318 - Livemark feed items without title or link get the value from the previous item, r=dietrich, a=mconnor. 2007-09-16 18:46:27 -07:00
mozilla.mano@sent.com
b0a9d68eed Bug 396300 - Put unfiled-bookmarks under their own root. r=dietirch, a=mconnor. 2007-09-16 18:42:15 -07:00
mozilla.mano@sent.com
131a271663 Bug 384228 - Implement Search-In-Folder(s) back-end. r=dietrich. 2007-09-15 13:07:02 -07:00
mozilla.mano@sent.com
fa04ada8be Bug 393464 - Re-landing tag-search so search-in-folders (bug 384228) and related work could get the same sort of love. patch by dietrich, r=sspitzer, a=mconnor. 2007-09-15 12:53:43 -07:00
dietrich@mozilla.com
e57ed8b642 Bug 393464 Bookmarks manager doesn't search in tags field (reverting) 2007-09-10 11:08:21 -07:00
dietrich@mozilla.com
bce8d8a0e9 Bug 395066 Hang when trying to clear browsing history (r=sspitzer, a=mconnor) 2007-09-09 17:48:34 -07:00
sspitzer@mozilla.org
f01bfd52d9 fix for bug #395446: if the user chooses a result from autocomplete results, or types it manually, have that weigh heavily in ranking url bar autocomplete results r=dietrich, a=mconnor for m8 2007-09-09 11:21:25 -07:00
sspitzer@mozilla.org
c494c75f52 fix for bug #395541: when searching previous autocomplete results, if we find any, tell the front end immediately, instead of waiting for our first db query to return r=dietrich, a=mconnor for m8 2007-09-09 11:18:58 -07:00
sspitzer@mozilla.org
303da8daac fix for bug #395445: Tag and Star icon both show for Location bar entries r=dietrich, a=mconnor for m8 2007-09-07 16:18:23 -07:00
sspitzer@mozilla.org
4b0bd8fb03 fix for bug #394527: livemark feed URIs should show up as "bookmarked" (gold star on) in the url bar and in url bar autocomplete search results for performance: when searching previous autocomplete results, we don't need to regenerate the hash tables (of livemark item ids and livemark feed URIs). when searching previous autocomplete results, if we find any, tell the front end immediately, instead of waiting for our first db query to return. r=dietrich, a=mconnor for m8 2007-09-07 14:47:21 -07:00
sspitzer@mozilla.org
4c276981e8 fix for bug #395267: show tag results (first) in the url bar autocomplete results. r=dietrich, a=mconnor for m8 2007-09-06 22:35:10 -07:00
dietrich@mozilla.com
fa47232b99 Bug 393464 Bookmarks manager doesn't search in tags field (r=sspitzer, a=mconnor) 2007-09-06 16:10:48 -07:00
sspitzer@mozilla.org
f7b5521f7c backing out the fix for bug #390244 vacuuming too aggressively, and vacuuming can take too long. r=dietrich 2007-09-06 12:25:50 -07:00
dietrich@mozilla.com
2a9a34cd9b Bug 394741 Searching in history sidebar doesn't work / returns nothing. (r=sspitzer) 2007-09-05 20:34:27 -07:00
sspitzer@mozilla.org
c3fb208244 relanding the fix for bug #390244: code to drop the user_title column from moz_places table (see bug #389876) makes the places.sqlite file 30% bigger backed out earlier due to tbox orange, but robcee has removed the 122 MB places.sqlite files that kept growing for the unit test tinderboxen. bug #393410 covers the tinderboxen fix. r=dietrich 2007-09-05 16:20:19 -07:00
cbiesinger@gmx.at
10f4183f96 392980 make it possible to QI FaviconLoadListener to nsIRequestObserver r=2xgavin,2xsayrer,mano 2007-09-05 13:23:54 -07:00
benjamin@smedbergs.us
4c8ac0b212 Backout bug 390244 due to tbox orange, per #developers 2007-09-05 12:16:52 -07:00
sspitzer@mozilla.org
6b876fcc5e fix for bug #390244: code to drop the user_title column from moz_places table (see bug #389876) makes the places.sqlite file 30% bigger r=dietrich 2007-09-05 08:18:33 -07:00
sspitzer@mozilla.org
ed826a21c0 backing out, tree is closed 2007-09-04 20:19:46 -07:00
sspitzer@mozilla.org
97281b255a fix for bug #390244: code to drop the user_title column from moz_places table (see bug #389876) makes the places.sqlite file 30% bigger r=dietrich 2007-09-04 20:16:08 -07:00
dietrich@mozilla.com
8393b84957 Bug 317847 Implement "Save this Search" (r=mano) 2007-09-01 14:23:36 -07:00
sspitzer@mozilla.org
b672b31be0 fix for bug #394484: Star icon in url autocomplete results shouldn't be set for items in RSS / Live Bookmarks. r=dietrich 2007-08-31 17:58:10 -07:00
gijskruitbosch@gmail.com
9228e23715 Bug 298705 - live bookmarks should only refresh when browser is active r=mano@mozilla.com (Asaf Romano) Toolkit only, no approval needed. 2007-08-31 13:33:54 -07:00
sspitzer@mozilla.org
0ec80ef4d4 fix for bug #385834: places' sqlite file can get overly large, do incremental vacuuming. r=dietrich 2007-08-28 00:19:57 -07:00
mozilla.mano@sent.com
7c1760b346 Bug 393924 - Stop setting the bookmarkFeedURI annotation on livemark children. r=sspitzer. 2007-08-27 17:35:55 -07:00
dietrich@mozilla.com
54c378f7da Bug 393472 EXPIRE_NEVER annos can be orphaned when moz_places records are deleted (r=sspitzer) Bug 387573 ExpireHistoryParanoid does not cleanup all unused values (for mak77@supereva.it, r=dietrich) 2007-08-24 10:40:55 -07:00
sspitzer@mozilla.org
2112848c76 fix for bug #393223: annotations expired too early r=dietrich 2007-08-23 15:26:11 -07:00
dietrich@mozilla.com
ddeff8f23a Bug 386711 (followup) Use single queries in nsNavHistoryExpire methods (for mak77@supereva.it, r=dietrich) 2007-08-22 09:50:16 -07:00
sspitzer@mozilla.org
573b2b762c fix for bug #389491: have url bar autocomplete do a case insensitive search against both url and title with results orderded by a combination of last visited and visit count also includes fixes for bugs: #383672: after visiting http://cheese.livejournal.com/, typing livejournal in the urlbar should suggest http://cheese.livejournal.com/ #392141: strip trailing / leading whitespace before doing url bar autocomplete #391887: typing "https://" no longer drops down a list of https sites #390404: javascript: urls (and other urls) that I didn't type or click on are in url bar when I autocomplete #385033: URLBar dropdown hangs and eats keystrokes when typing #373256: URL/location bar autocomplete slowness (sqlite database doesn't seem to be cached) r=dietrich 2007-08-21 17:05:03 -07:00
dietrich@mozilla.com
c557c3900c Bug 386711 Use single queries in nsNavHistoryExpire methods (r=dietrich) 2007-08-21 14:58:34 -07:00
sspitzer@mozilla.org
39f2d29221 fix for bug #392392: I've typed http://gmail.com in the urlbar, but I don't see that in the history sidebar or history menu (due to redirect handing in places) r=dietrich 2007-08-20 15:43:28 -07:00
dietrich@mozilla.com
a5fe8d1711 Bug 392401 EXPIRE_HISTORY expiration policy should be disallowed for item annotations (r=mano) 2007-08-19 13:02:48 -07:00
mozilla.mano@sent.com
18ad48a0ed Bug 385266 - New starring, bookmarking and tagging UI. This is work-in-progress and not yet enabled for anything but the star button itself. Smart folders are not yet hooked up either. r=dietrich. 2007-08-15 18:15:50 -07:00
dietrich@mozilla.com
8edf5e93cf Bug 392383 remove obsolete references to aUserTitleChanged (r=sspitzer) 2007-08-15 14:22:56 -07:00
neil@parkwaycc.co.uk
9616047979 Bug 391346 nsMorkHistoryImporter contains potentially unsafe static cast plus fix some compiler warnings such as integer constant overflow r=Mano 2007-08-15 08:50:22 -07:00
dietrich@mozilla.com
514aab2c87 Bug 376725 test nsINavHistoryResultViewer (r=sspitzer) 2007-08-14 23:14:26 -07:00
dietrich@mozilla.com
4a3f567999 Bug 392213 nsINavBookmarksService.idl comments need clarification for extension developers (r=thunder) 2007-08-14 23:07:18 -07:00
sspitzer@mozilla.org
9d755fa725 fix for bug #392003: first run migration / import from IE is slow, history import should use "run in batch" r=sayrer 2007-08-14 07:20:42 -07:00
joshmoz@gmail.com
b5c4e524c2 fix osx/gcc4 warnings in places. b=391526 r=sspitzer 2007-08-13 13:56:46 -07:00
dietrich@mozilla.com
5e5c4a3704 Bug 386603 Reload live bookmark does not actually show the feed being refreshed (for stevewon@gmail.com, r=dietrich) 2007-08-10 12:23:58 -07:00
ginn.chen@sun.com
9a8c1632f4 Bug 389793 Firefox build failed on OpenSolaris without --disable-mochitest r=benjamin a=dsicore 2007-08-05 20:22:32 -07:00
sspitzer@mozilla.org
21de63fb54 fix for bug #389782: history sidebar doesn't show the same results as fx 2, dup licate uris when grouped by site, last visited, or most visited r=dietrich 2007-08-02 22:41:31 -07:00
dietrich@mozilla.com
8b2b2a1f82 Bug 390706 RLk stats jumped from 4.92 KB to 8.55 KB (r=mano) 2007-08-02 18:04:01 -07:00
dietrich@mozilla.com
1773021091 Backing out the fix to bug 390706, caused increased leakage 2007-08-02 15:38:37 -07:00
dietrich@mozilla.com
1f5823aa2f Bug 390706 RLk stats jumped from 4.92 KB to 8.55 KB (r=mano) 2007-08-02 15:11:45 -07:00
mozilla.mano@sent.com
3f958cc2b2 Bug 382877 - dynamic containers implementation, part 1. r=dietrich. 2007-08-02 13:19:44 -07:00
sspitzer@mozilla.org
642110d085 fix for bug #375777: javascript: urls (and other urls) that I didn't type
or click on are in my history sidebar and history menu.

note, the url bar autocomplete has the same issue, and the fix for that
is coming in bug #390404

r=dietrich
2007-08-02 10:34:55 -07:00
dietrich@mozilla.com
ee2638e3a7 Bug 389876 followup (r+a=mconnor) 2007-07-30 21:55:51 -07:00
dietrich@mozilla.com
e492b2e147 Bug 390171 clearing history for a host can delete annotations (r=sspitzer, a=mconnor) 2007-07-30 20:30:52 -07:00
dietrich@mozilla.com
ef91f561d8 Bug 389876 after places schema change to remove moz_places.user_title, first time start up is very slow (r=sspitzer, a=schrep) 2007-07-30 19:16:02 -07:00
dietrich@mozilla.com
c310f89a2d Bug 389902 annotations expired on dateAdded but not dateModified (r=sspitzer, a=mconnor) 2007-07-30 16:15:32 -07:00
sspitzer@mozilla.org
cd3ca5e8d2 unit test for bug #385397: history menu is slow to open with a large history
r=dietrich, a=mconnor for M7
2007-07-28 17:08:34 -07:00
dietrich@mozilla.com
0842e677c0 Bug 389808 Firefox start with a blank personal toolbar (r=sspitzer, a=schrep) 2007-07-27 13:47:45 -07:00
sspitzer@mozilla.org
96fb8dba04 fix for bug #385397: history menu is slow to open with a large history
use a highly tuned SQL query for our history menu query, which is:

place:type=0&sort=4&maxResults=10

r=dietrich, a=schrep
2007-07-26 14:39:06 -07:00
dietrich@mozilla.com
95308401cd Bug 319455 Expire annotations (r=sspitzer) 2007-07-26 09:23:11 -07:00
thunder@mozilla.com
7751055b97 Bug 360134: Add GUIDs to items so they can be uniquely identified across profiles (for sync purposes). r=mano 2007-07-25 20:53:59 -07:00
mozilla.mano@sent.com
67258253c1 Bug 388695 - getBookmarkIdsForURI should sort by relevance. r=dietrich, sayrer. 2007-07-22 16:25:49 -07:00
sspitzer@mozilla.org
a30c748784 fix for bug #389003: sometimes favicons in url results are blank, need to use
the favicon service.

r=mano
2007-07-21 13:05:27 -07:00
sspitzer@mozilla.org
9b31ea7ba3 fix for bug #389024: Search in "Current Collection Only" in Bookmarks Manager doesn't return results
r=mano
2007-07-21 02:34:22 -07:00
sspitzer@mozilla.org
11ce56d087 unit tests for bug #385829: Search for bookmark queries by lastModified / dateDated
r=mano
2007-07-20 15:26:01 -07:00
sspitzer@mozilla.org
18a0640622 fix for bug #373353: add favicons to the results in the location bar
r=mano
2007-07-20 14:55:18 -07:00
mozilla.mano@sent.com
15f04b5ba3 Backing out bug 388695 due to tinderbox suckage. 2007-07-18 21:01:53 -07:00
mozilla.mano@sent.com
dc8d2f6f2f Bug 388695 - getBookmarkIdsForURI should sort by relevance. r=dietrich. 2007-07-18 19:31:37 -07:00
mozilla.mano@sent.com
0419606b62 Bug 386392 - Drop pre places/places-bookmarks support from browser/. r=gavin. 2007-07-17 14:08:24 -07:00
sspitzer@mozilla.org
c353ff5bb1 fix for bug #385829: Search for bookmark queries by lastModified / dateDated
r=mano
2007-07-16 18:13:50 -07:00
sspitzer@mozilla.org
9cc14dc091 fix for bug #386956: Simplify nsNavHistory::RemoveDuplicateURLs
patch=Marcho Bonardo <mak77@supereva.it>
r=sspitzer
2007-07-12 16:49:58 -07:00
mozilla.mano@sent.com
0f3555aa18 Bug 385828 - Insertion, removal and move operations of items should update the last-modified field of their containing folder. r=dietrich. 2007-07-11 15:38:13 -07:00
mozilla.mano@sent.com
501fbf8e09 Bug 331654 - Provide a way to handle annotations values in a type-agnostic way. r=dietrich. 2007-07-11 02:57:59 -07:00
peterv@propagandism.org
239dae7f24 Backing out to fix orange. 2007-07-10 03:54:09 -07:00
mozilla.mano@sent.com
9107997f37 Bug 385828 - Insertion, removal and move operations of items should update the last-modified field of their containing folder. r=dietrich. 2007-07-10 00:57:31 -07:00
jwalden@mit.edu
e3c4baccae Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros. 2007-07-08 00:08:04 -07:00
sspitzer@mozilla.org
e4b1415f69 fix for bug #386303: Duplicate indexes in nsFaviconService and nsAnnotationService
patch=Marco Bonardo <mak77@supereva.it>

r=sspitzer
2007-07-06 18:15:29 -07:00
sdwilsh@shawnwilsher.com
9091040e12 Bug 386368 - Use getters and setters for database schema version. r=sspitzer 2007-07-02 10:25:41 -07:00
dietrich@mozilla.com
2971dd437e Reverting until windows perf #s are back and things are less noisy 2007-06-27 13:57:56 -07:00
dietrich@mozilla.com
a9f8a9121b Backing out bug 327350 for bug 385957 2007-06-27 13:39:25 -07:00
sspitzer@mozilla.org
c98a26e88b fix for bug #385867: crash when opening the history sidebar (grouped by date) if visit time is in the future
r=dietrich
2007-06-26 08:42:07 -07:00
dietrich@mozilla.com
b964904a99 Bug 327350 initialization of places services can fail in error conditions (r=mano) 2007-06-25 20:57:28 -07:00
mozilla.mano@sent.com
491954f795 Bug 385771 - disallow item-annotations for invalid item ids. r=dietrich. 2007-06-25 18:08:54 -07:00
flamingice@sourmilk.net
dfa3b5a1b9 Bug 385113, Incorrect checks for alloc failure, r=mano 2007-06-25 09:33:18 -07:00
kairo@kairo.at
2472cd5c37 bug 383833 - prepare to eliminate toolkit's mork-based history implementation: make places-enabled builds not descend into history/ any more and use places' nsIBrowserHistory for them, r=mano 2007-06-25 04:05:02 -07:00
dietrich@mozilla.com
1fd046cf84 Bug 380345 Remove dummy connection/statement from the History database (r=sspitzer) 2007-06-23 09:11:33 -07:00
gerv@gerv.net
bad43e28ef Bug 236613: change to MPL/LGPL/GPL tri-license. 2007-06-21 12:55:33 -07:00
darin@meer.net
ecbcf25a51 fixes bug 250900 "nsIBrowserHistory corrupts URI strings [was: crash when a long malformed URL is entered in the Location Bar [@js_CloneFunctionObject]]" r=biesi sr=neil 2007-06-21 12:55:32 -07:00
mconnor@myrealbox.com
511059a5d9 Bug 235915, RemovePage method is no longer part of nsIBrowserHistory interface, patch by bsmedsberg, r=mconnor 2007-06-21 12:55:31 -07:00
bryner@brianryner.com
158d446867 fixing firefox bustage 2007-06-21 12:55:30 -07:00
ben@bengoodger.com
c21a66d503 Migration Branch landing, currently turned off! 2007-06-21 12:55:29 -07:00
bsmedberg@covad.net
ccdf8858f6 Bug 224829 - docshell should not require non-gecko interface nsIBrowserHistory. This was fixed by introducing a new interface nsIGlobalHistory2 to replace the current nsIGlobalHistory. There are two-way adapters so that the frozen interface still works. r=biesi sr=bz a=mscott for toolkit/ changes. 2007-06-21 12:55:28 -07:00
ben@netscape.com
a21e76b352 Fixing Firebird build bustage after timeless' fishy checkin to bug 58613. 2007-06-21 12:55:27 -07:00
varga@netscape.com
5de4383c22 Landing bookmarks changes.
Bug 205378 - Meta bug for changes in bookmarks sorting code
r=jag, sr=sspitzer, a=sspitzer,asa

The CloneResource() has been back ported from Firebird, originally
implemented by Pierre Chanial.
2007-06-21 12:55:26 -07:00
bryner@netscape.com
cedd57a7f8 stub out OutputReferrerURL to fix phoenix bustage 2007-06-21 12:55:25 -07:00
hewitt@netscape.com
daff09aed1 moving the phoenix history from browser to toolkit 2007-06-21 12:55:24 -07:00
sspitzer@mozilla.org
7228bda8ed fix for bug #380735: Persist open state of the "age in days" and "site" containers in the history sidebar
r=dietrich
2007-06-19 22:19:06 -07:00
sspitzer@mozilla.org
211029ed57 partial fix for bug #364298: Crash [ @ BindStatementURI ] when pasting a folder from the history sidebar into the bookmarks toolbar
this turns the crash into a javascript exception, but we are still unable to copy and paste history folder into bookmarks.

r=dietrich
2007-06-19 09:34:32 -07:00
sspitzer@mozilla.org
8847d7a2d8 fix for bug #383572: changes made to bookmarks don't show in bookmark searches / Crash [@ nsCOMArray_base::InsertObjectAt nsNavHistoryFolderResultNode::OnItemChanged] deleting "ghost" bookmark
r=dietrich
2007-06-19 09:25:11 -07:00
mozilla.mano@sent.com
b036599eca Bug 384623 - renaming root folder in the bookmarks tree doesn't update the tree view. r=dietrich. 2007-06-18 16:55:58 -07:00
mozilla.mano@sent.com
8d7d4ed8bb Bug 384503 - Bookmarks service crashes destroying a PRLock. r=sayrer. 2007-06-14 17:40:44 -07:00
dietrich@mozilla.com
2071d84ad8 Bug 371074 Full rebuild isn't always triggered when excludeQueries is set (r=mano) 2007-06-12 20:08:00 -07:00
sspitzer@mozilla.org
70f581190a fix for bug #384091: possible to stop background checking livemarks for updates (until you restart the browser)fix for bug #357236: nsLivemarkService.js should respect browser.bookmarks.livemark_refresh_secondspatch=Christine Yen <cyen@mozilla.com>r=sspitzer 2007-06-12 08:56:36 -07:00
sspitzer@mozilla.org
e17228fb9c fix for bug #383678: moving a folder to its grandchild folder (or deeper) results in datalossr=dietrich 2007-06-12 08:36:16 -07:00
mozilla.mano@sent.com
45f52083ae Bug 383803 - Places Tagging Back-end. r=dietrich. 2007-06-11 22:18:50 -07:00
mozilla.mano@sent.com
53c7685c28 Bug 382813 - nsFaviconService shouldn't rely on icons in chrome://browser. r=sspitzer. 2007-06-05 16:18:47 -07:00
tony@ponderer.org
2d00396f58 Bug 382618 - remove /toolkit/components/url-classifier/content/js/lang.jspatch by Simon Bünzli, r=me 2007-06-02 09:59:52 -07:00
dietrich@mozilla.com
9965fa5d00 Bug 382094 bookmarks root should be a child of the places root (r=mano) 2007-05-31 18:33:29 -07:00
mozilla.mano@sent.com
b34f3a837c Bug 382073 - Bookmarks Service batch update API is a footgun. r=sayrer/mrbkap, a=mconnor. 2007-05-31 17:44:43 -07:00
mozilla.mano@sent.com
2cf106564a Bug 380519 - Don't use the moz_bookmarks.folderType field for marking the toolbar folder. r=dietrich, a=mconnor. 2007-05-31 17:35:49 -07:00
dietrich@mozilla.com
5ed0e38674 Bug 327350 initialization of places services can fail in error conditions (r=sspitzer) 2007-05-30 23:06:38 -07:00
sspitzer@mozilla.org
5b7b3c1145 fix for bug #382221: Dragging bookmark on toolbar doesn't give permanent resultwe need to adjust the indices before we make the change to the item we aremoving, otherwise, our we'll impact the index of the item we are moving.r=dietrich 2007-05-30 16:25:19 -07:00
mozilla.mano@sent.com
60bdcc02cd Follow up to crash fix for bug 240397. 2007-05-29 12:44:26 -07:00
mozilla.mano@sent.com
5801eded85 Fix crash caused by the backout-patch for bug 240397. 2007-05-29 11:50:12 -07:00
dietrich@mozilla.com
ba6626a38d Bug 382248 problems when I remove places.sqlite (we don't re-import bookmarks.html and we lose all bookmarks) (r=sspitzer) 2007-05-29 10:48:52 -07:00
sspitzer@mozilla.org
d01b365fc8 fix for bug #376905: Places bookmarks build flag doesn't influence livemark service being copiedr=sayrerpatch=gijskruitbosch+bugs@gmail.com 2007-05-28 18:08:59 -07:00
mozilla.mano@sent.com
8774824ded Backout the fix for bug 240397 (the change was part of bug 320181), patch on bug 240397. r=mconnor. 2007-05-28 16:28:46 -07:00
sspitzer@mozilla.org
35358cf38e remove unused strings. 2007-05-27 21:12:02 -07:00
sspitzer@mozilla.org
36437f7205 fix for bug #381894: Some Live Bookmarks only show in the places organizer.also, there was a crash lurking in the export code when we didn't have a feed uri.r=sayrer 2007-05-27 20:50:34 -07:00
sspitzer@mozilla.org
53c9312ffb minor typo, no bug. 2007-05-27 20:26:08 -07:00
mozilla.mano@sent.com
72121a07bd Bug 370859 - generic container icon is used for live-bookmarks containers which were added incrementally. r=dietrich. 2007-05-27 15:08:13 -07:00
mozilla.mano@sent.com
673374be43 Bug 330578 - (Shift+) delete in URL bar autocomplete list no longer persistent. r=mconnor. 2007-05-27 10:45:20 -07:00
dietrich@mozilla.com
669f9b5306 Bug 381360 basic bookmarks query test failing (r=sspitzer) 2007-05-25 19:04:57 -07:00
sspitzer@mozilla.org
23afb689e2 partial fix for bug #379729: browser will freeze when reloading live bookmarks.r=sayrer 2007-05-25 15:09:07 -07:00
sspitzer@mozilla.org
b643a886db Bug 381240 - disabling more dateAdded tests 2007-05-25 01:22:02 -07:00
dietrich@mozilla.com
4dd4308599 Bug 381378 export is unacceptably slow for large bookmarks collections (r=mano) 2007-05-24 22:41:49 -07:00
dietrich@mozilla.com
28094c9ab2 Bug 381240 - disabling more lastModified tests 2007-05-24 22:15:37 -07:00
sspitzer@mozilla.org
29b1ae96ac fix for bug #381453: when loaded in frames / iframes, pages that redirect show up in historyr=dietrich 2007-05-24 19:52:24 -07:00
sspitzer@mozilla.org
55c0d7d099 bug 381240 - disabling more tests for now 2007-05-24 08:07:44 -07:00
sspitzer@mozilla.org
22a9fef741 bug 381240 - disabling more tests for now 2007-05-23 17:45:46 -07:00
dietrich@mozilla.com
03a6d8398a Bug 381240 - disabling tests for now 2007-05-23 10:24:40 -07:00
mozilla.mano@sent.com
7645978be1 Backing out cycle-collecting for mQueries from bug 381239, this was not implemented right and does not seem to be necessary either way. 2007-05-22 18:23:24 -07:00
mozilla.mano@sent.com
f9539b60a7 Bug 371820 - Places interfaces should use xpidl-friendly types. r=dietrich. 2007-05-22 18:18:21 -07:00
mozilla.mano@sent.com
fcf315384a Bug 372508 - rename insertItem to insertBookmark and add a title parameter. r=dietrich. 2007-05-22 18:06:31 -07:00
mozilla.mano@sent.com
4466f1279a Bug 372508 - onFolderChanged removal. r=dietrcih. 2007-05-22 16:56:50 -07:00
mozilla.mano@sent.com
fb0664a9e6 Bug 371823 - Optimize item moves. r=sspitzer. 2007-05-22 15:03:53 -07:00
sspitzer@mozilla.org
13e7c6f6c6 fix for bug #377281: Changing bookmark properties sets incorrect keyword_id value in databaser=dietrich 2007-05-20 21:51:46 -07:00
dietrich@mozilla.com
d46f3a6e67 reverting the failing part of the patch to bug 381237 2007-05-20 13:10:40 -07:00
sspitzer@mozilla.org
ab39cce55f adding LOG statements so when test_annotation fails we can figure it out.see bug #381351r=dietrich 2007-05-20 13:10:09 -07:00
dietrich@mozilla.com
f16d9f1f0e Bug 381237 test failure on toolbar folder value on the qm-win2k3-01 - attempting to re-enable this test (r=mano) 2007-05-20 12:22:47 -07:00
mozilla.mano@sent.com
d4e917b4da Bug 381220 - until I modify a folder, the dateAdded / lastModified values don't appear in the bookmark organizer. r=sspitzer. 2007-05-20 04:39:02 -07:00
sspitzer@mozilla.org
9b06287e93 adding some LOG() so I can figure out why the last-modified tests for placesbookmarks are failing on tinderbox.bug #381240 2007-05-19 18:24:48 -07:00
mozilla.mano@sent.com
d658713a0e Trying to break the cycle on nsNavHistoryQueryResultNode::mQueries. 2007-05-19 12:02:38 -07:00
dietrich@mozilla.com
6f1e93c626 disabling post-test cleanup temporarily, r=sayrer 2007-05-19 02:07:15 -07:00
dietrich@mozilla.com
ebb2e1142f Bug 381240 - disabling to allow further testing (r=sayrer) 2007-05-19 01:20:50 -07:00
dietrich@mozilla.com
96893e679f Bug 381240 backing out tests to figure out why failing on linux only (r=sayrer) 2007-05-19 00:18:44 -07:00
sspitzer@mozilla.org
2af310476a fix for bug #371827: places bookmarks need additional metadate for lastModified and dateAdded.fix for bug #381209: don't write out ID attributes to bookmarks.html, as it will confuse Firefox 2.patch by dietrich, sspitzer. r=mano,dietrich,sspitzer 2007-05-18 17:40:55 -07:00
thunder@mozilla.com
06fe86956c Bug 380997: Don't set the places bookmarks toolbar favicon. r=sspitzer 2007-05-18 01:45:36 -07:00
sspitzer@mozilla.org
3b7031ae75 fix for bug #380801: crash on startup when doing forced db migrationr=dietrich 2007-05-16 23:44:02 -07:00
thunder@mozilla.com
b0ef359d62 Bug 376253: Places bookmarks import/export unit tests + assorted fixes uncovered by the tests. r=mano, r=dietrich 2007-05-16 23:06:48 -07:00
dietrich@mozilla.com
c024882007 Bug 380011 bookmarks.html replacement trouble (r=sspitzer) 2007-05-16 21:29:27 -07:00
mozilla.mano@sent.com
3031ce0327 Bug 372508 part 2 - remove folderId getter. r=sspitzer. 2007-05-14 14:56:38 -07:00
mozilla.mano@sent.com
4c735f8832 Bug 376650 - Sort by keyword support. r=sspitzer. 2007-05-14 14:47:59 -07:00
mozilla.mano@sent.com
301af5c506 Bug 380505 - Simplify and optimize mDBGetChildren. r=sspitzer. 2007-05-14 14:42:57 -07:00
mozilla.mano@sent.com
0205fdf011 Bug 380437 - 'Set as bookmarks toolbar folder' doesn't stick after restart. r=sspitzer. 2007-05-11 17:00:25 -07:00
enndeakin@sympatico.ca
3042d48295 Bug 325342, implement places sort bookmark folder by name command, r=dietrich,mano 2007-05-11 12:06:57 -07:00
mozilla.mano@sent.com
72de7137c4 Bug 380317 - crash on shutdown in nsPlacesImportExportService::WriteContainerContents(), mLivemarkService is null. r=sspitzer. 2007-05-10 16:52:47 -07:00
mozilla.mano@sent.com
769a716f84 Bug 372508 - compact the bookmark APIs - part 1. r=sspitzer. 2007-05-10 11:18:34 -07:00
mozilla.mano@sent.com
f1ee4c669a Bug 379211 - Use item IDs for annotating bookmark/folder items rather than place: URIs. r=dietrich. 2007-05-10 01:05:19 -07:00
dietrich@mozilla.com
0069f830d2 follow-up to bug 379986 (r=sayrer) 2007-05-08 18:51:39 -07:00
dietrich@mozilla.com
484d7290e6 Bug 379986 make bookmark folders use ids from the moz_bookmarks table (r=mano) 2007-05-08 18:19:12 -07:00
sspitzer@mozilla.org
cfe81fc145 fix for bug #372051: problems when moving a livemark containerr=mano. Thanks to onemen.one@gmail.com for the patch. 2007-05-08 14:19:39 -07:00
dietrich@mozilla.com
1cd5754cc2 Bug 376008 bookmarks html import/export needs to move to /browser (r=mano) 2007-05-03 01:56:41 -07:00
dietrich@mozilla.com
3897a975ae Bug 379218 moz_annos table is created w/o the type column (r=mano) 2007-05-02 12:07:57 -07:00
dietrich@mozilla.com
62feabd61f Bug 378820 Crash in addVisit (r=mano) 2007-05-01 09:34:33 -07:00
mozilla.mano@sent.com
0b0726896f Bug 376630 - Test sorting functionality. r=dietrich. 2007-04-27 03:11:11 -07:00
mozilla.mano@sent.com
47eb048b72 Bug 378828 - Support sortingAnnotation in place: URIs. r=dietrich. 2007-04-27 03:04:13 -07:00
mozilla.mano@sent.com
425c75c6a1 Bug 378816 - Fall back to natural order if two bookmark nodes in a container share all their details. r=dietrich. 2007-04-27 03:00:46 -07:00
mozilla.mano@sent.com
90df784a6d Address review comment from bug 378808 2007-04-27 02:59:08 -07:00
mozilla.mano@sent.com
a89b1b0436 Bug 378808 - Initial sorting mode for a folder query is ignored. r=dietrich. 2007-04-27 02:56:15 -07:00
mozilla.mano@sent.com
e6692e3d56 Bug 378802 - Changing the details of a bookmark does not sort results in which it's listed. r=dietrich. 2007-04-27 02:53:01 -07:00
dietrich@mozilla.com
4216eb9e59 Bug 378659 Firefox UI frequently becomes broken; removing places.sqlite "fixes" it (r=mano) 2007-04-25 17:52:50 -07:00
mozilla.mano@sent.com
7737f46584 Bug 377500 - Result is broken if two bookmarks items have the same URL but with different titles. r=dietrich. 2007-04-25 14:03:29 -07:00
dietrich@mozilla.com
140a45bd1e Bug 378069 bookmark id import is broken (r=mano) 2007-04-23 14:37:37 -07:00
mozilla.mano@sent.com
b619efb2e1 Bug 376851 - API for sorting a result by an annotation. r=dietrich. 2007-04-22 15:20:25 -07:00
dietrich@mozilla.com
4e4384eab1 Bug 377066 GetAnnotationInfo always returns VALUE_TYPE_TEXT as the annotation type (r=mano) 2007-04-22 14:48:52 -07:00
dietrich@mozilla.com
9490bd48d1 Bug 349523 Generate bookmarks.html, default_places.html from properties (r=mano) 2007-04-15 14:15:56 -07:00
philringnalda@gmail.com
f384cf2d81 Bug 376906 - tabs bad, r=gavin 2007-04-12 21:17:12 -07:00
dietrich@mozilla.com
076b7d4a14 Bug 376863 bookmarkId is set to the node type for bookmark folders? (r=mano) 2007-04-11 12:52:44 -07:00
mozilla.mano@sent.com
ddd3a0c442 Test for Bug 376798. r=dietrich. 2007-04-10 03:59:05 -07:00
mozilla.mano@sent.com
399b713919 Bug 376954 - Document about when accessing childCount throws. patch from Johnathan Nightingale <johnath@mozilla.com>, r=me. 2007-04-09 17:42:13 -07:00
mozilla.mano@sent.com
5bb1430076 Bug 376798 - QueriesToQueryString prefixes the first parameter with an ampersand. r=dietrich. 2007-04-09 17:30:52 -07:00
mozilla.mano@sent.com
d014df4d47 Bug 376786 - Annotation-based queries are broken. r=dietrich. 2007-04-09 17:24:37 -07:00
enndeakin@sympatico.ca
6531a65657 Bug 376992, folders array not freed, r=dietrich 2007-04-09 17:04:03 -07:00
mozilla.mano@sent.com
44af177a14 Bug 376726 - View's itemChanged method isn't called when the title/uri of a bookmark item is changed. r=dietrich. 2007-04-06 10:24:42 -07:00
mozilla.mano@sent.com
ef8e7fc668 Bug 376633 - Sort By Title should not group by item type. r=dietrich. 2007-04-06 01:29:41 -07:00
dietrich@mozilla.com
18173d1eda Bug 372501 Items in moz_bookmarks should be explicitly typed (r=sspitzer) 2007-04-04 10:21:03 -07:00
dietrich@mozilla.com
8f85c8c63d Bug 376374 places bookmarks backups should be only for --enable-places-bookmarks builds (r=sspitzer) 2007-04-03 11:11:03 -07:00
dietrich@mozilla.com
8c1e93fef5 updating test for bug 371798 (r=sayrer) 2007-04-02 16:57:44 -07:00
dietrich@mozilla.com
131961dcb3 Bug 373239 add a schema version to places.sqlite (r=sspitzer) 2007-03-31 19:38:42 -07:00
dietrich@mozilla.com
03c1fa614d Bug 371812 add bookmark id support to bookmarks html import/export (r=sspitzer) 2007-03-31 16:34:23 -07:00
dietrich@mozilla.com
afd9371848 test for bug 371798 (r=sayrer) 2007-03-31 12:35:16 -07:00
mozilla.mano@sent.com
51ba92a2cc Bug 371076 (and bug 371077) - Query the bookmarks root rather than the places root in bookmarks-trees; allow exposing the root node of a query in the tree view (used in the organizer left pane, and in the add-bookmark dialog). This should also allow incremental updates in the bookmarks-sidebar. r=dietrich. 2007-03-27 17:28:34 -07:00
dbaron@dbaron.org
a7d9802f77 Remove GetKeyPointer method from nsTHashtable key types. b=374906 r=bsmedberg 2007-03-27 08:34:59 -07:00
dietrich@mozilla.com
1c1266a112 Bug 335961 bookmarks export doesn't export keywords (r=sspitzer) 2007-03-26 16:11:09 -07:00
dietrich@mozilla.com
2719851c0d Bug 374876 - write out bookmarks.html and archives (r=sspitzer) 2007-03-25 13:14:28 -07:00
mozilla.mano@sent.com
bd9d273059 Bug 373838 - Replace nsNavHistoryResultTreeViewer with a JS, browser-specific tree view. r=dietrich. 2007-03-25 05:28:29 -07:00
sspitzer@mozilla.org
f3ee8725dc testcase for bug #369887. r=dietrich 2007-03-23 01:06:01 -07:00
sayrer@gmail.com
64f9bcc4c8 fix test bustage. 2007-03-22 18:53:02 -07:00
dietrich@mozilla.com
7a5fefa6c5 Bug 374944 Places toolkit tests should move into /toolkit (r=sayrer) 2007-03-22 17:56:55 -07:00
sspitzer@mozilla.org
26d5160d60 fix for bug #369887: searches in bookmarks sidebar and organize bookmarks dialog don't show all the results: missing 'hidden' bookmarks and failing to match on title.r=dietrich 2007-03-22 16:05:37 -07:00
hg@mozilla.com
465265d0d4 Free the (distributed) Lizard! Automatic merge from CVS: Module mozilla: tag HG_REPO_INITIAL_IMPORT at 22 Mar 2007 10:30 PDT, 2007-03-22 10:30:00 -07:00