Commit Graph

105 Commits

Author SHA1 Message Date
Chris Kitching
18410626e8 Bug 1081582: Fix spelling. r=rnewman 2014-10-12 00:28:29 +01:00
Chris Kitching
a2d4c562ce Bug 1081606: Don't call toArray with zero-size arrays. r=rnewman
* * *
Bug 1081606: Don't call toArray with zero-size arrays. r=rnewman
2014-10-12 02:52:38 +01:00
Chris Kitching
24cc652153 Bug 1081597: Refactor some branches. r=rnewman
* * *
Bug 1081597: Refactor some branches. r=rnewman
2014-10-12 01:41:42 +01:00
Chris Kitching
9182d8a43f Bug 1081401: Remove unnecessary autoboxing (recalcitrant sync part). r=rnewman 2014-10-11 20:49:46 +01:00
Chris Kitching
e26a79c75c Bug 1081605: Don't bother creating arrays to pass to varags methods. r=rnewman 2014-10-12 02:40:31 +01:00
Chris Kitching
ef5903ad00 Bug 1081397: Finalise large numbers of fields. r=rnewman
* * *
Bug 1081397: Finalise large numbers of fields. r=rnewman
2014-10-11 00:17:01 +01:00
Chris Kitching
f66158ea72 Bug 1081287: Use EnumMap where possible. r=rnewman
* * *
Bug 1081287: Use EnumMap where possible in sync. r=rnewman
* * *
Bug 1081287: Use EnumMap where possible. r=rnewman
* * *
Bug 1081287: Use EnumMap where possible. r=rnewman
* * *
Bug 1081287: Use EnumMap where possible. r=rnewman
2014-10-10 21:01:01 +01:00
Chris Kitching
d8c813b17c Bug 1064620: Replace # with //# for IDE integration. r=nalexander 2014-10-11 15:22:55 +01:00
Ryan VanderMeulen
733a4ca774 Backed out changeset f6422f380251 (bug 1064620) for bustage. 2014-10-10 17:13:58 -04:00
Nick Alexander
0b4ba7bfcc Bug 1064620: Replace # with //# for IDE integration. r=nalexander 2014-10-10 21:11:56 +01:00
Richard Newman
b24aefaf8b Bug 1060536 - Move LocaleAware into Fennec to allow for easier reuse from Search. r=nalexander
--HG--
rename : mobile/android/base/sync/setup/activities/LocaleAware.java => mobile/android/base/LocaleAware.java
2014-08-29 16:14:54 -07:00
Nick Alexander
9848a8d413 Bug 984503 - Follow-up to fix build bustage. r=me 2014-08-29 15:19:12 -07:00
Vivek Balakrishnan
506f67b538 Bug 984503 - Add "Remove Firefox Account" menu option to FxAccount status activity. r=nalexander,rnewman
The menu is exposed as "More..." on devices that do not have a hardware
menu button.

========

8adeb1be57
Author: Nick Alexander <nalexander@mozilla.com>
    Bug 984503 - Part 4: Show a toast after removing Firefox Account.

========

aeffca77dc
Author: Nick Alexander <nalexander@mozilla.com>
    Bug 984503 - Part 3: Hide "More..." option if device has a hardware menu button.

    The reason for this dance is to keep the "Remove Account" button out of
    view if at all possible.  I don't want to make it too easy to delete
    your account.

========

4efe597308
Author: Nick Alexander <nalexander@mozilla.com>
Date:   Thu Aug 28 15:04:38 2014 -0700

    Bug 984503 - Part 2: Add "More..." to Firefox Account status list.

========

ad6a55dc33
Author: vivek <vivekb.balakrishnan@gmail.com>
Date:   Thu Aug 21 00:25:30 2014 +0300

    Bug 984503 - Part 1: Add menu option to remove Firefox Account.
2014-08-28 15:05:11 -07:00
Wes Kocher
b5be1efda0 Backed out 2 changesets (bug 984503) for android build bustage
Backed out changeset 579667582c6a (bug 984503)
Backed out changeset 56c4334e838f (bug 984503)
2014-08-29 12:30:33 -07:00
Vivek Balakrishnan
6694cea5ba Bug 984503 - Add "Remove Firefox Account" menu option to FxAccount status activity. r=nalexander,rnewman
The menu is exposed as "More..." on devices that do not have a hardware
menu button.

========

8adeb1be57
Author: Nick Alexander <nalexander@mozilla.com>
    Bug 984503 - Part 4: Show a toast after removing Firefox Account.

========

aeffca77dc
Author: Nick Alexander <nalexander@mozilla.com>
Date:   Thu Aug 28 15:05:11 2014 -0700

    Bug 984503 - Part 3: Hide "More..." option if device has a hardware menu button.

    The reason for this dance is to keep the "Remove Account" button out of
    view if at all possible.  I don't want to make it too easy to delete
    your account.

========

4efe597308
Author: Nick Alexander <nalexander@mozilla.com>
Date:   Thu Aug 28 15:04:38 2014 -0700

    Bug 984503 - Part 2: Add "More..." to Firefox Account status list.

========

ad6a55dc33
Author: vivek <vivekb.balakrishnan@gmail.com>
Date:   Thu Aug 21 00:25:30 2014 +0300

    Bug 984503 - Part 1: Add menu option to remove Firefox Account.

--HG--
extra : rebase_source : 946b86baaa36de4b143d6d8a614f7cc3a2118a6a
2014-08-28 15:14:55 -07:00
Nick Alexander
df6f6ffb85 Bug 1026005 - Create Loader for querying/updating Accounts status. r=mcomella
========

3cd96669bc
Author: Nick Alexander <nalexander@mozilla.com>
Date:   Mon Aug 18 17:43:24 2014 -0700

    Bug 1026005 - Review comments.

========

5aefe1f716
Author: Nick Alexander <nalexander@mozilla.com>
Date:   Mon Jun 16 11:16:16 2014 -0700

    Bug 1026005 - Part 2: Add AccountLoader.

========

61bc36bd7d
Author: Nick Alexander <nalexander@mozilla.com>
Date:   Mon Jun 16 11:12:37 2014 -0700

    Bug 1026005 - Part 1: Add and broadcast ACCOUNT_STATE_CHANGED_ACTION.

========

9d80df0aa7
Author: Nick Alexander <nalexander@mozilla.com>
Date:   Mon Aug 18 17:42:11 2014 -0700

    Bug 1026005 - Pre: Allow testing with |mvn integration-test|.

    This avoids errors like:

    W dalvikvm(24082)             Class resolved by unexpected DEX: Lorg/mozilla/gecko/fxa/AccountLoader;(0x42c13358):0x75440000 ref [Landroid/support/v4/content/AsyncTaskLoader;] Landroid/support/v4/content/AsyncTaskLoader;(0x42c13358):0x74a71000
    W dalvikvm(24082)             (Lorg/mozilla/gecko/fxa/AccountLoader; had used a different Landroid/support/v4/content/AsyncTaskLoader; during pre-verification)
    W dalvikvm(24082)             Unable to resolve superclass of Lorg/mozilla/gecko/fxa/AccountLoader; (247)
    W dalvikvm(24082)             Link of class 'Lorg/mozilla/gecko/fxa/AccountLoader;' failed
    E dalvikvm(24082)             Could not find class 'org.mozilla.gecko.fxa.AccountLoader', referenced from method org.mozilla.gecko.background.fxa.TestAccountLoader.testInitialLoad
    W dalvikvm(24082)             VFY: unable to resolve new-instance 1299 (Lorg/mozilla/gecko/fxa/AccountLoader;) in Lorg/mozilla/gecko/background/fxa/TestAccountLoader;
    D dalvikvm(24082)             VFY: replacing opcode 0x22 at 0x0005
    W dalvikvm(24082)             Class resolved by unexpected DEX: Lorg/mozilla/gecko/fxa/AccountLoader;(0x42c13358):0x75440000 ref [Landroid/support/v4/content/AsyncTaskLoader;] Landroid/support/v4/content/AsyncTaskLoader;(0x42c13358):0x74a71000
    W dalvikvm(24082)             (Lorg/mozilla/gecko/fxa/AccountLoader; had used a different Landroid/support/v4/content/AsyncTaskLoader; during pre-verification)
    W dalvikvm(24082)             Unable to resolve superclass of Lorg/mozilla/gecko/fxa/AccountLoader; (247)
    W dalvikvm(24082)             Link of class 'Lorg/mozilla/gecko/fxa/AccountLoader;' failed
    D dalvikvm(24082)             DexOpt: unable to opt direct call 0x1df8 at 0x07 in Lorg/mozilla/gecko/background/fxa/TestAccountLoader;.testInitialLoad
    I TestRunner(24082)           started: testInitialLoad(org.mozilla.gecko.background.fxa.TestAccountLoader)
    I TestRunner(24082)           failed: testInitialLoad(org.mozilla.gecko.background.fxa.TestAccountLoader)
    I TestRunner(24082)           ----- begin exception -----
    I TestRunner(24082)
    I TestRunner(24082)           java.lang.NoClassDefFoundError: org.mozilla.gecko.fxa.AccountLoader
    I TestRunner(24082)           	at org.mozilla.gecko.background.fxa.TestAccountLoader.testInitialLoad(TestAccountLoader.java:145)
    I TestRunner(24082)           	at java.lang.reflect.Method.invokeNative(Native Method)
    I TestRunner(24082)           	at java.lang.reflect.Method.invoke(Method.java:525)
    I TestRunner(24082)           	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
    I TestRunner(24082)           	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
    I TestRunner(24082)           	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
    I TestRunner(24082)           	at junit.framework.TestCase.runBare(TestCase.java:134)
    I TestRunner(24082)           	at junit.framework.TestResult$1.protect(TestResult.java:115)
    I TestRunner(24082)           	at junit.framework.TestResult.runProtected(TestResult.java:133)
    I TestRunner(24082)           	at junit.framework.TestResult.run(TestResult.java:118)
    I TestRunner(24082)           	at junit.framework.TestCase.run(TestCase.java:124)
    I TestRunner(24082)           	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
    I TestRunner(24082)           	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
    I TestRunner(24082)           	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
    I TestRunner(24082)           	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1738)
    I TestRunner(24082)           ----- end exception -----
    I TestRunner(24082)           finished: testInitialLoad(org.mozilla.gecko.background.fxa.TestAccountLoader)
2014-08-22 11:15:38 -07:00
Nick Alexander
8e348d97bb Bug 1056227 - Don't always go back to status after updating Firefox Account credentials. r=mcomella
========

1c4a5d5c13
Author: Nick Alexander <nalexander@mozilla.com>
Date:   Wed Aug 20 10:53:40 2014 -0700

    Bug 1056227 - Don't always go back to status after updating Firefox Account credentials.

    This was a simple oversight.  With embedded links to update your
    credentials in Fennec's Remote Tabs interfaces, just returning to where
    you came from is the right thing to do.
2014-08-22 11:15:31 -07:00
Nick Alexander
6e42778210 Bug 1046020 - Follow-up: Revert added initializers. r=trivial 2014-08-18 21:23:20 -07:00
Ben Curtis
86ca102fd8 Bug 1046020 - Include URI port in token server audiences. r=nalexander
========

5b97feec90
Author: Ben Curtis <androiddev@nosolutions.com>
    Bug 1046020 - Include URI port in token server audiences.

--HG--
extra : amend_source : 706eaa493e969ce27470aafd482f6b61f5f88db8
2014-08-13 16:47:23 -07:00
Nick Alexander
61da33795f Bug 830270 - Follow-up: Land other piece. r=trivial
This landed with only some of the changes from the android-sync
repository present.
2014-08-14 11:25:46 -07:00
Chris Kitching
9f496ef232 Bug 1041836: Delete redundant initialisers. (generated) r=rnewman 2014-07-25 20:14:47 -07:00
Bryan Kok
9a71300c19 Bug 1019719 - Localize the Sync client name. r=nalexander 2014-07-21 11:13:24 -07:00
Richard Newman
badc72a920 Bug 1036459. r=nalexander 2014-07-09 13:41:58 -07:00
Richard Newman
2fca312a2b Bug 1030740 - Add return statements inadvertently omitted from Bug 1025937. r=mcomella 2014-06-26 09:48:48 -07:00
Nick Alexander
3060f6e1c8 Bug 1022749 - Show custom server URLs in setup activities. r=rnewman
========

cf613656fe
Author: Nick Alexander <nalexander@mozilla.com>
    Bug 1022749 - Part 2: Show custom server URLs in status activity.

========

91268a261f
Author: Nick Alexander <nalexander@mozilla.com>
    Bug 1022749 - Part 1: Show custom server URLs in setup activities.
2014-06-09 17:31:58 -07:00
Nick Alexander
535ad13f99 Bug 1022748 - Part 2: Use custom server URLs in setup activities. r=rnewman
========

2582a39b7f
Author: Nick Alexander <nalexander@mozilla.com>
    Bug 1022748 - Review comments.

========

8c9a8df84f
Author: Nick Alexander <nalexander@mozilla.com>
    Bug 1022748 - Part 4: Don't show Get Started activity when custom server URLs are passed.

    The Get Started activity provides no feedback about custom URLs, and it
    just gets in the way of power users, so skip it entirely.

========

2701a9ea52
Author: Nick Alexander <nalexander@mozilla.com>
Date:   Mon Jun 9 17:25:51 2014 -0700

    Bug 1022748 - Part 3: Pass through server details to update credentials activity.

    This information can be extracted from the AndroidFxAccount object in
    the activity, but feeding the information through extras keeps the
    processing and display pipeline uniform across all setup activities.

========

b9dd884764
Author: Nick Alexander <nalexander@mozilla.com>
Date:   Mon Jun 9 17:17:57 2014 -0700

    Bug 1022748 - Part 2: Use custom server URLs passed through extras in setup activities.

========

be8284ea25
Author: Nick Alexander <nalexander@mozilla.com>
Date:   Mon Jun 9 15:06:03 2014 -0700

    Bug 1022748 - Part 1: Pass extras through setup activities.

    This also passes the password button's show/hide state between create
    and set up.
2014-06-21 16:21:41 -07:00
Nick Alexander
b5a3a2be4a Bug 993134 - Make TestAccountPickler tolerate multiple accounts. r=mcomella
========

872d926e32
Author: Nick Alexander <nalexander@mozilla.com>
Date:   Wed Jun 4 14:21:17 2014 -0700

    Bug 993134 - Part 5: Work around Android intermittent issue.

========

c76bb53901
Author: Nick Alexander <nalexander@mozilla.com>
Date:   Tue Jun 3 17:02:15 2014 -0700

    Bug 993134 - Part 4: Make fxa.TestAccountPickler robust.

    This tested extracting data from an AndroidFxAccount before, and another
    after, backed by different Android Accounts.  Unfortunately, one Account
    replaced the other, but had the same name, leading to a race
    condition (between reading and deleting the first account).  To address
    this, we extract all the data before deleting, and then compare it to
    the data from the newly pickled account.

========

bd32978f7b
Author: Nick Alexander <nalexander@mozilla.com>
Date:   Tue Jun 3 15:34:09 2014 -0700

    Bug 993134 - Part 3: Use AndroidSyncTestCaseWithAccounts to make fxa.TestAccountPickler when accounts exist.

========

ec7d910187
Author: Nick Alexander <nalexander@mozilla.com>
Date:   Tue Jun 3 15:33:29 2014 -0700

    Bug 993134 - Part 2: Extract AndroidSyncTestCaseWithAccounts.

========

6563ad7bd8
Author: Nick Alexander <nalexander@mozilla.com>
Date:   Tue Jun 3 15:30:15 2014 -0700

    Bug 993134 - Part 1: Make getApplicationContext return getTargetContext.

    I was finding that repeated instrumentation-test runs were returning a
    null application context, indicating a race between test start-up and
    target instantiation.  This works well for me on two test devices.
2014-06-21 15:42:38 -07:00
Richard Newman
97f8a936d0 Bug 1025937 - Silently drop null intents in background IntentServices. r=mcomella 2014-06-16 16:18:59 -07:00
Nick Alexander
ecd6ed4a2e Bug 788688 - Allow setting client's device name in FxAccountStatusActivity. r=rnewman
========

8c7b253142
Author: Nick Alexander <nalexander@mozilla.com>
Date:   Tue Jun 3 15:48:40 2014 -0700

    Bug 788688 - Review comment: Include timestamp in setClientName.

========

b53b9092c2
Author: Nick Alexander <nalexander@mozilla.com>
Date:   Thu May 29 16:05:25 2014 -0700

    Bug 788688 - Post: PII client data to ease debugging.

========

fd59f3c984
Author: Nick Alexander <nalexander@mozilla.com>
Date:   Wed Jun 4 15:01:12 2014 -0700

    Bug 788688 - Part 4: Work around Android DialogPreference caching bug.

========

87d10bc16a
Author: Nick Alexander <nalexander@mozilla.com>
Date:   Thu May 29 14:44:24 2014 -0700

    Bug 788688 - Part 3: Add "Device name" pref to Status activity.

    In the edge case where what the user has entered (empty text) and what
    is persisted (default client name) differ, Android does not update the
    contents of the dialog's EditText correctly.  Removing and re-creating
    all preferences is the only way I found to work around this; that's in
    the next commit.

========

7af72f6c2f
Author: Nick Alexander <nalexander@mozilla.com>
Date:   Thu May 29 16:05:59 2014 -0700

    Bug 788688 - Part 2: Upload clients and tabs records when client name changes.

========

0e99eae1b5
Author: Nick Alexander <nalexander@mozilla.com>
Date:   Thu May 29 15:28:36 2014 -0700

    Bug 788688 - Part 1: Add setClientName with timestamp to ClientsDataDelegate.

========

1999e263db
Author: Nick Alexander <nalexander@mozilla.com>
Date:   Thu May 29 14:10:40 2014 -0700

    Bug 788688 - Pre: Clean some imports.
2014-06-04 16:37:25 -07:00
Michael Comella
9ee2ca1def Bug 958889 - Part 2.7: Provide public read-only access to FXAccount state and resend verification code. r=nalexander 2014-05-22 18:38:02 -07:00
Michael Comella
80c80d5987 Bug 958889 - Part 2.5: Add old Sync upgrade URL method to services and strings. r=nalexander 2014-05-14 08:56:23 -07:00
Nick Alexander
3262b2c402 Bug 850600 - Refactor FirefoxAccounts. r=rnewman
========

9acbc565be
Author: Nick Alexander <nalexander@mozilla.com>
Date:   Fri Apr 18 11:30:26 2014 -0700

    Bug 850600 - Part 0: Refactor FirefoxAccounts.
2014-04-18 11:32:32 -07:00
Nick Alexander
a2cdec41a9 Bug 986664 - Make Android FxAccountClient* HAWK requests always include request payload hash. r=rnewman
Relanding with correct bug number.
2014-04-17 12:04:17 -07:00
Nick Alexander
c142ddf606 Backed out changeset c0e6f3b758b4 (bug 985766) for landing with wrong bug number. 2014-04-17 12:02:43 -07:00
Nick Alexander
ffd32d2897 Bug 996843 - Autocomplete email addresses in Android Firefox Accounts sign-up/sign-in. r=rnewman
========

c41a37fad3
Author: Nick Alexander <nalexander@mozilla.com>
    Bug 996843 - Part 2: Populate email autocomplete list in onResume.

========

418b103991
Author: Nick Alexander <nalexander@mozilla.com>
Date:   Tue Apr 15 15:15:41 2014 -0700

    Bug 996843 - Part 1: Make email an AutoCompleteTextView.
2014-04-15 15:16:15 -07:00
Nick Alexander
054440e00f Bug 996749 - Kill PrefsSource. r=rnewman
========

6ced7b05cd
Author: Nick Alexander <nalexander@mozilla.com>
    Bug 996749 - Part 3: Finally kill PrefsSource.

========

b37547fbd8
Author: Nick Alexander <nalexander@mozilla.com>
Date:   Tue Apr 15 10:47:11 2014 -0700

    Bug 996749 - Part 2: Remove storageEndpoint from FxAccountGlobalSession constructor.

    This is just a separation of concerns: let's inject our dependency as
    configured as possible.

========

42e8fe761f
Author: Nick Alexander <nalexander@mozilla.com>
Date:   Mon Apr 14 12:30:21 2014 -0700

    Bug 996749 - Part 1: Remove debugAssertion.

    This is no longer valuable, since we're not getting timestamp HAWK
    errors from the server.
2014-04-15 10:59:00 -07:00
Nick Alexander
043cabc42e Bug 985766 - Always include payload verification hashes in FxAccountClient* requests. r=rnewman
========

130f1a5d52
Author: Nick Alexander <nalexander@mozilla.com>
    Bug 985766 - Part 4: Explain why we do not include payload verification hashes in Sync storage endpoint requests.

========

5cb1211b48
Author: Nick Alexander <nalexander@mozilla.com>
Date:   Tue Apr 8 11:19:03 2014 -0700

    Bug 985766 - Part 3: Always include payload verification hashes in FxAccountClient* requests.

========

616193c436
Author: Nick Alexander <nalexander@mozilla.com>
Date:   Tue Apr 8 11:18:10 2014 -0700

    Bug 985766 - Part 2: Don't include payload verification to non-enclosing HAWK requests.

========

c0c032db09
Author: Nick Alexander <nalexander@mozilla.com>
Date:   Thu Apr 3 11:05:30 2014 -0700

    Bug 985766 - Part 1: Remove little-used HawkAuthHeaderProvider constructor.
2014-04-08 11:19:37 -07:00
Richard Newman
4bffb6f53a Bug 970176 - Part 2: invoke LocaleManager locale switching code prior to handling strings or Locale in background services. r=nalexander 2014-04-15 15:07:15 -07:00
Nick Alexander
ac8e18946d Bug 967333 - Request sync when entering and leaving ConfirmAccountActivity. r=rnewman 2014-04-10 11:39:37 -07:00
Nick Alexander
cb7da9e953 Bug 981827 - Make Android and Desktop FxAccounts client use same key parameters. r=rnewman 2014-04-09 16:57:16 -07:00
Nick Alexander
44908bfc3b Bug 966104 - Add Sync status listener to Android FxA activities. r=rnewman 2014-04-04 16:24:00 -07:00
Nick Alexander
9622fd22b3 Bug 988437 - Part 1: Allow unpickling across Android Account types; bump pickle version. r=rnewman 2014-04-01 21:32:54 -07:00
Nick Alexander
3dd622b457 Bug 990680 - Remove extras from GlobalSession constructor. r=rnewman 2014-04-01 15:31:28 -07:00
Nick Alexander
cdb92600e1 Bug 983350 - Follow-up: Rev User-Agent string. r=rnewman 2014-04-01 15:01:58 -07:00
Nick Alexander
9fabb1441b Bug 988571 - Migrate Android Firefox Accounts from Doghouse to Separated state on application upgrade. r=rnewman 2014-03-28 00:32:59 -07:00
Nick Alexander
0406d36fad Bug 989105 - Redirect Send Tab to Status activity when the Firefox Account definitely cannot send a tab. r=rnewman
--HG--
extra : rebase_source : fa924a2d14147041604c67758270c85603a43acb
2014-03-27 17:15:55 -07:00
Nick Alexander
ff2d767beb Bug 983856 - Message when syncing is disabled by Android. r=rnewman 2014-03-26 22:11:05 -07:00
Ashwin Swaroop
6596fb9c77 Bug 983860 - Fixed a copy-paste error and replaced log message in AndroidFxAccount.enableSyncing() to say "Enabling" instead of "Disabling"; r=nalexander 2014-03-26 22:00:58 -07:00
Michael Comella
8e2648d558 Bug 957894: Update account pickling code for Firefox Accounts. r=nalexander 2014-03-26 11:31:43 -07:00
Richard Newman
e4245f9061 Bug 986096 - On access to Sync through settings after setup, user should be sent to config screen not 'back to browsing'. r=nalexander 2014-03-20 19:14:44 -07:00