Commit Graph

1748 Commits

Author SHA1 Message Date
Edward Lee
61295bf349 Bug 522084 - Automatically sync much sooner if there's more data to fetch from the server
Have the syncInterval getter return with a lower interval for non-mobile clients while still enforcing backoff if it's bigger than the sync interval.
2009-10-13 11:56:46 -07:00
Edward Lee
bd2a51d362 Bug 522077 - Download a certain total number of items each sync instead of fixed "catch up"
Limit the initial the first fetch of new items by a total number of fetch and subtract the number of items processed. Use the difference to keep fetching more items from the backlog in chunks.
2009-10-13 11:20:28 -07:00
Edward Lee
8ce9ab3899 Split multiple id deletes into 100-id chunks instead of hitting max apache URI length. 2009-10-12 18:11:31 -07:00
Edward Lee
6f198b2a1f Bug 482906 - Gracefully handle wiping weave passwords if syncing doesn't restore them
After potentially wiping out all local passwords, save the Weave passwords to disk.
2009-10-12 16:45:40 -07:00
Edward Lee
13cddbf9bc Bug 520215 - Only wipe if data is able to be restored from the server
For each engine, try decrypting a record from the server before wiping local data.
2009-10-12 16:22:54 -07:00
Edward Lee
a994e4258f Simplify logic for Engines.getAll/Enabled and use Enabled for main sync loop. 2009-10-08 13:51:22 -07:00
Edward Lee
7d40472caa Land external changes to Sync.js: setTimeout timer reference, checkAppReady comments/calls. 2009-10-08 11:45:51 -07:00
Edward Lee
3e50bcc32f Bug 517492 - Sync will not complete, causing firefox not to quit successfully
Lazily listen for quit-application on the first sync-async call and bail out if the notification is sent while waiting for the callback.
2009-10-07 18:15:38 -07:00
Edward Lee
92b88d22c8 Bug 519147 - "Sign In" is greyed out in Weave menu when Firefox starts, in Weave 0.7pre4
Switch back to STATUS_OK (from STATUS_DELAYED) when the delayed startup is actually called.
2009-10-07 10:47:55 -07:00
Edward Lee
4c119524e4 Move the status record into a separate Status object exported with the Weave object. 2009-10-07 10:47:43 -07:00
Edward Lee
b41a7fd607 Remove eval() workaround now that jit.chrome doesn't crash on latest 1.9.2 fennec (bug 517247). 2009-10-02 13:46:38 -07:00
Edward Lee
4af9c4ceef Don't try logging out when already logged out -- about:weave calls logout which tries to _log, but Fennec weave hasn't loaded Weave yet. 2009-09-30 15:16:56 -07:00
Edward Lee
545f5e72b9 Bug 518226 - Service should bubble up partial sync information
Set a flag on the status object to indicate partial sync after syncing an engine. For now, just show some text under the sync arrows to let the user know nothing needs to be done.
2009-09-30 14:46:59 -07:00
Mike Connor
a783c62509 fix merge fail 2009-09-29 18:40:18 -07:00
Mike Connor
8a69ade4d1 bug 518273 - need to handle not having an active node assigned, r=edilee
--HG--
extra : rebase_source : f86c6cc164241cee263345de5e13dd5ae0a3758b
2009-09-29 18:33:41 -07:00
Edward Lee
52565baca2 Remove unused threshold code that will be replaced soon with bug 518075. 2009-09-29 13:02:08 -07:00
Edward Lee
f519abe53b Don't wrap changePassword with _catch and persist the password on success. 2009-09-28 16:28:38 -07:00
Edward Lee
14764a5484 Don't unnecessarily throw from verifyLogin and remove its _catch wrapper.
--HG--
extra : rebase_source : ca74b47b96f4d1fbc1b8454d5b505a57b558e729
2009-09-28 16:13:42 -07:00
Mike Connor
bdec449e3f bug 515593 - remove a bunch of stuff we shouldn't sync, will revisit potential additions for 0.8 2009-09-28 15:54:45 -07:00
Edward Lee
c3a8636447 Bug 519262 - Forgot password doesn't work -> throbber keeps spinning
Just get the pref without slashifying with getURLPref.
2009-09-28 13:34:56 -07:00
Edward Lee
16a246fc75 Call eval() in Sync-async loop to work around crashes on 1.9.2 Fennec. 2009-09-25 20:53:46 -07:00
Edward Lee
622aae4ece Default to mobile sync interval (5 min) for account creation and upgrade. 2009-09-25 20:47:38 -07:00
Edward Lee
32f373dcc0 Don't unconditionally forceGC on processIncoming especially when there's nothing to process. 2009-09-25 18:39:24 -07:00
Edward Lee
a69c3b332a Sort the sync timing report to show certain functions first. 2009-09-25 18:38:47 -07:00
Edward Lee
6be9a2d6a5 Add some account creation error handling, but it's still pretty clunky with username detection and alerts for other stuff. 2009-09-25 18:19:30 -07:00
Edward Lee
ff074548e7 Use the default or backoff intervals only after checking a previously scheduled sync and pick the bigger of the two. 2009-09-25 17:32:35 -07:00
Edward Lee
81fce3dc55 Run sync on idle on a separate event so that login can return and release the lock before trying to sync. 2009-09-25 17:28:48 -07:00
Edward Lee
4f389c5c8a Bug 518972 - Only upload history records that have more than one visit
Allow each engine to provide a custom Collection object and have History provide a collection that filters out certain data. This is inefficient because we have to first create then encrypt the record before we can filter it out.
2009-09-25 16:52:12 -07:00
Edward Lee
51a7e2fb0b Bug 518958 - Only sync tabs if there has been tab activity
Check the score, which gets bumped up on tab open/close/select, to decide if tabs should be marked as changed.
2009-09-25 16:14:26 -07:00
Edward Lee
af91626ec4 Persist sync intervals because we only update it when changing the number of clients. 2009-09-25 15:41:27 -07:00
Edward Lee
f042fdc078 Bug 514601 - Don't send DELETE for old history/form data on every sync
Don't send any deletes as the server will do the delete with bug 518945.
2009-09-25 15:30:26 -07:00
Edward Lee
4abc9f56ba Bug 517597 - waste fewer resources while a user only has one client active
Adjust how often Weave syncs based on the number of clients and only sync tabs if there are multiple clients.
2009-09-25 15:05:09 -07:00
Edward Lee
87014d7af0 Bug 518864 - Persist "next sync time" across events that disable sync
Save a nextSync value in a pref and use it to trigger a sync-on-idle if the "next sync time" already passed when logging in. Make sure to default to backoff time first, then next sync, then use the default.
2009-09-25 11:46:29 -07:00
Edward Lee
f0d86921f5 Wire up "custom" inputs to set/read and show/hide server url box. 2009-09-25 09:11:19 -07:00
Edward Lee
9f5510bc30 Bug 512809 - signup form uses colors for input validation feedback. r=Mardak
Add initial error reporting and "available" tagging. Also add "start over" functionality and change some custom settings display.
2009-09-25 09:09:05 -07:00
Edward Lee
e3741b6774 Bug 513944 - Weave should not load / do anything until it absolutely needs to
Weave already triggers on a late notification and puts itself on the event loop, so just additionally delay startup based on the number of open tabs (which will all be busy at startup).
2009-09-25 08:13:12 -07:00
Mike Connor
426cb34a4f Land some initial statusbar UI bits of bug 513944 and remove unused/debug code. 2009-09-24 23:16:27 -07:00
Edward Lee
7518b09ad6 Add a simpler-to-use nsITimer wrapper, Utils.delay, that can use a named property of an object to additionally delay or clear the timer. Get rid of Utils.EventListener and simplify/fix up users. 2009-09-24 22:51:38 -07:00
Edward Lee
2ca32ed22d Correctly cancel any sync triggers after starting a sync with a shared function that removes timers and idle observers. 2009-09-24 19:04:06 -07:00
Edward Lee
51761d2ab6 Bug 518146 - Generate shorter GUIDs than nsIUUIDGenerator
Randomly generate 10 characters from a pool of 70 possible characters for an equivalent 61.29-bit GUID which should have around 1% chance of collision (within a collection) after ~100 million records.
2009-09-24 15:54:47 -07:00
Edward Lee
0f5ee84542 Bug 506268 - Session restore fails halfway through, leaves tabs unloaded
Load Weave off of the event that triggered sessionstore so that it and its callers can finish loading before autoconnect does network activity.
2009-09-24 14:31:05 -07:00
Edward Lee
2fbfee64a6 Bug 518077 - Add custom settings for "sign in" to set things like server url
Provide an initial implementation to read and set preferences: autoconnect, serverURL. For now show them in a "Custom settings" expando tab like the one for create account, but the styling isn't great.

--HG--
extra : rebase_source : 3fc1e8bad7786cf06e2da8c95e7bca5f50fb6ec3
2009-09-22 01:00:43 -07:00
Dan Mills
2c3554a154 Bug 518069: forgot password UI / bug 518067: directional sync dialog during setup 2009-09-21 23:52:00 -07:00
Edward Lee
6ffc23f7f0 Don't update the cluster on each login unless verify login failed or there was no cluster set. 2009-09-21 18:03:56 -07:00
Edward Lee
0e855e54d8 Bug 518022 - Logging in with invalid username results in "Couldn't sign in: Network error"
Report 404 info/collections responses as "login rejected" if we're on the right cluster.
2009-09-21 17:34:19 -07:00
Edward Lee
eba12cbe8d Bug 518018 - Default to serverURL instead of userAPI on 404 cluster check
Rework server/user/misc prefs to allow relative paths and full urls for generating API paths. Cache string properties of generated URLs under the storageAPI instead of using dynamic getters.
2009-09-21 17:13:41 -07:00
Dan Mills
2cc002ba27 implement forgot password/passphrase dialogs 2009-09-20 19:26:01 -07:00
Edward Lee
9b503e9895 Keep track of previously opened windows of pages that should only have one instance open and close the old one if it's still open. 2009-09-18 00:15:37 -07:00
Edward Lee
666d0373fe Land about-weave on weave. Bug 516350 - about:weave round 3 followup fixes. r=thunder 2009-09-17 14:51:00 -07:00
Edward Lee
0611761d74 Use trace logging for reporting GUIDs. 2009-09-17 14:41:24 -07:00
Edward Lee
8db1de49fa Merge weave to about-weave. 2009-09-16 19:16:48 -07:00
Edward Lee
b48bdeef35 Remove meta serialization now that resource takes objects. 2009-09-16 19:15:55 -07:00
Edward Lee
fe86dd9174 Remove trailing period for passphrase error code. 2009-09-16 19:15:46 -07:00
Edward Lee
5b99d57ab4 Use the lazyStrings object for error strings to avoid using the wrong file (locales vs locale). 2009-09-16 16:52:43 -07:00
Edward Lee
882a10af2c Resolve conflicts by taking the already-fixed about.js and locally-fixed constants.js.in. 2009-09-16 13:56:37 -07:00
Edward Lee
4b97bca2eb Merge mconnor's about-weave branch to weave-about-weave with conflicts. 2009-09-16 13:53:15 -07:00
Edward Lee
584475732e Resolve constants.js.in conflicts by switching to the new format. 2009-09-16 13:45:08 -07:00
Edward Lee
7a23b07d84 Merge weave to weave-about-weave with conflicts. 2009-09-16 13:39:51 -07:00
Dan Mills
08c0f91578 Bug 516350 - about:weave round 3 initial landing 2009-09-16 13:36:11 -07:00
Edward Lee
748bd77b8f Get rid of the ugly EXPORTED_SYMBOLS array of strings for constants and generate it from a constants hash that sets the value and provides the exported name. Remove some unused constants and line-up the values at 40th column. 2009-09-15 19:07:23 -07:00
Mike Connor
30f7aa6e96 fix minor merge kvetch 2009-09-15 21:57:06 -04:00
Dan Mills
5094a04f3d initial patch
--HG--
extra : rebase_source : 250c8f0d85483300147a6f0d691e0214db6d837b
2009-09-15 21:54:05 -04:00
Mike Connor
4faaba2018 bug 511549 - make detailedStatus much smarter about errors and backoff, r=edilee
--HG--
extra : rebase_source : 42e3eb9c89d2567d18c02e7583202e284dd69b0e
2009-09-15 21:38:52 -04:00
Mike Connor
d5124cde40 missing file fail from bug 512393 2009-09-15 17:18:00 -04:00
Edward Lee
e0cdb15290 Bug 516096 - Nothing loads; about:weave has empty boxes/buttons; can't log in or sync
Work around bug 514803 by not calling toLocaleString() and generate a date string manually.
2009-09-11 17:14:45 -07:00
Edward Lee
7efe9c1d76 Merge weave-partial-view to weave. Bug 507429 - Partial sync download support. r=thunder 2009-09-11 16:48:58 -07:00
Edward Lee
7556f0c2cd Address review comments nits. r=thunder 2009-09-11 16:44:26 -07:00
Edward Lee
d932000cff Chop off the end of long URIs for debug output onStartRequest. 2009-09-11 14:52:27 -07:00
Edward Lee
7f9b6c7f87 Be less chatty when showing GUIDs and ignore cases. 2009-09-11 14:39:48 -07:00
Edward Lee
91e977a052 Fix exception name. 2009-09-11 13:10:19 -07:00
Edward Lee
e856402be7 Add some comments to partial download code and remove other comments. 2009-09-11 08:24:42 -07:00
Edward Lee
9380981a9e Merge weave to weave-partial-view. 2009-09-10 23:18:33 -07:00
Edward Lee
fb1bc5da49 Bug 507429 - Partial sync download support
Only fetch a limited number of items on first/update syncs and if we get the same number, ask the server for the ids to fetch later. Also on every download, process some of the backlog and save the list of GUIDs to disk as json for cross-session support.
2009-09-10 23:11:33 -07:00
Edward Lee
8b8447ab6e Remove some unnecessary logs that follow right after the notify/event now that we only show verbose. Only log non-success response body for Trace. 2009-09-10 22:57:36 -07:00
Edward Lee
dadc08925c Use a short-circuiting check to determine if a history visit already exists. 2009-09-10 21:27:47 -07:00
Edward Lee
dc6d0cb84b Don't create a GUID when looking for dupes and set the GUID when adding a url. 2009-09-10 20:04:34 -07:00
Edward Lee
5944a1f90a Add limit as a param to Collection. Make requesting guids the default. 2009-09-10 14:18:31 -07:00
Edward Lee
b59b775794 Merge weave to weave-partial-view. 2009-09-10 12:42:29 -07:00
Edward Lee
8f5372e6b1 Update lastSync to the lastModified time from info/collections instead of updating times on each record. This is to prepare for fetching a list of GUIDs and processing a list of GUIDs. 2009-09-10 12:41:38 -07:00
Edward Lee
b0c3b9005e Bug 515676 - Allow giving objects to PUT/POST without Filters to avoid stringify([parse(stringify(stringify(obj)))])
Get rid of Filters and automatically JSON.stringify PUT/POST data that aren't strings, so plain Records can be passed in to PUT and POST. This leverages toJSON of Records to provide an object that can be serialized. Fix up client record serialize/deserialize to still escape/unescape non-ASCII.
2009-09-10 11:05:13 -07:00
Edward Lee
e8d9f12442 Bug 515678 - Provide a smart getter to get the object representation of a JSON Resource response
Always allow getting an object representation of potentially JSON response for any Resource instead of explicitly on filterDownload. Update existing Resource GETs that manually parse the response. This prevents the String response from accidentally toString()ing a filteredDownload that converted to a different type.
2009-09-10 11:04:36 -07:00
Edward Lee
0dc7cf0d81 Merge weave to weave-partial-view. 2009-09-08 23:35:21 -07:00
Edward Lee
87de5afcd8 Detect dupe separators by identifying them by their position and generate the lookup lazily with the folder/title mapping for now. 2009-09-08 23:33:58 -07:00
Edward Lee
258a985cee Expose a _handleDupe on engines and provide a custom one for bookmarks that tracks GUID changes so that it can keep an alias mapping to fix incoming item properties (id, parent, predecessor). Move out _reparentOrphans so that it is triggered on update and not just create because folders can change ids to the right parent. 2009-09-08 23:33:15 -07:00
Edward Lee
c021c5dcf6 Remove the brief log now that we only show verbose. 2009-09-07 18:24:21 -07:00
Edward Lee
19443b737b Bug 514323 - Use info/collections to check if there's new data. r=thunder
Fetch info/collections before syncing engines and set the lastModified property on the engine so that they can check if they need to process incoming.
2009-09-03 21:30:40 -07:00
Edward Lee
ec0c49c88c Bug 513191 - cloud -> client sync wipes auth cache, including weave credentials. r=thunder
Bug 506790 - Utils.setPassword unnecessarily removes logins and add them when the realm/user/pass are the same
Bug 506792 - Utils.setPassword gets called multiple times for both password and passphrase on login
Bug 514499 - Passphrase not verified with auto-login
Don't aggressively persist the password with smart (dumb?) setters that clear out the temp password; and provide a separate function to persist the login. This effectively makes setting password/passphrase always temporary until persisted, which will check if the value is different from the one already stored on disk. A number of verify/cluster functions are privitized to not need to take user/pass/passph as arguments so that the default authenticator will work, and verifyPassphrase will use the stored passphrase to correctly handle auto-login.
2009-09-03 21:11:32 -07:00
Edward Lee
9ec91eed07 Bug 514600 - Track how long various parts of sync take
Instrument all functions that are part of the sync engine (except some constructors, etc.) and generate statistics (min/max/sum/num/avg) for processing. For now with the default appender, implement toString to report just the total time.
2009-09-03 20:11:36 -07:00
Edward Lee
afeb89b845 Remove unimplemented engines so they do not initialize. 2009-09-03 19:57:02 -07:00
Edward Lee
a914ebad5b Bug 512600 - Split rel/dev-track users on to separate servers. r=thunder
Insert the server_url for the default preference at package time. For now, have both rel and dev use auth.smc.
2009-09-03 01:03:05 -07:00
Edward Lee
0fa22bedac Switch to 0.5 server API for deleting multiple ids from a collection. 2009-08-31 18:30:44 -07:00
Edward Lee
0e889ae8fb Resolve bookmarks.js merge conflicts switching to batchSync (with trailing comma). 2009-08-31 18:04:40 -07:00
Edward Lee
5a3c53fd6a Merge weave to weave-partial-view w/ conflicts. 2009-08-31 18:03:35 -07:00
Edward Lee
678f177443 Detect dupe folders by title for now. Might need to update the hash during sync if titles are added. 2009-08-31 17:54:21 -07:00
Edward Lee
f8541ddf2f Pick a canonical guid to keep in a way that all machines can agree without having all data -- "smaller" guid. 2009-08-31 17:51:26 -07:00
Edward Lee
994b05a7d1 Implement multiple ids deletion for use with 0.3 APIs. 2009-08-31 17:50:23 -07:00
Edward Lee
97e3f746cb Switch end-of-sync deletes to something SyncEngine is aware of and runs at _syncFinish. 2009-08-31 17:30:34 -07:00
Edward Lee
5e9d07e643 Use places utils to find an existing bookmark dupe for an incoming record. 2009-08-31 17:29:47 -07:00
Edward Lee
5468320159 Convert uses of recordLike/findLikeId to findDupe except Bookmarks is unimplemented. 2009-08-31 17:27:30 -07:00
Edward Lee
e633a4dcea Remove mostly unused FaultTolerance service and fix up remaining references. 2009-08-31 17:17:20 -07:00
Edward Lee
c70241b5ce Bug 512457 - Report errors before they get eaten up by runInBatchMode
Save the exception from inside runBatched and not have runInBatchMode return failure, so we can then expose the exception.
2009-08-31 16:28:00 -07:00
Edward Lee
813888cd91 Remove unused fennec preference overlays, scripts, strings, styles. 2009-08-28 12:21:26 -07:00
Dan Mills
db5d4e1bd6 remove 'GPrefs' from Svc, Preferences will do fine; don't make the username in the center status a link, since the whole area is a click target; open 'generic dialogs' for change password & passphrase 2009-08-26 21:20:08 -07:00
Edward Lee
b1741b5482 Add erase server data button to the cloud bubble.
--HG--
extra : rebase_source : fef9abc20e34ebe40fc0d0a2b660e3869c5f6965
2009-08-26 20:22:59 -07:00
Edward Lee
fae3856f53 Remove Firefox Weave pref pane and point Preferences... to about:weave.
--HG--
extra : rebase_source : c8e47a770d342dc52aa49d8912be66cd2fa1bfa2
2009-08-26 19:50:39 -07:00
Dan Mills
b039c047b4 about:weave polish: add localized help drawer & other small fixes
--HG--
extra : rebase_source : e82da40950dd20d6f418c90cb9b02ba896cd5693
2009-08-26 18:48:22 -07:00
Edward Lee
b8e1f6aad3 Bug 512637 - Use newlines instead of JSON collection for incremental parsing. r=thunder
Switch to newline mode when using a collection record handler, and look for newlines! Easy! Update test to provide newline-separated strings instead of JSON.
2009-08-26 18:09:41 -07:00
Edward Lee
ab865b703e Land weave-0.5-api on weave. r=thunder. 2009-08-26 18:03:52 -07:00
Edward Lee
f33e9b23f3 New User API returns server code 2 instead of http 417. 2009-08-26 17:59:50 -07:00
Edward Lee
cb743d3b33 Remove old modified arg for collections. 2009-08-26 17:52:46 -07:00
Edward Lee
76cc6cfde5 Save an exception/catch when failing to import a record. 2009-08-26 17:49:23 -07:00
Edward Lee
943386f42d Server expects catcha-challenge not captcha_challenge for new users. 2009-08-26 16:45:24 -07:00
Dan Mills
e24dbcf68f Parse new 0.5 error codes. 2009-08-26 16:44:30 -07:00
Edward Lee
4175f5ee7e Resolve lastChannel removal and 0.5 api changes. r=thunder 2009-08-26 16:09:48 -07:00
Edward Lee
9fd47b7f98 Merge weave to weave-0.5-api w/ conflicts. 2009-08-26 15:42:05 -07:00
Edward Lee
009411f482 Bug 511746 - Resource.foo shouldn't throw except in exceptional cases. r=thunder
Get rid of lastChannel and return a String object from _request with additional properties of status, succeeded, headers -- even if the response was handled by cache. Update engines to check for non-success and throw the failure. Update tests to use these additional properties instead of lastChannel, etc.
2009-08-26 15:32:46 -07:00
Dan Mills
e4ea37a013 Adds another pref for the "misc" api, makes base/misc url prefs default to auth.smc/{user,misc}/, fixes about:weave captcha path. r=Mardak 2009-08-26 15:01:28 -07:00
Edward Lee
4d055dc574 Bug 506297 - Livemarks with null site/feed uris cause sync to fail
It's possible for livemarks to not have a siteURI, so don't assume it to be there.

--HG--
extra : rebase_source : 870bb41c980834ef3e5f302739d20adfed6f7f8d
2009-08-26 14:22:11 -07:00
Mike Connor
12a9dca217 remove files that were supposed to be culled already, stupid Hg 2009-08-26 13:07:23 -04:00
Mike Connor
dbf5dccaab add missing pick-sync.dtd
--HG--
extra : rebase_source : 082544cd2a595206bd550cee94d35f635444e5ed
2009-08-26 13:03:33 -04:00
Edward Lee
ca6fe1108c Backed out changeset 129ca9a54aed due to burning
test_auth_manager:      FAIL
test_resource:  FAIL
2009-08-26 01:50:36 -07:00
Anant Narayanan
371e639357 Change Resource.get() semantics and support X-Weave-Alert (bug #478330)
--HG--
extra : rebase_source : e0eb1e34f85ddd041005d780590640005dc0b434
2009-08-26 00:05:57 -07:00
Edward Lee
8431f6ff7f Read out the timestamp of the POST response header because the modified time is not part of the response data. 2009-08-25 18:04:46 -07:00
Edward Lee
8c87f37ff7 Fix wipeServer to use the new 0.5 API: get list at info/collections, a hash; delete storage/<engine>. 2009-08-25 17:43:40 -07:00
Edward Lee
a2e27b0d93 Just strip out " from cluster response because Spidermonkey JSON.parse does not allow literals. 2009-08-25 17:42:25 -07:00
Edward Lee
f20a2b4143 Make an alias to the clusterURL + username as userURL. Fix whitespace problems. 2009-08-25 17:15:36 -07:00
Anant Narayanan
e7097f319f Bug 507433 - Update client to use the weave 0.5 server. r-Mardak
Initial 0.5 server API switch not quite working.
2009-08-25 17:06:13 -07:00
Edward Lee
dfe8e7e513 Don't include changes to special places Library "exclude from backup" items. 2009-08-25 16:15:05 -07:00
Edward Lee
9560da1d43 Remove unused alias for wbo/identity. 2009-08-25 08:52:52 -07:00
Mike Connor
a99aaee6d7 bug 512393 - l10n cleanup for 0.6, includes fix for bug 511548 as well 2009-08-25 00:47:35 -04:00
Edward Lee
ca002d3239 Create records with the correct parent/pred if it's still waiting for them to sync. 2009-08-24 16:17:59 -07:00
Edward Lee
e6e554073c Bug 512001 - Kill the Wizard! (and Account Pane + Login)
Remove the Wizard Dialog, Account Pane, Login Dialog, Add-ons Pane, Advanced Dialog and their related xul/js/css/strings/images. Clean up some unused functions, xul:preferences, css, strings. Orphaned functionality: autoconnect preference, reset/forgot password/passphrase.
2009-08-21 17:32:41 -07:00
Edward Lee
94e6abd74c Extend Utils.anno to handle pages and clean up GUID code for history engine. Also fix a bug where changeItemID would set annotations to expire on session. 2009-08-21 14:29:37 -07:00
Edward Lee
a4b22bc213 Remove old dumping code for debugging bug 476903. 2009-08-21 14:29:35 -07:00
Edward Lee
381bdb6576 Bug 511794 - Always use _view instead of _temp + table or just table
Also use subqueries instead of multiple queries and drop the query count down to 2.
2009-08-21 14:29:30 -07:00
Edward Lee
2906267e0c Use the plain get/set for wbo.modified because it's not needed anymore and was causing JS strict warnings: reference undefined property. 2009-08-20 17:10:14 -07:00
Edward Lee
e6732d5263 Conditionally log trace records to avoid always doing record.toString().
--HG--
extra : rebase_source : 65d8025324ed95eac29d530e2699a2f29c8a2cb7
2009-08-20 17:00:15 -07:00
Edward Lee
19f12428d3 Remove unused cancelRequested code that causes JS strict warnings. 2009-08-20 16:26:22 -07:00
Anant Narayanan
e77295f6f7 Correct network handling in findCluster
--HG--
extra : rebase_source : 7e5d2eee8927d95d17d8449bc6789619a1ac8af8
2009-08-20 12:14:34 -07:00
Dan Mills
23f2e1ae15 Always load about:weave, never the wizard; fix captcha to load in an iframe; fix password fields to be type text when the page is loaded (with the explanation text in them) 2009-08-20 11:49:50 -07:00
Edward Lee
5dfda076bb Try/catch in checkUsername if resource throws and default to generic-server-error. 2009-08-20 10:20:01 -07:00
Edward Lee
83920494dc Handle createAccount resource exceptions correctly (null ret, throw fail) and cleanup. Check for non-failure in the UI instead of only success 200. 2009-08-20 10:14:19 -07:00
Edward Lee
c29ee791ce Resolve commit conflicts from merging in weave. 2009-08-19 22:53:04 -07:00
Edward Lee
144a9195b9 Merge weave to about-weave. 2009-08-19 22:46:50 -07:00
Edward Lee
c9b2732fbe Merge weave to weave-relative. 2009-08-19 22:16:10 -07:00
Mike Connor
1f94c8885f bug 481733 - provide better error messages, handle errors better, make autoconnect more robust, r=edilee
--HG--
extra : rebase_source : 3eb68a7b4be88c7bd7b9c2b02c96218298cce2f9
2009-08-19 23:27:22 -04:00
Mike Connor
f600de80bc bug 481733 - provide better error messages, handle errors better, make autoconnect more robust, r=edilee 2009-08-19 23:27:22 -04:00
Dan Mills
b475610101 merge upstream changes 2009-08-19 20:13:53 -07:00
Edward Lee
c4393b5e3b Handle holes in bookmark folders and fix up bookmarks to be at an earlier position if a hole was detected. 2009-08-19 19:32:05 -07:00
Anant Narayanan
096dd8c74d Handle 401s from the server correctly. (bug #509552) 2009-08-19 18:22:22 -07:00
Edward Lee
4bb37a06d2 Add tests to make sure bookmarks are in the right position after creating/updating. 2009-08-19 18:15:12 -07:00
Edward Lee
6b910e2590 Share the logging _ code for tests. 2009-08-19 18:01:06 -07:00
Dan Mills
a3d13166a2 clean up weave events handling; add timed bubble after account creation; add status text below arrows 2009-08-19 17:10:17 -07:00
Dan Mills
bd35370bb3 initial commit of new about:weave 2009-08-18 20:03:11 -07:00
Edward Lee
87f47c35a6 Attach followers for both created items and updated items (call from applyIncoming) when it's under the right parent. Share logic for attaching followers when creating a folder then fixing the reparented children and when creating/updating an item in the right parent. 2009-08-18 18:42:15 -07:00
Edward Lee
fae8b93210 Add the successor ids when adding/removing items as well as both old and new successors when moving. 2009-08-18 18:39:10 -07:00
Edward Lee
b264174b42 When updating the position of an item, move all of its followers with it. Share chain moving logic used for fixing followers on create and updating positions. 2009-08-18 18:36:31 -07:00
Edward Lee
0435aca087 For items that have the correct parent, see if there's an item following it and reposition the chain of items to after the correct parented item. A chain of followers starts at the item with the predecessor annotation and goes until the end of the folder, an item that is looking for a predecessor, or ends up at where we started (the predecessor). 2009-08-17 02:34:03 -07:00
Edward Lee
7a297f3b5f Simplify the debug output when creating bookmarks and include the parent and position. 2009-08-16 12:39:30 -07:00
Edward Lee
014c01848d Print out the stack when failing to apply an incoming record. 2009-08-16 12:39:23 -07:00
Edward Lee
7c3bc745a0 Use the predecessorid to figure out where to put the item or save the predecessor as an annotation. 2009-08-16 12:39:15 -07:00
Edward Lee
96a4461af4 Set the predecessorid when creating records for upload. 2009-08-16 12:39:00 -07:00
Edward Lee
4cb51d9bde Remove the missing parent annotation after reparenting an orphan. 2009-08-15 14:43:10 -07:00
Edward Lee
306fc8507b Reparent orphans when creating the parent folder. 2009-08-15 01:07:40 -07:00
Edward Lee
7cc5c17773 Use a shared setGUID for new items and changing guids so that the item always ends up with the GUID (because conflicts shouldn't have been Weave generated). 2009-08-15 01:04:06 -07:00
Edward Lee
004fdf436d Store the parent GUID as an annotation if the item is missing a parent and share some parent lookup code. 2009-08-15 01:00:46 -07:00
Edward Lee
31270d064c Move _preprocess to before applyIncoming to share code for create/update/remove. 2009-08-15 01:00:32 -07:00
Edward Lee
cbba430108 Rename weaveId to just GUID and share a id<->guid function across store and tracker. 2009-08-15 00:59:49 -07:00
Edward Lee
fae7aaa071 Temporarily append everything and don't use sortindex for ordering within a folder. 2009-08-15 00:57:09 -07:00
Edward Lee
2335b057db Get rid of depth and sort on index instead. 2009-08-15 00:56:27 -07:00
Edward Lee
3ca750f464 Remove meta/mini records. Bye! 2009-08-13 18:50:54 -07:00
Edward Lee
39895d48b2 Put Annotations in Svc and expose a get/set Utils.anno call to use from bookmarks. 2009-08-13 17:59:26 -07:00
Edward Lee
983afb76a9 Remove unused bookmark annotations/constants. 2009-08-13 17:43:20 -07:00
Edward Lee
11ce9c4f76 Bug 510152 - Check for failure onStopRequest and throw the error for extra debugging
Wrap the error code with a JS Error to track the stack, and re-wrap it to get the full stack trace. Also, remove args for __request for the stack because it's sometimes the whole record..
2009-08-12 20:28:46 -07:00
Anant Narayanan
e1144b86c4 Ask for password/passphrase before changing it (bug #507434) 2009-08-11 11:22:13 -07:00
Edward Lee
8a14a4dfd4 Bug 507691 - Server responds with json decode failure for fat unicode characters
Make sure we generate ASCII data for upload by escaping on serialize and unescaping on deserialize. Test to make sure serialized data is ASCII and the original records aren't modified by serialize.
2009-08-06 11:28:33 -07:00
Edward Lee
bc5f3d3be8 Bug 507296 - Sync bookmarks and history in batched mode. r=thunder
Wrap the original SyncEngine._sync function with a call to runInBatchMode, so SQL disk writes happen at the end of batch mode instead of on every change.
2009-07-30 11:52:26 -07:00
Anant Narayanan
45673ccb67 WinCE crypto binary (bug #487171) 2009-07-28 17:14:52 -07:00
Anant Narayanan
a79e153fb9 Backed out changeset 9e8936813ae1 2009-07-28 17:13:15 -07:00
Anant Narayanan
7a7c271cd7 WinCE crypto binary 2009-07-28 16:54:24 -07:00
Anant Narayanan
e299866ead Re-structure window utils 2009-07-28 14:30:32 -07:00
Edward Lee
1a4c241fc9 Change client engine to override findLikeId instead of recordLike to save on some work (iterating over changed ids). 2009-07-28 10:07:07 -07:00
Edward Lee
6ddbaa9a8e Bug 506795 - Handle adding duplicate logins. r=thunder
Refactor reconcile to call findLikeId that by default will look for recordLike in the outgoing queue as it does now. Override findLikeId for password engine to search local logins.
2009-07-28 10:06:02 -07:00
Edward Lee
a14ea8d26f Add i86pc machine detection for crypto Makefile. Add SunOS for test Makefiles. 2009-07-26 02:55:38 -07:00
Edward Lee
d02b8efc49 Bug 506302 - Shorten stack traces
Trim the full path from JS stacks and just show the file and convert nsIException traces to look like js stacks: func()@file:line. Only difference is js stacks show arguments while nsIException always shows just (). Fix up some places where we print the exception instead of the fixed up string.
2009-07-24 15:28:42 -07:00
Anant Narayanan
7b33ae1109 Remove useless check for crypto methods 2009-07-23 17:12:32 -07:00
Anant Narayanan
77050fe32c Fix verifyPassphrase for cases when the key actually exits :-/ 2009-07-23 17:01:58 -07:00
Anant Narayanan
0a5e02179f Fix verifyPassphrase returning false on first login 2009-07-23 16:52:28 -07:00
Edward Lee
39607ef7b9 Bug 505940 - Unnecessarily uploading records on first sync
Remove short-circuit logic of comparing number of keys for deepEquals and iterate through each key on both objects to make sure both have the same value.
2009-07-22 23:49:15 -07:00
Edward Lee
551f097468 Convert various debug messages to trace. 2009-07-22 21:40:18 -07:00
Mike Connor
dd7f0c31ad bug 497938 - Client should back off server when it is busy, r=edilee
--HG--
extra : rebase_source : 347137310b0ff0bba8b5267632259645c516e56b
2009-07-22 23:48:41 -04:00
Edward Lee
5860298b5a Bug 504788 - Handle different weave versions by wiping, upgrading, updating. r=thunder
Store the most newest Weave version on the server and update it if necessary on each remoteSetup. Make a concept of a compatible version where this version of Weave can read but might change records with its full sync.

--HG--
extra : rebase_source : c11cada1e3ba07e00113fca439610d0b6fd78190
2009-07-22 18:49:07 -07:00
Dan Mills
db7966a67b Bug 505906: Don't do a last POST if there is nothing left to send. Regression from bug 481347. r=mardak 2009-07-22 17:48:47 -07:00
Edward Lee
a26f0b1166 Bug 485573 - Fennec runs out of memory and crashes if too many history items to sync. r=thunder
Incrementally process records as the collection finds record boundaries and converts them to records for the engine to use. Get rid of the collection iterator and original RecordParser. Add tests for incremental record parsing and remove old iter tests.
2009-07-22 16:38:34 -07:00
Dan Mills
7f9996ac73 Bug 481347: Split uploads into multiple chunks to get around server upload limit and curtail memory usage 2009-07-22 16:21:33 -07:00
Anant Narayanan
bb5bad5e68 Verify passphrase on login (bug 505571) 2009-07-21 21:05:23 -07:00
Anant Narayanan
995121086c Make change password work (bug 505570) 2009-07-21 20:59:02 -07:00
Anant Narayanan
c6a90202ff Add ability to change passphrase (and merge XUL files) bug #443696 2009-07-21 16:54:46 -07:00
Anant Narayanan
3541ab1269 Expose rewrapPrivateKey & verifyPassphrase (bug #505401) 2009-07-21 15:02:30 -07:00
Anant Narayanan
1676f8958b Merge with backed out changeset 2009-07-21 14:33:26 -07:00
Anant Narayanan
0697eb1f5c Backed out changeset 5768a19f21d3 (crypto review not done yet) 2009-07-21 14:32:57 -07:00
Anant Narayanan
6a3dde2cd9 Reset passphrase code + UI (bug #443696)
--HG--
extra : rebase_source : 4905bf56bf8efc90b49f99f56603a93908efdd63
2009-07-21 14:31:16 -07:00
Anant Narayanan
1509f1d1cb Crypto changes
--HG--
extra : rebase_source : 0a953a43c01b95e7c467ec4ca7feeb0aaa00f5e1
2009-07-21 11:18:29 -07:00
Daniel Holbert
d04ec4df06 Bug 502293: Fix a string so that Weave will *actually* display error messages, instead of showing a percent sign. r=thunder 2009-07-21 12:35:12 -07:00
Edward Lee
c5690e2288 Bug 504256 - sync should observe idle service and only sync when the user is idle
Detect if the user has been recently active, and if so, skip the sync. Arbitrarily picking 30 seconds for now.
2009-07-17 16:55:15 -07:00
Edward Lee
2f261f5115 Bug 504389 - Don't automatically sync after clicking on wipe server
Remove description reference to automatically sending local data.
2009-07-17 12:23:03 -07:00
Edward Lee
baa48207f2 Bug 504387 - Cache keys after creating/PUTting them instead of after GETting. r=thunder
Set the record manager for CryptoMetas, PubKeys, PrivKeys after uploading keys.
2009-07-16 23:13:58 -07:00
Edward Lee
fd0528fc6b Bug 504389 - Don't automatically sync after clicking on wipe server
Don't open the sync status after wiping, and move the after-wipe sleep to inside freshStart with shorter wait.
2009-07-16 16:31:54 -07:00
Mike Connor
6ccbc1e360 move password tests to need-work because they've been broken for a year
--HG--
rename : services/sync/tests/unit/test_passwords.js => services/sync/tests/unit/need-work/test_passwords.js
2009-07-16 11:51:10 -04:00
Edward Lee
83b93be2b6 merge weave 0.5pre2. 2009-07-15 16:48:05 -07:00
Edward Lee
71cfc26ab9 Bug 504372 - Don't immediately start syncing right after wiping the server
Wait a while after wiping so that the DELETEs replicate.
2009-07-15 11:26:22 -07:00
Edward Lee
828bd7bfc7 Bug 504346 - Set the storage version with storage version instead of weave version
Make it so WEAVE_VERSION is only used to detect add-on version upgrades.
2009-07-15 11:07:44 -07:00
Edward Lee
af402ab06f Bug 504346 - Set the storage version with storage version instead of weave version
Rename MIN_SERVER_STORAGE_VERSION -> STORAGE_VERSION and use it when setting meta/global's storageVersion.
2009-07-15 10:31:35 -07:00
Edward Lee
e0f49d8631 merge weave. resolve Makefile storage_version changes. 2009-07-14 19:23:15 -07:00
Edward Lee
5d5107e98e Bug 504236 - Allow separate weave and storage versions
Update the substitution names to separately replace the storage version with the new storage version Makefile variable.
2009-07-14 19:19:49 -07:00
Edward Lee
b935178671 Bug 504212 - Have javascript stack traces show [object Object] for various CryptoWrapper functions
Also update createKeypair for keys to pass around the passphrase object and update the tests to pass around an object.
2009-07-14 19:04:32 -07:00
Edward Lee
4f7ab3c5c2 Remove pref tracker init debug message. 2009-07-14 18:47:29 -07:00
Edward Lee
bc0326da9c Log jsonLoad/Save as trace instead of debug. 2009-07-14 18:44:41 -07:00
Edward Lee
68d361380a Bug 504230 - Use Engine's logging level for Store and Tracker
Use the log.logger.engine.* prefs to determine what the Store and Tracker should log with. This requires putting the same engine name on each Store/Tracker object, so there's some duplicate string values right now.
2009-07-14 18:34:03 -07:00
Edward Lee
9fde263097 Bug 504216 - Force various engines to be disabled
Have the disabled engines return null for enabled instead of the pref's true/false.
2009-07-14 17:03:57 -07:00
Edward Lee
e94143f4e2 Bug 504212 - Have javascript stack traces show [object Object] for various CryptoWrapper functions
Pass the ID object instead of reading out the password and passing it in to encrypt/decrypt.
2009-07-14 16:51:04 -07:00
Edward Lee
ba2b880253 Bug 504196 - Enable Forms and Prefs sync by default
Toggle forms/prefs preferences to true by default.
2009-07-14 16:08:15 -07:00
Edward Lee
2b33ab565b Bug 504177 - Don't block the UI when syncing up/down
Sync.sleep(0) to let the main thread do UI, etc. after every record encrypt or decrypt.
2009-07-14 14:01:26 -07:00
Edward Lee
d252180708 Debug log the size of PUT/POSTs messages.
--HG--
extra : rebase_source : 67a4e2afd1c908cc9184c0866226a55c77a96292
2009-07-14 13:59:46 -07:00
Anant Narayanan
7cd35a2c36 Limit form history records (bug 494952, r=thunder)
--HG--
extra : rebase_source : c3e983d30a14efd972eea2651a59be76924da256
2009-07-14 12:28:18 -07:00
Edward Lee
5ad22f9709 Bug 479189 - weave does not sync tag smart folders properly
Create a new record type, BookmarkQuery, to handle place: uri smart bookmarks. Store what tag name the query wants and lookup the id for that tag on other machines on create/update.
2009-07-13 17:43:15 -07:00
Edward Lee
22570f2932 Bug 503938 - Tags with a single bookmark keep generating new tag ids
Share a tagging code for create/update that will tag a dummy uri temporarily while it untags the bookmark to make sure every tag has at least one child during this untag/tag process.
2009-07-13 13:40:49 -07:00
Mike Connor
0d4506ba23 fix tests 2009-07-11 02:30:37 -04:00
Mike Connor
44bd8a8cb4 arglebargle 2009-07-11 01:20:45 -04:00
Mike Connor
8d26fd31e1 file moves
--HG--
rename : services/sync/IWeaveCrypto.xpt => services/crypto/components/IWeaveCrypto.xpt
2009-07-10 11:57:56 -04:00
Edward Lee
6b52988511 Print the exception with the stack on fault tolerance. 2009-07-09 18:05:58 -07:00
Edward Lee
e934d2d097 Strip newline from various debug output. 2009-07-09 17:44:41 -07:00
Edward Lee
6ddece8b22 Bug 502482 - error while syncing bookmarks from server
Set the item type for generic PlacesItems, but don't do anything when trying to create it.
2009-07-09 17:15:00 -07:00
Edward Lee
f3b15e11d4 Remove async and wrap from test_load_modules. 2009-07-09 13:58:19 -07:00
Edward Lee
5c482eea0d merge weave. resolve comments added to resource.js. 2009-07-09 11:21:20 -07:00
Dan Mills
7626f0f740 switch from autogenerated load-module tests to a single test that loads all modules 2009-07-01 11:51:52 -07:00
Edward Lee
1c1025b37d Convert a log.info to log.debug for passwords so it doesn't clutter the brief log. 2009-06-25 22:52:28 -07:00
Edward Lee
39f333a78e Bug 500598 - Undefined item in tabContainer.childNodes after closing tabs
The childNodes NodeList keeps its indices even after removal, so it's safer to convert the array-like thing into an actual array. Condense the QueryInterface code to the instanceof magic.
2009-06-25 22:46:14 -07:00
Edward Lee
d6422004f2 Bug 500551 - Failed to load XPCOM component WeaveCrypto.so
Only try loading WeaveCrypto maemo binary on Linux (until we get Linux_arm-msvc).
2009-06-25 17:27:03 -07:00
Anant Narayanan
fec355a521 Add some docs for Resource module 2009-06-25 16:13:52 -07:00
Edward Lee
0e6bc6f2ea Bug 500518 - Update fennec login screen to use richpref styling
Use a richlistbox with richpref styling for input/buttons like the rest of the weave prefs. Hide password/passphrase after entering, but keep them visible when entering for the first time.
2009-06-25 14:26:33 -07:00
Edward Lee
84c52a6411 merge weave. resolve addition of kSpecialIds to bookmarks.js near removal of Async.sugar. 2009-06-23 22:34:57 -07:00
Anant Narayanan
22bd439624 Change priority of some log messages to trace 2009-06-22 18:19:42 -07:00
Edward Lee
eeef9a8201 Bug 487282 - "browser is null" error in tabs.js
Share browser detection code for register and unregister tab listeners and better check for tabbrowser windows.
2009-06-22 15:53:42 -07:00
Edward Lee
ad7d001bb3 Bug 498924 - Refactor bookmark special ids out of BookmarksStore
Lazily load places ids for a given weave id/place name pair into kSpecialIds and update all consumers. Expose a Svc.Bookmark in utils.
2009-06-17 09:28:15 -07:00
Edward Lee
3ef568c718 Cleanup/refactor followup to bug 481327.
Change _ignore to take itemId to find folderId and pull out addChanged/getItemGUID/upScore to addId.
2009-06-17 08:51:54 -07:00
Edward Lee
34400917b0 Bug 481327 - Script gets stuck during startup. r=Mardak 2009-06-17 08:51:54 -07:00
Edward Lee
ad5f01ba04 Bug 493816 - Timestamps need to be saved as string prefs
Internally store .lastSync as a string but keep exposing set/getters as float values. parseFloat takes both strings and numbers and gives a number.

--HG--
extra : rebase_source : b657dd3f732b9f3b3b0ef208ee53e799aa87d2c6
2009-06-16 17:22:59 -07:00
Anant Narayanan
e5e0fa16e3 Check if password and username are different on account creation (bug #442878) 2009-06-16 17:07:01 -07:00
Mikhail Stepura (mishail)
fde4deb743 Bug 486042 - "Load this bookmark in the sidebar" status not synced. r=Mardak 2009-06-16 16:16:39 -07:00