Commit Graph

175 Commits

Author SHA1 Message Date
Shawn Wilsher
8075a939ec Bug 476292 - Crashes on startup on OS X and Linux [@ nsNavBookmarks::IsRealBookmark] [@ PL_DHashTableOperate]
This fixes a crash when we initialize nsNavBookmarks with a database that is out
of date (the schema version is less than the current one).  Because the bookmark
service initializes the history service in its Init method, and the history
service tries to get the bookmark service if the database needs an upgrade, we
try to re-enter the bookmark service's constructor.  Bad things happen.

Adds a test to ensure that we don't do this again.

r=dietrich
r=MaK77
2009-02-03 21:58:21 -05:00
Shawn Wilsher
4756beb1ae Bug 449406 - bookmarks of TRANSITION_DOWNLOAD and TRANSITION_EMBED don't show up in the location bar if they've been visited
This adds a new function to nsNavBookmarks that determines if a place id is a
"real" bookmark (not a livemark child).  It also makes a number of places use
this new function to unify and simplify a number of code paths.

Additionally, it changes how frecency is calculated for bookmarked items.  If a
visit is bookmarked (aIsBookmarked is true in CalculateFrecencyInternal), the
visited bookmark bonus is now added for all visits.  The visit bonus was also
cut in half for bookmarks so TRANSITION_BOOKMARK will still end up with the same
value (150).

r=dietrich
r=MaK77
2009-01-27 21:01:33 -05:00
Daniel Holbert
2a7d88e05a Bug 473236 - Remove executable bit from files that don't need it. (Only changes file mode -- no code changes.) r=bsmedberg 2009-01-21 22:55:08 -08:00
Drew Willcoxon
c149de9294 Bug 412132 - after changing a bookmark's location, need to update the frecency of the "old" uri, r=dietrich 2009-01-13 11:48:27 +01:00
Marco Bonardo
4c89a6229d Bug 454977 - remove INSERT OR REPLACE to avoid error prone paths with views, r=dietrich 2009-01-13 11:48:25 +01:00
Robert Kaiser
0b557fdaa3 bug 471886 - Make places autocomplete tests even more robust against default prefs, r=Mardak 2009-01-10 16:29:17 +01:00
Marco Bonardo
3b1f2a552d Bug 468400 - xpcshell-simple/test_places/unit/test_adaptive.js | *** TIMEOUT ***: The test timed out while polling database, r=sdwilsh 2009-01-08 00:37:01 +01:00
Marco Bonardo
83a374cd4f Bug 470429 - nsPlacesDBFlush::onItemAdded should not sync if the item is a container, r=sdwilsh 2009-01-08 00:37:00 +01:00
Marco Bonardo
248d436712 Bug 462765 - instant-apply muddies the MRU folder list in the bookmark properties dialog, r=dietrich 2009-01-08 00:37:00 +01:00
Marco Bonardo
0cafd269c4 Bug 470707 - [SeaMonkey] test_download_history.js fails now, r=dietrich 2008-12-30 22:42:23 +01:00
Marco Bonardo
485f62946f Bug 439129 - Clearing browsing history does not hide livemarks children from the location bar, r=dietrich 2008-12-30 22:42:22 +01:00
Dietrich Ayala
17dd8776c4 Bug 414715 - Notify the user if places.sqlite is locked and bookmarks and history will not work (relanding w/ leak fix, r=marco, r=gavin, l10n-r=pike) 2008-12-30 13:44:55 +01:00
Dietrich Ayala
44e08929e7 backout bug 414715 due to leaks 2008-12-29 17:22:39 -08:00
Dietrich Ayala
c51318949c Bug 414715 - Notify the user if places.sqlite is locked and bookmarks and history will not work (relanding w/ leak fix, r=marco, r=gavin, l10n-r=pike) 2008-12-29 14:49:05 -08:00
Marco Bonardo
dce47704f5 Bug 458849 - transition download visits saved when "Keep my history..." is unchecked, r=sdwilsh 2008-12-19 13:36:15 +01:00
Dietrich Ayala
a81ff7e680 imported patch backout-bug414715 2008-12-18 17:09:25 -08:00
Dietrich Ayala
3299fb830d Bug 414715 - Notify the user if places.sqlite is locked and bookmarks and history will not work (r=marco, r=gavin, l10n-r=pike) 2008-12-18 13:47:48 -08:00
Dietrich Ayala
5dfe4f0055 Bug 469102 - Places Tag Autocomplete breaks with certain tags (Regex escaping) (r=marco) 2008-12-18 12:33:47 -08:00
Marco Bonardo
45b8f132d3 Bug 468836 - Existing tags no longer show and cannot be edited, r=dietrich 2008-12-11 15:23:25 +01:00
Robert Sayre
38305f3678 backout bug 468836, checked in on persistent orange. 2008-12-11 02:44:01 -08:00
Marco Bonardo
1006ee8d3a Bug 468836 - Existing tags no longer show and cannot be edited, r=dietrich 2008-12-11 01:32:24 +01:00
Robert Kaiser
309980c5e5 bug 468341 - Some toolkit places tests fail on SeaMonkey unit test boxes - make tests mor tolerant to default prefs, non-override DOM error messages, non-existing browser-specific services and protcol defintions, r=sdwilsh a=tests-only 2008-12-10 13:18:14 +01:00
Marco Bonardo
6d9599a014 followup to Bug 431558 - implement preventive maintenance for places.sqlite, remove observer on test finish, r=sdwilsh 2008-12-10 11:44:01 +01:00
Dietrich Ayala
7a9981ce5f Bug 463513 - Tagging service could hold a fixed cache instead of an open node, r=mak77 2008-12-10 11:40:13 +01:00
Marco Bonardo
0dd8a6691d Bug 431558 - implement preventive maintenance for places.sqlite, r=dietrich 2008-12-09 21:39:32 +01:00
Marco Bonardo
c53ec05b07 Bug 460119 - Convert autocomplete feedback increase to an async query, r=dietrich 2008-12-04 16:41:06 +01:00
Marco Bonardo
d984c838eb Bug 463863 - Download history not shown in Places history, r=dietrich, ui-r=beltzner 2008-12-04 13:59:04 +01:00
mak77@bonardo.net
3d576ef8ce Bug 463471 - temp tables are not correctly synced to disk when the user clear private data on shutdown (r=sdwilsh, r=dietrich) 2008-11-13 22:45:49 -08:00
Marco Bonardo
45455110de backout test for bug 463471 causing orange 2008-11-13 11:33:01 +01:00
Marco Bonardo
36f739f320 Bug 463471 - temp tables are not correctly synced to disk when the user clear private data on shutdown, r=dietrich, sdwilsh a=beltzner 2008-11-12 21:50:02 +01:00
Marco Bonardo
20ae2fab49 Bug 462366 - correct bogus importBookmarksHTML behaviour, r=dietrich a=beltzner 2008-11-12 21:45:53 +01:00
mak77@bonardo.net
234918c058 Bug 418643 - Bookmark folder deletion executes too many SQL statements (r=dietrich) 2008-11-05 14:02:12 -08:00
Dietrich Ayala
029ea93f23 Bug 419792 - Use optimized query to get tags for nsNavHistoryResultNode (r=mano) 2008-11-05 10:20:00 -08:00
Ehsan Akhgari
a2e1bc51b4 Bug 248970 - Private Browsing mode (global toggle for saving/caching everything) [Places unit test fix]; r=dietrich 2008-11-04 02:52:22 +03:30
Ehsan Akhgari
4770654ff7 Bug 248970 - Private Browsing mode (global toggle for saving/caching everything) [unit test API changes]; r,sr=mconnor 2008-11-04 02:52:22 +03:30
Dietrich Ayala
15440bfcb0 Bug 415960 - bookmark tags edit control should provide autocomplete (r=mano, core by asouzis@users.sf.net) 2008-10-31 09:16:22 -07:00
Marco Bonardo
f118fc44e0 Bug 460947 - fsync stuff has a wrong query for expiration sites cap
r=dietrich
2008-10-27 18:52:23 -04:00
Marco Bonardo ext:(%2C%20Shawn%20Wilsher%20%3Csdwilsh%40shawnwilsher.com%3E)
3fc608c2a6 Bug 449640 - Modify the places backend to use the temporary tables &
Bug 450705 - Optimize the query changes from the temp table rewrite
This changeset merges patches from two bugs to actually use the temporary tables
created for places.
Bug 449640 patch by Shawn Wilsher <sdwilsh@shawnwilsher.com>
r=dietrich, r=Mak77
Bug 450705 patch by Marco Bonardo <mak77@bonardo.net>
r=sdwilsh, r=dietrich, r=Mardak
2008-10-27 18:52:20 -04:00
Ehsan Akhgari
229637b291 Bug 248970 - Private Browsing mode (global toggle for saving/caching everything) [places part]; r=dietrich 2008-10-20 00:44:59 +03:30
Marco Bonardo
3b22c3d551 Bug 457698 - nsNavHistoryFolderResultNode::OnItemAdded ignores dynamic containers, r=dietrich 2008-10-13 18:14:50 +02:00
Marco Bonardo
6d926ff1b7 Bug 457686 - appendURINode should not append to a dynamic container if we are inside an excludeItems query, r=dietrich 2008-10-13 18:06:50 +02:00
Marco Bonardo
56441e9d6e Bug 457681 - if ExcludeReadOnlyFolders is false, readonly dynamic containers are still excluded, r=dietrich 2008-10-13 17:58:36 +02:00
Daniel Holbert
72c410a648 Bug 458167 - (comments-only changes) Grammar Nazi Vol1: s/it's/its/ for the posessive version of the word, and a few other misc comment-typos, in these directories: accessible browser config profile rdf toolkit tools xpcom xpfe 2008-10-01 23:49:45 -07:00
Dietrich Ayala
89c275d5aa Bug 420331 - wyciwyg: uris show up in location bar (r=mardak) 2008-09-29 23:46:52 -07:00
Dietrich Ayala
5d9c44b264 pushing test for bug 433317, forgot to check-in initially 2008-09-29 23:22:46 -07:00
Shawn Wilsher
4a538b5c1c Backout of last four changesets (places fsync work) 2008-09-26 14:20:14 -04:00
Marco Bonardo ext:(%2C%20Shawn%20Wilsher%20%3Csdwilsh%40shawnwilsher.com%3E)
b9562883b9 Bug 449640 - Modify the places backend to use the temporary tables &
Bug 450705 - Optimize the query changes from the temp table rewrite
This changeset merges patches from two bugs to actually use the temporary tables
created for places.
Bug 449640 patch by Shawn Wilsher <sdwilsh@shawnwilsher.com>
r=dietrich, r=Mak77
Bug 450705 patch by Marco Bonardo <mak77@bonardo.net>
r=sdwilsh, r=dietrich, r=Mardak
2008-09-26 13:45:59 -04:00
Marco Bonardo
016e09eab3 Bug 451499 - wrong folder icon appears on smart bookmarks, r=dietrich 2008-09-06 17:21:55 +02:00
Shawn Wilsher
f22841cdcd Bug 452777 - regression from lastInsertRowID: Undo folder deletion mix up views
r=Mak77
2008-09-03 12:45:20 -04:00
Marco Bonardo
fed5a1056a Bug 442731 - GIF favicons are not resampled in places.sqlite (large icons are stored), r=dietrich, pavlov 2008-09-02 13:59:59 +02:00