Bug 923368 - Home panel items should allow for copying URL. r=margaret

This commit is contained in:
Zhanpeng Zeng 2014-05-21 20:27:18 +08:00
parent 0b0da9015a
commit ff7a656969
2 changed files with 14 additions and 0 deletions

View File

@ -18,6 +18,7 @@ import org.mozilla.gecko.db.BrowserContract.Combined;
import org.mozilla.gecko.db.BrowserDB;
import org.mozilla.gecko.favicons.Favicons;
import org.mozilla.gecko.home.TopSitesGridView.TopSitesGridContextMenuInfo;
import org.mozilla.gecko.util.Clipboard;
import org.mozilla.gecko.util.ThreadUtils;
import org.mozilla.gecko.util.UiAsyncTask;
@ -133,6 +134,16 @@ abstract class HomeFragment extends Fragment {
// the frequency of use for various actions.
Telemetry.sendUIEvent(TelemetryContract.Event.ACTION, TelemetryContract.Method.CONTEXT_MENU, getResources().getResourceEntryName(itemId));
if (itemId == R.id.home_copyurl) {
if (info.url == null) {
Log.e(LOGTAG, "Can't copy address because URL is null");
return false;
}
Clipboard.setText(info.url);
return true;
}
if (itemId == R.id.home_share) {
if (info.url == null) {
Log.e(LOGTAG, "Can't share because URL is null");

View File

@ -14,6 +14,9 @@
<item android:id="@+id/home_open_in_reader"
android:title="@string/contextmenu_open_in_reader"/>
<item android:id="@+id/home_copyurl"
android:title="@string/contextmenu_copyurl"/>
<item android:id="@+id/home_share"
android:title="@string/contextmenu_share"/>