Bug 888074 - Replacing single-threaded uses of StringBuffer with StringBuilder. r=rnewman

build/mobile/sutagent/android/WifiConfiguration.java

@@ -305,7 +305,7 @@ public class WifiConfiguration implements Parcelable {
     }
 
     public String toString() {
-        StringBuffer sbuf = new StringBuffer();
+        StringBuilder sbuf = new StringBuilder();
         if (this.status == WifiConfiguration.Status.CURRENT) {
             sbuf.append("* ");
         } else if (this.status == WifiConfiguration.Status.DISABLED) {

mobile/android/base/CrashReporter.java

@@ -283,7 +283,7 @@ public class CrashReporter extends Activity
             Process proc = Runtime.getRuntime().exec(new String[] {
                 "logcat", "-v", "threadtime", "-t", "200", "-d", "*:D"
             });
-            StringBuffer sb = new StringBuffer();
+            StringBuilder sb = new StringBuilder();
             br = new BufferedReader(new InputStreamReader(proc.getInputStream()));
             for (String s = br.readLine(); s != null; s = br.readLine()) {
                 sb.append(s).append('\n');
@@ -334,7 +334,7 @@ public class CrashReporter extends Activity
 
             // Add some extra information to notes so its displayed by
             // crash-stats.mozilla.org. Remove this when bug 607942 is fixed.
-            StringBuffer sb = new StringBuffer();
+            StringBuilder sb = new StringBuilder();
             sb.append(extras.containsKey(NOTES_KEY) ? extras.get(NOTES_KEY) + "\n" : "");
             if (AppConstants.MOZ_MIN_CPU_VERSION < 7) {
                 sb.append("nothumb Build\n");

mobile/android/base/GeckoEvent.java

@@ -599,7 +599,7 @@ public class GeckoEvent {
     public static GeckoEvent createViewportEvent(ImmutableViewportMetrics metrics, DisplayPortMetrics displayPort) {
         GeckoEvent event = new GeckoEvent(NativeGeckoEvent.VIEWPORT);
         event.mCharacters = "Viewport:Change";
-        StringBuffer sb = new StringBuffer(256);
+        StringBuilder sb = new StringBuilder(256);
         sb.append("{ \"x\" : ").append(metrics.viewportRectLeft)
           .append(", \"y\" : ").append(metrics.viewportRectTop)
           .append(", \"zoom\" : ").append(metrics.zoomFactor)

mobile/android/base/GeckoProfile.java

@@ -238,7 +238,7 @@ public final class GeckoProfile {
     private String readFile(File target) throws IOException {
         FileReader fr = new FileReader(target);
         try {
-            StringBuffer sb = new StringBuffer();
+            StringBuilder sb = new StringBuilder();
             char[] buf = new char[8192];
             int read = fr.read(buf);
             while (read >= 0) {
@@ -346,7 +346,7 @@ public final class GeckoProfile {
 
     private static String saltProfileName(String name) {
         String allowedChars = "abcdefghijklmnopqrstuvwxyz0123456789";
-        StringBuffer salt = new StringBuffer(16);
+        StringBuilder salt = new StringBuilder(16);
         for (int i = 0; i < 8; i++) {
             salt.append(allowedChars.charAt((int)(Math.random() * allowedChars.length())));
         }

mobile/android/base/db/LocalBrowserDB.java

@@ -758,7 +758,7 @@ public class LocalBrowserDB implements BrowserDB.BrowserDBIface {
 
     @Override
     public Cursor getFaviconsForUrls(ContentResolver cr, List<String> urls) {
-        StringBuffer selection = new StringBuffer();
+        StringBuilder selection = new StringBuilder();
         String[] selectionArgs = new String[urls.size()];
 
         for (int i = 0; i < urls.size(); i++) {
@@ -846,7 +846,7 @@ public class LocalBrowserDB implements BrowserDB.BrowserDBIface {
 
     @Override
     public Cursor getThumbnailsForUrls(ContentResolver cr, List<String> urls) {
-        StringBuffer selection = new StringBuffer();
+        StringBuilder selection = new StringBuilder();
         String[] selectionArgs = new String[urls.size()];
 
         for (int i = 0; i < urls.size(); i++) {

mobile/android/base/gfx/DisplayPortMetrics.java

@@ -56,7 +56,7 @@ public final class DisplayPortMetrics {
     }
 
     public String toJSON() {
-        StringBuffer sb = new StringBuffer(256);
+        StringBuilder sb = new StringBuilder(256);
         sb.append("{ \"left\": ").append(mPosition.left)
           .append(", \"top\": ").append(mPosition.top)
           .append(", \"right\": ").append(mPosition.right)

mobile/android/base/gfx/RectUtils.java

@@ -31,7 +31,7 @@ public final class RectUtils {
     }
 
     public static String toJSON(RectF rect) {
-        StringBuffer sb = new StringBuffer(256);
+        StringBuilder sb = new StringBuilder(256);
         sb.append("{ \"left\": ").append(rect.left)
           .append(", \"top\": ").append(rect.top)
           .append(", \"right\": ").append(rect.right)

mobile/android/base/mozglue/GeckoLoader.java.in

@@ -59,7 +59,7 @@ public final class GeckoLoader {
                 return;
             }
 
-            StringBuffer pluginSearchPath = new StringBuffer();
+            StringBuilder pluginSearchPath = new StringBuilder();
             for (int i = 0; i < pluginDirs.length; i++) {
                 pluginSearchPath.append(pluginDirs[i]);
                 pluginSearchPath.append(":");

mobile/android/base/widget/AddonsSection.java

@@ -102,7 +102,7 @@ public class AddonsSection extends AboutHomeSection {
         String str = null;
         try {
             byte[] buf = new byte[32768];
-            StringBuffer jsonString = new StringBuffer();
+            StringBuilder jsonString = new StringBuilder();
             int read = 0;
             while ((read = fileStream.read(buf, 0, 32768)) != -1)
                 jsonString.append(new String(buf, 0, read));