From fd802e39b53b76248993245cabdd41707f093138 Mon Sep 17 00:00:00 2001 From: Margaret Leibovic Date: Mon, 24 Sep 2012 14:48:21 -0700 Subject: [PATCH] Bug 789887 - Avoid creating unnecessary AboutHomeRunnables. r=lucasr --- mobile/android/base/BrowserApp.java | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/mobile/android/base/BrowserApp.java b/mobile/android/base/BrowserApp.java index 69af635e741..65e0c5bad29 100644 --- a/mobile/android/base/BrowserApp.java +++ b/mobile/android/base/BrowserApp.java @@ -51,6 +51,7 @@ abstract public class BrowserApp extends GeckoApp public static BrowserToolbar mBrowserToolbar; private AboutHomeContent mAboutHomeContent; + private boolean mAboutHomeShowing; static Vector sAddonMenuItems = new Vector(); @@ -584,17 +585,25 @@ abstract public class BrowserApp extends GeckoApp mAboutHomeContent.update(EnumSet.of(AboutHomeContent.UpdateFlags.TOP_SITES)); } - public void showAboutHome() { + private void showAboutHome() { + if (mAboutHomeShowing) + return; + + mAboutHomeShowing = true; Runnable r = new AboutHomeRunnable(true); mMainHandler.postAtFrontOfQueue(r); } - public void hideAboutHome() { + private void hideAboutHome() { + if (!mAboutHomeShowing) + return; + + mAboutHomeShowing = false; Runnable r = new AboutHomeRunnable(false); mMainHandler.postAtFrontOfQueue(r); } - public class AboutHomeRunnable implements Runnable { + private class AboutHomeRunnable implements Runnable { boolean mShow; AboutHomeRunnable(boolean show) { mShow = show;