wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 1212047 - Improve ESLint logging in case of error r=glandium

Browse Source 
Fix *all* return codes
This commit is contained in:
Michael Ratcliffe 2015-10-23 17:18:45 +01:00
parent 3075c6bc68
commit fca1eef858
1 changed files with 32 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
python/mach_commands.py
View File

@ -239,25 +239,41 @@ class MachCommands(MachCommandBase):
return 1
# Install eslint.
print("Installing eslint...")
with open(os.devnull, "w") as fnull:
subprocess.call([npmPath, "install", "eslint", "-g"],
stdout=fnull, stderr=fnull)
success = self.callProcess("eslint",
[npmPath, "install", "eslint", "-g"])
if not success:
return 1
# Install eslint-plugin-mozilla.
print("")
print("Installing eslint-plugin-mozilla...")
with open(os.devnull, "w") as fnull:
subprocess.call([npmPath, "link"],
cwd="testing/eslint-plugin-mozilla",
stdout=fnull, stderr=fnull)
success = self.callProcess("eslint-plugin-mozilla",
[npmPath, "link"],
"testing/eslint-plugin-mozilla")
if not success:
return 1
# Install eslint-plugin-react.
print("")
print("Installing eslint-plugin-react...")
with open(os.devnull, "w") as fnull:
subprocess.call([npmPath, "install", "-g", "eslint-plugin-react"],
stdout=fnull, stderr=fnull)
success = self.callProcess("eslint-plugin-react",
[npmPath, "install", "eslint-plugin-react", "-g"])
if not success:
return 1
print("\nESLint and approved plugins installed successfully!")
def callProcess(self, name, cmd, cwd=None):
print("\nInstalling %s using \"%s\"..." % (name, " ".join(cmd)))
try:
with open(os.devnull, "w") as fnull:
subprocess.check_call(cmd, cwd=cwd, stdout=fnull)
except subprocess.CalledProcessError:
if cwd:
print("\nError installing %s in the %s folder, aborting." % (name, cwd))
else:
print("\nError installing %s, aborting." % name)
return False
return True
def getPossibleNodePathsWin(self):
"""
@ -301,7 +317,7 @@ class MachCommands(MachCommandBase):
appPaths = self.getPossibleNodePathsWin()
for p in appPaths:
print(" - " + p)
print(" - %s" % p)
elif platform.system() == "Darwin":
print(" - /usr/local/bin/node")
elif platform.system() == "Linux":