From fc38f092b3628ffe77ebb94f3ca1b0fce78035c5 Mon Sep 17 00:00:00 2001 From: Mike Shal Date: Tue, 25 Nov 2014 10:43:43 -0500 Subject: [PATCH] Bug 1091668 - generate voucher on signed plugin-container; r=glandium --- python/eme/gen-eme-voucher.py | 2 +- toolkit/mozapps/installer/make-eme.mk | 5 +++-- toolkit/mozapps/installer/packager.mk | 6 +++--- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/python/eme/gen-eme-voucher.py b/python/eme/gen-eme-voucher.py index d5ef24e7d57..24d1cb8b98d 100644 --- a/python/eme/gen-eme-voucher.py +++ b/python/eme/gen-eme-voucher.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python3.3 +#!/usr/bin/env python # Copyright 2014 Adobe Systems Incorporated. All Rights Reserved. # # Adobe permits you to use, modify, and distribute this file in accordance diff --git a/toolkit/mozapps/installer/make-eme.mk b/toolkit/mozapps/installer/make-eme.mk index 462928b77f8..d3b67a4f0c3 100644 --- a/toolkit/mozapps/installer/make-eme.mk +++ b/toolkit/mozapps/installer/make-eme.mk @@ -6,7 +6,8 @@ include $(MOZILLA_DIR)/toolkit/mozapps/installer/signing.mk ifdef MOZ_SIGN_CMD ifeq ($(OS_ARCH),WINNT) - MAKE_SIGN_EME_VOUCHER := $(PYTHON) $(MOZILLA_DIR)/python/eme/gen-eme-voucher.py -input $(DIST)/bin/plugin-container.exe -output $(DIST)/$(STAGEPATH)$(MOZ_PKG_DIR)/voucher.bin && \ - $(MOZ_SIGN_CMD) -f emevoucher "$(DIST)/$(STAGEPATH)$(MOZ_PKG_DIR)/voucher.bin" + # Note: CWD is DIST + MAKE_SIGN_EME_VOUCHER := $(PYTHON) $(MOZILLA_DIR)/python/eme/gen-eme-voucher.py -input $(STAGEPATH)$(MOZ_PKG_DIR)/plugin-container.exe -output $(STAGEPATH)$(MOZ_PKG_DIR)/voucher.bin && \ + $(MOZ_SIGN_CMD) -f emevoucher "$(STAGEPATH)$(MOZ_PKG_DIR)/voucher.bin" endif endif diff --git a/toolkit/mozapps/installer/packager.mk b/toolkit/mozapps/installer/packager.mk index 455eb5b6d5a..eef656c9994 100644 --- a/toolkit/mozapps/installer/packager.mk +++ b/toolkit/mozapps/installer/packager.mk @@ -541,8 +541,9 @@ MAKE_PACKAGE = cd ./$(PKG_DMG_SOURCE) && $(MOZ_SIGN_PREPARED_PACKAGE_CMD) $(M && cd $(PACKAGE_BASE_DIR) \ && $(INNER_MAKE_PACKAGE) else -MAKE_PACKAGE = $(MOZ_SIGN_PREPARED_PACKAGE_CMD) \ - $(MOZ_PKG_DIR) && $(INNER_MAKE_PACKAGE) +MAKE_PACKAGE = $(MOZ_SIGN_PREPARED_PACKAGE_CMD) $(MOZ_PKG_DIR) \ + && $(or $(MAKE_SIGN_EME_VOUCHER),true) \ + && $(INNER_MAKE_PACKAGE) endif #Darwin else @@ -709,7 +710,6 @@ stage-package: $(MOZ_PKG_MANIFEST) $(MOZ_PKG_MANIFEST) $(DIST) $(DIST)/$(STAGEPATH)$(MOZ_PKG_DIR)$(if $(MOZ_PKG_MANIFEST),,$(_BINPATH)) \ $(if $(filter omni,$(MOZ_PACKAGER_FORMAT)),$(if $(NON_OMNIJAR_FILES),--non-resource $(NON_OMNIJAR_FILES))) $(PYTHON) $(MOZILLA_DIR)/toolkit/mozapps/installer/find-dupes.py $(DIST)/$(STAGEPATH)$(MOZ_PKG_DIR) - $(MAKE_SIGN_EME_VOUCHER) ifndef LIBXUL_SDK ifdef MOZ_PACKAGE_JSSHELL # Package JavaScript Shell