Bug 1122032 Part 3 - Automatically allow screensharing for the Loop in-desktop pages. r=jesup

browser/base/content/test/general/browser_devices_get_user_media_about_urls.js

@@ -22,6 +22,37 @@ XPCOMUtils.defineLazyServiceGetter(this, "MediaManagerService",
 
 var gTab;
 
+// Taken from dom/media/tests/mochitest/head.js
+function isMacOSX10_6orOlder() {
+  var is106orOlder = false;
+
+  if (navigator.platform.indexOf("Mac") == 0) {
+    var version = Cc["@mozilla.org/system-info;1"]
+                    .getService(Ci.nsIPropertyBag2)
+                    .getProperty("version");
+    // the next line is correct: Mac OS 10.6 corresponds to Darwin version 10.x !
+    // Mac OS 10.7 is Darwin version 11.x. the |version| string we've got here
+    // is the Darwin version.
+    is106orOlder = (parseFloat(version) < 11.0);
+  }
+  return is106orOlder;
+}
+
+// Screensharing is disabled on older platforms (WinXP and Mac 10.6).
+function isOldPlatform() {
+  const isWinXP = navigator.userAgent.indexOf("Windows NT 5.1") != -1;
+  if (isMacOSX10_6orOlder() || isWinXP) {
+    info(true, "Screensharing disabled for OSX10.6 and WinXP");
+    return true;
+  }
+  return false;
+}
+
+// Linux prompts aren't working for screensharing.
+function isLinux() {
+  return navigator.platform.indexOf("Linux") != -1;
+}
+
 var gObservedTopics = {};
 function observer(aSubject, aTopic, aData) {
   if (!(aTopic in gObservedTopics))
@@ -97,16 +128,41 @@ function expectNoObserverCalled() {
   gObservedTopics = {};
 }
 
+function promiseMessage(aMessage, aAction) {
+  let deferred = Promise.defer();
+
+  content.addEventListener("message", function messageListener(event) {
+    content.removeEventListener("message", messageListener);
+    is(event.data, aMessage, "received " + aMessage);
+    if (event.data == aMessage)
+      deferred.resolve();
+    else
+      deferred.reject();
+  });
+
+  if (aAction)
+    aAction();
+
+  return deferred.promise;
+}
+
 function getMediaCaptureState() {
   let hasVideo = {};
   let hasAudio = {};
-  MediaManagerService.mediaCaptureWindowState(content, hasVideo, hasAudio);
+  let hasScreenShare = {};
+  let hasWindowShare = {};
+  MediaManagerService.mediaCaptureWindowState(content, hasVideo, hasAudio,
+                                              hasScreenShare, hasWindowShare);
   if (hasVideo.value && hasAudio.value)
     return "CameraAndMicrophone";
   if (hasVideo.value)
     return "Camera";
   if (hasAudio.value)
     return "Microphone";
+  if (hasScreenShare)
+    return "Screen";
+  if (hasWindowShare)
+    return "Window";
   return "none";
 }
 
@@ -173,6 +229,7 @@ registerCleanupFunction(function() {
   Services.prefs.setCharPref(PREF_LOOP_CSP, originalLoopCsp);
 });
 
+const permissionError = "error: PermissionDeniedError: The user did not grant permission for the operation.";
 
 let gTests = [
 
@@ -207,6 +264,46 @@ let gTests = [
   }
 },
 
+{
+  desc: "getUserMedia about:loopconversation should prompt for window sharing",
+  run: function checkShareScreenLoop() {
+    if (isOldPlatform() || isLinux()) {
+      return;
+    }
+
+    Services.prefs.setCharPref(PREF_LOOP_CSP, "default-src 'unsafe-inline'");
+
+    let classID = Cc["@mozilla.org/uuid-generator;1"]
+                    .getService(Ci.nsIUUIDGenerator).generateUUID();
+    registrar.registerFactory(classID, "",
+                              "@mozilla.org/network/protocol/about;1?what=loopconversation",
+                              factory);
+
+    yield loadPage("about:loopconversation");
+
+    yield promiseObserverCalled("getUserMedia:request", () => {
+      info("requesting screen");
+      content.wrappedJSObject.requestDevice(false, true, "window");
+    });
+    // Wait for the devices to actually be captured and running before
+    // proceeding.
+    yield promisePopupNotification("webRTC-shareDevices");
+
+    isnot(getMediaCaptureState(), "Window",
+       "expected camera and microphone not to be shared");
+
+    yield promiseMessage(permissionError, () => {
+      PopupNotifications.panel.firstChild.button.click();
+    });
+
+    expectObserverCalled("getUserMedia:response:deny");
+    expectObserverCalled("recording-window-ended");
+
+    registrar.unregisterFactory(classID, factory);
+    Services.prefs.setCharPref(PREF_LOOP_CSP, originalLoopCsp);
+  }
+},
+
 {
   desc: "getUserMedia about:evil should prompt",
   run: function checkAudioVideoNonLoop() {
@@ -236,6 +333,8 @@ function test() {
   waitForExplicitFinish();
 
   Services.prefs.setBoolPref(PREF_PERMISSION_FAKE, true);
+  // Ensure this is always true
+  Services.prefs.setBoolPref("media.getusermedia.screensharing.enabled", true);
 
   gTab = gBrowser.addTab();
   gBrowser.selectedTab = gTab;

browser/base/content/test/general/get_user_media.html

@@ -24,11 +24,17 @@ function message(m) {
 
 var gStream;
 
-function requestDevice(aAudio, aVideo) {
+function requestDevice(aAudio, aVideo, aShare) {
   var opts = {video: aVideo, audio: aAudio};
-  if (useFakeStreams) {
+  if (aShare) {
+    opts.video = {
+      mozMediaSource: aShare,
+      mediaSource: aShare
+    }
+  } else if (useFakeStreams) {
     opts.fake = true;
   }
+
   window.navigator.mozGetUserMedia(opts, function(stream) {
     gStream = stream;
     message("ok");

dom/media/MediaManager.cpp

@@ -1683,6 +1683,18 @@ MediaManager::GetUserMedia(
 
   nsIURI* docURI = aWindow->GetDocumentURI();
 
+  bool isLoop = false;
+  nsCOMPtr<nsIURI> loopURI;
+  nsresult rv = NS_NewURI(getter_AddRefs(loopURI), "about:loopconversation");
+  NS_ENSURE_SUCCESS(rv, rv);
+  rv = docURI->EqualsExceptRef(loopURI, &isLoop);
+  NS_ENSURE_SUCCESS(rv, rv);
+
+  if (isLoop) {
+    privileged = true;
+  }
+
+
   if (c.mVideo.IsMediaTrackConstraints()) {
     auto& tc = c.mVideo.GetAsMediaTrackConstraints();
     MediaSourceEnum src = StringToEnum(dom::MediaSourceEnumValues::strings,
@@ -1725,6 +1737,17 @@ MediaManager::GetUserMedia(
     default:
       return task->Denied(NS_LITERAL_STRING("NotFoundError"));
     }
+
+    // For all but tab sharing, Loop needs to prompt as we are using the
+    // permission menu for selection of the device currently. For tab sharing,
+    // Loop has implicit permissions within Firefox, as it is built-in,
+    // and will manage the active tab and provide appropriate UI.
+    if (isLoop &&
+        (src == dom::MediaSourceEnum::Window ||
+         src == dom::MediaSourceEnum::Application ||
+         src == dom::MediaSourceEnum::Screen)) {
+       privileged = false;
+    }
   }
 
 #ifdef MOZ_B2G_CAMERA
@@ -1733,17 +1756,6 @@ MediaManager::GetUserMedia(
   }
 #endif
 
-  bool isLoop = false;
-  nsCOMPtr<nsIURI> loopURI;
-  nsresult rv = NS_NewURI(getter_AddRefs(loopURI), "about:loopconversation");
-  NS_ENSURE_SUCCESS(rv, rv);
-  rv = docURI->EqualsExceptRef(loopURI, &isLoop);
-  NS_ENSURE_SUCCESS(rv, rv);
-
-  if (isLoop) {
-    privileged = true;
-  }
-
   // XXX No full support for picture in Desktop yet (needs proper UI)
   if (privileged ||
       (c.mFake && !Preferences::GetBool("media.navigator.permission.fake"))) {