Bug 1038465: Pass suggested filename to application reputation query (r=paolo)

This commit is contained in:
Monica Chew 2014-07-15 13:46:52 -07:00
parent 43d570fd95
commit f6c97ae996
3 changed files with 6 additions and 0 deletions

View File

@ -82,6 +82,7 @@ user_pref("urlclassifier.updateinterval", 172800);
// Point the url-classifier to the local testing server for fast failures
user_pref("browser.safebrowsing.gethashURL", "http://%(server)s/safebrowsing-dummy/gethash");
user_pref("browser.safebrowsing.updateURL", "http://%(server)s/safebrowsing-dummy/update");
user_pref("browser.safebrowsing.appRepURL", "http://%(server)s/safebrowsing-dummy/update");
// Point update checks to the local testing server for fast failures
user_pref("extensions.update.url", "http://%(server)s/extensions-dummy/updateURL");
user_pref("extensions.update.background.url", "http://%(server)s/extensions-dummy/updateBackgroundURL");

View File

@ -361,8 +361,11 @@ PendingLookup::IsBinaryFile()
nsString fileName;
nsresult rv = mQuery->GetSuggestedFileName(fileName);
if (NS_FAILED(rv)) {
LOG(("No suggested filename [this = %p]", this));
return false;
}
LOG(("Suggested filename: %s [this = %p]",
NS_ConvertUTF16toUTF8(fileName).get(), this));
return
// Executable extensions for MS Windows, from
// https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/safe_browsing/download_protection_util.cc&l=14

View File

@ -517,11 +517,13 @@ this.DownloadIntegration = {
if (aDownload.source.referrer) {
aReferrer: NetUtil.newURI(aDownload.source.referrer);
}
let aSuggestedFileName = OS.Path.basename(aDownload.target.path);
gApplicationReputationService.queryReputation({
sourceURI: NetUtil.newURI(aDownload.source.url),
referrerURI: aReferrer,
fileSize: aDownload.currentBytes,
sha256Hash: hash,
suggestedFileName: aSuggestedFileName,
signatureInfo: sigInfo,
redirects: channelRedirects },
function onComplete(aShouldBlock, aRv) {