diff --git a/mobile/android/base/resources/layout/fxaccount_account_verified.xml b/mobile/android/base/resources/layout/fxaccount_account_verified.xml index 8f5bb9ba81e..c72d58cbefb 100644 --- a/mobile/android/base/resources/layout/fxaccount_account_verified.xml +++ b/mobile/android/base/resources/layout/fxaccount_account_verified.xml @@ -5,8 +5,8 @@ - file, You can obtain one at http://mozilla.org/MPL/2.0/. --> diff --git a/mobile/android/base/resources/layout/fxaccount_confirm_account.xml b/mobile/android/base/resources/layout/fxaccount_confirm_account.xml index 51dc32db23b..daf10a90b20 100644 --- a/mobile/android/base/resources/layout/fxaccount_confirm_account.xml +++ b/mobile/android/base/resources/layout/fxaccount_confirm_account.xml @@ -5,8 +5,8 @@ - file, You can obtain one at http://mozilla.org/MPL/2.0/. --> diff --git a/mobile/android/base/resources/layout/fxaccount_create_account.xml b/mobile/android/base/resources/layout/fxaccount_create_account.xml index ddc3e285749..f56dae6b68d 100644 --- a/mobile/android/base/resources/layout/fxaccount_create_account.xml +++ b/mobile/android/base/resources/layout/fxaccount_create_account.xml @@ -6,8 +6,8 @@ --> @@ -25,14 +25,14 @@ @@ -74,7 +74,7 @@ diff --git a/mobile/android/base/resources/layout/fxaccount_get_started.xml b/mobile/android/base/resources/layout/fxaccount_get_started.xml index be6ec0c03e8..e40c70cb0bf 100644 --- a/mobile/android/base/resources/layout/fxaccount_get_started.xml +++ b/mobile/android/base/resources/layout/fxaccount_get_started.xml @@ -5,8 +5,8 @@ - file, You can obtain one at http://mozilla.org/MPL/2.0/. --> diff --git a/mobile/android/base/resources/layout/fxaccount_status_error_preference.xml b/mobile/android/base/resources/layout/fxaccount_status_error_preference.xml index a54187d7628..8d1bddd8e39 100644 --- a/mobile/android/base/resources/layout/fxaccount_status_error_preference.xml +++ b/mobile/android/base/resources/layout/fxaccount_status_error_preference.xml @@ -1,6 +1,6 @@ diff --git a/mobile/android/base/resources/layout/fxaccount_update_credentials.xml b/mobile/android/base/resources/layout/fxaccount_update_credentials.xml index 3736d7cf2ce..4b40586d569 100644 --- a/mobile/android/base/resources/layout/fxaccount_update_credentials.xml +++ b/mobile/android/base/resources/layout/fxaccount_update_credentials.xml @@ -6,8 +6,8 @@ --> diff --git a/mobile/android/base/resources/layout/sync_setup_jpake_waiting.xml b/mobile/android/base/resources/layout/sync_setup_jpake_waiting.xml index 7e32c5a0f8e..5e94574c96e 100644 --- a/mobile/android/base/resources/layout/sync_setup_jpake_waiting.xml +++ b/mobile/android/base/resources/layout/sync_setup_jpake_waiting.xml @@ -19,7 +19,7 @@ diff --git a/mobile/android/base/resources/layout/sync_setup_webview.xml b/mobile/android/base/resources/layout/sync_setup_webview.xml index 7abcc6d7242..9fa6dfb68e5 100644 --- a/mobile/android/base/resources/layout/sync_setup_webview.xml +++ b/mobile/android/base/resources/layout/sync_setup_webview.xml @@ -6,6 +6,6 @@ + android:layout_width="fill_parent" + android:layout_height="fill_parent" /> diff --git a/mobile/android/base/resources/values-v11/sync_styles.xml b/mobile/android/base/resources/values-v11/sync_styles.xml index edd695864c8..1bf21ca5477 100644 --- a/mobile/android/base/resources/values-v11/sync_styles.xml +++ b/mobile/android/base/resources/values-v11/sync_styles.xml @@ -7,7 +7,7 @@ @@ -39,7 +39,7 @@ @@ -81,7 +81,7 @@ true @color/fxaccount_linkified_textColor @color/fxaccount_linkified_textColorLink - match_parent + fill_parent wrap_content center @@ -95,7 +95,7 @@ @@ -44,7 +44,7 @@ diff --git a/mobile/android/base/sync/SyncConfiguration.java b/mobile/android/base/sync/SyncConfiguration.java index 83c5d156257..80c68a3fe9a 100644 --- a/mobile/android/base/sync/SyncConfiguration.java +++ b/mobile/android/base/sync/SyncConfiguration.java @@ -472,7 +472,7 @@ public class SyncConfiguration { } else { edit.putString(PREF_ENABLED_ENGINE_NAMES, setToJSONObjectString(enabledEngineNames)); } - if (declinedEngineNames.isEmpty()) { + if (declinedEngineNames == null || declinedEngineNames.isEmpty()) { edit.remove(PREF_DECLINED_ENGINE_NAMES); } else { edit.putString(PREF_DECLINED_ENGINE_NAMES, setToJSONObjectString(declinedEngineNames)); diff --git a/mobile/android/base/sync/jpake/stage/DecryptDataStage.java b/mobile/android/base/sync/jpake/stage/DecryptDataStage.java index 5e2bed93a9d..f2679b21a19 100644 --- a/mobile/android/base/sync/jpake/stage/DecryptDataStage.java +++ b/mobile/android/base/sync/jpake/stage/DecryptDataStage.java @@ -44,7 +44,7 @@ public class DecryptDataStage extends JPakeStage { Logger.debug(LOG_TAG, "Decrypting data."); String cleartext = null; try { - cleartext = new String(decryptPayload(iPayload, jClient.myKeyBundle), "UTF-8"); + cleartext = new String(decryptPayload(iPayload, jClient.myKeyBundle), "UTF-8"); } catch (UnsupportedEncodingException e) { Logger.error(LOG_TAG, "Failed to decrypt data.", e); jClient.abort(Constants.JPAKE_ERROR_INTERNAL); diff --git a/mobile/android/tests/background/junit3/res/layout/main.xml b/mobile/android/tests/background/junit3/res/layout/main.xml index db8893bd9ce..14dbff7e057 100644 --- a/mobile/android/tests/background/junit3/res/layout/main.xml +++ b/mobile/android/tests/background/junit3/res/layout/main.xml @@ -1,11 +1,11 @@ diff --git a/mobile/android/tests/background/junit3/src/sync/TestSyncConfiguration.java b/mobile/android/tests/background/junit3/src/sync/TestSyncConfiguration.java index 327660a94a1..389aaf8915b 100644 --- a/mobile/android/tests/background/junit3/src/sync/TestSyncConfiguration.java +++ b/mobile/android/tests/background/junit3/src/sync/TestSyncConfiguration.java @@ -44,7 +44,8 @@ public class TestSyncConfiguration extends AndroidSyncTestCase { config.persistToPrefs(); assertFalse(prefs.contains(SyncConfiguration.PREF_DECLINED_ENGINE_NAMES)); config = newSyncConfiguration(); - assertNull(config.declinedEngineNames); + assertNotNull(config.declinedEngineNames); + assertTrue(config.declinedEngineNames.isEmpty()); } public void testEnabledEngineNames() {