Bug 1068671 - Fix review comment (comment 15 on the bug) and a couple of typos. r=mak

This commit is contained in:
Asaf Romano 2014-10-01 12:59:11 +03:00
parent 6860a7fd03
commit f4eb33eb12
2 changed files with 3 additions and 3 deletions

View File

@ -107,7 +107,7 @@
let tagName = PlacesUtils.nodeIsTagQuery(elt._placesNode) ?
elt._placesNode.title : null;
if ((PlacesUtils.nodeIsFolder(elt._placesNode) &&
!PlacesUIUtils.isContentsReadOnly(elt._placesNode) ||
!PlacesUIUtils.isContentsReadOnly(elt._placesNode)) ||
PlacesUtils.nodeIsTagQuery(elt._placesNode)) {
// This is a folder or a tag container.
if (eventY - eltY < eltHeight * 0.20) {

View File

@ -1674,9 +1674,9 @@ PlacesTreeView.prototype = {
if (PlacesUtils.nodeIsSeparator(node) || PlacesUtils.isRootItem(itemId))
return false;
let parentId = node.parent.itemId;
let parentId = PlacesUtils.getConcreteItemId(node.parent);
if (parentId == PlacesUIUtils.leftPaneFolderId ||
parentId == PlacesUIUtils.allBallBookmarksFolderId) {
parentId == PlacesUIUtils.allBookmarksFolderId) {
// Note that the for the time being this is the check that actually
// blocks renaming places "roots", and not the isRootItem check above.
// That's because places root are only exposed through folder shortcuts