Bug 993580 - Permanently fix webconsole error count test and temporarily fix box model tests. r=pbrosset

This commit is contained in:
Girish Sharma 2014-04-10 02:30:01 +05:30
parent 03d14c1c41
commit f3707ea5e5
6 changed files with 15 additions and 9 deletions

View File

@ -317,7 +317,7 @@ DevTools.prototype = {
closeToolbox: function DT_closeToolbox(target) {
let toolbox = this._toolboxes.get(target);
if (toolbox == null) {
return;
return promise.reject(null);
}
return toolbox.destroy();
},

View File

@ -22,7 +22,8 @@ let test = asyncTest(function*() {
inspector.sidebar.select("layoutview");
yield inspector.sidebar.once("layoutview-ready");
yield runTests();
yield gDevTools.closeToolbox(toolbox);
// TODO: Closing the toolbox in this test leaks - bug 994314
// yield gDevTools.closeToolbox(target);
});
addTest("Test that editing margin dynamically updates the document, pressing escape cancels the changes",

View File

@ -1,3 +1,4 @@
/* Any copyright is dedicated to the Public Domain.
http://creativecommons.org/publicdomain/zero/1.0/ */
@ -22,7 +23,8 @@ let test = asyncTest(function*() {
inspector.sidebar.select("layoutview");
yield inspector.sidebar.once("layoutview-ready");
yield runTests();
yield gDevTools.closeToolbox(toolbox);
// TODO: Closing the toolbox in this test leaks - bug 994314
// yield gDevTools.closeToolbox(target);
});
addTest("When all properties are set on the node editing one should work",

View File

@ -22,7 +22,8 @@ let test = asyncTest(function*() {
inspector.sidebar.select("layoutview");
yield inspector.sidebar.once("layoutview-ready");
yield runTests();
yield gDevTools.closeToolbox(toolbox);
// TODO: Closing the toolbox in this test leaks - bug 994314
// yield gDevTools.closeToolbox(target);
});
addTest("Test that adding a border applies a border style when necessary",

View File

@ -22,7 +22,8 @@ let test = asyncTest(function*() {
inspector.sidebar.select("layoutview");
yield inspector.sidebar.once("layoutview-ready");
yield runTests();
yield gDevTools.closeToolbox(toolbox);
// TODO: Closing the toolbox in this test leaks - bug 994314
// yield gDevTools.closeToolbox(target);
});
addTest("Test that entering units works",

View File

@ -193,10 +193,11 @@ function test() {
function testEnd() {
document.getElementById("developer-toolbar-closebutton").doCommand();
let target1 = TargetFactory.forTab(tab1);
gDevTools.closeToolbox(target1);
gBrowser.removeTab(tab1);
gBrowser.removeTab(tab2);
finish();
gDevTools.closeToolbox(target1).then(() => {
gBrowser.removeTab(tab1);
gBrowser.removeTab(tab2);
finish();
});
}
// Utility functions