From f2f92c69fe17f09828c7563c81fdfcf7ef8f88eb Mon Sep 17 00:00:00 2001 From: Nathan Froyd Date: Tue, 25 Oct 2016 10:26:31 -0400 Subject: [PATCH] Bug 1312543 - remove bogus comparison in ia2Accessible.cpp; r=surkov This comparison is confused, as aNRanges is an out argument; we only care about non-nullness of the pointer. Additionally, recent versions of clang consider non-equality comparisons with pointer types an error. MozReview-Commit-ID: 8lXeCwP6Lz6 --- accessible/windows/ia2/ia2Accessible.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accessible/windows/ia2/ia2Accessible.cpp b/accessible/windows/ia2/ia2Accessible.cpp index ec17b47e222..fed74cb5f95 100644 --- a/accessible/windows/ia2/ia2Accessible.cpp +++ b/accessible/windows/ia2/ia2Accessible.cpp @@ -759,7 +759,7 @@ ia2Accessible::get_selectionRanges(IA2Range** aRanges, { A11Y_TRYBLOCK_BEGIN - if (!aRanges || !aNRanges || aNRanges <= 0) + if (!aRanges || !aNRanges) return E_INVALIDARG; *aNRanges = 0;