wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 971272 - Post: Add informational test showing unnecessary directories may be created. r=gps

Browse Source
This commit is contained in:
Nick Alexander 2014-02-13 09:09:09 -08:00
parent d022342df3
commit f1b0cc2217
1 changed files with 31 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
python/mozbuild/mozpack/test/test_copier.py
View File

@ -8,7 +8,10 @@ from mozpack.copier import (
FileRegistry,
Jarrer,
)
from mozpack.files import GeneratedFile
from mozpack.files import (
GeneratedFile,
ExistingFile,
)
from mozpack.mozjar import JarReader
import mozpack.path
import unittest
@ -283,6 +286,33 @@ class TestFileCopier(TestWithTmpDir):
self.assertEqual(result.removed_files, set())
self.assertEqual(result.removed_directories, set())
def test_optional_exists_creates_unneeded_directory(self):
"""Demonstrate that a directory not strictly required, but specified
as the path to an optional file, will be unnecessarily created.
This behaviour is wrong; fixing it is tracked by Bug 972432;
and this test exists to guard against unexpected changes in
behaviour.
"""
dest = self.tmppath('dest')
copier = FileCopier()
copier.add('foo/bar', ExistingFile(required=False))
result = copier.copy(dest)
st = os.lstat(self.tmppath('dest/foo'))
self.assertFalse(stat.S_ISLNK(st.st_mode))
self.assertTrue(stat.S_ISDIR(st.st_mode))
# What's worse, we have no record that dest was created.
self.assertEquals(len(result.updated_files), 0)
# But we do have an erroneous record of an optional file
# existing when it does not.
self.assertIn(self.tmppath('dest/foo/bar'), result.existing_files)
class TestFilePurger(TestWithTmpDir):
def test_file_purger(self):