Bug 960774: Add ActorDestroy impl for all parent-side actors that don't have one. It will be required soon. r=bent

2024-09-13 09:24:08 -07:00 · 2014-05-02 13:44:13 -05:00 · 2014-05-02 13:44:13 -05:00 · f00583cc36
commit f00583cc36
parent ed6788888b
40 changed files with 181 additions and 2 deletions
--- a/content/canvas/public/DocumentRendererParent.h
+++ b/content/canvas/public/DocumentRendererParent.h
@ -26,8 +26,10 @@ public:
    void DrawToCanvas(const nsIntSize& renderedSize,
 		      const nsCString& aData);

+    virtual void ActorDestroy(ActorDestroyReason aWhy) MOZ_OVERRIDE;
+
    virtual bool Recv__delete__(const nsIntSize& renderedSize,
-                                const nsCString& data);
+                                const nsCString& data) MOZ_OVERRIDE;

 private:
    nsCOMPtr<nsICanvasRenderingContextInternal> mCanvas;
--- a/content/canvas/src/DocumentRendererParent.cpp
+++ b/content/canvas/src/DocumentRendererParent.cpp
@ -48,6 +48,12 @@ void DocumentRendererParent::DrawToCanvas(const nsIntSize& aSize,
    mCanvas->Redraw(damageRect);
 }

+void
+DocumentRendererParent::ActorDestroy(ActorDestroyReason aWhy)
+{
+  // Implement me! Bug 1005139
+}
+
 bool
 DocumentRendererParent::Recv__delete__(const nsIntSize& renderedSize,
                                       const nsCString& data)
--- a/content/media/webspeech/synth/ipc/SpeechSynthesisParent.cpp
+++ b/content/media/webspeech/synth/ipc/SpeechSynthesisParent.cpp
@ -18,6 +18,12 @@ SpeechSynthesisParent::~SpeechSynthesisParent()
  MOZ_COUNT_DTOR(SpeechSynthesisParent);
 }

+void
+SpeechSynthesisParent::ActorDestroy(ActorDestroyReason aWhy)
+{
+  // Implement me! Bug 1005141
+}
+
 bool
 SpeechSynthesisParent::RecvReadVoiceList(InfallibleTArray<RemoteVoice>* aVoices,
                                         InfallibleTArray<nsString>* aDefaults)
@ -81,6 +87,12 @@ SpeechSynthesisRequestParent::~SpeechSynthesisRequestParent()
  MOZ_COUNT_DTOR(SpeechSynthesisRequestParent);
 }

+void
+SpeechSynthesisRequestParent::ActorDestroy(ActorDestroyReason aWhy)
+{
+  // Implement me! Bug 1005141
+}
+
 bool
 SpeechSynthesisRequestParent::RecvPause()
 {
--- a/content/media/webspeech/synth/ipc/SpeechSynthesisParent.h
+++ b/content/media/webspeech/synth/ipc/SpeechSynthesisParent.h
@ -22,6 +22,8 @@ class SpeechSynthesisParent : public PSpeechSynthesisParent
  friend class SpeechSynthesisRequestParent;

 public:
+  virtual void ActorDestroy(ActorDestroyReason aWhy) MOZ_OVERRIDE;
+
  bool RecvReadVoiceList(InfallibleTArray<RemoteVoice>* aVoices,
                         InfallibleTArray<nsString>* aDefaults) MOZ_OVERRIDE;

@ -57,6 +59,8 @@ public:

 protected:

+  virtual void ActorDestroy(ActorDestroyReason aWhy) MOZ_OVERRIDE;
+
  virtual bool RecvPause() MOZ_OVERRIDE;

  virtual bool RecvResume() MOZ_OVERRIDE;
--- a/dom/fmradio/ipc/FMRadioParent.cpp
+++ b/dom/fmradio/ipc/FMRadioParent.cpp
@ -25,6 +25,12 @@ FMRadioParent::~FMRadioParent()
  IFMRadioService::Singleton()->RemoveObserver(this);
 }

+void
+FMRadioParent::ActorDestroy(ActorDestroyReason aWhy)
+{
+  // Implement me! Bug 1005146
+}
+
 bool
 FMRadioParent::RecvGetStatusInfo(StatusInfo* aStatusInfo)
 {
--- a/dom/fmradio/ipc/FMRadioParent.h
+++ b/dom/fmradio/ipc/FMRadioParent.h
@ -22,6 +22,9 @@ public:
  FMRadioParent();
  ~FMRadioParent();

+  virtual void
+  ActorDestroy(ActorDestroyReason aWhy) MOZ_OVERRIDE;
+
  virtual bool
  RecvGetStatusInfo(StatusInfo* aStatusInfo) MOZ_OVERRIDE;

--- a/dom/indexedDB/ipc/IndexedDBParent.cpp
+++ b/dom/indexedDB/ipc/IndexedDBParent.cpp
@ -2219,6 +2219,12 @@ IndexedDBDeleteDatabaseRequestParent::HandleEvent(nsIDOMEvent* aEvent)
  return NS_OK;
 }

+void
+IndexedDBDeleteDatabaseRequestParent::ActorDestroy(ActorDestroyReason aWhy)
+{
+  // Implement me! Bug 1005149
+}
+
 nsresult
 IndexedDBDeleteDatabaseRequestParent::SetOpenRequest(
                                                 IDBOpenDBRequest* aOpenRequest)
--- a/dom/indexedDB/ipc/IndexedDBParent.h
+++ b/dom/indexedDB/ipc/IndexedDBParent.h
@ -863,6 +863,8 @@ protected:
  IndexedDBDeleteDatabaseRequestParent(IDBFactory* aFactory);
  virtual ~IndexedDBDeleteDatabaseRequestParent();

+  virtual void ActorDestroy(ActorDestroyReason aWhy) MOZ_OVERRIDE;
+
  nsresult
  SetOpenRequest(IDBOpenDBRequest* aOpenRequest);

--- a/dom/ipc/Blob.cpp
+++ b/dom/ipc/Blob.cpp
@ -474,6 +474,9 @@ public:
    MOZ_ASSERT(NS_IsMainThread());
  }

+protected:
+  virtual void ActorDestroy(ActorDestroyReason aWhy) MOZ_OVERRIDE;
+
 private:
  // This method is only called by the IPDL message machinery.
  virtual bool
@ -2160,6 +2163,12 @@ InputStreamChild::Recv__delete__(const InputStreamParams& aParams,
  return true;
 }

+void
+InputStreamParent::ActorDestroy(ActorDestroyReason aWhy)
+{
+  // Implement me! Bug 1005150
+}
+
 bool
 InputStreamParent::Recv__delete__(const InputStreamParams& aParams,
                                  const OptionalFileDescriptorSet& aFDs)
--- a/dom/ipc/ContentParent.cpp
+++ b/dom/ipc/ContentParent.cpp
@ -309,6 +309,8 @@ public:
    MemoryReportRequestParent();
    virtual ~MemoryReportRequestParent();

+    virtual void ActorDestroy(ActorDestroyReason aWhy) MOZ_OVERRIDE;
+
    virtual bool Recv__delete__(const uint32_t& generation, const InfallibleTArray<MemoryReport>& report);
 private:
    ContentParent* Owner()
@ -322,6 +324,12 @@ MemoryReportRequestParent::MemoryReportRequestParent()
    MOZ_COUNT_CTOR(MemoryReportRequestParent);
 }

+void
+MemoryReportRequestParent::ActorDestroy(ActorDestroyReason aWhy)
+{
+  // Implement me! Bug 1005154
+}
+
 bool
 MemoryReportRequestParent::Recv__delete__(const uint32_t& generation, const InfallibleTArray<MemoryReport>& childReports)
 {
--- a/dom/ipc/CrashReporterParent.cpp
+++ b/dom/ipc/CrashReporterParent.cpp
@ -26,6 +26,12 @@ CrashReporterParent::AnnotateCrashReport(const nsCString& key,
 #endif
 }

+void
+CrashReporterParent::ActorDestroy(ActorDestroyReason aWhy)
+{
+  // Implement me! Bug 1005155
+}
+
 bool
 CrashReporterParent::RecvAppendAppNotes(const nsCString& data)
 {
--- a/dom/ipc/CrashReporterParent.h
+++ b/dom/ipc/CrashReporterParent.h
@ -77,6 +77,8 @@ public:
  AnnotateCrashReport(const nsCString& key, const nsCString& data);

 protected:
+  virtual void ActorDestroy(ActorDestroyReason aWhy) MOZ_OVERRIDE;
+
  virtual bool
    RecvAnnotateCrashReport(const nsCString& key, const nsCString& data) MOZ_OVERRIDE {
    AnnotateCrashReport(key, data);
--- a/dom/ipc/FileDescriptorSetParent.cpp
+++ b/dom/ipc/FileDescriptorSetParent.cpp
@ -27,6 +27,12 @@ FileDescriptorSetParent::ForgetFileDescriptors(
  mFileDescriptors.SwapElements(aFileDescriptors);
 }

+void
+FileDescriptorSetParent::ActorDestroy(ActorDestroyReason aWhy)
+{
+  // Implement me! Bug 1005157
+}
+
 bool
 FileDescriptorSetParent::RecvAddFileDescriptor(
                                          const FileDescriptor& aFileDescriptor)
--- a/dom/ipc/FileDescriptorSetParent.h
+++ b/dom/ipc/FileDescriptorSetParent.h
@ -36,6 +36,8 @@ private:
  FileDescriptorSetParent(const FileDescriptor& aFileDescriptor);
  ~FileDescriptorSetParent();

+  virtual void ActorDestroy(ActorDestroyReason aWhy) MOZ_OVERRIDE;
+
  virtual bool
  RecvAddFileDescriptor(const FileDescriptor& aFileDescriptor) MOZ_OVERRIDE;

--- a/dom/plugins/ipc/BrowserStreamParent.cpp
+++ b/dom/plugins/ipc/BrowserStreamParent.cpp
@ -30,6 +30,12 @@ BrowserStreamParent::~BrowserStreamParent()
 {
 }

+void
+BrowserStreamParent::ActorDestroy(ActorDestroyReason aWhy)
+{
+  // Implement me! Bug 1005159
+}
+
 bool
 BrowserStreamParent::AnswerNPN_RequestRead(const IPCByteRanges& ranges,
                                           NPError* result)
--- a/dom/plugins/ipc/BrowserStreamParent.h
+++ b/dom/plugins/ipc/BrowserStreamParent.h
@ -26,6 +26,8 @@ public:

  virtual bool IsBrowserStream() MOZ_OVERRIDE { return true; }

+  virtual void ActorDestroy(ActorDestroyReason aWhy) MOZ_OVERRIDE;
+
  virtual bool AnswerNPN_RequestRead(const IPCByteRanges& ranges,
                                     NPError* result) MOZ_OVERRIDE;

--- a/dom/plugins/ipc/PluginIdentifierParent.cpp
+++ b/dom/plugins/ipc/PluginIdentifierParent.cpp
@ -17,6 +17,12 @@ using namespace mozilla::plugins::parent;
 namespace mozilla {
 namespace plugins {

+void
+PluginIdentifierParent::ActorDestroy(ActorDestroyReason aWhy)
+{
+  // Implement me! Bug 1005161
+}
+
 bool
 PluginIdentifierParent::RecvRetain()
 {
--- a/dom/plugins/ipc/PluginIdentifierParent.h
+++ b/dom/plugins/ipc/PluginIdentifierParent.h
@ -64,6 +64,8 @@ protected:
    MOZ_COUNT_DTOR(PluginIdentifierParent);
  }

+  virtual void ActorDestroy(ActorDestroyReason aWhy) MOZ_OVERRIDE;
+
  virtual bool RecvRetain() MOZ_OVERRIDE;

  void AddTemporaryRef() {
--- a/dom/plugins/ipc/PluginInstanceParent.cpp
+++ b/dom/plugins/ipc/PluginInstanceParent.cpp
@ -56,6 +56,12 @@ using namespace mozilla::plugins;
 using namespace mozilla::layers;
 using namespace mozilla::gl;

+void
+StreamNotifyParent::ActorDestroy(ActorDestroyReason aWhy)
+{
+  // Implement me! Bug 1005162
+}
+
 bool
 StreamNotifyParent::RecvRedirectNotifyResponse(const bool& allow)
 {
--- a/dom/plugins/ipc/PluginScriptableObjectParent.cpp
+++ b/dom/plugins/ipc/PluginScriptableObjectParent.cpp
@ -643,6 +643,12 @@ PluginScriptableObjectParent::DropNPObject()
  unused << SendUnprotect();
 }

+void
+PluginScriptableObjectParent::ActorDestroy(ActorDestroyReason aWhy)
+{
+  // Implement me! Bug 1005163
+}
+
 bool
 PluginScriptableObjectParent::AnswerHasMethod(PPluginIdentifierParent* aId,
                                              bool* aHasMethod)
--- a/dom/plugins/ipc/PluginScriptableObjectParent.h
+++ b/dom/plugins/ipc/PluginScriptableObjectParent.h
@ -45,6 +45,9 @@ public:
  void
  InitializeLocal(NPObject* aObject);

+  virtual void
+  ActorDestroy(ActorDestroyReason aWhy) MOZ_OVERRIDE;
+
  virtual bool
  AnswerHasMethod(PPluginIdentifierParent* aId,
                  bool* aHasMethod) MOZ_OVERRIDE;
--- a/dom/plugins/ipc/PluginStreamParent.cpp
+++ b/dom/plugins/ipc/PluginStreamParent.cpp
@ -26,6 +26,12 @@ PluginStreamParent::PluginStreamParent(PluginInstanceParent* npp,
    mStream = nullptr;
 }

+void
+PluginStreamParent::ActorDestroy(ActorDestroyReason aWhy)
+{
+  // Implement me! Bug 1005166
+}
+
 bool
 PluginStreamParent::AnswerNPN_Write(const Buffer& data, int32_t* written)
 {
--- a/dom/plugins/ipc/PluginStreamParent.h
+++ b/dom/plugins/ipc/PluginStreamParent.h
@ -26,6 +26,8 @@ public:

  virtual bool IsBrowserStream() MOZ_OVERRIDE { return false; }

+  virtual void ActorDestroy(ActorDestroyReason aWhy) MOZ_OVERRIDE;
+
  virtual bool AnswerNPN_Write(const Buffer& data, int32_t* written) MOZ_OVERRIDE;

  virtual bool Answer__delete__(const NPError& reason, const bool& artificial) MOZ_OVERRIDE;
--- a/dom/plugins/ipc/PluginSurfaceParent.cpp
+++ b/dom/plugins/ipc/PluginSurfaceParent.cpp
@ -24,5 +24,11 @@ PluginSurfaceParent::~PluginSurfaceParent()
 {
 }

+void
+PluginSurfaceParent::ActorDestroy(ActorDestroyReason aWhy)
+{
+  // Implement me! Bug 1005167
+}
+
 }
 }
--- a/dom/plugins/ipc/PluginSurfaceParent.h
+++ b/dom/plugins/ipc/PluginSurfaceParent.h
@ -27,6 +27,8 @@ public:
                      const bool transparent);
  ~PluginSurfaceParent();

+  virtual void ActorDestroy(ActorDestroyReason aWhy) MOZ_OVERRIDE;
+
  gfxASurface* Surface() { return mSurface; }

 private:
--- a/dom/plugins/ipc/StreamNotifyParent.h
+++ b/dom/plugins/ipc/StreamNotifyParent.h
@ -34,6 +34,8 @@ public:
    mDestructionFlag = nullptr;
  }

+  virtual void ActorDestroy(ActorDestroyReason aWhy) MOZ_OVERRIDE;
+
 private:
  bool RecvRedirectNotifyResponse(const bool& allow) MOZ_OVERRIDE;

--- a/dom/src/storage/DOMStorageIPC.cpp
+++ b/dom/src/storage/DOMStorageIPC.cpp
@ -378,6 +378,12 @@ DOMStorageDBParent::NewCache(const nsACString& aScope)
  return new CacheParentBridge(this, aScope);
 }

+void
+DOMStorageDBParent::ActorDestroy(ActorDestroyReason aWhy)
+{
+  // Implement me! Bug 1005169
+}
+
 bool
 DOMStorageDBParent::RecvAsyncPreload(const nsCString& aScope, const bool& aPriority)
 {
--- a/dom/src/storage/DOMStorageIPC.h
+++ b/dom/src/storage/DOMStorageIPC.h
@ -171,6 +171,7 @@ public:

 private:
  // IPC
+  virtual void ActorDestroy(ActorDestroyReason aWhy) MOZ_OVERRIDE;
  bool RecvAsyncPreload(const nsCString& aScope, const bool& aPriority);
  bool RecvPreload(const nsCString& aScope, const uint32_t& aAlreadyLoadedCount,
                   InfallibleTArray<nsString>* aKeys, InfallibleTArray<nsString>* aValues,
--- a/gfx/layers/ipc/LayerTransactionParent.cpp
+++ b/gfx/layers/ipc/LayerTransactionParent.cpp
@ -175,6 +175,12 @@ LayerTransactionParent::GetCompositorBackendType() const
 }

 /* virtual */
+void
+LayerTransactionParent::ActorDestroy(ActorDestroyReason aWhy)
+{
+  // Implement me! Bug 1005171
+}
+
 bool
 LayerTransactionParent::RecvUpdateNoSwap(const InfallibleTArray<Edit>& cset,
                                         const TargetConfig& targetConfig,
--- a/gfx/layers/ipc/LayerTransactionParent.h
+++ b/gfx/layers/ipc/LayerTransactionParent.h
@ -80,6 +80,8 @@ public:
  virtual bool IsSameProcess() const MOZ_OVERRIDE;

 protected:
+  virtual void ActorDestroy(ActorDestroyReason aWhy) MOZ_OVERRIDE;
+
  virtual bool RecvUpdate(const EditArray& cset,
                          const TargetConfig& targetConfig,
                          const bool& isFirstPaint,
--- a/ipc/testshell/TestShellParent.cpp
+++ b/ipc/testshell/TestShellParent.cpp
@ -18,6 +18,12 @@ using mozilla::ipc::TestShellCommandParent;
 using mozilla::ipc::PTestShellCommandParent;
 using mozilla::dom::ContentParent;

+void
+TestShellParent::ActorDestroy(ActorDestroyReason aWhy)
+{
+  // Implement me! Bug 1005177
+}
+
 PTestShellCommandParent*
 TestShellParent::AllocPTestShellCommandParent(const nsString& aCommand)
 {
--- a/ipc/testshell/TestShellParent.h
+++ b/ipc/testshell/TestShellParent.h
@ -24,6 +24,8 @@ class TestShellCommandParent;
 class TestShellParent : public PTestShellParent
 {
 public:
+  virtual void ActorDestroy(ActorDestroyReason aWhy) MOZ_OVERRIDE;
+
  PTestShellCommandParent*
  AllocPTestShellCommandParent(const nsString& aCommand);

--- a/netwerk/base/src/ChannelDiverterParent.cpp
+++ b/netwerk/base/src/ChannelDiverterParent.cpp
@ -61,5 +61,11 @@ ChannelDiverterParent::DivertTo(nsIStreamListener* newListener)
  mDivertableChannelParent->DivertTo(newListener);
 }

+void
+ChannelDiverterParent::ActorDestroy(ActorDestroyReason aWhy)
+{
+  // Implement me! Bug 1005179
+}
+
 } // namespace net
 } // namespace mozilla
--- a/netwerk/base/src/ChannelDiverterParent.h
+++ b/netwerk/base/src/ChannelDiverterParent.h
@ -27,6 +27,9 @@ public:
  bool Init(const ChannelDiverterArgs& aChannel);

  void DivertTo(nsIStreamListener* newListener);
+
+  virtual void ActorDestroy(ActorDestroyReason aWhy) MOZ_OVERRIDE;
+
 private:
  nsRefPtr<ADivertableParentChannel> mDivertableChannelParent;
 };
--- a/netwerk/cookie/CookieServiceParent.cpp
+++ b/netwerk/cookie/CookieServiceParent.cpp
@ -64,6 +64,12 @@ CookieServiceParent::~CookieServiceParent()
 {
 }

+void
+CookieServiceParent::ActorDestroy(ActorDestroyReason aWhy)
+{
+  // Implement me! Bug 1005181
+}
+
 bool
 CookieServiceParent::RecvGetCookieString(const URIParams& aHost,
                                         const bool& aIsForeign,
--- a/netwerk/cookie/CookieServiceParent.h
+++ b/netwerk/cookie/CookieServiceParent.h
@ -28,7 +28,9 @@ protected:
                       bool& aIsInBrowserElement,
                       bool& aIsPrivate);

-   virtual bool RecvGetCookieString(const URIParams& aHost,
+  virtual void ActorDestroy(ActorDestroyReason aWhy) MOZ_OVERRIDE;
+
+  virtual bool RecvGetCookieString(const URIParams& aHost,
                                   const bool& aIsForeign,
                                   const bool& aFromHttp,
                                   const IPC::SerializedLoadContext&
--- a/netwerk/ipc/NeckoParent.cpp
+++ b/netwerk/ipc/NeckoParent.cpp
@ -178,6 +178,12 @@ NeckoParent::CreateChannelLoadContext(PBrowserParent* aBrowser,
  return nullptr;
 }

+void
+NeckoParent::ActorDestroy(ActorDestroyReason aWhy)
+{
+  // Implement me! Bug 1005184
+}
+
 PHttpChannelParent*
 NeckoParent::AllocPHttpChannelParent(PBrowserParent* aBrowser,
                                     const SerializedLoadContext& aSerialized,
--- a/netwerk/ipc/NeckoParent.h
+++ b/netwerk/ipc/NeckoParent.h
@ -57,6 +57,8 @@ public:
                           const SerializedLoadContext& aSerialized,
                           nsCOMPtr<nsILoadContext> &aResult);

+  virtual void ActorDestroy(ActorDestroyReason aWhy) MOZ_OVERRIDE;
+
  virtual void
  CloneManagees(ProtocolBase* aSource,
              mozilla::ipc::ProtocolCloneContext* aCtx) MOZ_OVERRIDE;
--- a/netwerk/ipc/RemoteOpenFileParent.cpp
+++ b/netwerk/ipc/RemoteOpenFileParent.cpp
@ -17,6 +17,12 @@
 namespace mozilla {
 namespace net {

+void
+RemoteOpenFileParent::ActorDestroy(ActorDestroyReason aWhy)
+{
+  // Implement me! Bug 1005186
+}
+
 bool
 RemoteOpenFileParent::OpenSendCloseDelete()
 {
--- a/netwerk/ipc/RemoteOpenFileParent.h
+++ b/netwerk/ipc/RemoteOpenFileParent.h
@ -22,6 +22,8 @@ public:
  : mURI(aURI)
  {}

+  virtual void ActorDestroy(ActorDestroyReason aWhy) MOZ_OVERRIDE;
+
  bool OpenSendCloseDelete();

 private: