wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

bug 735577 - followup 2 - additional comments describing ISize/BSize in nsHTMLReflow{Metrics,State}.h. r=roc

Browse Source
This commit is contained in:
Jonathan Kew 2013-12-29 22:04:28 +00:00
parent f4958b2b4b
commit eb1cfcc097
2 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
layout/generic/nsHTMLReflowMetrics.h
View File

@ -218,15 +218,25 @@ public:
, mWritingMode(aState.GetWritingMode())
{}
// ISize and BSize are logical-coordinate dimensions:
// ISize is the size in the writing mode's inline direction (which equates to
// width in horizontal writing modes, height in vertical ones), and BSize is
// the size in the block-progression direction.
nscoord ISize() const { return mISize; }
nscoord BSize() const { return mBSize; }
nscoord& ISize() { return mISize; }
nscoord& BSize() { return mBSize; }
// Width and Height are physical dimensions, independent of writing mode.
// Accessing these is slightly more expensive than accessing the logical
// dimensions (once vertical writing mode support is enabled); as far as
// possible, client code should work purely with logical dimensions.
nscoord Width() const { return mWritingMode.IsVertical() ? mBSize : mISize; }
nscoord Height() const { return mWritingMode.IsVertical() ? mISize : mBSize; }
// It's only meaningful to consider "ascent" on the block-start side of the
// frame; asking for the "ascent" on any other side will just return zero.
nscoord TopAscent() const
{
return mWritingMode.IsVertical() ? 0 : mBlockStartAscent;
@ -245,11 +255,15 @@ public:
nscoord& Width() { return mWritingMode.IsVertical() ? mBSize : mISize; }
nscoord& Height() { return mWritingMode.IsVertical() ? mISize : mBSize; }
// To set the ascent value, we must be sure we're working with the correct
// writing mode, so either pass it to the logical setter...
void SetBlockStartAscent(mozilla::WritingMode aWritingMode, nscoord aAscent)
{
NS_ASSERTION(aWritingMode == mWritingMode, "writing mode mismatch");
mBlockStartAscent = aAscent;
}
// ...or call the appropriate physical setter (these will probably be removed
// eventually).
void SetTopAscent(nscoord aAscent)
{
NS_ASSERTION(!mWritingMode.IsVertical(), "writing mode mismatch");

4
layout/generic/nsHTMLReflowState.h
View File

@ -302,6 +302,10 @@ struct nsHTMLReflowState : public nsCSSOffsetState {
nscoord& ComputedMinHeight() { return mComputedMinHeight; }
nscoord& ComputedMaxHeight() { return mComputedMaxHeight; }
// ISize and BSize are logical-coordinate dimensions:
// ISize is the size in the writing mode's inline direction (which equates to
// width in horizontal writing modes, height in vertical ones), and BSize is
// the size in the block-progression direction.
nscoord AvailableISize() const
{ return mWritingMode.IsVertical() ? mAvailableHeight : mAvailableWidth; }
nscoord AvailableBSize() const