bug 1003935 - call dontreuse() on reclaimed conns with transaction refs r=sworkman

This commit is contained in:
Patrick McManus 2014-04-30 13:15:46 -04:00
parent e1cd2d77fe
commit ead27b6335
2 changed files with 11 additions and 1 deletions

View File

@ -2366,6 +2366,13 @@ nsHttpConnectionMgr::OnMsgReclaimConnection(int32_t, void *param)
ConditionallyStopTimeoutTick();
}
// a connection that still holds a reference to a transaction was
// not closed naturally (i.e. it was reset or aborted) and is
// therefore not something that should be reused.
if (conn->Transaction()) {
conn->DontReuse();
}
if (conn->CanReuse()) {
LOG((" adding connection to idle list\n"));
// Keep The idle connection list sorted with the connections that

View File

@ -1066,7 +1066,10 @@ nsHttpTransaction::Restart()
// clear old connection state...
mSecurityInfo = 0;
NS_IF_RELEASE(mConnection);
if (mConnection) {
mConnection->DontReuse();
NS_RELEASE(mConnection);
}
// disable pipelining for the next attempt in case pipelining caused the
// reset. this is being overly cautious since we don't know if pipelining