wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 1248958 - CacheIndex mRWBuf ownership too fragile, read-after-free, r=honzab

Browse Source
This commit is contained in:
Michal Novotny 2016-02-18 11:43:20 +01:00
parent 8a89aa994d
commit ea8530a9b7
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
netwerk/cache2/CacheIndex.cpp
View File

@ -347,13 +347,15 @@ CacheIndex::PreShutdown()
nsCOMPtr<nsIRunnable> event;
event = NS_NewRunnableMethod(index, &CacheIndex::PreShutdownInternal);
nsCOMPtr<nsIEventTarget> ioTarget = CacheFileIOManager::IOTarget();
MOZ_ASSERT(ioTarget);
RefPtr<CacheIOThread> ioThread = CacheFileIOManager::IOThread();
MOZ_ASSERT(ioThread);
// PreShutdownInternal() will be executed before any queued event on INDEX
// level. That's OK since we don't want to wait for any operation in progess.
// We need to interrupt it and save journal as quickly as possible.
rv = ioTarget->Dispatch(event, nsIEventTarget::DISPATCH_NORMAL);
// Executing PreShutdownInternal() on WRITE level ensures that read/write
// events holding pointer to mRWBuf will be executed before we release the
// buffer by calling FinishRead()/FinishWrite() in PreShutdownInternal(), but
// it will be executed before any queued event on INDEX level. That's OK since
// we don't want to wait until updating of the index finishes.
rv = ioThread->Dispatch(event, CacheIOThread::WRITE);
if (NS_FAILED(rv)) {
NS_WARNING("CacheIndex::PreShutdown() - Can't dispatch event");
LOG(("CacheIndex::PreShutdown() - Can't dispatch event" ));