Bug 1043898: Remove MNot's operand() and use input() instead; r=nbp

This commit is contained in:
Benjamin Bouvier 2014-07-28 13:18:42 +02:00
parent be39891576
commit e92f13bf2e
5 changed files with 8 additions and 12 deletions

View File

@ -5526,7 +5526,7 @@ CodeGenerator::visitNotV(LNotV *lir)
Label *ifFalsy;
OutOfLineTestObjectWithLabels *ool = nullptr;
MDefinition *operand = lir->mir()->operand();
MDefinition *operand = lir->mir()->input();
// Unfortunately, it's possible that someone (e.g. phi elimination) switched
// out our operand after we did cacheOperandMightEmulateUndefined. So we
// might think it can emulate undefined _and_ know that it can't be an

View File

@ -2473,7 +2473,7 @@ LIRGenerator::visitSetInitializedLength(MSetInitializedLength *ins)
bool
LIRGenerator::visitNot(MNot *ins)
{
MDefinition *op = ins->operand();
MDefinition *op = ins->input();
// String is converted to length of string in the type analysis phase (see
// TestPolicy).

View File

@ -278,7 +278,7 @@ MTest::foldsTo(TempAllocator &alloc)
MDefinition *op = getOperand(0);
if (op->isNot())
return MTest::New(alloc, op->toNot()->operand(), ifFalse(), ifTrue());
return MTest::New(alloc, op->toNot()->input(), ifFalse(), ifTrue());
return this;
}
@ -2770,8 +2770,8 @@ MDefinition *
MNot::foldsTo(TempAllocator &alloc)
{
// Fold if the input is constant
if (operand()->isConstant()) {
bool result = operand()->toConstant()->valueToBoolean();
if (input()->isConstant()) {
bool result = input()->toConstant()->valueToBoolean();
if (type() == MIRType_Int32)
return MConstant::New(alloc, Int32Value(!result));
@ -2780,11 +2780,11 @@ MNot::foldsTo(TempAllocator &alloc)
}
// NOT of an undefined or null value is always true
if (operand()->type() == MIRType_Undefined || operand()->type() == MIRType_Null)
if (input()->type() == MIRType_Undefined || input()->type() == MIRType_Null)
return MConstant::New(alloc, BooleanValue(true));
// NOT of an object that can't emulate undefined is always false.
if (operand()->type() == MIRType_Object && !operandMightEmulateUndefined())
if (input()->type() == MIRType_Object && !operandMightEmulateUndefined())
return MConstant::New(alloc, BooleanValue(false));
return this;

View File

@ -6339,10 +6339,6 @@ class MNot
return operandIsNeverNaN_;
}
MDefinition *operand() const {
return getOperand(0);
}
virtual AliasSet getAliasSet() const {
return AliasSet::None();
}

View File

@ -2804,7 +2804,7 @@ MCompare::collectRangeInfoPreTrunc()
void
MNot::collectRangeInfoPreTrunc()
{
if (!Range(operand()).canBeNaN())
if (!Range(input()).canBeNaN())
operandIsNeverNaN_ = true;
}