From e855e8f7b4c40d7c140b758e7cc61c19c0e349b0 Mon Sep 17 00:00:00 2001 From: Michael Shuen Date: Tue, 1 Jul 2014 08:36:00 -0400 Subject: [PATCH] Bug 1031920 - Stop leaking mDataPtr on failure in ArrayBufferBuilder::getArrayBuffer. r=smaug --- content/base/src/nsXMLHttpRequest.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/content/base/src/nsXMLHttpRequest.cpp b/content/base/src/nsXMLHttpRequest.cpp index ec5874793f7..0d381c614d8 100644 --- a/content/base/src/nsXMLHttpRequest.cpp +++ b/content/base/src/nsXMLHttpRequest.cpp @@ -4065,12 +4065,11 @@ ArrayBufferBuilder::getArrayBuffer(JSContext* aCx) } JSObject* obj = JS_NewArrayBufferWithContents(aCx, mLength, mDataPtr); - mDataPtr = nullptr; mLength = mCapacity = 0; if (!obj) { js_free(mDataPtr); - return nullptr; } + mDataPtr = nullptr; return obj; }