Bug 924307 - Intermittent "reporter is null at abouthealth.js:27"; r=rnewman

The error message comes from abouthealth.js not checking if a variable
is null before access. That bug is fixed.

However, the underlying issue of "the reporter is null" still remains.
Logging has been added to hopefully catch issues. The signature of the
failure will change.

--HG--
extra : rebase_source : bc887406a3570a767bae5407b5836314157ac421
extra : amend_source : f22cad2eae46bd08ae25a7d376fbf8e2d1d0ea92
This commit is contained in:
Gregory Szorc 2013-11-20 11:41:08 -08:00
parent daec0cfe86
commit e84f6d729a
3 changed files with 7 additions and 1 deletions

View File

@ -24,6 +24,11 @@ const prefs = new Preferences("datareporting.healthreport.");
let healthReportWrapper = {
init: function () {
if (!reporter) {
healthReportWrapper.handleInitFailure();
return;
}
reporter.onInit().then(healthReportWrapper.refreshPayload,
healthReportWrapper.handleInitFailure);

View File

@ -108,7 +108,6 @@ run-if = crashreporter
[browser_CTP_resize.js]
[browser_URLBarSetURI.js]
[browser_aboutHealthReport.js]
skip-if = os == "linux" # Bug 924307
[browser_aboutHome.js]
[browser_aboutSyncProgress.js]
[browser_addKeywordSearch.js]

View File

@ -212,6 +212,8 @@ DataReportingService.prototype = Object.freeze({
this._loadHealthReporter();
} catch (ex) {
this._healthReporter = null;
Cu.reportError("Exception when obtaining health reporter: " +
CommonUtils.exceptionStr(ex));
}
return this._healthReporter;