wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 948873 - Function closures and other psuedo variables shouldn't have a bottom border in the variables view, r=past

Browse Source
This commit is contained in:
Victor Porof 2013-12-12 22:14:29 +02:00
parent 8934b1fb77
commit e8291ba700
7 changed files with 29 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
browser/devtools/shared/widgets/VariablesView.jsm
View File

@ -2680,12 +2680,19 @@ Variable.prototype = Heritage.extend(Scope.prototype, {
}
else if (name == "<exception>") {
target.setAttribute("exception", "");
target.setAttribute("pseudo-item", "");
}
else if (name == "<return>") {
target.setAttribute("return", "");
target.setAttribute("pseudo-item", "");
}
else if (name == "__proto__") {
target.setAttribute("proto", "");
target.setAttribute("pseudo-item", "");
}
if (Object.keys(descriptor).length == 0) {
target.setAttribute("pseudo-item", "");
}
},

4
browser/devtools/shared/widgets/widgets.css
View File

@ -64,6 +64,10 @@
display: none;
}
.variable-or-property[pseudo-item] > tooltip {
display: none;
}
*:not(:hover) .variables-view-delete,
*:not(:hover) .variables-view-add-property {
visibility: hidden;

8
browser/themes/linux/devtools/widgets.css
View File

@ -512,19 +512,19 @@
/* Custom configurable/enumerable/writable or frozen/sealed/extensible
* variables and properties */
.variable-or-property[non-enumerable]:not([self]):not([exception]):not([return]):not([scope]) > .title > .name {
.variable-or-property[non-enumerable]:not([self]):not([pseudo-item]) > .title > .name {
opacity: 0.6;
}
.variable-or-property[non-configurable] > .title > .name {
.variable-or-property[non-configurable]:not([pseudo-item]) > .title > .name {
border-bottom: 1px dashed #99f;
}
.variable-or-property[non-writable] > .title > .name {
.variable-or-property[non-writable]:not([pseudo-item]) > .title > .name {
border-bottom: 1px dashed #f99;
}
.variable-or-property[safe-getter] > .title > .name {
.variable-or-property[safe-getter]:not([pseudo-item]) > .title > .name {
border-bottom: 1px dashed #8b0;
}

8
browser/themes/osx/devtools/widgets.css
View File

@ -506,19 +506,19 @@
/* Custom configurable/enumerable/writable or frozen/sealed/extensible
* variables and properties */
.variable-or-property[non-enumerable]:not([self]):not([exception]):not([return]):not([scope]) > .title > .name {
.variable-or-property[non-enumerable]:not([self]):not([pseudo-item]) > .title > .name {
opacity: 0.6;
}
.variable-or-property[non-configurable] > .title > .name {
.variable-or-property[non-configurable]:not([pseudo-item]) > .title > .name {
border-bottom: 1px dashed #99f;
}
.variable-or-property[non-writable] > .title > .name {
.variable-or-property[non-writable]:not([pseudo-item]) > .title > .name {
border-bottom: 1px dashed #f99;
}
.variable-or-property[safe-getter] > .title > .name {
.variable-or-property[safe-getter]:not([pseudo-item]) > .title > .name {
border-bottom: 1px dashed #8b0;
}

6
browser/themes/shared/devtools/dark-theme.css
View File

@ -93,7 +93,8 @@
.theme-fg-color1,
.cm-s-mozilla .cm-number,
.variable-or-property .token-number,
.variable-or-property[return] > .title > .name { /* green */
.variable-or-property[return] > .title > .name,
.variable-or-property[scope] > .title > .name { /* green */
color: #5c9966;
}
@ -103,8 +104,7 @@
.cm-s-mozilla .cm-def,
.cm-s-mozilla .cm-property,
.cm-s-mozilla .cm-qualifier,
.variables-view-variable > .title > .name,
.variable-or-property[scope] > .title > .name { /* blue */
.variables-view-variable > .title > .name { /* blue */
color: #3689b2;
}

6
browser/themes/shared/devtools/light-theme.css
View File

@ -92,7 +92,8 @@
.theme-fg-color1,
.cm-s-mozilla .cm-number,
.variable-or-property .token-number,
.variable-or-property[return] > .title > .name { /* green */
.variable-or-property[return] > .title > .name,
.variable-or-property[scope] > .title > .name { /* green */
color: hsl(72,100%,27%);
}
@ -102,8 +103,7 @@
.cm-s-mozilla .cm-def,
.cm-s-mozilla .cm-property,
.cm-s-mozilla .cm-qualifier,
.variables-view-variable > .title > .name,
.variable-or-property[scope] > .title > .name { /* blue */
.variables-view-variable > .title > .name { /* blue */
color: hsl(208,56%,40%);
}

8
browser/themes/windows/devtools/widgets.css
View File

@ -509,19 +509,19 @@
/* Custom configurable/enumerable/writable or frozen/sealed/extensible
* variables and properties */
.variable-or-property[non-enumerable]:not([self]):not([exception]):not([return]):not([scope]) > .title > .name {
.variable-or-property[non-enumerable]:not([self]):not([pseudo-item]) > .title > .name {
opacity: 0.6;
}
.variable-or-property[non-configurable] > .title > .name {
.variable-or-property[non-configurable]:not([pseudo-item]) > .title > .name {
border-bottom: 1px dashed #99f;
}
.variable-or-property[non-writable] > .title > .name {
.variable-or-property[non-writable]:not([pseudo-item]) > .title > .name {
border-bottom: 1px dashed #f99;
}
.variable-or-property[safe-getter] > .title > .name {
.variable-or-property[safe-getter]:not([pseudo-item]) > .title > .name {
border-bottom: 1px dashed #8b0;
}