Bug 1216020 - Comment all ALLOW_COMPILER_WARNINGS lines. r=glandium.

DONTBUILD because it only changes comments.

This will hopefully prevent confusion like that in bug 1215903.

build/stlport/moz.build

@@ -70,4 +70,5 @@ if CONFIG['GNU_CXX']:
 # installing it in dist/lib.
 NO_EXPAND_LIBS = True
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True

db/sqlite3/src/moz.build

@@ -9,6 +9,7 @@ EXPORTS += [
     'sqlite3.h',
 ]
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 if CONFIG['MOZ_FOLD_LIBS']:

extensions/spellcheck/hunspell/src/moz.build

@@ -28,6 +28,7 @@ LOCAL_INCLUDES += [
     '../glue',
 ]
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 include('/ipc/chromium/chromium-config.mozbuild')

gfx/angle/moz.build

@@ -160,6 +160,7 @@ if CONFIG['GKMEDIAS_SHARED_LIBRARY']:
 DEFINES['COMPONENT_BUILD'] = True
 DEFINES['ANGLE_TRANSLATOR_IMPLEMENTATION'] = True
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 FINAL_LIBRARY = 'gkmedias'

gfx/angle/src/libANGLE/moz.build

@@ -311,5 +311,6 @@ SOURCES['renderer/d3d/HLSLCompiler.cpp'].flags += ['-DANGLE_PRELOADED_D3DCOMPILE
 if CONFIG['MOZ_HAS_WINSDK_WITH_D3D']:
     SOURCES['renderer/d3d/d3d11/SwapChain11.cpp'].flags += ['-DANGLE_RESOURCE_SHARE_TYPE=D3D11_RESOURCE_MISC_SHARED_KEYEDMUTEX']
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 

gfx/cairo/cairo/src/moz.build

@@ -185,6 +185,7 @@ UNIFIED_SOURCES += [
     'cairo.c',
 ]
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 FINAL_LIBRARY = 'gkmedias'

gfx/cairo/libpixman/src/moz.build

@@ -58,6 +58,7 @@ SOURCES += [
     'pixman.c',
 ]
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 FINAL_LIBRARY = 'gkmedias'

gfx/graphite2/src/moz.build

@@ -67,6 +67,7 @@ else:
     # thebes
     DEFINES['GRAPHITE2_STATIC'] = True
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 FINAL_LIBRARY = 'gkmedias'

gfx/harfbuzz/src/moz.build

@@ -59,6 +59,7 @@ UNIFIED_SOURCES += [
     'hb-warning.cc',
 ]
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 FINAL_LIBRARY = 'gkmedias'

gfx/ots/src/moz.build

@@ -50,6 +50,7 @@ UNIFIED_SOURCES += [
 if CONFIG['GKMEDIAS_SHARED_LIBRARY']:
     NO_VISIBILITY_FLAGS = True
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 FINAL_LIBRARY = 'gkmedias'

gfx/skia/moz.build

@@ -583,6 +583,7 @@ if CONFIG['INTEL_ARCHITECTURE'] and CONFIG['GNU_CC'] and CONFIG['OS_ARCH'] != 'W
             'skia/src/opts/SkBlitRow_opts_SSE4_asm.S',
         ]
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 FINAL_LIBRARY = 'gkmedias'

intl/hyphenation/hyphen/moz.build

@@ -15,5 +15,5 @@ LOCAL_INCLUDES += [
     '../glue',
 ]
 
-# Suppress warnings in third-party code.
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True

ipc/chromium/src/third_party/moz.build

@@ -54,6 +54,7 @@ if os_linux:
             'libevent/epoll_sub.c',
         ]
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 FINAL_LIBRARY = 'xul'

media/libav/moz.build

@@ -63,6 +63,7 @@ if CONFIG['_MSC_VER']:
 if CONFIG['OS_ARCH'] != 'WINNT':
     SOURCES['libavcodec/avfft.c'].flags += ['-include', 'avfft_perms.h']
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 include("libavcommon.mozbuild")

media/libjpeg/moz.build

@@ -149,6 +149,7 @@ ASFLAGS += ['-I%s/media/libjpeg/simd/' % TOPSRCDIR]
 if CONFIG['GKMEDIAS_SHARED_LIBRARY']:
     NO_VISIBILITY_FLAGS = True
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 FINAL_LIBRARY = 'gkmedias'

media/libopus/moz.build

@@ -14,6 +14,7 @@ EXPORTS.opus += [
     'include/opus_types.h',
 ]
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 FINAL_LIBRARY = 'gkmedias'

media/libsoundtouch/src/moz.build

@@ -42,6 +42,7 @@ else:
     # Windows need alloca renamed to _alloca
     DEFINES['alloca'] = '_alloca'
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 if CONFIG['CLANG_CXX']:

media/libspeex_resampler/src/moz.build

@@ -15,6 +15,7 @@ SOURCES += [
     'simd_detect.cpp',
 ]
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 FINAL_LIBRARY = 'gkmedias'

media/libstagefright/moz.build

@@ -129,6 +129,7 @@ TEST_DIRS += [
     'gtest',
 ]
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 FINAL_LIBRARY = 'xul'

media/libtheora/moz.build

@@ -13,6 +13,7 @@ EXPORTS.theora += [
     'include/theora/theoraenc.h',
 ]
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 FINAL_LIBRARY = 'gkmedias'

media/libvorbis/moz.build

@@ -51,6 +51,7 @@ if CONFIG['OS_ARCH'] == 'SunOS':
 if CONFIG['GKMEDIAS_SHARED_LIBRARY']:
     NO_VISIBILITY_FLAGS = True
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 FINAL_LIBRARY = 'gkmedias'

media/libvpx/moz.build

@@ -55,6 +55,7 @@ if 'vp8/encoder/arm/armv5te/boolhuff_armv5te.asm' not in arm_asm_files:
 if CONFIG['GKMEDIAS_SHARED_LIBRARY']:
     NO_VISIBILITY_FLAGS = True
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 FINAL_LIBRARY = 'gkmedias'

media/mtransport/third_party/moz.build

@@ -63,12 +63,14 @@ nrappkit_non_unified_sources = [
 
 GYP_DIRS['nICEr'].input = 'nICEr/nicer.gyp'
 GYP_DIRS['nICEr'].variables = gyp_vars
+# We allow warnings for third-party code that can be updated from upstream.
 GYP_DIRS['nICEr'].sandbox_vars['ALLOW_COMPILER_WARNINGS'] = True
 GYP_DIRS['nICEr'].sandbox_vars['FINAL_LIBRARY'] = 'webrtc'
 GYP_DIRS['nICEr'].non_unified_sources += nICEr_non_unified_sources
 
 GYP_DIRS['nrappkit'].input = 'nrappkit/nrappkit.gyp'
 GYP_DIRS['nrappkit'].variables = gyp_vars
+# We allow warnings for third-party code that can be updated from upstream.
 GYP_DIRS['nrappkit'].sandbox_vars['ALLOW_COMPILER_WARNINGS'] = True
 GYP_DIRS['nrappkit'].sandbox_vars['FINAL_LIBRARY'] = 'webrtc'
 GYP_DIRS['nrappkit'].non_unified_sources += nrappkit_non_unified_sources

media/pocketsphinx/moz.build

@@ -58,6 +58,7 @@ if CONFIG['GNU_CC']:
 if CONFIG['GKMEDIAS_SHARED_LIBRARY']:
     NO_VISIBILITY_FLAGS = True,
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 FINAL_LIBRARY = 'gkmedias'

media/sphinxbase/moz.build

@@ -79,6 +79,7 @@ if CONFIG['GNU_CC']:
 if CONFIG['GKMEDIAS_SHARED_LIBRARY']:
     NO_VISIBILITY_FLAGS = True,
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 FINAL_LIBRARY = 'gkmedias'

media/webrtc/moz.build

@@ -40,6 +40,7 @@ GYP_DIRS += ['trunk']
 
 GYP_DIRS['trunk'].input = 'trunk/peerconnection.gyp'
 GYP_DIRS['trunk'].variables = gyp_vars
+# We allow warnings for third-party code that can be updated from upstream.
 GYP_DIRS['trunk'].sandbox_vars['ALLOW_COMPILER_WARNINGS'] = True
 GYP_DIRS['trunk'].sandbox_vars['FINAL_LIBRARY'] = 'webrtc'
 GYP_DIRS['trunk'].non_unified_sources += webrtc_non_unified_sources
@@ -89,6 +90,7 @@ if CONFIG['MOZ_WIDGET_TOOLKIT'] != 'gonk':
     GYP_DIRS += ['trunk/testing']
     GYP_DIRS['trunk/testing'].input = 'trunk/testing/gtest.gyp'
     GYP_DIRS['trunk/testing'].variables = gyp_vars
+    # We allow warnings for third-party code that can be updated from upstream.
     GYP_DIRS['trunk/testing'].sandbox_vars['ALLOW_COMPILER_WARNINGS'] = True
     GYP_DIRS['trunk/testing'].non_unified_sources += webrtc_non_unified_sources
 

memory/jemalloc/moz.build

@@ -72,4 +72,5 @@ DEFINES['abort'] = 'moz_abort'
 GENERATED_INCLUDES += ['src/include']
 LOCAL_INCLUDES += ['src/include']
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True

modules/brotli/moz.build

@@ -23,6 +23,7 @@ UNIFIED_SOURCES += [
     'dec/streams.c',
 ]
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 Library('brotli')

netwerk/sctp/src/moz.build

@@ -43,6 +43,7 @@ Library('nksctp_s')
 
 include('/ipc/chromium/chromium-config.mozbuild')
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 FINAL_LIBRARY = 'xul'

other-licenses/android/moz.build

@@ -27,6 +27,7 @@ SOURCES += [
     'res_state.c',
 ]
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 FINAL_LIBRARY = 'mozglue'

other-licenses/skia-npapi/moz.build

@@ -16,6 +16,7 @@ UNIFIED_SOURCES += [
     'SkANP.cpp',
 ]
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 FINAL_LIBRARY = 'xul'

other-licenses/snappy/moz.build

@@ -17,6 +17,7 @@ UNIFIED_SOURCES += [
     'src/snappy.cc',
 ]
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 FINAL_LIBRARY = 'xul'

toolkit/components/protobuf/moz.build

@@ -106,6 +106,7 @@ SOURCES += [
     'src/google/protobuf/wire_format.cc',
 ]
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 FINAL_LIBRARY = 'xul'

toolkit/crashreporter/google-breakpad/src/client/linux/crash_generation/moz.build

@@ -9,6 +9,7 @@ UNIFIED_SOURCES += [
     'crash_generation_server.cc',
 ]
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 FINAL_LIBRARY = 'xul'

toolkit/crashreporter/google-breakpad/src/client/linux/handler/moz.build

@@ -10,6 +10,7 @@ UNIFIED_SOURCES += [
     'minidump_descriptor.cc',
 ]
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 FINAL_LIBRARY = 'xul'

toolkit/crashreporter/google-breakpad/src/client/mac/handler/moz.build

@@ -11,6 +11,7 @@ UNIFIED_SOURCES += [
     'minidump_generator.cc',
 ]
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 FINAL_LIBRARY = 'xul'

toolkit/crashreporter/google-breakpad/src/common/mac/moz.build

@@ -41,6 +41,7 @@ SOURCES += [
 
 Library('breakpad_mac_common_s')
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 FINAL_LIBRARY = 'xul'

toolkit/crashreporter/google-breakpad/src/common/moz.build

@@ -88,6 +88,7 @@ if CONFIG['OS_TARGET'] == 'Android':
 
 Library('breakpad_common_s')
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 FINAL_LIBRARY = 'xul'

toolkit/crashreporter/google-breakpad/src/processor/moz.build

@@ -21,6 +21,7 @@ UNIFIED_SOURCES += [
     'tokenize.cc',
 ]
 
+# We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
 
 FINAL_LIBRARY = 'xul'