Bug 625289 patch 8 - Add FIXME comments suggesting additional use of ResolveStyleContext when resolving the root frame. r=heycam

This isn't actually a problem for this patch series because the root
element can't have an ancestor that's reframed because it has no
ancestors, and reframes of the element itself trigger a restyling
operation that does actually start transitions.

That said, later patches in this bug hook in to ResolveStyleContext, and
other things might as well in the future, thus the FIXME.
This commit is contained in:
L. David Baron 2014-08-13 15:39:02 -07:00
parent b0f54ace4a
commit e191155e27

View File

@ -2408,6 +2408,9 @@ nsCSSFrameConstructor::ConstructDocElementFrame(Element* aDocEle
aDocElement->UnsetFlags(ELEMENT_ALL_RESTYLE_FLAGS);
// --------- CREATE AREA OR BOX FRAME -------
// FIXME: Should this use ResolveStyleContext? (The calls in this
// function are the only case in nsCSSFrameConstructor where we don't
// do so for the construction of a style context for an element.)
nsRefPtr<nsStyleContext> styleContext;
styleContext = mPresShell->StyleSet()->ResolveStyleFor(aDocElement,
nullptr);
@ -2440,6 +2443,10 @@ nsCSSFrameConstructor::ConstructDocElementFrame(Element* aDocEle
}
if (resolveStyle) {
// FIXME: Should this use ResolveStyleContext? (The calls in this
// function are the only case in nsCSSFrameConstructor where we
// don't do so for the construction of a style context for an
// element.)
styleContext = mPresShell->StyleSet()->ResolveStyleFor(aDocElement,
nullptr);
display = styleContext->StyleDisplay();