wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 738617 - Revert changeset 6d139ebc0f43 (bug 730139). Reserving let breaks some web sites. r=Waldo, a=mfinkle.

Browse Source
This commit is contained in:
Jason Orendorff 2012-04-18 15:07:11 -05:00
parent 02682d2114
commit e126ffe211
7 changed files with 10 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
content/xbl/test/test_bug389322.xhtml
View File

@ -113,7 +113,7 @@ function report(testName, success) {
]]></script>
<script type="text/javascript"><![CDATA[
try {
eval("let (x=1) (x)");
let (x=1) (x);
var success = false;
}
catch (e) { success = true; }

12
js/src/frontend/TokenStream.cpp
View File

@ -1323,18 +1323,12 @@ TokenStream::checkForKeyword(const jschar *s, size_t length, TokenKind *ttp, JSO
JSMSG_RESERVED_ID, kw->chars);
}
/* The let keyword is reserved on <1.7 */
if (kw->tokentype == TOK_LET) {
return ReportCompileErrorNumber(cx, this, NULL, JSREPORT_ERROR,
JSMSG_RESERVED_ID, kw->chars);
}
/*
* The keyword is not in this version. Treat it as an identifier,
* unless it is yield which we treat as TOK_STRICT_RESERVED by
* falling through to the code below (ES5 forbids it in strict mode).
* unless it is let or yield which we treat as TOK_STRICT_RESERVED by
* falling through to the code below (ES5 forbids them in strict mode).
*/
if (kw->tokentype != TOK_YIELD)
if (kw->tokentype != TOK_LET && kw->tokentype != TOK_YIELD)
return true;
}

2
js/src/jit-test/tests/basic/regress-bug720680.js
View File

@ -9,7 +9,7 @@ function addTestCase( t ) {\
SECTION,\
'(new Date('+d+')).getUTCDay()',\
WeekDay((d)),\
(new Date(foo ({ stop } = 'properties.length' )('/ab[c\\\n]/'))).getUTCDay() \
(new Date(let ({ stop } = 'properties.length' )('/ab[c\\\n]/'))).getUTCDay() \
);\
}\
");

2
js/src/tests/ecma_5/misc/future-reserved-words.js
View File

@ -21,7 +21,6 @@ var futureReservedWords =
"export",
"extends",
"import",
"let", // Reserved even for versionless code, contrary to ES5 - see bug 730139
"super",
];
@ -29,6 +28,7 @@ var strictFutureReservedWords =
[
"implements",
"interface",
"let", // enabled: this file doesn't execute as JS1.7
"package",
"private",
"protected",

14
js/src/tests/js1_5/LexicalConventions/let.js
View File

@ -1,14 +0,0 @@
/*
* Any copyright is dedicated to the Public Domain.
* http://creativecommons.org/licenses/publicdomain/
*/
var actual = 'No error';
try {
eval("var let = true");
} catch (exc) {
actual = exc + '';
}
reportCompare('SyntaxError: let is a reserved identifier', actual, 'ok');

4
js/src/tests/js1_5/Regress/regress-351515.js
View File

@ -47,6 +47,7 @@ test();
//-----------------------------------------------------------------------------
yield = 1;
let = 1;
function test()
{
@ -54,9 +55,10 @@ function test()
printBugNumber(BUGNUMBER);
printStatus (summary);
function f(yield) { return yield; }
function f(yield, let) { return yield+let; }
var yield = 1;
var let = 1;
function yield() {}

2
js/src/tests/js1_6/extensions/regress-352392.js
View File

@ -52,7 +52,7 @@ function test()
printBugNumber(BUGNUMBER);
printStatus (summary);
expect = 'SyntaxError: let is a reserved identifier';
expect = 'SyntaxError: invalid for each loop';
try
{
var obj = { };