wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 1067805 - Pushed a wrong version of the part 1 in bug 1001090; fix that. (r=me)

Browse Source
This commit is contained in:
Shu-yu Guo 2014-09-16 03:23:06 -07:00
parent cbe73fc537
commit defbbb4e7a
2 changed files with 2 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
js/src/frontend/Parser.cpp
View File

@ -121,36 +121,7 @@ MarkUsesAsHoistedLexical(ParseNode *pn)
// Distinguish hoisted uses as a different JSOp for easier compilation.
while ((pnu = *pnup) != nullptr && pnu->pn_blockid >= start) {
MOZ_ASSERT(pnu->isUsed());
// JavaScript is parsed in dominator order. This condition says to
// mark uses which either:
//
// 1) Is at the same dominator level.
//
// This covers the case where the right hand side of declarations
// cannot refer to the binding itself. e.g, |let x = x| is a
// ReferenceError. Note that the use of 'x' follows the definition
// node 'let x' in the program text.
//
// 2) Precedes the definition in the program text.
//
// This covers all hoisted uses.
//
// The uses that are not covered by these two conditions are uses of
// the binding as free variables in function definitions on the right
// hand side of the binding node. e.g.,
//
// let x = function () { x(); }
//
// does not mark the upvar use of 'x' inside the lambda as needing a
// TDZ check.
//
// N.B. This function expects to be called at the point of defining
// the lexical binding, and should not be called afterwards, as it
// would erroneously unmark hoisted function definitions and needing
// TDZ checks, which is currently handled in leaveFunction.
if (pnu->pn_blockid == start || pnu->pn_pos < pn->pn_pos)
pnu->pn_dflags |= PND_LET;
pnu->pn_dflags |= PND_LET;
pnup = &pnu->pn_link;
}
}

1
js/src/jit-test/tests/basic/testLet.js
View File

@ -324,6 +324,7 @@ isReferenceError('let [x] = [x];');
isReferenceError('let {x} = {x:x};');
isReferenceError('switch (x) {case 3:let x;break;default:if (x === undefined) {return "ponies";}}');
isReferenceError('let x = function() {} ? x() : function() {}');
isReferenceError('(function() { let x = (function() { return x }()); }())');
// redecl with function statements
isParseError('let a; function a() {}');