wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 396412, crash setting left/top attributes on a popup that hasn't been opened, r+sr=bz,a=dbaron

Browse Source
This commit is contained in:
enndeakin@sympatico.ca 2007-09-18 07:32:22 -07:00
parent a2387c6402
commit dbd41f890e
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
layout/xul/base/src/nsMenuPopupFrame.cpp
View File

@ -1622,9 +1622,12 @@ nsMenuPopupFrame::MoveToInternal(PRInt32 aLeft, PRInt32 aTop)
aLeft = context->AppUnitsToDevPixels(nsPresContext::CSSPixelsToAppUnits(aLeft));
aTop = context->AppUnitsToDevPixels(nsPresContext::CSSPixelsToAppUnits(aTop));
// Move the widget
// Move the widget. The widget will be null if it hasn't been created yet,
// but that's OK as the popup won't be open in this case.
// XXXbz don't we want screenPos to be the parent _widget_'s position, then?
view->GetWidget()->Move(aLeft - screenPos.x, aTop - screenPos.y);
nsIWidget* widget = view->GetWidget();
if (widget)
widget->Move(aLeft - screenPos.x, aTop - screenPos.y);
}
void

1
layout/xul/base/src/nsXULPopupManager.cpp
View File

@ -194,6 +194,7 @@ nsXULPopupManager::GetSubmenuWidgetChain(nsISupportsArray **_retval)
while (item) {
nsCOMPtr<nsIWidget> widget;
item->Frame()->GetWidget(getter_AddRefs(widget));
NS_ASSERTION(widget, "open popup has no widget");
nsCOMPtr<nsISupports> genericWidget(do_QueryInterface(widget));
(*_retval)->AppendElement(genericWidget);
// In the case when a menulist inside a panel is open, clicking in the