wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 1246314 - Add comment to explain why we don't log exceptions. r=me

Browse Source
This commit is contained in:
Michael Comella 2016-02-05 16:38:05 -08:00
parent 8e437865d7
commit db10d75d83
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mobile/android/base/java/org/mozilla/gecko/GeckoProfile.java
View File

@ -616,6 +616,7 @@ public final class GeckoProfile {
try { try {
clientIdFileContents = readFile(CLIENT_ID_FILE_PATH); clientIdFileContents = readFile(CLIENT_ID_FILE_PATH);
} catch (final IOException e) { } catch (final IOException e) {
// Don't log exception to avoid leaking profile path.
throw new IOException("Could not read client ID file to retrieve client ID"); throw new IOException("Could not read client ID file to retrieve client ID");
} }
@ -623,6 +624,7 @@ public final class GeckoProfile {
final org.json.JSONObject json = new org.json.JSONObject(clientIdFileContents); final org.json.JSONObject json = new org.json.JSONObject(clientIdFileContents);
return json.getString(CLIENT_ID_JSON_ATTR); return json.getString(CLIENT_ID_JSON_ATTR);
} catch (final JSONException e) { } catch (final JSONException e) {
// Don't log exception to avoid leaking profile path.
throw new IOException("Could not parse JSON to retrieve client ID"); throw new IOException("Could not parse JSON to retrieve client ID");
} }
} }