Bug 877523 - Correctly handle small maximum delay values for DelayNode; r=roc

This commit is contained in:
Ehsan Akhgari 2013-05-30 20:52:26 -04:00
parent 9fe092d49d
commit d822bd3533
3 changed files with 45 additions and 1 deletions

View File

@ -116,7 +116,7 @@ public:
if (!mBuffer.SetLength(aNumberOfChannels)) {
return false;
}
const int32_t numFrames = NS_lround(mMaxDelay) * aSampleRate;
const int32_t numFrames = NS_lround(mMaxDelay * aSampleRate);
for (uint32_t channel = 0; channel < aNumberOfChannels; ++channel) {
if (!mBuffer[channel].SetLength(numFrames)) {
return false;

View File

@ -53,6 +53,7 @@ MOCHITEST_FILES := \
test_channelSplitterNodeWithVolume.html \
test_currentTime.html \
test_delayNode.html \
test_delayNodeSmallMaxDelay.html \
test_delayNodeWithGain.html \
test_delayNodeWithGainAlternate.html \
test_dynamicsCompressorNode.html \

View File

@ -0,0 +1,43 @@
<!DOCTYPE HTML>
<html>
<head>
<title>Test DelayNode</title>
<script type="text/javascript" src="/tests/SimpleTest/SimpleTest.js"></script>
<link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css" />
</head>
<body>
<pre id="test">
<script src="webaudio.js" type="text/javascript"></script>
<script class="testbody" type="text/javascript">
var gTest = {
length: 2048,
numberOfChannels: 1,
createGraph: function(context) {
var source = context.createBufferSource();
var delay = context.createDelay(0.02);
source.buffer = this.buffer;
source.connect(delay);
source.start(0);
return delay;
},
createExpectedBuffers: function(context) {
var expectedBuffer = context.createBuffer(1, 2048, context.sampleRate);
for (var i = 0; i < 2048; ++i) {
expectedBuffer.getChannelData(0)[i] = Math.sin(440 * 2 * Math.PI * i / context.sampleRate);
}
this.buffer = expectedBuffer;
return expectedBuffer;
},
};
runTest();
</script>
</pre>
</body>
</html>