Bug 1044162 - part 0a - make additions to EXTRA_JS_MODULES use += instead of =; r=mshal

Straight assignments to HierarchicalStringList, which we'll change
EXTRA_JS_MODULES to in a later patch, don't work.  This change, in
addition to making things work as expected later on, also is more
consistent with existing practice.

dom/mobilemessage/src/moz.build

@@ -19,7 +19,7 @@ if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'android':
         'android/SmsService.cpp',
     ]
 elif CONFIG['MOZ_WIDGET_TOOLKIT'] == 'gonk' and CONFIG['MOZ_B2G_RIL']:
-    EXTRA_JS_MODULES = [
+    EXTRA_JS_MODULES += [
         'gonk/mms_consts.js',
         'gonk/MmsPduHelper.jsm',
         'gonk/MobileMessageDB.jsm',

dom/network/src/moz.build

@@ -27,7 +27,7 @@ UNIFIED_SOURCES += [
 ]
 
 if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'gonk':
-    EXTRA_JS_MODULES = [
+    EXTRA_JS_MODULES += [
         'NetworkStatsDB.jsm',
         'NetworkStatsService.jsm',
     ]

dom/wappush/src/moz.build

@@ -5,7 +5,7 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'gonk' and CONFIG['MOZ_B2G_RIL']:
-    EXTRA_JS_MODULES = [
+    EXTRA_JS_MODULES += [
         'gonk/CpPduHelper.jsm',
         'gonk/SiPduHelper.jsm',
         'gonk/SlPduHelper.jsm',

python/mozbuild/mozbuild/test/backend/data/variable_passthru/moz.build

@@ -7,7 +7,7 @@ SOURCES += ['bar.s', 'foo.asm']
 EXTRA_COMPONENTS = ['bar.js', 'foo.js']
 EXTRA_PP_COMPONENTS = ['bar.pp.js', 'foo.pp.js']
 
-EXTRA_JS_MODULES = ['bar.jsm', 'foo.jsm']
+EXTRA_JS_MODULES += ['bar.jsm', 'foo.jsm']
 EXTRA_PP_JS_MODULES = ['bar.pp.jsm', 'foo.pp.jsm']
 
 HOST_SOURCES += ['bar.cpp', 'foo.cpp']

python/mozbuild/mozbuild/test/frontend/data/variable-passthru/moz.build

@@ -7,7 +7,7 @@ SOURCES += ['fans.asm', 'tans.s']
 EXTRA_COMPONENTS=['fans.js', 'tans.js']
 EXTRA_PP_COMPONENTS=['fans.pp.js', 'tans.pp.js']
 
-EXTRA_JS_MODULES = ['bar.jsm', 'foo.jsm']
+EXTRA_JS_MODULES += ['bar.jsm', 'foo.jsm']
 EXTRA_PP_JS_MODULES = ['bar.pp.jsm', 'foo.pp.jsm']
 
 HOST_SOURCES += ['fans.cpp', 'tans.cpp']

toolkit/components/crashmonitor/moz.build

@@ -6,11 +6,11 @@
 
 XPCSHELL_TESTS_MANIFESTS += ['test/unit/xpcshell.ini']
 
-EXTRA_JS_MODULES = [
+EXTRA_JS_MODULES += [
     'CrashMonitor.jsm',
 ]
 
 EXTRA_COMPONENTS += [
     'crashmonitor.manifest',
     'nsCrashMonitor.js',
-]
+]

toolkit/components/places/moz.build

@@ -59,7 +59,7 @@ if CONFIG['MOZ_PLACES']:
         '../build',
     ]
 
-    EXTRA_JS_MODULES = [
+    EXTRA_JS_MODULES += [
         'BookmarkHTMLUtils.jsm',
         'BookmarkJSONUtils.jsm',
         'ClusterLib.js',

toolkit/components/promiseworker/moz.build

@@ -8,6 +8,6 @@ DIRS += [
     'worker'
 ]
 
-EXTRA_JS_MODULES = [
+EXTRA_JS_MODULES += [
     'PromiseWorker.jsm',
 ]

toolkit/components/social/moz.build

@@ -10,7 +10,7 @@ if CONFIG['MOZ_SOCIAL']:
     BROWSER_CHROME_MANIFESTS += ['test/browser/browser.ini']
 
     # social is turned off for android
-    EXTRA_JS_MODULES = [
+    EXTRA_JS_MODULES += [
         'FrameWorker.jsm',
         'FrameWorkerContent.js',
         'MessagePortBase.jsm',

tools/profiler/moz.build

@@ -19,7 +19,7 @@ if CONFIG['MOZ_ENABLE_PROFILER_SPS']:
         'PseudoStack.h',
         'shared-libraries.h',
     ]
-    EXTRA_JS_MODULES = [
+    EXTRA_JS_MODULES += [
         'Profiler.jsm',
     ]
     UNIFIED_SOURCES += [