Bug 1231728 - Enable no-dupe-args, no-dupe-keys, no-duplicate-case, no-obj-calls, no-with rules globally, no-redlecare and consistent-return in browser. r=Mossop

browser/.eslintrc

@@ -1,5 +1,13 @@
 {
   "extends": [
     "../toolkit/.eslintrc"
-  ]
+  ],
+
+  "rules": {
+    // No redeclaring variables
+    "no-redeclare": 2,
+
+    // Functions must always return something or nothing
+    "consistent-return": 2,
+  }
 }

toolkit/.eslintrc

@@ -53,13 +53,13 @@
     // "no-array-constructor": 2,
 
     // No duplicate arguments in function declarations
-    // "no-dupe-args": 2,
+    "no-dupe-args": 2,
 
     // No duplicate keys in object declarations
-    // "no-dupe-keys": 2,
+    "no-dupe-keys": 2,
 
     // No duplicate cases in switch statements
-    // "no-duplicate-case": 2,
+    "no-duplicate-case": 2,
 
     // No labels
     // "no-labels": 2,
@@ -116,7 +116,7 @@
     // "no-new-object": 2,
 
     // No Math() or JSON()
-    // "no-obj-calls": 2,
+    "no-obj-calls": 2,
 
     // No octal literals
     // "no-octal": 2,
@@ -158,7 +158,7 @@
     // "no-use-before-define": [2, "nofunc"],
 
     // No using with
-    // "no-with": 2,
+    "no-with": 2,
 
     // Always require semicolon at end of statement
     // "semi": [2, "always"],