Bug 1235308 - Fix -Wimplicit-fallthrough warnings in security/. r=keeler

security/certverifier/NSSCertDBTrustDomain.cpp:282:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
security/manager/ssl/nsNSSComponent.cpp:149:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
security/manager/ssl/nsSecureBrowserUIImpl.cpp:1406:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
This commit is contained in:
Chris Peterson 2015-12-25 00:03:35 -07:00
parent 10848ade35
commit d660932182
3 changed files with 5 additions and 5 deletions

View File

@ -264,7 +264,6 @@ NSSCertDBTrustDomain::DigestBuf(Input item, DigestAlgorithm digestAlg,
return DigestBufNSS(item, digestAlg, digestBuf, digestBufLen);
}
static PRIntervalTime
OCSPFetchingTypeToTimeoutTime(NSSCertDBTrustDomain::OCSPFetching ocspFetching)
{
@ -279,9 +278,10 @@ OCSPFetchingTypeToTimeoutTime(NSSCertDBTrustDomain::OCSPFetching ocspFetching)
case NSSCertDBTrustDomain::NeverFetchOCSP:
case NSSCertDBTrustDomain::LocalOnlyOCSPForEV:
PR_NOT_REACHED("we should never see this OCSPFetching type here");
default:
PR_NOT_REACHED("we're not handling every OCSPFetching type");
break;
}
PR_NOT_REACHED("we're not handling every OCSPFetching type");
return PR_SecondsToInterval(2);
}

View File

@ -135,7 +135,7 @@ bool EnsureNSSInitialized(EnsureNSSOperator op)
case nssInitFailed:
NS_ASSERTION(loading, "Bad call to EnsureNSSInitialized(nssInitFailed)");
loading = false;
// no break
MOZ_FALLTHROUGH;
case nssShutdown:
PR_AtomicSet(&haveLoaded, 0);

View File

@ -1324,7 +1324,7 @@ nsSecureBrowserUIImpl::GetSSLStatus(nsISSLStatus** _result)
break;
default:
NS_NOTREACHED("if this is reached you must add more entries to the switch");
MOZ_FALLTHROUGH_ASSERT("if this is reached you must add more entries to the switch");
case lis_no_security:
*_result = nullptr;
return NS_OK;