From d5b901ad3bfa4451a43f1460e0f63efc3c71e97a Mon Sep 17 00:00:00 2001 From: "florian@queze.net" Date: Tue, 22 Jan 2008 20:35:04 -0800 Subject: [PATCH] Bug 412019 - Applications pref pane: sorting by application only partially remembered. r=gavin, a1.9=beltzner --- browser/components/preferences/applications.js | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/browser/components/preferences/applications.js b/browser/components/preferences/applications.js index de7e5d10a0b..e0a9c0587ca 100755 --- a/browser/components/preferences/applications.js +++ b/browser/components/preferences/applications.js @@ -850,10 +850,16 @@ var gApplicationsPane = { // Figure out how we should be sorting the list. We persist sort settings // across sessions, so we can't assume the default sort column/direction. // XXX should we be using the XUL sort service instead? - if (document.getElementById("typeColumn").hasAttribute("sortDirection")) - this._sortColumn = document.getElementById("typeColumn"); - else if (document.getElementById("actionColumn").hasAttribute("sortDirection")) + if (document.getElementById("actionColumn").hasAttribute("sortDirection")) { this._sortColumn = document.getElementById("actionColumn"); + // The typeColumn element always has a sortDirection attribute, + // either because it was persisted or because the default value + // from the xul file was used. If we are sorting on the other + // column, we should remove it. + document.getElementById("typeColumn").removeAttribute("sortDirection"); + } + else + this._sortColumn = document.getElementById("typeColumn"); // Load the data and build the list of handlers. // By doing this in a timeout, we let the preferences dialog resize itself