wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 763011 - Report telemetry data for whether or not updates are enabled. r=rstrong

Browse Source
This commit is contained in:
Brian R. Bondy 2012-06-15 11:59:35 -04:00
parent 311cae060f
commit d5a8bf8d85
2 changed files with 33 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
toolkit/components/telemetry/TelemetryHistograms.h
View File

@ -314,6 +314,7 @@ HISTOGRAM(PLACES_FRECENCY_CALC_TIME_MS, 1, 100, 10, EXPONENTIAL, "PLACES: Time t
* Updater telemetry.
*/
HISTOGRAM(UPDATER_STATUS_CODES, 1, 50, 51, LINEAR, "Updater: the status of the latest update performed")
HISTOGRAM_BOOLEAN(UPDATER_UPDATES_ENABLED, "Updater: Whether or not updates are enabled")
/**
* Thunderbird-specific telemetry.

34
toolkit/mozapps/update/nsUpdateService.js
View File

@ -1592,8 +1592,17 @@ UpdateService.prototype = {
createInstance(Ci.nsIUpdatePrompt);
update.state = status;
this._submitTelemetryPing(status);
this._sendStatusCodeTelemetryPing(status);
if (status == STATE_SUCCEEDED) {
// Report telemetry that we want after each successful update.
// We do this only on successful updates so that we only get
// one report from each user for each version. If a user cancels
// UAC for example, we don't want 2 reports from them on the same
// version.
this._sendBoolPrefTelemetryPing(PREF_APP_UPDATE_ENABLED,
"UPDATER_UPDATES_ENABLED");
update.statusText = gUpdateBundle.GetStringFromName("installSuccess");
// Update the patch's metadata.
@ -1628,13 +1637,34 @@ UpdateService.prototype = {
}
},
/**
* Submit a telemetry ping with the boolean value of a pref for a histogram
*
* @param pref
* The preference to report
* @param histogram
* The histogram ID to report to
*/
_sendBoolPrefTelemetryPing: function AUS__boolTelemetryPing(pref, histogram) {
try {
// The getPref is already wrapped in a try/catch but we never
// want telemetry pings breaking app update so we just put it
// inside the try to be safe.
let val = getPref("getBoolPref", pref, false);
Services.telemetry.getHistogramById(histogram).add(+val);
} catch(e) {
// Don't allow any exception to be propagated.
Components.utils.reportError(e);
}
},
/**
* Submit the results of applying the update via telemetry.
*
* @param status
* The status of the update as read from the update.status file
*/
_submitTelemetryPing: function AUS__submitTelemetryPing(status) {
_sendStatusCodeTelemetryPing: function AUS__statusTelemetryPing(status) {
try {
let parts = status.split(":");
if ((parts.length == 1 && status != STATE_SUCCEEDED) ||