diff --git a/browser/base/content/browser.js b/browser/base/content/browser.js index df1d34168bf..ff18c60c6b2 100644 --- a/browser/base/content/browser.js +++ b/browser/base/content/browser.js @@ -4061,7 +4061,8 @@ var CombinedStopReload = { var stop = document.getElementById("stop-button"); if (urlbar) { - if (!reload || urlbar.nextSibling != reload || + if (urlbar.parentNode.getAttribute("mode") != "icons" || + !reload || urlbar.nextSibling != reload || !stop || reload.nextSibling != stop) urlbar.removeAttribute("combined"); else { diff --git a/browser/base/content/browser.xul b/browser/base/content/browser.xul index 01abe7ad6fc..b7afb1199fd 100644 --- a/browser/base/content/browser.xul +++ b/browser/base/content/browser.xul @@ -532,145 +532,145 @@ customizationtarget="nav-bar-customizationtarget" context="toolbar-context-menu"> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + tooltip="back-button-tooltip"/> + + + - + + + + + + + + + + + + + - - + + + + + + + + + + + + + + - - - - - - diff --git a/browser/components/customizableui/src/CustomizableUI.jsm b/browser/components/customizableui/src/CustomizableUI.jsm index 3119ddd9528..da5ce0f734d 100644 --- a/browser/components/customizableui/src/CustomizableUI.jsm +++ b/browser/components/customizableui/src/CustomizableUI.jsm @@ -224,16 +224,11 @@ let gFuturePlacements = new Map(); */ let gDefaultPlacements = new Map([ ["nav-bar", [ - "unified-back-forward-button", - "urlbar-container", - "reload-button", - "stop-button", "search-container", - "webrtc-status-button", "bookmarks-menu-button-container", "downloads-button", - "home-button", "social-toolbar-button", + "PanelUI-button", "share-page" ]], ["PanelUI-contents", [ @@ -376,7 +371,6 @@ let CustomizableUIInternal = { let placements = gPlacements.get(area); this.buildArea(area, placements, aToolbar); - aToolbar.setAttribute("currentset", placements.join(",")); // We register this window to have its customization data cleaned up when // unloading. diff --git a/browser/components/customizableui/src/CustomizeMode.jsm b/browser/components/customizableui/src/CustomizeMode.jsm index 1578969949a..d1ee9ccd54a 100644 --- a/browser/components/customizableui/src/CustomizeMode.jsm +++ b/browser/components/customizableui/src/CustomizeMode.jsm @@ -375,15 +375,19 @@ CustomizeMode.prototype = { // also want to (try) persisting with currentset as well to make it // less painful to switch to older builds. persistCurrentSets: function() { - let document = this.document; - let toolbars = document.querySelectorAll("toolbar"); + //XXXjaws The toolbar bindings that are included in this changeset (/browser/base/content/toolbar.xml) + // don't implement currentSet. They probably need to inherit the toolkit bindings. + return; - for (let toolbar of toolbars) { - // Calculate currentset and store it in the attribute. - toolbar.setAttribute("currentset", toolbar.currentSet); - // Persist the currentset attribute directly on hardcoded toolbars. - document.persist(toolbar.id, "currentset"); - } + let document = this.document; + let toolbar = document.getElementById("nav-bar"); + + // Calculate currentset and store it in the attribute. + let currentSet = toolbar.currentSet; + toolbar.setAttribute("currentset", currentSet); + + // Persist the currentset attribute directly on hardcoded toolbars. + document.persist(toolbar.id, "currentset"); }, reset: function() { diff --git a/browser/themes/linux/browser.css b/browser/themes/linux/browser.css index 98d4b5d8f5b..d508482a0d8 100644 --- a/browser/themes/linux/browser.css +++ b/browser/themes/linux/browser.css @@ -15,8 +15,8 @@ %define fgTabTexture linear-gradient(transparent 0px, transparent 1px, hsla(0,0%,100%,0.35) 1px, hsla(0,0%,100%,0.35) 2px, hsla(0,0%,100%,0.65) 2px, hsla(0,0%,100%,0.65) 3px, @toolbarHighlight@) %define fgTabBackgroundMiddle @fgTabTexture@, linear-gradient(transparent 0px, transparent 2px, -moz-dialog 2px, -moz-dialog) %define forwardTransitionLength 150ms -%define conditionalForwardWithUrlbar window:not([chromehidden~=toolbar]) :-moz-any(#nav-bar[currentset*="unified-back-forward-button,urlbar-container"], #nav-bar:not([currentset])) > #nav-bar-customizationtarget > #unified-back-forward-button -%define conditionalForwardWithUrlbar_small window:not([chromehidden~=toolbar]) :-moz-any(#nav-bar[currentset*="unified-back-forward-button,urlbar-container"][iconsize=small],#nav-bar:not([currentset])[iconsize=small]) > #nav-bar-customizationtarget > #unified-back-forward-button +%define conditionalForwardWithUrlbar window:not([chromehidden~=toolbar]) :-moz-any(#nav-bar[currentset*="unified-back-forward-button,urlbar-container"], #nav-bar:not([currentset])) > #unified-back-forward-button +%define conditionalForwardWithUrlbar_small window:not([chromehidden~=toolbar]) :-moz-any(#nav-bar[currentset*="unified-back-forward-button,urlbar-container"][iconsize=small],#nav-bar:not([currentset])[iconsize=small]) > #unified-back-forward-button %define conditionalForwardWithUrlbarWidth 32 %define conditionalForwardWithUrlbarWidth_small 24 diff --git a/browser/themes/osx/browser.css b/browser/themes/osx/browser.css index 62bfec6850f..99b2166758a 100644 --- a/browser/themes/osx/browser.css +++ b/browser/themes/osx/browser.css @@ -9,7 +9,7 @@ %define fgTabTexture linear-gradient(hsla(0,0%,100%,0.6), hsla(0,0%,100%,0.6) 0px, hsl(0,0%,99%) 1px, hsl(0,0%,92%)) %define fgTabBackgroundMiddle linear-gradient(transparent, transparent) %define forwardTransitionLength 150ms -%define conditionalForwardWithUrlbar window:not([chromehidden~=toolbar]) #navigator-toolbox[iconsize=large] > :-moz-any(#nav-bar[currentset*="unified-back-forward-button,urlbar-container"],#nav-bar:not([currentset])) > #nav-bar-customizationtarget > #unified-back-forward-button +%define conditionalForwardWithUrlbar window:not([chromehidden~=toolbar]) #navigator-toolbox[iconsize=large] > :-moz-any(#nav-bar[currentset*="unified-back-forward-button,urlbar-container"],#nav-bar:not([currentset])) > #unified-back-forward-button %define conditionalForwardWithUrlbarWidth 27 @namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"); diff --git a/browser/themes/windows/browser.css b/browser/themes/windows/browser.css index 3dc64b52e58..bdc819d2e00 100644 --- a/browser/themes/windows/browser.css +++ b/browser/themes/windows/browser.css @@ -15,7 +15,7 @@ %define navbarTextboxCustomBorder border-color: rgba(0,0,0,.32); %define navbarLargeIcons #navigator-toolbox[iconsize=large] > #nav-bar %define forwardTransitionLength 150ms -%define conditionalForwardWithUrlbar window:not([chromehidden~=toolbar]) #navigator-toolbox[iconsize=large] > :-moz-any(#nav-bar[currentset*="unified-back-forward-button,urlbar-container"],#nav-bar:not([currentset])) > #nav-bar-customizationtarget > #unified-back-forward-button +%define conditionalForwardWithUrlbar window:not([chromehidden~=toolbar]) #navigator-toolbox[iconsize=large] > :-moz-any(#nav-bar[currentset*="unified-back-forward-button,urlbar-container"],#nav-bar:not([currentset])) > #unified-back-forward-button %define conditionalForwardWithUrlbarWidth 27 %ifdef MOZ_OFFICIAL_BRANDING