From d34f8e816f40636a8151f58fd42ecbdfe4db34ea Mon Sep 17 00:00:00 2001 From: Chris Peterson Date: Wed, 20 Aug 2014 22:36:57 -0700 Subject: [PATCH] Bug 1036781 - Part 3: Replace MOZ_ASSUME_UNREACHABLE with MOZ_CRASH in js/src/jit for x86 and x64. r=jandem --- js/src/jit/shared/Assembler-x86-shared.cpp | 2 +- js/src/jit/shared/Assembler-x86-shared.h | 146 +++++++++--------- .../jit/shared/CodeGenerator-x86-shared.cpp | 17 +- js/src/jit/shared/MacroAssembler-x86-shared.h | 8 +- js/src/jit/shared/MoveEmitter-x86-shared.cpp | 6 +- js/src/jit/x64/Assembler-x64.cpp | 4 +- js/src/jit/x64/Assembler-x64.h | 28 ++-- js/src/jit/x64/Bailouts-x64.cpp | 2 +- js/src/jit/x64/BaselineIC-x64.cpp | 4 +- js/src/jit/x64/CodeGenerator-x64.cpp | 16 +- js/src/jit/x64/Lowering-x64.cpp | 4 +- js/src/jit/x64/MacroAssembler-x64.cpp | 6 +- js/src/jit/x64/MacroAssembler-x64.h | 2 +- js/src/jit/x64/Trampoline-x64.cpp | 8 +- js/src/jit/x86/MacroAssembler-x86.cpp | 2 +- 15 files changed, 127 insertions(+), 128 deletions(-) diff --git a/js/src/jit/shared/Assembler-x86-shared.cpp b/js/src/jit/shared/Assembler-x86-shared.cpp index 066784d8dcc..c6f18fc064c 100644 --- a/js/src/jit/shared/Assembler-x86-shared.cpp +++ b/js/src/jit/shared/Assembler-x86-shared.cpp @@ -128,6 +128,6 @@ AssemblerX86Shared::InvertCondition(Condition cond) case BelowOrEqual: return Above; default: - MOZ_ASSUME_UNREACHABLE("unexpected condition"); + MOZ_CRASH("unexpected condition"); } } diff --git a/js/src/jit/shared/Assembler-x86-shared.h b/js/src/jit/shared/Assembler-x86-shared.h index a08d637a162..8254d881abf 100644 --- a/js/src/jit/shared/Assembler-x86-shared.h +++ b/js/src/jit/shared/Assembler-x86-shared.h @@ -246,7 +246,7 @@ class AssemblerX86Shared : public AssemblerShared return NaN_IsTrue; } - MOZ_ASSUME_UNREACHABLE("Unknown double condition"); + MOZ_CRASH("Unknown double condition"); } static void StaticAsserts() { @@ -370,7 +370,7 @@ class AssemblerX86Shared : public AssemblerShared masm.movl_mr(src.address(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void movl(Register src, const Operand &dest) { @@ -388,7 +388,7 @@ class AssemblerX86Shared : public AssemblerShared masm.movl_rm(src.code(), dest.address()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void movl(Imm32 imm32, const Operand &dest) { @@ -403,7 +403,7 @@ class AssemblerX86Shared : public AssemblerShared masm.movl_i32m(imm32.value, dest.disp(), dest.base(), dest.index(), dest.scale()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } @@ -432,7 +432,7 @@ class AssemblerX86Shared : public AssemblerShared masm.movaps_mr(src.disp(), src.base(), src.index(), src.scale(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void movaps(FloatRegister src, const Operand &dest) { @@ -445,7 +445,7 @@ class AssemblerX86Shared : public AssemblerShared masm.movaps_rm(src.code(), dest.disp(), dest.base(), dest.index(), dest.scale()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void movups(const Operand &src, FloatRegister dest) { @@ -458,7 +458,7 @@ class AssemblerX86Shared : public AssemblerShared masm.movups_mr(src.disp(), src.base(), src.index(), src.scale(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void movups(FloatRegister src, const Operand &dest) { @@ -471,7 +471,7 @@ class AssemblerX86Shared : public AssemblerShared masm.movups_rm(src.code(), dest.disp(), dest.base(), dest.index(), dest.scale()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } @@ -512,7 +512,7 @@ class AssemblerX86Shared : public AssemblerShared masm.movdqu_mr(src.disp(), src.base(), src.index(), src.scale(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void movdqu(FloatRegister src, const Operand &dest) { @@ -525,7 +525,7 @@ class AssemblerX86Shared : public AssemblerShared masm.movdqu_rm(src.code(), dest.disp(), dest.base(), dest.index(), dest.scale()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void movdqa(const Operand &src, FloatRegister dest) { @@ -538,7 +538,7 @@ class AssemblerX86Shared : public AssemblerShared masm.movdqa_mr(src.disp(), src.base(), src.index(), src.scale(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void movdqa(FloatRegister src, const Operand &dest) { @@ -551,7 +551,7 @@ class AssemblerX86Shared : public AssemblerShared masm.movdqa_rm(src.code(), dest.disp(), dest.base(), dest.index(), dest.scale()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void movdqa(FloatRegister src, FloatRegister dest) { @@ -575,7 +575,7 @@ class AssemblerX86Shared : public AssemblerShared masm.movzbl_mr(src.disp(), src.base(), src.index(), src.scale(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void movsbl(const Operand &src, Register dest) { @@ -587,7 +587,7 @@ class AssemblerX86Shared : public AssemblerShared masm.movsbl_mr(src.disp(), src.base(), src.index(), src.scale(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void movb(Register src, const Operand &dest) { @@ -599,7 +599,7 @@ class AssemblerX86Shared : public AssemblerShared masm.movb_rm(src.code(), dest.disp(), dest.base(), dest.index(), dest.scale()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void movb(Imm32 src, const Operand &dest) { @@ -611,7 +611,7 @@ class AssemblerX86Shared : public AssemblerShared masm.movb_i8m(src.value, dest.disp(), dest.base(), dest.index(), dest.scale()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void movzwl(const Operand &src, Register dest) { @@ -626,7 +626,7 @@ class AssemblerX86Shared : public AssemblerShared masm.movzwl_mr(src.disp(), src.base(), src.index(), src.scale(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void movzwl(Register src, Register dest) { @@ -641,7 +641,7 @@ class AssemblerX86Shared : public AssemblerShared masm.movw_rm(src.code(), dest.disp(), dest.base(), dest.index(), dest.scale()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void movw(Imm32 src, const Operand &dest) { @@ -653,7 +653,7 @@ class AssemblerX86Shared : public AssemblerShared masm.movw_i16m(src.value, dest.disp(), dest.base(), dest.index(), dest.scale()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void movswl(const Operand &src, Register dest) { @@ -665,7 +665,7 @@ class AssemblerX86Shared : public AssemblerShared masm.movswl_mr(src.disp(), src.base(), src.index(), src.scale(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void leal(const Operand &src, Register dest) { @@ -677,7 +677,7 @@ class AssemblerX86Shared : public AssemblerShared masm.leal_mr(src.disp(), src.base(), src.index(), src.scale(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } @@ -763,7 +763,7 @@ class AssemblerX86Shared : public AssemblerShared masm.jmp_r(op.reg()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void cmpEAX(Label *label) { cmpSrc(label); } @@ -862,7 +862,7 @@ class AssemblerX86Shared : public AssemblerShared masm.call_m(op.disp(), op.base()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } @@ -897,7 +897,7 @@ class AssemblerX86Shared : public AssemblerShared masm.cmpl_mr(rhs.disp(), rhs.base(), lhs.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void cmpl(Register src, Imm32 imm) { @@ -918,7 +918,7 @@ class AssemblerX86Shared : public AssemblerShared masm.cmpl_im(imm.value, op.address()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void cmpl(const Operand &lhs, Register rhs) { @@ -933,7 +933,7 @@ class AssemblerX86Shared : public AssemblerShared masm.cmpl_rm(rhs.code(), lhs.address()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void cmpl(const Operand &op, ImmWord imm) { @@ -948,7 +948,7 @@ class AssemblerX86Shared : public AssemblerShared masm.cmpl_im(imm.value, op.address()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void cmpl(const Operand &op, ImmPtr imm) { @@ -990,7 +990,7 @@ class AssemblerX86Shared : public AssemblerShared masm.testl_i32m(rhs.value, lhs.address()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); break; } } @@ -1010,7 +1010,7 @@ class AssemblerX86Shared : public AssemblerShared masm.addl_im(imm.value, op.address()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void subl(Imm32 imm, Register dest) { @@ -1025,7 +1025,7 @@ class AssemblerX86Shared : public AssemblerShared masm.subl_im(imm.value, op.disp(), op.base()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void addl(Register src, Register dest) { @@ -1043,7 +1043,7 @@ class AssemblerX86Shared : public AssemblerShared masm.subl_mr(src.disp(), src.base(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void subl(Register src, const Operand &dest) { @@ -1055,7 +1055,7 @@ class AssemblerX86Shared : public AssemblerShared masm.subl_rm(src.code(), dest.disp(), dest.base()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void orl(Register reg, Register dest) { @@ -1073,7 +1073,7 @@ class AssemblerX86Shared : public AssemblerShared masm.orl_im(imm.value, op.disp(), op.base()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void xorl(Register src, Register dest) { @@ -1091,7 +1091,7 @@ class AssemblerX86Shared : public AssemblerShared masm.xorl_im(imm.value, op.disp(), op.base()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void andl(Register src, Register dest) { @@ -1109,7 +1109,7 @@ class AssemblerX86Shared : public AssemblerShared masm.andl_im(imm.value, op.disp(), op.base()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void addl(const Operand &src, Register dest) { @@ -1121,7 +1121,7 @@ class AssemblerX86Shared : public AssemblerShared masm.addl_mr(src.disp(), src.base(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void orl(const Operand &src, Register dest) { @@ -1133,7 +1133,7 @@ class AssemblerX86Shared : public AssemblerShared masm.orl_mr(src.disp(), src.base(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void xorl(const Operand &src, Register dest) { @@ -1145,7 +1145,7 @@ class AssemblerX86Shared : public AssemblerShared masm.xorl_mr(src.disp(), src.base(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void andl(const Operand &src, Register dest) { @@ -1157,7 +1157,7 @@ class AssemblerX86Shared : public AssemblerShared masm.andl_mr(src.disp(), src.base(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void imull(Register multiplier) { @@ -1181,7 +1181,7 @@ class AssemblerX86Shared : public AssemblerShared masm.imull_mr(src.disp(), src.base(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void negl(const Operand &src) { @@ -1193,7 +1193,7 @@ class AssemblerX86Shared : public AssemblerShared masm.negl_m(src.disp(), src.base()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void negl(Register reg) { @@ -1208,7 +1208,7 @@ class AssemblerX86Shared : public AssemblerShared masm.notl_m(src.disp(), src.base()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void notl(Register reg) { @@ -1239,7 +1239,7 @@ class AssemblerX86Shared : public AssemblerShared masm.incl_m32(op.disp(), op.base()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void lock_incl(const Operand &op) { @@ -1253,7 +1253,7 @@ class AssemblerX86Shared : public AssemblerShared masm.decl_m32(op.disp(), op.base()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void lock_decl(const Operand &op) { @@ -1268,7 +1268,7 @@ class AssemblerX86Shared : public AssemblerShared masm.cmpxchg32(src.code(), op.disp(), op.base()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } @@ -1281,7 +1281,7 @@ class AssemblerX86Shared : public AssemblerShared masm.xaddl_rm(srcdest.code(), mem.disp(), mem.base(), mem.index(), mem.scale()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } @@ -1298,7 +1298,7 @@ class AssemblerX86Shared : public AssemblerShared masm.push_m(src.disp(), src.base()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void push(Register src) { @@ -1317,7 +1317,7 @@ class AssemblerX86Shared : public AssemblerShared masm.pop_m(src.disp(), src.base()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void pop(Register src) { @@ -1376,7 +1376,7 @@ class AssemblerX86Shared : public AssemblerShared masm.pinsrd_mr(src.disp(), src.base(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void psrldq(Imm32 shift, FloatRegister dest) { @@ -1405,7 +1405,7 @@ class AssemblerX86Shared : public AssemblerShared masm.cvtsi2sd_mr(src.disp(), src.base(), src.index(), src.scale(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void cvttsd2si(FloatRegister src, Register dest) { @@ -1429,7 +1429,7 @@ class AssemblerX86Shared : public AssemblerShared masm.cvtsi2ss_mr(src.disp(), src.base(), src.index(), src.scale(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void cvtsi2ss(Register src, FloatRegister dest) { @@ -1485,7 +1485,7 @@ class AssemblerX86Shared : public AssemblerShared masm.paddd_mr(src.address(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void psubd(const Operand &src, FloatRegister dest) { @@ -1501,7 +1501,7 @@ class AssemblerX86Shared : public AssemblerShared masm.psubd_mr(src.address(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void addps(const Operand &src, FloatRegister dest) { @@ -1517,7 +1517,7 @@ class AssemblerX86Shared : public AssemblerShared masm.addps_mr(src.address(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void subps(const Operand &src, FloatRegister dest) { @@ -1533,7 +1533,7 @@ class AssemblerX86Shared : public AssemblerShared masm.subps_mr(src.address(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void mulps(const Operand &src, FloatRegister dest) { @@ -1549,7 +1549,7 @@ class AssemblerX86Shared : public AssemblerShared masm.mulps_mr(src.address(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void divps(const Operand &src, FloatRegister dest) { @@ -1565,7 +1565,7 @@ class AssemblerX86Shared : public AssemblerShared masm.divps_mr(src.address(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void pxor(FloatRegister src, FloatRegister dest) { @@ -1605,7 +1605,7 @@ class AssemblerX86Shared : public AssemblerShared masm.addsd_mr(src.address(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void addss(const Operand &src, FloatRegister dest) { @@ -1621,7 +1621,7 @@ class AssemblerX86Shared : public AssemblerShared masm.addss_mr(src.address(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void subsd(FloatRegister src, FloatRegister dest) { @@ -1642,7 +1642,7 @@ class AssemblerX86Shared : public AssemblerShared masm.subsd_mr(src.disp(), src.base(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void subss(const Operand &src, FloatRegister dest) { @@ -1655,7 +1655,7 @@ class AssemblerX86Shared : public AssemblerShared masm.subss_mr(src.disp(), src.base(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void mulsd(FloatRegister src, FloatRegister dest) { @@ -1672,7 +1672,7 @@ class AssemblerX86Shared : public AssemblerShared masm.mulsd_mr(src.disp(), src.base(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void mulss(const Operand &src, FloatRegister dest) { @@ -1685,7 +1685,7 @@ class AssemblerX86Shared : public AssemblerShared masm.mulss_mr(src.disp(), src.base(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void mulss(FloatRegister src, FloatRegister dest) { @@ -1710,7 +1710,7 @@ class AssemblerX86Shared : public AssemblerShared masm.divsd_mr(src.disp(), src.base(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void divss(const Operand &src, FloatRegister dest) { @@ -1723,7 +1723,7 @@ class AssemblerX86Shared : public AssemblerShared masm.divss_mr(src.disp(), src.base(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void xorpd(FloatRegister src, FloatRegister dest) { @@ -1780,7 +1780,7 @@ class AssemblerX86Shared : public AssemblerShared masm.minsd_mr(src.disp(), src.base(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void maxsd(FloatRegister src, FloatRegister dest) { @@ -1797,7 +1797,7 @@ class AssemblerX86Shared : public AssemblerShared masm.maxsd_mr(src.disp(), src.base(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void fisttp(const Operand &dest) { @@ -1807,7 +1807,7 @@ class AssemblerX86Shared : public AssemblerShared masm.fisttp_m(dest.disp(), dest.base()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void fld(const Operand &dest) { @@ -1816,7 +1816,7 @@ class AssemblerX86Shared : public AssemblerShared masm.fld_m(dest.disp(), dest.base()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void fstp(const Operand &src) { @@ -1825,7 +1825,7 @@ class AssemblerX86Shared : public AssemblerShared masm.fstp_m(src.disp(), src.base()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void fstp32(const Operand &src) { @@ -1834,7 +1834,7 @@ class AssemblerX86Shared : public AssemblerShared masm.fstp32_m(src.disp(), src.base()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } @@ -1885,14 +1885,14 @@ class AssemblerX86Shared : public AssemblerShared } static void PatchInstructionImmediate(uint8_t *code, PatchedImmPtr imm) { - MOZ_ASSUME_UNREACHABLE("Unused."); + MOZ_CRASH("Unused."); } static uint32_t NopSize() { return 1; } static uint8_t *NextInstruction(uint8_t *cur, uint32_t *count) { - MOZ_ASSUME_UNREACHABLE("nextInstruction NYI on x86"); + MOZ_CRASH("nextInstruction NYI on x86"); } // Toggle a jmp or cmp emitted by toggledJump(). diff --git a/js/src/jit/shared/CodeGenerator-x86-shared.cpp b/js/src/jit/shared/CodeGenerator-x86-shared.cpp index a1c7e5f4d8a..d7249171121 100644 --- a/js/src/jit/shared/CodeGenerator-x86-shared.cpp +++ b/js/src/jit/shared/CodeGenerator-x86-shared.cpp @@ -1338,7 +1338,7 @@ CodeGeneratorX86Shared::visitBitOpI(LBitOpI *ins) masm.andl(ToOperand(rhs), ToRegister(lhs)); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected binary opcode"); + MOZ_CRASH("unexpected binary opcode"); } return true; @@ -1372,7 +1372,7 @@ CodeGeneratorX86Shared::visitShiftI(LShiftI *ins) } break; default: - MOZ_ASSUME_UNREACHABLE("Unexpected shift op"); + MOZ_CRASH("Unexpected shift op"); } } else { JS_ASSERT(ToRegister(rhs) == ecx); @@ -1393,7 +1393,7 @@ CodeGeneratorX86Shared::visitShiftI(LShiftI *ins) } break; default: - MOZ_ASSUME_UNREACHABLE("Unexpected shift op"); + MOZ_CRASH("Unexpected shift op"); } } @@ -1535,7 +1535,7 @@ CodeGeneratorX86Shared::visitMathD(LMathD *math) masm.divsd(rhs, lhs); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected opcode"); + MOZ_CRASH("unexpected opcode"); } return true; } @@ -1562,8 +1562,7 @@ CodeGeneratorX86Shared::visitMathF(LMathF *math) masm.divss(rhs, lhs); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected opcode"); - return false; + MOZ_CRASH("unexpected opcode"); } return true; } @@ -2109,7 +2108,7 @@ CodeGeneratorX86Shared::visitSimdValueX4(LSimdValueX4 *ins) masm.loadAlignedFloat32x4(Address(StackPointer, 0), output); break; } - default: MOZ_ASSUME_UNREACHABLE("Unknown SIMD kind"); + default: MOZ_CRASH("Unknown SIMD kind"); } masm.freeStack(Simd128DataSize); @@ -2177,7 +2176,7 @@ CodeGeneratorX86Shared::visitSimdBinaryArithIx4(LSimdBinaryArithIx4 *ins) // x86 doesn't have SIMD i32 div. break; } - MOZ_ASSUME_UNREACHABLE("unexpected SIMD op"); + MOZ_CRASH("unexpected SIMD op"); } bool @@ -2202,7 +2201,7 @@ CodeGeneratorX86Shared::visitSimdBinaryArithFx4(LSimdBinaryArithFx4 *ins) masm.packedDivFloat32(rhs, lhs); return true; } - MOZ_ASSUME_UNREACHABLE("unexpected SIMD op"); + MOZ_CRASH("unexpected SIMD op"); } bool diff --git a/js/src/jit/shared/MacroAssembler-x86-shared.h b/js/src/jit/shared/MacroAssembler-x86-shared.h index 857560d9677..3e169f202c5 100644 --- a/js/src/jit/shared/MacroAssembler-x86-shared.h +++ b/js/src/jit/shared/MacroAssembler-x86-shared.h @@ -402,7 +402,7 @@ class MacroAssemblerX86Shared : public Assembler loadDouble(src.toBaseIndex(), dest); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void storeDouble(FloatRegister src, const Address &dest) { @@ -420,7 +420,7 @@ class MacroAssemblerX86Shared : public Assembler storeDouble(src, dest.toBaseIndex()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void moveDouble(FloatRegister src, FloatRegister dest) { @@ -580,7 +580,7 @@ class MacroAssemblerX86Shared : public Assembler loadFloat32(src.toBaseIndex(), dest); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void storeFloat32(FloatRegister src, const Address &dest) { @@ -598,7 +598,7 @@ class MacroAssemblerX86Shared : public Assembler storeFloat32(src, dest.toBaseIndex()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void moveFloat32(FloatRegister src, FloatRegister dest) { diff --git a/js/src/jit/shared/MoveEmitter-x86-shared.cpp b/js/src/jit/shared/MoveEmitter-x86-shared.cpp index 26cfe789c56..6df64b48381 100644 --- a/js/src/jit/shared/MoveEmitter-x86-shared.cpp +++ b/js/src/jit/shared/MoveEmitter-x86-shared.cpp @@ -148,7 +148,7 @@ MoveEmitterX86::emit(const MoveResolver &moves) emitFloat32X4Move(from, to); break; default: - MOZ_ASSUME_UNREACHABLE("Unexpected move type"); + MOZ_CRASH("Unexpected move type"); } } } @@ -278,7 +278,7 @@ MoveEmitterX86::breakCycle(const MoveOperand &to, MoveOp::Type type) masm.Push(toOperand(to)); break; default: - MOZ_ASSUME_UNREACHABLE("Unexpected move type"); + MOZ_CRASH("Unexpected move type"); } } @@ -350,7 +350,7 @@ MoveEmitterX86::completeCycle(const MoveOperand &to, MoveOp::Type type) masm.Pop(toPopOperand(to)); break; default: - MOZ_ASSUME_UNREACHABLE("Unexpected move type"); + MOZ_CRASH("Unexpected move type"); } } diff --git a/js/src/jit/x64/Assembler-x64.cpp b/js/src/jit/x64/Assembler-x64.cpp index 9f639090447..c55d9dc66dd 100644 --- a/js/src/jit/x64/Assembler-x64.cpp +++ b/js/src/jit/x64/Assembler-x64.cpp @@ -44,7 +44,7 @@ ABIArgGenerator::next(MIRType type) current_ = ABIArg(FloatArgRegs[regIndex_++]); break; default: - MOZ_ASSUME_UNREACHABLE("Unexpected argument type"); + MOZ_CRASH("Unexpected argument type"); } return current_; #else @@ -68,7 +68,7 @@ ABIArgGenerator::next(MIRType type) current_ = ABIArg(FloatArgRegs[floatRegIndex_++]); break; default: - MOZ_ASSUME_UNREACHABLE("Unexpected argument type"); + MOZ_CRASH("Unexpected argument type"); } return current_; #endif diff --git a/js/src/jit/x64/Assembler-x64.h b/js/src/jit/x64/Assembler-x64.h index ff13fb381ee..76202106eae 100644 --- a/js/src/jit/x64/Assembler-x64.h +++ b/js/src/jit/x64/Assembler-x64.h @@ -358,7 +358,7 @@ class Assembler : public AssemblerX86Shared masm.movq_mr(src.address(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void movq(Register src, const Operand &dest) { @@ -376,7 +376,7 @@ class Assembler : public AssemblerX86Shared masm.movq_rm(src.code(), dest.address()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void movq(Imm32 imm32, const Operand &dest) { @@ -394,7 +394,7 @@ class Assembler : public AssemblerX86Shared masm.movq_i32m(imm32.value, dest.address()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void movq(Register src, FloatRegister dest) { @@ -432,7 +432,7 @@ class Assembler : public AssemblerX86Shared masm.andq_mr(src.address(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } @@ -451,7 +451,7 @@ class Assembler : public AssemblerX86Shared masm.addq_im(imm.value, dest.address()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void addq(Register src, Register dest) { @@ -469,7 +469,7 @@ class Assembler : public AssemblerX86Shared masm.addq_mr(src.address(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } @@ -491,7 +491,7 @@ class Assembler : public AssemblerX86Shared masm.subq_mr(src.address(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void subq(Register src, const Operand &dest) { @@ -503,7 +503,7 @@ class Assembler : public AssemblerX86Shared masm.subq_rm(src.code(), dest.disp(), dest.base()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void shlq(Imm32 imm, Register dest) { @@ -533,7 +533,7 @@ class Assembler : public AssemblerX86Shared masm.orq_mr(src.address(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void xorq(Register src, Register dest) { @@ -592,7 +592,7 @@ class Assembler : public AssemblerX86Shared masm.leaq_mr(src.disp(), src.base(), src.index(), src.scale(), dest.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexepcted operand kind"); + MOZ_CRASH("unexepcted operand kind"); } } @@ -635,7 +635,7 @@ class Assembler : public AssemblerX86Shared masm.cmpq_rm(rhs.code(), lhs.address()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void cmpq(const Operand &lhs, Imm32 rhs) { @@ -650,7 +650,7 @@ class Assembler : public AssemblerX86Shared masm.cmpq_im(rhs.value, lhs.address()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void cmpq(Register lhs, const Operand &rhs) { @@ -662,7 +662,7 @@ class Assembler : public AssemblerX86Shared masm.cmpq_mr(rhs.disp(), rhs.base(), lhs.code()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } void cmpq(Register lhs, Register rhs) { @@ -687,7 +687,7 @@ class Assembler : public AssemblerX86Shared masm.testq_i32m(rhs.value, lhs.disp(), lhs.base()); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); break; } } diff --git a/js/src/jit/x64/Bailouts-x64.cpp b/js/src/jit/x64/Bailouts-x64.cpp index 3f8bb8ad7fe..e95d050a42b 100644 --- a/js/src/jit/x64/Bailouts-x64.cpp +++ b/js/src/jit/x64/Bailouts-x64.cpp @@ -60,7 +60,7 @@ IonBailoutIterator::IonBailoutIterator(const JitActivationIterator &activations, switch (mode_) { case SequentialExecution: topIonScript_ = script()->ionScript(); break; case ParallelExecution: topIonScript_ = script()->parallelIonScript(); break; - default: MOZ_ASSUME_UNREACHABLE("No such execution mode"); + default: MOZ_CRASH("No such execution mode"); } snapshotOffset_ = bailout->snapshotOffset(); } diff --git a/js/src/jit/x64/BaselineIC-x64.cpp b/js/src/jit/x64/BaselineIC-x64.cpp index ce8705a999a..caeae9b1cc1 100644 --- a/js/src/jit/x64/BaselineIC-x64.cpp +++ b/js/src/jit/x64/BaselineIC-x64.cpp @@ -184,7 +184,7 @@ ICBinaryArith_Int32::Compiler::generateStubCode(MacroAssembler &masm) } break; default: - MOZ_ASSUME_UNREACHABLE("Unhandled op in BinaryArith_Int32"); + MOZ_CRASH("Unhandled op in BinaryArith_Int32"); } // Return from stub. @@ -233,7 +233,7 @@ ICUnaryArith_Int32::Compiler::generateStubCode(MacroAssembler &masm) masm.negl(R0.valueReg()); break; default: - MOZ_ASSUME_UNREACHABLE("Unexpected op"); + MOZ_CRASH("Unexpected op"); } masm.tagValue(JSVAL_TYPE_INT32, R0.valueReg(), R0); diff --git a/js/src/jit/x64/CodeGenerator-x64.cpp b/js/src/jit/x64/CodeGenerator-x64.cpp index 8ebabe805b1..048d7ee1fdd 100644 --- a/js/src/jit/x64/CodeGenerator-x64.cpp +++ b/js/src/jit/x64/CodeGenerator-x64.cpp @@ -54,7 +54,7 @@ FrameSizeClass::ClassLimit() uint32_t FrameSizeClass::frameSize() const { - MOZ_ASSUME_UNREACHABLE("x64 does not use frame size classes"); + MOZ_CRASH("x64 does not use frame size classes"); } bool @@ -110,7 +110,7 @@ CodeGeneratorX64::visitUnbox(LUnbox *unbox) cond = masm.testSymbol(Assembler::NotEqual, value); break; default: - MOZ_ASSUME_UNREACHABLE("Given MIRType cannot be unboxed."); + MOZ_CRASH("Given MIRType cannot be unboxed."); } if (!bailoutIf(cond, unbox->snapshot())) return false; @@ -133,7 +133,7 @@ CodeGeneratorX64::visitUnbox(LUnbox *unbox) masm.unboxSymbol(value, ToRegister(result)); break; default: - MOZ_ASSUME_UNREACHABLE("Given MIRType cannot be unboxed."); + MOZ_CRASH("Given MIRType cannot be unboxed."); } return true; @@ -231,13 +231,13 @@ CodeGeneratorX64::visitAsmJSUInt32ToFloat32(LAsmJSUInt32ToFloat32 *lir) bool CodeGeneratorX64::visitLoadTypedArrayElementStatic(LLoadTypedArrayElementStatic *ins) { - MOZ_ASSUME_UNREACHABLE("NYI"); + MOZ_CRASH("NYI"); } bool CodeGeneratorX64::visitStoreTypedArrayElementStatic(LStoreTypedArrayElementStatic *ins) { - MOZ_ASSUME_UNREACHABLE("NYI"); + MOZ_CRASH("NYI"); } bool @@ -280,7 +280,7 @@ CodeGeneratorX64::visitAsmJSLoadHeap(LAsmJSLoadHeap *ins) case Scalar::Uint32: masm.movl(srcAddr, ToRegister(out)); break; case Scalar::Float32: masm.loadFloat32(srcAddr, ToFloatRegister(out)); break; case Scalar::Float64: masm.loadDouble(srcAddr, ToFloatRegister(out)); break; - default: MOZ_ASSUME_UNREACHABLE("unexpected array type"); + default: MOZ_CRASH("unexpected array type"); } uint32_t after = masm.size(); if (ool) @@ -322,7 +322,7 @@ CodeGeneratorX64::visitAsmJSStoreHeap(LAsmJSStoreHeap *ins) case Scalar::Uint16: masm.movw(Imm32(ToInt32(ins->value())), dstAddr); break; case Scalar::Int32: case Scalar::Uint32: masm.movl(Imm32(ToInt32(ins->value())), dstAddr); break; - default: MOZ_ASSUME_UNREACHABLE("unexpected array type"); + default: MOZ_CRASH("unexpected array type"); } } else { switch (vt) { @@ -334,7 +334,7 @@ CodeGeneratorX64::visitAsmJSStoreHeap(LAsmJSStoreHeap *ins) case Scalar::Uint32: masm.movl(ToRegister(ins->value()), dstAddr); break; case Scalar::Float32: masm.storeFloat32(ToFloatRegister(ins->value()), dstAddr); break; case Scalar::Float64: masm.storeDouble(ToFloatRegister(ins->value()), dstAddr); break; - default: MOZ_ASSUME_UNREACHABLE("unexpected array type"); + default: MOZ_CRASH("unexpected array type"); } } uint32_t after = masm.size(); diff --git a/js/src/jit/x64/Lowering-x64.cpp b/js/src/jit/x64/Lowering-x64.cpp index a6478ae7200..a46a1f98f65 100644 --- a/js/src/jit/x64/Lowering-x64.cpp +++ b/js/src/jit/x64/Lowering-x64.cpp @@ -177,7 +177,7 @@ LIRGeneratorX64::visitAsmJSStoreHeap(MAsmJSStoreHeap *ins) lir = new(alloc()) LAsmJSStoreHeap(ptrAlloc, useRegisterAtStart(ins->value())); break; default: - MOZ_ASSUME_UNREACHABLE("unexpected array type"); + MOZ_CRASH("unexpected array type"); } return add(lir, ins); @@ -192,5 +192,5 @@ LIRGeneratorX64::visitAsmJSLoadFuncPtr(MAsmJSLoadFuncPtr *ins) bool LIRGeneratorX64::visitStoreTypedArrayElementStatic(MStoreTypedArrayElementStatic *ins) { - MOZ_ASSUME_UNREACHABLE("NYI"); + MOZ_CRASH("NYI"); } diff --git a/js/src/jit/x64/MacroAssembler-x64.cpp b/js/src/jit/x64/MacroAssembler-x64.cpp index 65a3038df74..c87136f9dff 100644 --- a/js/src/jit/x64/MacroAssembler-x64.cpp +++ b/js/src/jit/x64/MacroAssembler-x64.cpp @@ -167,7 +167,7 @@ MacroAssemblerX64::finish() switch(v.type()) { case SimdConstant::Int32x4: masm.int32x4Constant(v.value.asInt32x4()); break; case SimdConstant::Float32x4: masm.float32x4Constant(v.value.asFloat32x4()); break; - default: MOZ_ASSUME_UNREACHABLE("unexpected SimdConstant type"); + default: MOZ_CRASH("unexpected SimdConstant type"); } } @@ -223,7 +223,7 @@ MacroAssemblerX64::passABIArg(const MoveOperand &from, MoveOp::Type type) switch (type) { case MoveOp::FLOAT32: stackForCall_ += sizeof(float); break; case MoveOp::DOUBLE: stackForCall_ += sizeof(double); break; - default: MOZ_ASSUME_UNREACHABLE("Unexpected float register class argument type"); + default: MOZ_CRASH("Unexpected float register class argument type"); } } break; @@ -243,7 +243,7 @@ MacroAssemblerX64::passABIArg(const MoveOperand &from, MoveOp::Type type) break; } default: - MOZ_ASSUME_UNREACHABLE("Unexpected argument type"); + MOZ_CRASH("Unexpected argument type"); } enoughMemory_ = moveResolver_.addMove(from, to, type); diff --git a/js/src/jit/x64/MacroAssembler-x64.h b/js/src/jit/x64/MacroAssembler-x64.h index c3bcb68e7f1..31351c3985b 100644 --- a/js/src/jit/x64/MacroAssembler-x64.h +++ b/js/src/jit/x64/MacroAssembler-x64.h @@ -124,7 +124,7 @@ class MacroAssemblerX64 : public MacroAssemblerX86Shared base.scale(), base.disp() + 4); default: - MOZ_ASSUME_UNREACHABLE("unexpected operand kind"); + MOZ_CRASH("unexpected operand kind"); } } static inline Operand ToUpper32(const Address &address) { diff --git a/js/src/jit/x64/Trampoline-x64.cpp b/js/src/jit/x64/Trampoline-x64.cpp index 441d0599813..b31f0c93fa0 100644 --- a/js/src/jit/x64/Trampoline-x64.cpp +++ b/js/src/jit/x64/Trampoline-x64.cpp @@ -519,7 +519,7 @@ GenerateParallelBailoutThunk(MacroAssembler &masm) JitCode * JitRuntime::generateBailoutTable(JSContext *cx, uint32_t frameClass) { - MOZ_ASSUME_UNREACHABLE("x64 does not use bailout tables"); + MOZ_CRASH("x64 does not use bailout tables"); } JitCode * @@ -535,7 +535,7 @@ JitRuntime::generateBailoutHandler(JSContext *cx, ExecutionMode mode) GenerateParallelBailoutThunk(masm); break; default: - MOZ_ASSUME_UNREACHABLE("No such execution mode"); + MOZ_CRASH("No such execution mode"); } Linker linker(masm); @@ -651,7 +651,7 @@ JitRuntime::generateVMWrapper(JSContext *cx, const VMFunction &f) break; case VMFunction::DoubleByValue: case VMFunction::DoubleByRef: - MOZ_ASSUME_UNREACHABLE("NYI: x64 callVM should not be used with 128bits values."); + MOZ_CRASH("NYI: x64 callVM should not be used with 128bits values."); } } @@ -671,7 +671,7 @@ JitRuntime::generateVMWrapper(JSContext *cx, const VMFunction &f) masm.j(Assembler::Zero, masm.failureLabel(f.executionMode)); break; default: - MOZ_ASSUME_UNREACHABLE("unknown failure kind"); + MOZ_CRASH("unknown failure kind"); } // Load the outparam and free any allocated stack. diff --git a/js/src/jit/x86/MacroAssembler-x86.cpp b/js/src/jit/x86/MacroAssembler-x86.cpp index 05fb7a890d3..90e94db0844 100644 --- a/js/src/jit/x86/MacroAssembler-x86.cpp +++ b/js/src/jit/x86/MacroAssembler-x86.cpp @@ -194,7 +194,7 @@ MacroAssemblerX86::finish() switch (v.type()) { case SimdConstant::Int32x4: writeInt32x4Constant(v.value, cl.src()); break; case SimdConstant::Float32x4: writeFloat32x4Constant(v.value, cl.src()); break; - default: MOZ_ASSUME_UNREACHABLE("unexpected SimdConstant type"); + default: MOZ_CRASH("unexpected SimdConstant type"); } enoughMemory_ &= addCodeLabel(cl); if (!enoughMemory_)